* [PATCH] configure: the error info not consistence with option.
@ 2020-09-03 22:06 Yonggang Luo
2020-09-04 0:18 ` Paolo Bonzini
0 siblings, 1 reply; 5+ messages in thread
From: Yonggang Luo @ 2020-09-03 22:06 UTC (permalink / raw)
To: qemu-devel; +Cc: Paolo Bonzini, Yonggang Luo
Signed-off-by: Yonggang Luo <luoyonggang@gmail.com>
---
configure | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/configure b/configure
index e42d210e5f..ae63c4fd54 100755
--- a/configure
+++ b/configure
@@ -2545,7 +2545,7 @@ fi
# vhost-user backends
test "$vhost_net_user" = "" && vhost_net_user=$vhost_user
if test "$vhost_net_user" = "yes" && test "$vhost_user" = "no"; then
- error_exit "--enable-vhost-net-user requires --enable-vhost-user"
+ error_exit "--enable-vhost-net requires --enable-vhost-user"
fi
test "$vhost_crypto" = "" && vhost_crypto=$vhost_user
if test "$vhost_crypto" = "yes" && test "$vhost_user" = "no"; then
--
2.28.0.windows.1
^ permalink raw reply related [flat|nested] 5+ messages in thread
* Re: [PATCH] configure: the error info not consistence with option.
2020-09-03 22:06 [PATCH] configure: the error info not consistence with option Yonggang Luo
@ 2020-09-04 0:18 ` Paolo Bonzini
2020-09-04 3:54 ` 罗勇刚(Yonggang Luo)
0 siblings, 1 reply; 5+ messages in thread
From: Paolo Bonzini @ 2020-09-04 0:18 UTC (permalink / raw)
To: Yonggang Luo; +Cc: qemu-devel
[-- Attachment #1: Type: text/plain, Size: 467 bytes --]
>
> test "$vhost_net_user" = "" && vhost_net_user=$vhost_user
> if test "$vhost_net_user" = "yes" && test "$vhost_user" = "no"; then
> - error_exit "--enable-vhost-net-user requires --enable-vhost-user"
> + error_exit "--enable-vhost-net requires --enable-vhost-user"
> fi
>
This change seems wrong.
Paolo
test "$vhost_crypto" = "" && vhost_crypto=$vhost_user
> if test "$vhost_crypto" = "yes" && test "$vhost_user" = "no"; then
> --
> 2.28.0.windows.1
>
>
[-- Attachment #2: Type: text/html, Size: 1140 bytes --]
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH] configure: the error info not consistence with option.
2020-09-04 0:18 ` Paolo Bonzini
@ 2020-09-04 3:54 ` 罗勇刚(Yonggang Luo)
2020-09-04 7:54 ` Paolo Bonzini
0 siblings, 1 reply; 5+ messages in thread
From: 罗勇刚(Yonggang Luo) @ 2020-09-04 3:54 UTC (permalink / raw)
To: Paolo Bonzini; +Cc: qemu-devel
[-- Attachment #1: Type: text/plain, Size: 735 bytes --]
On Fri, Sep 4, 2020 at 8:18 AM Paolo Bonzini <pbonzini@redhat.com> wrote:
> test "$vhost_net_user" = "" && vhost_net_user=$vhost_user
>> if test "$vhost_net_user" = "yes" && test "$vhost_user" = "no"; then
>> - error_exit "--enable-vhost-net-user requires --enable-vhost-user"
>> + error_exit "--enable-vhost-net requires --enable-vhost-user"
>> fi
>>
>
> This change seems wrong.
>
I didn't found --enable-vhost-net-user option handling?
you may grep it?
>
> Paolo
>
> test "$vhost_crypto" = "" && vhost_crypto=$vhost_user
>> if test "$vhost_crypto" = "yes" && test "$vhost_user" = "no"; then
>> --
>> 2.28.0.windows.1
>>
>>
--
此致
礼
罗勇刚
Yours
sincerely,
Yonggang Luo
[-- Attachment #2: Type: text/html, Size: 2027 bytes --]
^ permalink raw reply [flat|nested] 5+ messages in thread* Re: [PATCH] configure: the error info not consistence with option.
2020-09-04 3:54 ` 罗勇刚(Yonggang Luo)
@ 2020-09-04 7:54 ` Paolo Bonzini
2020-09-05 5:43 ` 罗勇刚(Yonggang Luo)
0 siblings, 1 reply; 5+ messages in thread
From: Paolo Bonzini @ 2020-09-04 7:54 UTC (permalink / raw)
To: luoyonggang; +Cc: qemu-devel
On 04/09/20 05:54, 罗勇刚(Yonggang Luo) wrote:
>
> test "$vhost_net_user" = "" && vhost_net_user=$vhost_user
> if test "$vhost_net_user" = "yes" && test "$vhost_user" = "no";
> then
> - error_exit "--enable-vhost-net-user requires --enable-vhost-user"
> + error_exit "--enable-vhost-net requires --enable-vhost-user"
> fi
>
>
> This change seems wrong.
>
> I didn't found --enable-vhost-net-user option handling?
> you may grep it?
>
>
You're right, it is all dead code. The four lines are equivalent to
just vhost_net_user=$vhost_user. You could also add
--enable-vhost-net-user though!
Thanks,
Paolo
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH] configure: the error info not consistence with option.
2020-09-04 7:54 ` Paolo Bonzini
@ 2020-09-05 5:43 ` 罗勇刚(Yonggang Luo)
0 siblings, 0 replies; 5+ messages in thread
From: 罗勇刚(Yonggang Luo) @ 2020-09-05 5:43 UTC (permalink / raw)
To: Paolo Bonzini; +Cc: qemu-devel
[-- Attachment #1: Type: text/plain, Size: 1063 bytes --]
On Fri, Sep 4, 2020 at 3:54 PM Paolo Bonzini <pbonzini@redhat.com> wrote:
> On 04/09/20 05:54, 罗勇刚(Yonggang Luo) wrote:
> >
> > test "$vhost_net_user" = "" && vhost_net_user=$vhost_user
> > if test "$vhost_net_user" = "yes" && test "$vhost_user" = "no";
> > then
> > - error_exit "--enable-vhost-net-user requires
> --enable-vhost-user"
> > + error_exit "--enable-vhost-net requires --enable-vhost-user"
> > fi
> >
> >
> > This change seems wrong.
> >
> > I didn't found --enable-vhost-net-user option handling?
> > you may grep it?
> >
> >
>
> You're right, it is all dead code. The four lines are equivalent to
> just vhost_net_user=$vhost_user. You could also add
> --enable-vhost-net-user though!
>
I remove those four lines and use vhost_net_user=$vhost_user instead for
simplicity,
if we have no strong need of this option, i guess remove it are better
>
> Thanks,
>
> Paolo
>
>
--
此致
礼
罗勇刚
Yours
sincerely,
Yonggang Luo
[-- Attachment #2: Type: text/html, Size: 1854 bytes --]
^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2020-09-05 5:44 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-09-03 22:06 [PATCH] configure: the error info not consistence with option Yonggang Luo
2020-09-04 0:18 ` Paolo Bonzini
2020-09-04 3:54 ` 罗勇刚(Yonggang Luo)
2020-09-04 7:54 ` Paolo Bonzini
2020-09-05 5:43 ` 罗勇刚(Yonggang Luo)
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.