All of lore.kernel.org
 help / color / mirror / Atom feed
* Re: [PATCH v7d 02/23] dyndbg: reword "class unknown, " to "class:_UNKNOWN_"
@ 2023-11-10 23:32 J Fra
  0 siblings, 0 replies; 5+ messages in thread
From: J Fra @ 2023-11-10 23:32 UTC (permalink / raw)
  To: amd-gfx

[-- Attachment #1: Type: text/plain, Size: 1 bytes --]



[-- Attachment #2: Type: text/html, Size: 23 bytes --]

^ permalink raw reply	[flat|nested] 5+ messages in thread
* [PATCH v7d 02/23] dyndbg: reword "class unknown," to "class:_UNKNOWN_"
  2023-11-01  0:25 [PATCH v7d 00/23] fix DRM_USE_DYNAMIC_DEBUG=y regression Jim Cromie
  2023-11-01  0:25   ` Jim Cromie
  (?)
@ 2023-11-01  0:25   ` Jim Cromie
  0 siblings, 0 replies; 5+ messages in thread
From: Jim Cromie @ 2023-11-01  0:25 UTC (permalink / raw)
  To: linux-kernel, jbaron, gregkh, dri-devel, amd-gfx, intel-gvt-dev,
	intel-gfx
  Cc: lb, linux, joe, mcgrof, daniel.vetter, jani.nikula,
	ville.syrjala, seanpaul, robdclark, groeck, yanivt, bleung,
	linux-doc, quic_saipraka, will, catalin.marinas, quic_psodagud,
	maz, arnd, linux-arm-kernel, linux-arm-msm, mingo, jim.cromie

This appears in the control-file to report an unknown class-name, which
indicates that the class_id is not authorized, and dyndbg will ignore
changes to it.  Generally, this means that a DYNDBG_CLASSMAP_DEFINE or
DYNDBG_CLASSMAP_USE is missing.

But the word "unknown" appears in quite a few prdbg formats, so thats
a suboptimal search term to find occurrences of the problem.  Thus
change it to "_UNKNOWN_" which properly shouts the condition.

Signed-off-by: Jim Cromie <jim.cromie@gmail.com>
---
 lib/dynamic_debug.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/lib/dynamic_debug.c b/lib/dynamic_debug.c
index 6fba6423cc10..ceb3067a5c83 100644
--- a/lib/dynamic_debug.c
+++ b/lib/dynamic_debug.c
@@ -1151,7 +1151,7 @@ static int ddebug_proc_show(struct seq_file *m, void *p)
 		if (class)
 			seq_printf(m, " class:%s", class);
 		else
-			seq_printf(m, " class unknown, _id:%d", dp->class_id);
+			seq_printf(m, " class:_UNKNOWN_ _id:%d", dp->class_id);
 	}
 	seq_puts(m, "\n");
 
-- 
2.41.0


^ permalink raw reply related	[flat|nested] 5+ messages in thread
* [PATCH v7d 02/23] dyndbg: reword "class unknown, " to "class:_UNKNOWN_"
@ 2023-11-01  0:25   ` Jim Cromie
  0 siblings, 0 replies; 5+ messages in thread
From: Jim Cromie @ 2023-11-01  0:25 UTC (permalink / raw)
  To: linux-kernel, jbaron, gregkh, dri-devel, amd-gfx, intel-gvt-dev,
	intel-gfx
  Cc: quic_saipraka, linux-doc, daniel.vetter, linux, will, groeck,
	maz, mcgrof, mingo, catalin.marinas, arnd, jani.nikula,
	linux-arm-msm, seanpaul, linux-arm-kernel, lb, yanivt,
	quic_psodagud, joe, bleung

This appears in the control-file to report an unknown class-name, which
indicates that the class_id is not authorized, and dyndbg will ignore
changes to it.  Generally, this means that a DYNDBG_CLASSMAP_DEFINE or
DYNDBG_CLASSMAP_USE is missing.

But the word "unknown" appears in quite a few prdbg formats, so thats
a suboptimal search term to find occurrences of the problem.  Thus
change it to "_UNKNOWN_" which properly shouts the condition.

Signed-off-by: Jim Cromie <jim.cromie@gmail.com>
---
 lib/dynamic_debug.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/lib/dynamic_debug.c b/lib/dynamic_debug.c
index 6fba6423cc10..ceb3067a5c83 100644
--- a/lib/dynamic_debug.c
+++ b/lib/dynamic_debug.c
@@ -1151,7 +1151,7 @@ static int ddebug_proc_show(struct seq_file *m, void *p)
 		if (class)
 			seq_printf(m, " class:%s", class);
 		else
-			seq_printf(m, " class unknown, _id:%d", dp->class_id);
+			seq_printf(m, " class:_UNKNOWN_ _id:%d", dp->class_id);
 	}
 	seq_puts(m, "\n");
 
-- 
2.41.0


^ permalink raw reply related	[flat|nested] 5+ messages in thread
* [PATCH v7d 02/23] dyndbg: reword "class unknown, " to "class:_UNKNOWN_"
@ 2023-11-01  0:25   ` Jim Cromie
  0 siblings, 0 replies; 5+ messages in thread
From: Jim Cromie @ 2023-11-01  0:25 UTC (permalink / raw)
  To: linux-kernel, jbaron, gregkh, dri-devel, amd-gfx, intel-gvt-dev,
	intel-gfx
  Cc: quic_saipraka, linux-doc, daniel.vetter, linux, will,
	ville.syrjala, groeck, maz, mcgrof, mingo, catalin.marinas, arnd,
	jani.nikula, linux-arm-msm, seanpaul, linux-arm-kernel, lb,
	jim.cromie, yanivt, robdclark, quic_psodagud, joe, bleung

This appears in the control-file to report an unknown class-name, which
indicates that the class_id is not authorized, and dyndbg will ignore
changes to it.  Generally, this means that a DYNDBG_CLASSMAP_DEFINE or
DYNDBG_CLASSMAP_USE is missing.

But the word "unknown" appears in quite a few prdbg formats, so thats
a suboptimal search term to find occurrences of the problem.  Thus
change it to "_UNKNOWN_" which properly shouts the condition.

Signed-off-by: Jim Cromie <jim.cromie@gmail.com>
---
 lib/dynamic_debug.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/lib/dynamic_debug.c b/lib/dynamic_debug.c
index 6fba6423cc10..ceb3067a5c83 100644
--- a/lib/dynamic_debug.c
+++ b/lib/dynamic_debug.c
@@ -1151,7 +1151,7 @@ static int ddebug_proc_show(struct seq_file *m, void *p)
 		if (class)
 			seq_printf(m, " class:%s", class);
 		else
-			seq_printf(m, " class unknown, _id:%d", dp->class_id);
+			seq_printf(m, " class:_UNKNOWN_ _id:%d", dp->class_id);
 	}
 	seq_puts(m, "\n");
 
-- 
2.41.0


^ permalink raw reply related	[flat|nested] 5+ messages in thread
* [PATCH v7d 02/23] dyndbg: reword "class unknown," to "class:_UNKNOWN_"
@ 2023-11-01  0:25   ` Jim Cromie
  0 siblings, 0 replies; 5+ messages in thread
From: Jim Cromie @ 2023-11-01  0:25 UTC (permalink / raw)
  To: linux-kernel, jbaron, gregkh, dri-devel, amd-gfx, intel-gvt-dev,
	intel-gfx
  Cc: lb, linux, joe, mcgrof, daniel.vetter, jani.nikula,
	ville.syrjala, seanpaul, robdclark, groeck, yanivt, bleung,
	linux-doc, quic_saipraka, will, catalin.marinas, quic_psodagud,
	maz, arnd, linux-arm-kernel, linux-arm-msm, mingo, jim.cromie

This appears in the control-file to report an unknown class-name, which
indicates that the class_id is not authorized, and dyndbg will ignore
changes to it.  Generally, this means that a DYNDBG_CLASSMAP_DEFINE or
DYNDBG_CLASSMAP_USE is missing.

But the word "unknown" appears in quite a few prdbg formats, so thats
a suboptimal search term to find occurrences of the problem.  Thus
change it to "_UNKNOWN_" which properly shouts the condition.

Signed-off-by: Jim Cromie <jim.cromie@gmail.com>
---
 lib/dynamic_debug.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/lib/dynamic_debug.c b/lib/dynamic_debug.c
index 6fba6423cc10..ceb3067a5c83 100644
--- a/lib/dynamic_debug.c
+++ b/lib/dynamic_debug.c
@@ -1151,7 +1151,7 @@ static int ddebug_proc_show(struct seq_file *m, void *p)
 		if (class)
 			seq_printf(m, " class:%s", class);
 		else
-			seq_printf(m, " class unknown, _id:%d", dp->class_id);
+			seq_printf(m, " class:_UNKNOWN_ _id:%d", dp->class_id);
 	}
 	seq_puts(m, "\n");
 
-- 
2.41.0


_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

^ permalink raw reply related	[flat|nested] 5+ messages in thread
end of thread, other threads:[~2023-11-12 18:01 UTC | newest]

Thread overview: 5+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2023-11-10 23:32 [PATCH v7d 02/23] dyndbg: reword "class unknown, " to "class:_UNKNOWN_" J Fra
  -- strict thread matches above, loose matches on Subject: below --
2023-11-01  0:25 [PATCH v7d 00/23] fix DRM_USE_DYNAMIC_DEBUG=y regression Jim Cromie
2023-11-01  0:25 ` [PATCH v7d 02/23] dyndbg: reword "class unknown," to "class:_UNKNOWN_" Jim Cromie
2023-11-01  0:25   ` Jim Cromie
2023-11-01  0:25   ` [PATCH v7d 02/23] dyndbg: reword "class unknown, " " Jim Cromie
2023-11-01  0:25   ` Jim Cromie

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.