* [PATCH] PCI: export symbol pci_bus_sem to module
@ 2012-05-28 7:33 Jiang Liu
2012-06-08 7:01 ` Yinghai Lu
0 siblings, 1 reply; 5+ messages in thread
From: Jiang Liu @ 2012-05-28 7:33 UTC (permalink / raw)
To: Bjorn Helgaas, Amos Kong, Yijing Wang
Cc: Jiang Liu, Kenji Kaneshige, Yinghai Lu, Keping Chen, linux-pci,
Jiang Liu
Changeset "9080648 PCI: acpiphp: remove all functions in slot,
even without ACPI _EJx" introduces pci_bus_sem into the acpiphp
driver, but pci_bus_sem hasn't been exported to modules yet.
So export symbol pci_bus_sem to modules, otherwise the acpiphp
driver can't be built as module any more.
Signed-off-by: Yijing Wang <wangyijing@huawei.com>
Signed-off-by: Jiang Liu <liuj97@gmail.com>
---
drivers/pci/search.c | 2 ++
1 files changed, 2 insertions(+), 0 deletions(-)
diff --git a/drivers/pci/search.c b/drivers/pci/search.c
index 9d75dc8..e0c7a22 100644
--- a/drivers/pci/search.c
+++ b/drivers/pci/search.c
@@ -15,6 +15,8 @@
#include "pci.h"
DECLARE_RWSEM(pci_bus_sem);
+EXPORT_SYMBOL(pci_bus_sem);
+
/*
* find the upstream PCIe-to-PCI bridge of a PCI device
* if the device is PCIE, return NULL
--
1.7.1
^ permalink raw reply related [flat|nested] 5+ messages in thread
* Re: [PATCH] PCI: export symbol pci_bus_sem to module
2012-05-28 7:33 [PATCH] PCI: export symbol pci_bus_sem to module Jiang Liu
@ 2012-06-08 7:01 ` Yinghai Lu
2012-06-11 17:43 ` Bjorn Helgaas
0 siblings, 1 reply; 5+ messages in thread
From: Yinghai Lu @ 2012-06-08 7:01 UTC (permalink / raw)
To: Jiang Liu, Bjorn Helgaas, Wu Fengguang
Cc: Amos Kong, Yijing Wang, Kenji Kaneshige, Keping Chen, linux-pci,
Jiang Liu
[-- Attachment #1: Type: text/plain, Size: 1275 bytes --]
On Mon, May 28, 2012 at 12:33 AM, Jiang Liu <jiang.liu@huawei.com> wrote:
> Changeset "9080648 PCI: acpiphp: remove all functions in slot,
> even without ACPI _EJx" introduces pci_bus_sem into the acpiphp
> driver, but pci_bus_sem hasn't been exported to modules yet.
> So export symbol pci_bus_sem to modules, otherwise the acpiphp
> driver can't be built as module any more.
>
> Signed-off-by: Yijing Wang <wangyijing@huawei.com>
> Signed-off-by: Jiang Liu <liuj97@gmail.com>
> ---
> drivers/pci/search.c | 2 ++
> 1 files changed, 2 insertions(+), 0 deletions(-)
>
> diff --git a/drivers/pci/search.c b/drivers/pci/search.c
> index 9d75dc8..e0c7a22 100644
> --- a/drivers/pci/search.c
> +++ b/drivers/pci/search.c
> @@ -15,6 +15,8 @@
> #include "pci.h"
>
> DECLARE_RWSEM(pci_bus_sem);
> +EXPORT_SYMBOL(pci_bus_sem);
> +
> /*
> * find the upstream PCIe-to-PCI bridge of a PCI device
> * if the device is PCIE, return NULL
Bjorn,
can you please fold this one into
9080648:
PCI: acpiphp: remove all functions in slot, even without ACPI _EJx
that commit now is in pci/for-3.6
Fengguang's auto compiling test robot reported same error on my
for-pci-root-bus-hotplug branch that is based on
pci/for-3.6.
Thanks
Yinghai
[-- Attachment #2: fix_acpiphp_mod.patch --]
[-- Type: application/octet-stream, Size: 495 bytes --]
Subject: [PATCH] PCI: Fix compiling of acpiphp as module
Reported-by: Fengguang Wu <wfg@linux.intel.com>
Signed-off-by: Yinghai Lu <yinghai@kernel.org>
diff --git a/drivers/pci/search.c b/drivers/pci/search.c
index 9d75dc8..8630ca2 100644
--- a/drivers/pci/search.c
+++ b/drivers/pci/search.c
@@ -15,6 +15,7 @@
#include "pci.h"
DECLARE_RWSEM(pci_bus_sem);
+EXPORT_SYMBOL_GPL(pci_bus_sem);
/*
* find the upstream PCIe-to-PCI bridge of a PCI device
* if the device is PCIE, return NULL
^ permalink raw reply related [flat|nested] 5+ messages in thread
* Re: [PATCH] PCI: export symbol pci_bus_sem to module
2012-06-08 7:01 ` Yinghai Lu
@ 2012-06-11 17:43 ` Bjorn Helgaas
2012-06-11 20:01 ` Yinghai Lu
0 siblings, 1 reply; 5+ messages in thread
From: Bjorn Helgaas @ 2012-06-11 17:43 UTC (permalink / raw)
To: Yinghai Lu
Cc: Jiang Liu, Wu Fengguang, Amos Kong, Yijing Wang, Kenji Kaneshige,
Keping Chen, linux-pci, Jiang Liu
On Fri, Jun 8, 2012 at 12:01 AM, Yinghai Lu <yinghai@kernel.org> wrote:
> On Mon, May 28, 2012 at 12:33 AM, Jiang Liu <jiang.liu@huawei.com> wrote:
>> Changeset "9080648 PCI: acpiphp: remove all functions in slot,
>> even without ACPI _EJx" introduces pci_bus_sem into the acpiphp
>> driver, but pci_bus_sem hasn't been exported to modules yet.
>> So export symbol pci_bus_sem to modules, otherwise the acpiphp
>> driver can't be built as module any more.
>>
>> Signed-off-by: Yijing Wang <wangyijing@huawei.com>
>> Signed-off-by: Jiang Liu <liuj97@gmail.com>
>> ---
>> drivers/pci/search.c | 2 ++
>> 1 files changed, 2 insertions(+), 0 deletions(-)
>>
>> diff --git a/drivers/pci/search.c b/drivers/pci/search.c
>> index 9d75dc8..e0c7a22 100644
>> --- a/drivers/pci/search.c
>> +++ b/drivers/pci/search.c
>> @@ -15,6 +15,8 @@
>> #include "pci.h"
>>
>> DECLARE_RWSEM(pci_bus_sem);
>> +EXPORT_SYMBOL(pci_bus_sem);
>> +
>> /*
>> * find the upstream PCIe-to-PCI bridge of a PCI device
>> * if the device is PCIE, return NULL
>
> Bjorn,
>
> can you please fold this one into
>
> 9080648:
> PCI: acpiphp: remove all functions in slot, even without ACPI _EJx
>
> that commit now is in pci/for-3.6
Yes, I'll fix this. If you don't object, I'll make it
EXPORT_SYMBOL_GPL(). I think we'll have more changes in the bus
scan/remove paths, and it's possible we'll be able to un-export this
in the future.
Bjorn
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH] PCI: export symbol pci_bus_sem to module
2012-06-11 17:43 ` Bjorn Helgaas
@ 2012-06-11 20:01 ` Yinghai Lu
2012-06-11 22:00 ` Bjorn Helgaas
0 siblings, 1 reply; 5+ messages in thread
From: Yinghai Lu @ 2012-06-11 20:01 UTC (permalink / raw)
To: Bjorn Helgaas
Cc: Jiang Liu, Wu Fengguang, Amos Kong, Yijing Wang, Kenji Kaneshige,
Keping Chen, linux-pci, Jiang Liu
On Mon, Jun 11, 2012 at 10:43 AM, Bjorn Helgaas <bhelgaas@google.com> wrote:
> On Fri, Jun 8, 2012 at 12:01 AM, Yinghai Lu <yinghai@kernel.org> wrote:
>> On Mon, May 28, 2012 at 12:33 AM, Jiang Liu <jiang.liu@huawei.com> wrote:
>>> Changeset "9080648 PCI: acpiphp: remove all functions in slot,
>>> even without ACPI _EJx" introduces pci_bus_sem into the acpiphp
>>> driver, but pci_bus_sem hasn't been exported to modules yet.
>>> So export symbol pci_bus_sem to modules, otherwise the acpiphp
>>> driver can't be built as module any more.
>>>
>>> Signed-off-by: Yijing Wang <wangyijing@huawei.com>
>>> Signed-off-by: Jiang Liu <liuj97@gmail.com>
>>> ---
>>> drivers/pci/search.c | 2 ++
>>> 1 files changed, 2 insertions(+), 0 deletions(-)
>>>
>>> diff --git a/drivers/pci/search.c b/drivers/pci/search.c
>>> index 9d75dc8..e0c7a22 100644
>>> --- a/drivers/pci/search.c
>>> +++ b/drivers/pci/search.c
>>> @@ -15,6 +15,8 @@
>>> #include "pci.h"
>>>
>>> DECLARE_RWSEM(pci_bus_sem);
>>> +EXPORT_SYMBOL(pci_bus_sem);
>>> +
>>> /*
>>> * find the upstream PCIe-to-PCI bridge of a PCI device
>>> * if the device is PCIE, return NULL
>>
>> Bjorn,
>>
>> can you please fold this one into
>>
>> 9080648:
>> PCI: acpiphp: remove all functions in slot, even without ACPI _EJx
>>
>> that commit now is in pci/for-3.6
>
> Yes, I'll fix this. If you don't object, I'll make it
> EXPORT_SYMBOL_GPL(). I think we'll have more changes in the bus
> scan/remove paths, and it's possible we'll be able to un-export this
> in the future.
yes, it should be EXPORT_SYMBOL_GPL.
I updated that in attachment.
Thanks
Yinghai
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH] PCI: export symbol pci_bus_sem to module
2012-06-11 20:01 ` Yinghai Lu
@ 2012-06-11 22:00 ` Bjorn Helgaas
0 siblings, 0 replies; 5+ messages in thread
From: Bjorn Helgaas @ 2012-06-11 22:00 UTC (permalink / raw)
To: Yinghai Lu
Cc: Jiang Liu, Wu Fengguang, Amos Kong, Yijing Wang, Kenji Kaneshige,
Keping Chen, linux-pci, Jiang Liu
On Mon, Jun 11, 2012 at 2:01 PM, Yinghai Lu <yinghai@kernel.org> wrote:
> On Mon, Jun 11, 2012 at 10:43 AM, Bjorn Helgaas <bhelgaas@google.com> wrote:
>> On Fri, Jun 8, 2012 at 12:01 AM, Yinghai Lu <yinghai@kernel.org> wrote:
>>> On Mon, May 28, 2012 at 12:33 AM, Jiang Liu <jiang.liu@huawei.com> wrote:
>>>> Changeset "9080648 PCI: acpiphp: remove all functions in slot,
>>>> even without ACPI _EJx" introduces pci_bus_sem into the acpiphp
>>>> driver, but pci_bus_sem hasn't been exported to modules yet.
>>>> So export symbol pci_bus_sem to modules, otherwise the acpiphp
>>>> driver can't be built as module any more.
>>>>
>>>> Signed-off-by: Yijing Wang <wangyijing@huawei.com>
>>>> Signed-off-by: Jiang Liu <liuj97@gmail.com>
>>>> ---
>>>> drivers/pci/search.c | 2 ++
>>>> 1 files changed, 2 insertions(+), 0 deletions(-)
>>>>
>>>> diff --git a/drivers/pci/search.c b/drivers/pci/search.c
>>>> index 9d75dc8..e0c7a22 100644
>>>> --- a/drivers/pci/search.c
>>>> +++ b/drivers/pci/search.c
>>>> @@ -15,6 +15,8 @@
>>>> #include "pci.h"
>>>>
>>>> DECLARE_RWSEM(pci_bus_sem);
>>>> +EXPORT_SYMBOL(pci_bus_sem);
>>>> +
>>>> /*
>>>> * find the upstream PCIe-to-PCI bridge of a PCI device
>>>> * if the device is PCIE, return NULL
>>>
>>> Bjorn,
>>>
>>> can you please fold this one into
>>>
>>> 9080648:
>>> PCI: acpiphp: remove all functions in slot, even without ACPI _EJx
>>>
>>> that commit now is in pci/for-3.6
>>
>> Yes, I'll fix this. If you don't object, I'll make it
>> EXPORT_SYMBOL_GPL(). I think we'll have more changes in the bus
>> scan/remove paths, and it's possible we'll be able to un-export this
>> in the future.
>
> yes, it should be EXPORT_SYMBOL_GPL.
I applied this to my "next" branch, with EXPORT_SYMBOL_GPL. Thanks!
^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2012-06-11 22:00 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2012-05-28 7:33 [PATCH] PCI: export symbol pci_bus_sem to module Jiang Liu
2012-06-08 7:01 ` Yinghai Lu
2012-06-11 17:43 ` Bjorn Helgaas
2012-06-11 20:01 ` Yinghai Lu
2012-06-11 22:00 ` Bjorn Helgaas
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.