From: Evan Green <evgreen@chromium.org>
To: georgi.djakov@linaro.org
Cc: mark.rutland@arm.com, lorenzo.pieralisi@arm.com,
Vincent Guittot <vincent.guittot@linaro.org>,
arnd@arndb.de, linux-pm@vger.kernel.org, seansw@qti.qualcomm.com,
gregkh@linuxfoundation.org,
Michael Turquette <mturquette@baylibre.com>,
rjw@rjwysocki.net, linux-kernel@vger.kernel.org,
amit.kucheria@linaro.org,
Bjorn Andersson <bjorn.andersson@linaro.org>,
robh+dt@kernel.org, Saravana Kannan <skannan@codeaurora.org>,
Alexandre Bailon <abailon@baylibre.com>,
khilman@baylibre.com, linux-arm-msm@vger.kernel.org,
daidavid1@codeaurora.org, linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH v7 8/8] interconnect: Allow endpoints translation via DT
Date: Fri, 3 Aug 2018 15:59:56 -0700 [thread overview]
Message-ID: <CAE=gft7+3n-Phh-FdamSFRZVq49Z234_HfU3Ze0MGJiYXGEmcw@mail.gmail.com> (raw)
In-Reply-To: <20180731161340.13000-9-georgi.djakov@linaro.org>
On Tue, Jul 31, 2018 at 9:13 AM Georgi Djakov <georgi.djakov@linaro.org> wrote:
>
> Currently we support only platform data for specifying the interconnect
> endpoints. As now the endpoints are hard-coded into the consumer driver
> this may lead to complications when a single driver is used by multiple
> SoCs, which may have different interconnect topology.
> To avoid cluttering the consumer drivers, introduce a translation function
> to help us get the board specific interconnect data from device-tree.
>
> Signed-off-by: Georgi Djakov <georgi.djakov@linaro.org>
> ---
> drivers/interconnect/core.c | 62 ++++++++++++++++++++++++++++++++++++
> include/linux/interconnect.h | 7 ++++
> 2 files changed, 69 insertions(+)
>
FWIW I don't have any strong opinions on whether of_icc_get returns an
error or NULL, other than to suggest following suit with what other
frameworks have chosen to do. Though perhaps most other frameworks are
not quite as optional for a particular driver.
Reviewed-by: Evan Green <evgreen@chromium.org>
WARNING: multiple messages have this Message-ID (diff)
From: Evan Green <evgreen@chromium.org>
To: georgi.djakov@linaro.org
Cc: linux-pm@vger.kernel.org, gregkh@linuxfoundation.org,
rjw@rjwysocki.net, robh+dt@kernel.org,
Michael Turquette <mturquette@baylibre.com>,
khilman@baylibre.com,
Vincent Guittot <vincent.guittot@linaro.org>,
Saravana Kannan <skannan@codeaurora.org>,
Bjorn Andersson <bjorn.andersson@linaro.org>,
amit.kucheria@linaro.org, seansw@qti.qualcomm.com,
daidavid1@codeaurora.org, mark.rutland@arm.com,
lorenzo.pieralisi@arm.com,
Alexandre Bailon <abailon@baylibre.com>,
arnd@arndb.de, linux-kernel@vger.kernel.org,
linux-arm-kernel@lists.infradead.org,
linux-arm-msm@vger.kernel.org
Subject: Re: [PATCH v7 8/8] interconnect: Allow endpoints translation via DT
Date: Fri, 3 Aug 2018 15:59:56 -0700 [thread overview]
Message-ID: <CAE=gft7+3n-Phh-FdamSFRZVq49Z234_HfU3Ze0MGJiYXGEmcw@mail.gmail.com> (raw)
In-Reply-To: <20180731161340.13000-9-georgi.djakov@linaro.org>
On Tue, Jul 31, 2018 at 9:13 AM Georgi Djakov <georgi.djakov@linaro.org> wrote:
>
> Currently we support only platform data for specifying the interconnect
> endpoints. As now the endpoints are hard-coded into the consumer driver
> this may lead to complications when a single driver is used by multiple
> SoCs, which may have different interconnect topology.
> To avoid cluttering the consumer drivers, introduce a translation function
> to help us get the board specific interconnect data from device-tree.
>
> Signed-off-by: Georgi Djakov <georgi.djakov@linaro.org>
> ---
> drivers/interconnect/core.c | 62 ++++++++++++++++++++++++++++++++++++
> include/linux/interconnect.h | 7 ++++
> 2 files changed, 69 insertions(+)
>
FWIW I don't have any strong opinions on whether of_icc_get returns an
error or NULL, other than to suggest following suit with what other
frameworks have chosen to do. Though perhaps most other frameworks are
not quite as optional for a particular driver.
Reviewed-by: Evan Green <evgreen@chromium.org>
WARNING: multiple messages have this Message-ID (diff)
From: evgreen@chromium.org (Evan Green)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH v7 8/8] interconnect: Allow endpoints translation via DT
Date: Fri, 3 Aug 2018 15:59:56 -0700 [thread overview]
Message-ID: <CAE=gft7+3n-Phh-FdamSFRZVq49Z234_HfU3Ze0MGJiYXGEmcw@mail.gmail.com> (raw)
In-Reply-To: <20180731161340.13000-9-georgi.djakov@linaro.org>
On Tue, Jul 31, 2018 at 9:13 AM Georgi Djakov <georgi.djakov@linaro.org> wrote:
>
> Currently we support only platform data for specifying the interconnect
> endpoints. As now the endpoints are hard-coded into the consumer driver
> this may lead to complications when a single driver is used by multiple
> SoCs, which may have different interconnect topology.
> To avoid cluttering the consumer drivers, introduce a translation function
> to help us get the board specific interconnect data from device-tree.
>
> Signed-off-by: Georgi Djakov <georgi.djakov@linaro.org>
> ---
> drivers/interconnect/core.c | 62 ++++++++++++++++++++++++++++++++++++
> include/linux/interconnect.h | 7 ++++
> 2 files changed, 69 insertions(+)
>
FWIW I don't have any strong opinions on whether of_icc_get returns an
error or NULL, other than to suggest following suit with what other
frameworks have chosen to do. Though perhaps most other frameworks are
not quite as optional for a particular driver.
Reviewed-by: Evan Green <evgreen@chromium.org>
next prev parent reply other threads:[~2018-08-03 22:59 UTC|newest]
Thread overview: 72+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-07-31 16:13 [PATCH v7 0/8] Introduce on-chip interconnect API Georgi Djakov
2018-07-31 16:13 ` Georgi Djakov
2018-07-31 16:13 ` [PATCH v7 1/8] interconnect: Add generic " Georgi Djakov
2018-07-31 16:13 ` Georgi Djakov
2018-08-02 0:05 ` Randy Dunlap
2018-08-02 0:05 ` Randy Dunlap
2018-08-02 11:58 ` Georgi Djakov
2018-08-02 11:58 ` Georgi Djakov
2018-08-03 22:59 ` Evan Green
2018-08-03 22:59 ` Evan Green
2018-07-31 16:13 ` [PATCH v7 2/8] dt-bindings: Introduce interconnect provider bindings Georgi Djakov
2018-07-31 16:13 ` Georgi Djakov
2018-08-02 21:02 ` Rob Herring
2018-08-02 21:02 ` Rob Herring
2018-08-07 14:54 ` Georgi Djakov
2018-08-07 14:54 ` [PATCH " Georgi Djakov
2018-08-07 14:54 ` Georgi Djakov
2018-08-20 15:32 ` [PATCH " Maxime Ripard
2018-08-20 15:32 ` Maxime Ripard
2018-08-20 15:32 ` Maxime Ripard
2018-08-24 14:51 ` Georgi Djakov
2018-08-24 14:51 ` Georgi Djakov
2018-08-24 14:51 ` Georgi Djakov
2018-08-24 15:35 ` Rob Herring
2018-08-24 15:35 ` Rob Herring
2018-08-24 15:35 ` Rob Herring
2018-08-27 15:11 ` Maxime Ripard
2018-08-27 15:11 ` Maxime Ripard
2018-08-27 15:11 ` Maxime Ripard
2018-08-29 12:33 ` Georgi Djakov
2018-08-29 12:33 ` Georgi Djakov
2018-08-29 12:33 ` Georgi Djakov
2018-08-30 7:47 ` Maxime Ripard
2018-08-30 7:47 ` Maxime Ripard
2018-08-30 7:47 ` Maxime Ripard
2018-08-27 15:08 ` Maxime Ripard
2018-08-27 15:08 ` Maxime Ripard
2018-08-27 15:08 ` Maxime Ripard
2018-08-29 12:31 ` Georgi Djakov
2018-08-29 12:31 ` Georgi Djakov
2018-08-29 12:31 ` Georgi Djakov
2018-07-31 16:13 ` [PATCH v7 3/8] interconnect: Add debugfs support Georgi Djakov
2018-07-31 16:13 ` Georgi Djakov
2018-08-03 22:59 ` Evan Green
2018-08-03 22:59 ` Evan Green
2018-07-31 16:13 ` [PATCH v7 4/8] interconnect: qcom: Add RPM communication Georgi Djakov
2018-07-31 16:13 ` Georgi Djakov
2018-08-03 22:59 ` Evan Green
2018-08-03 22:59 ` Evan Green
2018-08-03 22:59 ` Evan Green
2018-07-31 16:13 ` [PATCH v7 5/8] dt-bindings: interconnect: Document qcom, msm8916 NoC bindings Georgi Djakov
2018-07-31 16:13 ` Georgi Djakov
2018-07-31 16:13 ` [PATCH v7 5/8] dt-bindings: interconnect: Document qcom,msm8916 " Georgi Djakov
2018-07-31 16:13 ` [PATCH v7 6/8] interconnect: qcom: Add msm8916 interconnect provider driver Georgi Djakov
2018-07-31 16:13 ` Georgi Djakov
2018-08-03 22:59 ` Evan Green
2018-08-03 22:59 ` Evan Green
2018-07-31 16:13 ` [PATCH v7 7/8] dt-bindings: Introduce interconnect consumers bindings Georgi Djakov
2018-07-31 16:13 ` Georgi Djakov
2018-07-31 16:13 ` [PATCH v7 8/8] interconnect: Allow endpoints translation via DT Georgi Djakov
2018-07-31 16:13 ` Georgi Djakov
2018-08-01 22:57 ` skannan
2018-08-01 22:57 ` skannan at codeaurora.org
2018-08-02 12:07 ` Georgi Djakov
2018-08-02 12:07 ` Georgi Djakov
2018-08-02 19:12 ` skannan
2018-08-02 19:12 ` skannan at codeaurora.org
2018-08-09 14:17 ` Georgi Djakov
2018-08-09 14:17 ` Georgi Djakov
2018-08-03 22:59 ` Evan Green [this message]
2018-08-03 22:59 ` Evan Green
2018-08-03 22:59 ` Evan Green
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAE=gft7+3n-Phh-FdamSFRZVq49Z234_HfU3Ze0MGJiYXGEmcw@mail.gmail.com' \
--to=evgreen@chromium.org \
--cc=abailon@baylibre.com \
--cc=amit.kucheria@linaro.org \
--cc=arnd@arndb.de \
--cc=bjorn.andersson@linaro.org \
--cc=daidavid1@codeaurora.org \
--cc=georgi.djakov@linaro.org \
--cc=gregkh@linuxfoundation.org \
--cc=khilman@baylibre.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pm@vger.kernel.org \
--cc=lorenzo.pieralisi@arm.com \
--cc=mark.rutland@arm.com \
--cc=mturquette@baylibre.com \
--cc=rjw@rjwysocki.net \
--cc=robh+dt@kernel.org \
--cc=seansw@qti.qualcomm.com \
--cc=skannan@codeaurora.org \
--cc=vincent.guittot@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.