All of lore.kernel.org
 help / color / mirror / Atom feed
* [PATCH 1/2] Staging: wilc1000: Do not use multiple blank lines
@ 2015-10-04 14:04 Aybuke Ozdemir
  2015-10-04 14:04 ` [PATCH 2/2] Staging: wilc1000: Added 'function' word Aybuke Ozdemir
  0 siblings, 1 reply; 6+ messages in thread
From: Aybuke Ozdemir @ 2015-10-04 14:04 UTC (permalink / raw)
  To: outreachy-kernel; +Cc: Aybuke Ozdemir

This patch removes unnecessary blank lines between functions.
Found by checkpatch.pl:
"CHECK: Please don't use multiple blank lines".

Signed-off-by: Aybuke Ozdemir <aybuke.147@gmail.com>
---
 drivers/staging/wilc1000/coreconfigurator.c | 11 -----------
 1 file changed, 11 deletions(-)

diff --git a/drivers/staging/wilc1000/coreconfigurator.c b/drivers/staging/wilc1000/coreconfigurator.c
index 14e8efc..439c828 100644
--- a/drivers/staging/wilc1000/coreconfigurator.c
+++ b/drivers/staging/wilc1000/coreconfigurator.c
@@ -8,7 +8,6 @@
  *  @version	1.0
  */
 
-
 /*****************************************************************************/
 /* File Includes                                                             */
 /*****************************************************************************/
@@ -24,7 +23,6 @@
 /* Function Macros                                                           */
 /*****************************************************************************/
 
-
 /*****************************************************************************/
 /* Type Definitions                                                          */
 /*****************************************************************************/
@@ -122,7 +120,6 @@ typedef enum {
 	INFOELEM_ID_FORCE_32BIT  = 0xFFFFFFFF
 } tenuInfoElemID;
 
-
 typedef struct {
 	char *pcRespBuffer;
 	s32 s32MaxRespBuffLen;
@@ -130,8 +127,6 @@ typedef struct {
 	bool bRespRequired;
 } tstrConfigPktInfo;
 
-
-
 /*****************************************************************************/
 /* Extern Variable Declarations                                              */
 /*****************************************************************************/
@@ -143,8 +138,6 @@ typedef struct {
 /* Static Function Declarations                                              */
 /*****************************************************************************/
 
-
-
 /*****************************************************************************/
 /* Functions                                                                 */
 /*****************************************************************************/
@@ -613,7 +606,6 @@ s32 ParseAssocRespInfo(u8 *pu8Buffer, u32 u32BufferLen,
 
 	*ppstrConnectRespInfo = pstrConnectRespInfo;
 
-
 	return s32Error;
 }
 
@@ -667,7 +659,6 @@ s32 ParseSurveyResults(u8 ppu8RcvdSiteSurveyResults[][MAX_SURVEY_RESULT_FRAG_SIZ
 	for (i = 0; i < u32RcvdSurveyResultsNum; i++) {
 		u32SurveyBytesLength = ppu8RcvdSiteSurveyResults[i][0];
 
-
 		for (j = 0; j < u32SurveyBytesLength; j += SURVEY_RESULT_LENGTH) {
 			u32SurveyResultsCount++;
 		}
@@ -706,7 +697,6 @@ ERRORHANDLER:
 	return s32Error;
 }
 
-
 s32 DeallocateSurveyResults(wid_site_survey_reslts_s *pstrSurveyResults)
 {
 	s32 s32Error = 0;
@@ -735,7 +725,6 @@ s32 CoreConfiguratorDeInit(void)
 
 	PRINT_D(CORECONFIG_DBG, "CoreConfiguratorDeInit()\n");
 
-
 	return s32Error;
 }
 
-- 
2.1.4



^ permalink raw reply related	[flat|nested] 6+ messages in thread
* [PATCH 2/2] Staging: wilc1000: Added 'function' word.
  2015-10-04 14:04 [PATCH 1/2] Staging: wilc1000: Do not use multiple blank lines Aybuke Ozdemir
@ 2015-10-04 14:04 ` Aybuke Ozdemir
  2015-10-04 18:46   ` [Outreachy kernel] " Julia Lawall
  0 siblings, 1 reply; 6+ messages in thread
From: Aybuke Ozdemir @ 2015-10-04 14:04 UTC (permalink / raw)
  To: outreachy-kernel; +Cc: Aybuke Ozdemir

This patch organizing missing written word missing.
Found by checkpatch.pl:
CHECK: 'funcion' may be misspelled - perhaps 'function'?

Signed-off-by: Aybuke Ozdemir <aybuke.147@gmail.com>
---
 drivers/staging/wilc1000/coreconfigurator.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/staging/wilc1000/coreconfigurator.c b/drivers/staging/wilc1000/coreconfigurator.c
index 439c828..08f5675 100644
--- a/drivers/staging/wilc1000/coreconfigurator.c
+++ b/drivers/staging/wilc1000/coreconfigurator.c
@@ -296,7 +296,7 @@ static inline u16 get_assoc_resp_cap_info(u8 *data)
 	return cap_info;
 }
 
-/* This funcion extracts the association status code from the incoming       */
+/* This function extracts the association status code from the incoming       */
 /* association response frame and returns association status code            */
 static inline u16 get_asoc_status(u8 *data)
 {
-- 
2.1.4



^ permalink raw reply related	[flat|nested] 6+ messages in thread
* Re: [Outreachy kernel] [PATCH 2/2] Staging: wilc1000: Added 'function' word.
  2015-10-04 14:04 ` [PATCH 2/2] Staging: wilc1000: Added 'function' word Aybuke Ozdemir
@ 2015-10-04 18:46   ` Julia Lawall
  2015-10-04 23:59     ` Aybuke Ozdemir
  0 siblings, 1 reply; 6+ messages in thread
From: Julia Lawall @ 2015-10-04 18:46 UTC (permalink / raw)
  To: Aybuke Ozdemir; +Cc: outreachy-kernel

Something like "fix spelling mistake" would be better.  Because the workd
is not really added.

julia

On Sun, 4 Oct 2015, Aybuke Ozdemir wrote:

> This patch organizing missing written word missing.
> Found by checkpatch.pl:
> CHECK: 'funcion' may be misspelled - perhaps 'function'?
>
> Signed-off-by: Aybuke Ozdemir <aybuke.147@gmail.com>
> ---
>  drivers/staging/wilc1000/coreconfigurator.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/staging/wilc1000/coreconfigurator.c b/drivers/staging/wilc1000/coreconfigurator.c
> index 439c828..08f5675 100644
> --- a/drivers/staging/wilc1000/coreconfigurator.c
> +++ b/drivers/staging/wilc1000/coreconfigurator.c
> @@ -296,7 +296,7 @@ static inline u16 get_assoc_resp_cap_info(u8 *data)
>  	return cap_info;
>  }
>
> -/* This funcion extracts the association status code from the incoming       */
> +/* This function extracts the association status code from the incoming       */
>  /* association response frame and returns association status code            */
>  static inline u16 get_asoc_status(u8 *data)
>  {
> --
> 2.1.4
>
> --
> You received this message because you are subscribed to the Google Groups "outreachy-kernel" group.
> To unsubscribe from this group and stop receiving emails from it, send an email to outreachy-kernel+unsubscribe@googlegroups.com.
> To post to this group, send email to outreachy-kernel@googlegroups.com.
> To view this discussion on the web visit https://groups.google.com/d/msgid/outreachy-kernel/1443967460-14302-2-git-send-email-aybuke.147%40gmail.com.
> For more options, visit https://groups.google.com/d/optout.
>


^ permalink raw reply	[flat|nested] 6+ messages in thread
* Re: [Outreachy kernel] [PATCH 2/2] Staging: wilc1000: Added 'function' word.
  2015-10-04 18:46   ` [Outreachy kernel] " Julia Lawall
@ 2015-10-04 23:59     ` Aybuke Ozdemir
  2015-10-05 10:55       ` Greg KH
  2015-10-05 12:45       ` Julia Lawall
  0 siblings, 2 replies; 6+ messages in thread
From: Aybuke Ozdemir @ 2015-10-04 23:59 UTC (permalink / raw)
  To: Julia Lawall; +Cc: outreachy-kernel

[-- Attachment #1: Type: text/plain, Size: 2114 bytes --]

Hi,

I had to build my operating system from scratch. When cloning repository, the
first part of the set already looks smooth. So I can not edit this patch.
Can I send a separate patch?

Thanks.

2015-10-04 21:46 GMT+03:00 Julia Lawall <julia.lawall@lip6.fr>:

> Something like "fix spelling mistake" would be better.  Because the workd
> is not really added.
>
> julia
>
> On Sun, 4 Oct 2015, Aybuke Ozdemir wrote:
>
> > This patch organizing missing written word missing.
> > Found by checkpatch.pl:
> > CHECK: 'funcion' may be misspelled - perhaps 'function'?
> >
> > Signed-off-by: Aybuke Ozdemir <aybuke.147@gmail.com>
> > ---
> >  drivers/staging/wilc1000/coreconfigurator.c | 2 +-
> >  1 file changed, 1 insertion(+), 1 deletion(-)
> >
> > diff --git a/drivers/staging/wilc1000/coreconfigurator.c
> b/drivers/staging/wilc1000/coreconfigurator.c
> > index 439c828..08f5675 100644
> > --- a/drivers/staging/wilc1000/coreconfigurator.c
> > +++ b/drivers/staging/wilc1000/coreconfigurator.c
> > @@ -296,7 +296,7 @@ static inline u16 get_assoc_resp_cap_info(u8 *data)
> >       return cap_info;
> >  }
> >
> > -/* This funcion extracts the association status code from the incoming
>      */
> > +/* This function extracts the association status code from the
> incoming       */
> >  /* association response frame and returns association status code
>       */
> >  static inline u16 get_asoc_status(u8 *data)
> >  {
> > --
> > 2.1.4
> >
> > --
> > You received this message because you are subscribed to the Google
> Groups "outreachy-kernel" group.
> > To unsubscribe from this group and stop receiving emails from it, send
> an email to outreachy-kernel+unsubscribe@googlegroups.com.
> > To post to this group, send email to outreachy-kernel@googlegroups.com.
> > To view this discussion on the web visit
> https://groups.google.com/d/msgid/outreachy-kernel/1443967460-14302-2-git-send-email-aybuke.147%40gmail.com
> .
> > For more options, visit https://groups.google.com/d/optout.
> >
>



-- 
Aybüke Özdemir
https://about.me/aybukeozdemir

[-- Attachment #2: Type: text/html, Size: 3996 bytes --]

^ permalink raw reply	[flat|nested] 6+ messages in thread
* Re: [Outreachy kernel] [PATCH 2/2] Staging: wilc1000: Added 'function' word.
  2015-10-04 23:59     ` Aybuke Ozdemir
@ 2015-10-05 10:55       ` Greg KH
  2015-10-05 12:45       ` Julia Lawall
  1 sibling, 0 replies; 6+ messages in thread
From: Greg KH @ 2015-10-05 10:55 UTC (permalink / raw)
  To: Aybuke Ozdemir; +Cc: Julia Lawall, outreachy-kernel


A: No.
Q: Should I include quotations after my reply?

http://daringfireball.net/2007/07/on_top

On Mon, Oct 05, 2015 at 02:59:57AM +0300, Aybuke Ozdemir wrote:
> Hi,
> 
> I had to build my operating system from scratch. When cloning repository, the
> first part of the set already looks smooth. So I can not edit this patch. Can I
> send a separate patch?

Please fix up and resend the whole series.

thanks,

greg k-h


^ permalink raw reply	[flat|nested] 6+ messages in thread
* Re: [Outreachy kernel] [PATCH 2/2] Staging: wilc1000: Added 'function' word.
  2015-10-04 23:59     ` Aybuke Ozdemir
  2015-10-05 10:55       ` Greg KH
@ 2015-10-05 12:45       ` Julia Lawall
  1 sibling, 0 replies; 6+ messages in thread
From: Julia Lawall @ 2015-10-05 12:45 UTC (permalink / raw)
  To: Aybuke Ozdemir; +Cc: outreachy-kernel

[-- Attachment #1: Type: TEXT/PLAIN, Size: 2980 bytes --]

On Mon, 5 Oct 2015, Aybuke Ozdemir wrote:

> Hi,
>
> I had to build my operating system from scratch. When cloning repository,
> the first part of the set already looks smooth. So I can not edit this
> patch. Can I send a separate patch?

If patch [1/2] is already applied, then just send part 2.

julia

>
> Thanks.
>
> 2015-10-04 21:46 GMT+03:00 Julia Lawall <julia.lawall@lip6.fr>:
>       Something like "fix spelling mistake" would be better.  Because
>       the workd
>       is not really added.
>
>       julia
>
>       On Sun, 4 Oct 2015, Aybuke Ozdemir wrote:
>
>       > This patch organizing missing written word missing.
>       > Found by checkpatch.pl:
>       > CHECK: 'funcion' may be misspelled - perhaps 'function'?
>       >
>       > Signed-off-by: Aybuke Ozdemir <aybuke.147@gmail.com>
>       > ---
>       >  drivers/staging/wilc1000/coreconfigurator.c | 2 +-
>       >  1 file changed, 1 insertion(+), 1 deletion(-)
>       >
>       > diff --git a/drivers/staging/wilc1000/coreconfigurator.c
>       b/drivers/staging/wilc1000/coreconfigurator.c
>       > index 439c828..08f5675 100644
>       > --- a/drivers/staging/wilc1000/coreconfigurator.c
>       > +++ b/drivers/staging/wilc1000/coreconfigurator.c
>       > @@ -296,7 +296,7 @@ static inline u16
>       get_assoc_resp_cap_info(u8 *data)
>       >       return cap_info;
>       >  }
>       >
>       > -/* This funcion extracts the association status code from the
>       incoming       */
>       > +/* This function extracts the association status code from
>       the incoming       */
>       >  /* association response frame and returns association status
>       code            */
>       >  static inline u16 get_asoc_status(u8 *data)
>       >  {
>       > --
>       > 2.1.4
>       >
> > --
> > You received this message because you are subscribed to the Google
> Groups "outreachy-kernel" group.
> > To unsubscribe from this group and stop receiving emails from it,
> send an email to outreachy-kernel+unsubscribe@googlegroups.com.
> > To post to this group, send email to
> outreachy-kernel@googlegroups.com.
> > To view this discussion on the web visithttps://groups.google.com/d/msgid/outreachy-kernel/1443967460-14302-2-git-s
> end-email-aybuke.147%40gmail.com.
> > For more options, visit https://groups.google.com/d/optout.
> >
>
>
>
>
> --
> Aybüke Özdemir
> https://about.me/aybukeozdemir
>
> --
> You received this message because you are subscribed to the Google Groups
> "outreachy-kernel" group.
> To unsubscribe from this group and stop receiving emails from it, send an
> email to outreachy-kernel+unsubscribe@googlegroups.com.
> To post to this group, send email to outreachy-kernel@googlegroups.com.
> To view this discussion on the web visithttps://groups.google.com/d/msgid/outreachy-kernel/CAEAX3JqmA3eW1w%2Bbh0DpW
> fYDkCQkVXE9_w8jaJ9W%3DZxTYhjGsQ%40mail.gmail.com.
> For more options, visit https://groups.google.com/d/optout.
>
>

^ permalink raw reply	[flat|nested] 6+ messages in thread
end of thread, other threads:[~2015-10-05 12:45 UTC | newest]

Thread overview: 6+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2015-10-04 14:04 [PATCH 1/2] Staging: wilc1000: Do not use multiple blank lines Aybuke Ozdemir
2015-10-04 14:04 ` [PATCH 2/2] Staging: wilc1000: Added 'function' word Aybuke Ozdemir
2015-10-04 18:46   ` [Outreachy kernel] " Julia Lawall
2015-10-04 23:59     ` Aybuke Ozdemir
2015-10-05 10:55       ` Greg KH
2015-10-05 12:45       ` Julia Lawall

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.