* [PATCH] sunrpc: convert to DEFINE_SHOW_ATTRIBUTE
@ 2018-12-15 7:14 Yangtao Li
2018-12-21 16:00 ` Frank Lee
0 siblings, 1 reply; 2+ messages in thread
From: Yangtao Li @ 2018-12-15 7:14 UTC (permalink / raw)
To: bfields, jlayton, trond.myklebust, anna.schumaker, davem
Cc: linux-nfs, netdev, linux-kernel, Yangtao Li
Use DEFINE_SHOW_ATTRIBUTE macro to simplify the code.
Signed-off-by: Yangtao Li <tiny.windzz@gmail.com>
---
net/sunrpc/rpc_pipe.c | 19 +++----------------
net/sunrpc/stats.c | 14 +-------------
2 files changed, 4 insertions(+), 29 deletions(-)
diff --git a/net/sunrpc/rpc_pipe.c b/net/sunrpc/rpc_pipe.c
index 4fda18d47e2c..69663681bf9d 100644
--- a/net/sunrpc/rpc_pipe.c
+++ b/net/sunrpc/rpc_pipe.c
@@ -1266,7 +1266,7 @@ static const struct rpc_pipe_ops gssd_dummy_pipe_ops = {
* that this file will be there and have a certain format.
*/
static int
-rpc_show_dummy_info(struct seq_file *m, void *v)
+rpc_dummy_info_show(struct seq_file *m, void *v)
{
seq_printf(m, "RPC server: %s\n", utsname()->nodename);
seq_printf(m, "service: foo (1) version 0\n");
@@ -1275,25 +1275,12 @@ rpc_show_dummy_info(struct seq_file *m, void *v)
seq_printf(m, "port: 0\n");
return 0;
}
-
-static int
-rpc_dummy_info_open(struct inode *inode, struct file *file)
-{
- return single_open(file, rpc_show_dummy_info, NULL);
-}
-
-static const struct file_operations rpc_dummy_info_operations = {
- .owner = THIS_MODULE,
- .open = rpc_dummy_info_open,
- .read = seq_read,
- .llseek = seq_lseek,
- .release = single_release,
-};
+DEFINE_SHOW_ATTRIBUTE(rpc_dummy_info);
static const struct rpc_filelist gssd_dummy_info_file[] = {
[0] = {
.name = "info",
- .i_fop = &rpc_dummy_info_operations,
+ .i_fop = &rpc_dummy_info_fops,
.mode = S_IFREG | 0400,
},
};
diff --git a/net/sunrpc/stats.c b/net/sunrpc/stats.c
index 71166b393732..d064fcec0b2e 100644
--- a/net/sunrpc/stats.c
+++ b/net/sunrpc/stats.c
@@ -62,19 +62,7 @@ static int rpc_proc_show(struct seq_file *seq, void *v) {
}
return 0;
}
-
-static int rpc_proc_open(struct inode *inode, struct file *file)
-{
- return single_open(file, rpc_proc_show, PDE_DATA(inode));
-}
-
-static const struct file_operations rpc_proc_fops = {
- .owner = THIS_MODULE,
- .open = rpc_proc_open,
- .read = seq_read,
- .llseek = seq_lseek,
- .release = single_release,
-};
+DEFINE_SHOW_ATTRIBUTE(rpc_proc);
/*
* Get RPC server stats
--
2.17.0
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] sunrpc: convert to DEFINE_SHOW_ATTRIBUTE
2018-12-15 7:14 [PATCH] sunrpc: convert to DEFINE_SHOW_ATTRIBUTE Yangtao Li
@ 2018-12-21 16:00 ` Frank Lee
0 siblings, 0 replies; 2+ messages in thread
From: Frank Lee @ 2018-12-21 16:00 UTC (permalink / raw)
To: Bruce Fields, jlayton, trond.myklebust, anna.schumaker, davem
Cc: linux-nfs, netdev, Linux Kernel Mailing List
Please igonre this one.
Thanks
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2018-12-21 16:01 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2018-12-15 7:14 [PATCH] sunrpc: convert to DEFINE_SHOW_ATTRIBUTE Yangtao Li
2018-12-21 16:00 ` Frank Lee
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.