* [PATCH] softirq: modify comments about PF_MEMALLOC in __do_softirq
@ 2018-10-18 14:21 Yangtao Li
2018-10-18 15:12 ` Steven Rostedt
` (3 more replies)
0 siblings, 4 replies; 6+ messages in thread
From: Yangtao Li @ 2018-10-18 14:21 UTC (permalink / raw)
To: joel, tglx
Cc: mingo, rostedt, frederic, paulmck, alexander.levin, linux-kernel,
Yangtao Li
---
kernel/softirq.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/kernel/softirq.c b/kernel/softirq.c
index 6f584861d329..6193e1d1b30d 100644
--- a/kernel/softirq.c
+++ b/kernel/softirq.c
@@ -257,7 +257,7 @@ asmlinkage __visible void __softirq_entry __do_softirq(void)
int softirq_bit;
/*
- * Mask out PF_MEMALLOC s current task context is borrowed for the
+ * Mask out PF_MEMALLOC as current task context is borrowed for the
* softirq. A softirq handled such as network RX might set PF_MEMALLOC
* again if the socket is related to swap
*/
--
2.17.0
^ permalink raw reply related [flat|nested] 6+ messages in thread
* Re: [PATCH] softirq: modify comments about PF_MEMALLOC in __do_softirq
2018-10-18 14:21 [PATCH] softirq: modify comments about PF_MEMALLOC in __do_softirq Yangtao Li
@ 2018-10-18 15:12 ` Steven Rostedt
2018-10-18 15:58 ` Frank Lee
` (2 subsequent siblings)
3 siblings, 0 replies; 6+ messages in thread
From: Steven Rostedt @ 2018-10-18 15:12 UTC (permalink / raw)
To: Yangtao Li
Cc: joel, tglx, mingo, frederic, paulmck, alexander.levin,
linux-kernel, trivial
I don't know if the trivial tree is dead or not, but this would be a
prime candidate.
Acked-by: Steven Rostedt (VMware) <rostedt@goodmis.org>
-- Steve
On Thu, 18 Oct 2018 10:21:33 -0400
Yangtao Li <tiny.windzz@gmail.com> wrote:
> ---
> kernel/softirq.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/kernel/softirq.c b/kernel/softirq.c
> index 6f584861d329..6193e1d1b30d 100644
> --- a/kernel/softirq.c
> +++ b/kernel/softirq.c
> @@ -257,7 +257,7 @@ asmlinkage __visible void __softirq_entry __do_softirq(void)
> int softirq_bit;
>
> /*
> - * Mask out PF_MEMALLOC s current task context is borrowed for the
> + * Mask out PF_MEMALLOC as current task context is borrowed for the
> * softirq. A softirq handled such as network RX might set PF_MEMALLOC
> * again if the socket is related to swap
> */
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH] softirq: modify comments about PF_MEMALLOC in __do_softirq
2018-10-18 14:21 [PATCH] softirq: modify comments about PF_MEMALLOC in __do_softirq Yangtao Li
2018-10-18 15:12 ` Steven Rostedt
@ 2018-10-18 15:58 ` Frank Lee
2018-10-18 16:10 ` Ingo Molnar
2018-10-18 16:13 ` [tip:irq/core] softirq: Fix typo in __do_softirq() comments tip-bot for Yangtao Li
3 siblings, 0 replies; 6+ messages in thread
From: Frank Lee @ 2018-10-18 15:58 UTC (permalink / raw)
To: joel, tglx
Cc: mingo, rostedt, frederic, Paul McKenney, alexander.levin, linux-kernel
This place looks like a small mistake. :-)
-- Yangtao Li
>On Thu, 18 Oct 2018
>Steven Rostedt (VMware) <rostedt@goodmis.org> wrote:
>I don't know if the trivial tree is dead or not, but this would be a
>prime candidate.
>
>Acked-by: Steven Rostedt (VMware) <rostedt@goodmis.org>
>
>-- Steve
>
>
>On Thu, 18 Oct 2018 10:21:33 -0400
>Yangtao Li <tiny.windzz@gmail.com> wrote:
>
>> ---
>> kernel/softirq.c | 2 +-
>> 1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/kernel/softirq.c b/kernel/softirq.c
>> index 6f584861d329..6193e1d1b30d 100644
>> --- a/kernel/softirq.c
>> +++ b/kernel/softirq.c
>> @@ -257,7 +257,7 @@ asmlinkage __visible void __softirq_entry __do_softirq(void)
>> int softirq_bit;
>>
>> /*
>> - * Mask out PF_MEMALLOC s current task context is borrowed for the
>> + * Mask out PF_MEMALLOC as current task context is borrowed for the
>> * softirq. A softirq handled such as network RX might set PF_MEMALLOC
>> * again if the socket is related to swap
>> */
On Thu, Oct 18, 2018 at 10:21 PM Yangtao Li <tiny.windzz@gmail.com> wrote:
>
> ---
> kernel/softirq.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/kernel/softirq.c b/kernel/softirq.c
> index 6f584861d329..6193e1d1b30d 100644
> --- a/kernel/softirq.c
> +++ b/kernel/softirq.c
> @@ -257,7 +257,7 @@ asmlinkage __visible void __softirq_entry __do_softirq(void)
> int softirq_bit;
>
> /*
> - * Mask out PF_MEMALLOC s current task context is borrowed for the
> + * Mask out PF_MEMALLOC as current task context is borrowed for the
> * softirq. A softirq handled such as network RX might set PF_MEMALLOC
> * again if the socket is related to swap
> */
> --
> 2.17.0
>
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH] softirq: modify comments about PF_MEMALLOC in __do_softirq
2018-10-18 14:21 [PATCH] softirq: modify comments about PF_MEMALLOC in __do_softirq Yangtao Li
2018-10-18 15:12 ` Steven Rostedt
2018-10-18 15:58 ` Frank Lee
@ 2018-10-18 16:10 ` Ingo Molnar
2018-10-18 16:19 ` Frank Lee
2018-10-18 16:13 ` [tip:irq/core] softirq: Fix typo in __do_softirq() comments tip-bot for Yangtao Li
3 siblings, 1 reply; 6+ messages in thread
From: Ingo Molnar @ 2018-10-18 16:10 UTC (permalink / raw)
To: Yangtao Li
Cc: joel, tglx, rostedt, frederic, paulmck, alexander.levin, linux-kernel
* Yangtao Li <tiny.windzz@gmail.com> wrote:
> ---
> kernel/softirq.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/kernel/softirq.c b/kernel/softirq.c
> index 6f584861d329..6193e1d1b30d 100644
> --- a/kernel/softirq.c
> +++ b/kernel/softirq.c
> @@ -257,7 +257,7 @@ asmlinkage __visible void __softirq_entry __do_softirq(void)
> int softirq_bit;
>
> /*
> - * Mask out PF_MEMALLOC s current task context is borrowed for the
> + * Mask out PF_MEMALLOC as current task context is borrowed for the
> * softirq. A softirq handled such as network RX might set PF_MEMALLOC
> * again if the socket is related to swap
> */
Can I add your Signed-off-by?
Thanks,
Ingo
^ permalink raw reply [flat|nested] 6+ messages in thread
* [tip:irq/core] softirq: Fix typo in __do_softirq() comments
2018-10-18 14:21 [PATCH] softirq: modify comments about PF_MEMALLOC in __do_softirq Yangtao Li
` (2 preceding siblings ...)
2018-10-18 16:10 ` Ingo Molnar
@ 2018-10-18 16:13 ` tip-bot for Yangtao Li
3 siblings, 0 replies; 6+ messages in thread
From: tip-bot for Yangtao Li @ 2018-10-18 16:13 UTC (permalink / raw)
To: linux-tip-commits
Cc: torvalds, mingo, peterz, tglx, linux-kernel, hpa, tiny.windzz
Commit-ID: e45506ac0af9b56b221863e9649fe122d8bb42ff
Gitweb: https://git.kernel.org/tip/e45506ac0af9b56b221863e9649fe122d8bb42ff
Author: Yangtao Li <tiny.windzz@gmail.com>
AuthorDate: Thu, 18 Oct 2018 10:21:33 -0400
Committer: Ingo Molnar <mingo@kernel.org>
CommitDate: Thu, 18 Oct 2018 18:10:23 +0200
softirq: Fix typo in __do_softirq() comments
s/s/as
[ mingo: Also add a missing 'the', add proper punctuation and clarify what 'swap' means here. ]
Signed-off-by: Yangtao Li <tiny.windzz@gmail.com>
Cc: Linus Torvalds <torvalds@linux-foundation.org>
Cc: Peter Zijlstra <peterz@infradead.org>
Cc: Thomas Gleixner <tglx@linutronix.de>
Cc: alexander.levin@verizon.com
Cc: frederic@kernel.org
Cc: joel@joelfernandes.org
Cc: paulmck@linux.vnet.ibm.com
Cc: rostedt@goodmis.org
Link: http://lkml.kernel.org/r/20181018142133.12341-1-tiny.windzz@gmail.com
Signed-off-by: Ingo Molnar <mingo@kernel.org>
---
kernel/softirq.c | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
diff --git a/kernel/softirq.c b/kernel/softirq.c
index 6f584861d329..9526895fe4ac 100644
--- a/kernel/softirq.c
+++ b/kernel/softirq.c
@@ -257,9 +257,9 @@ asmlinkage __visible void __softirq_entry __do_softirq(void)
int softirq_bit;
/*
- * Mask out PF_MEMALLOC s current task context is borrowed for the
- * softirq. A softirq handled such as network RX might set PF_MEMALLOC
- * again if the socket is related to swap
+ * Mask out PF_MEMALLOC as the current task context is borrowed for the
+ * softirq. A softirq handled, such as network RX, might set PF_MEMALLOC
+ * again if the socket is related to swapping.
*/
current->flags &= ~PF_MEMALLOC;
^ permalink raw reply related [flat|nested] 6+ messages in thread
* Re: [PATCH] softirq: modify comments about PF_MEMALLOC in __do_softirq
2018-10-18 16:10 ` Ingo Molnar
@ 2018-10-18 16:19 ` Frank Lee
0 siblings, 0 replies; 6+ messages in thread
From: Frank Lee @ 2018-10-18 16:19 UTC (permalink / raw)
To: mingo
Cc: joel, tglx, rostedt, frederic, Paul McKenney, alexander.levin,
linux-kernel
>On Thu, 18 Oct 2018
>Ingo Molnar <mingo@kernel.org> wrote:
>* Yangtao Li <tiny.windzz@gmail.com> wrote:
>
>> ---
>> kernel/softirq.c | 2 +-
>> 1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/kernel/softirq.c b/kernel/softirq.c
>> index 6f584861d329..6193e1d1b30d 100644
>> --- a/kernel/softirq.c
>> +++ b/kernel/softirq.c
>> @@ -257,7 +257,7 @@ asmlinkage __visible void __softirq_entry __do_softirq(void)
>> int softirq_bit;
>>
>> /*
>> - * Mask out PF_MEMALLOC s current task context is borrowed for the
>> + * Mask out PF_MEMALLOC as current task context is borrowed for the
>> * softirq. A softirq handled such as network RX might set PF_MEMALLOC
>> * again if the socket is related to swap
>> */
>
>Can I add your Signed-off-by?
>
>Thanks,
>
> Ingo
yeah，Thanks
-- Yangtao Li
Signed-off-by: Yangtao Li <tiny.windzz@gmail.com>
On Fri, Oct 19, 2018 at 12:10 AM Ingo Molnar <mingo@kernel.org> wrote:
>
>
> * Yangtao Li <tiny.windzz@gmail.com> wrote:
>
> > ---
> > kernel/softirq.c | 2 +-
> > 1 file changed, 1 insertion(+), 1 deletion(-)
> >
> > diff --git a/kernel/softirq.c b/kernel/softirq.c
> > index 6f584861d329..6193e1d1b30d 100644
> > --- a/kernel/softirq.c
> > +++ b/kernel/softirq.c
> > @@ -257,7 +257,7 @@ asmlinkage __visible void __softirq_entry __do_softirq(void)
> > int softirq_bit;
> >
> > /*
> > - * Mask out PF_MEMALLOC s current task context is borrowed for the
> > + * Mask out PF_MEMALLOC as current task context is borrowed for the
> > * softirq. A softirq handled such as network RX might set PF_MEMALLOC
> > * again if the socket is related to swap
> > */
>
> Can I add your Signed-off-by?
>
> Thanks,
>
> Ingo
^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2018-10-18 16:20 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2018-10-18 14:21 [PATCH] softirq: modify comments about PF_MEMALLOC in __do_softirq Yangtao Li
2018-10-18 15:12 ` Steven Rostedt
2018-10-18 15:58 ` Frank Lee
2018-10-18 16:10 ` Ingo Molnar
2018-10-18 16:19 ` Frank Lee
2018-10-18 16:13 ` [tip:irq/core] softirq: Fix typo in __do_softirq() comments tip-bot for Yangtao Li
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.