* [PATCH] ath10k: enable peer stats by default
@ 2016-09-06 19:05 ` Thomas Pedersen
0 siblings, 0 replies; 6+ messages in thread
From: Thomas Pedersen @ 2016-09-06 19:05 UTC (permalink / raw)
To: ath10k; +Cc: linux-wireless, Thomas Pedersen
IFTYPE_MESH_POINT need to rely on these for accurate path
selection metrics. Other modes will probably also find
them useful. Enabling peer stats has the side effect of
reducing max number of STAs from 128 to 118. There should
be negligible performance impact.
If users really need 128 STAs and don't mind losing out on
peer stats, they can still disable them:
echo 0 > debugfs/ieee80211/phyn/ath10k/peer_stats
Signed-off-by: Thomas Pedersen <twp@qca.qualcomm.com>
---
drivers/net/wireless/ath/ath10k/core.c | 3 +++
1 file changed, 3 insertions(+)
diff --git a/drivers/net/wireless/ath/ath10k/core.c b/drivers/net/wireless/ath/ath10k/core.c
index c9d163e..c0ab4f4 100644
--- a/drivers/net/wireless/ath/ath10k/core.c
+++ b/drivers/net/wireless/ath/ath10k/core.c
@@ -2145,6 +2145,9 @@ static void ath10k_core_register_work(struct work_struct *work)
struct ath10k *ar = container_of(work, struct ath10k, register_work);
int status;
+ /* peer stats are enabled by default */
+ set_bit(ATH10K_FLAG_PEER_STATS, &ar->dev_flags);
+
status = ath10k_core_probe_fw(ar);
if (status) {
ath10k_err(ar, "could not probe fw (%d)\n", status);
--
2.1.4
^ permalink raw reply related [flat|nested] 6+ messages in thread
* [PATCH] ath10k: enable peer stats by default
@ 2016-09-06 19:05 ` Thomas Pedersen
0 siblings, 0 replies; 6+ messages in thread
From: Thomas Pedersen @ 2016-09-06 19:05 UTC (permalink / raw)
To: ath10k; +Cc: Thomas Pedersen, linux-wireless
IFTYPE_MESH_POINT need to rely on these for accurate path
selection metrics. Other modes will probably also find
them useful. Enabling peer stats has the side effect of
reducing max number of STAs from 128 to 118. There should
be negligible performance impact.
If users really need 128 STAs and don't mind losing out on
peer stats, they can still disable them:
echo 0 > debugfs/ieee80211/phyn/ath10k/peer_stats
Signed-off-by: Thomas Pedersen <twp@qca.qualcomm.com>
---
drivers/net/wireless/ath/ath10k/core.c | 3 +++
1 file changed, 3 insertions(+)
diff --git a/drivers/net/wireless/ath/ath10k/core.c b/drivers/net/wireless/ath/ath10k/core.c
index c9d163e..c0ab4f4 100644
--- a/drivers/net/wireless/ath/ath10k/core.c
+++ b/drivers/net/wireless/ath/ath10k/core.c
@@ -2145,6 +2145,9 @@ static void ath10k_core_register_work(struct work_struct *work)
struct ath10k *ar = container_of(work, struct ath10k, register_work);
int status;
+ /* peer stats are enabled by default */
+ set_bit(ATH10K_FLAG_PEER_STATS, &ar->dev_flags);
+
status = ath10k_core_probe_fw(ar);
if (status) {
ath10k_err(ar, "could not probe fw (%d)\n", status);
--
2.1.4
_______________________________________________
ath10k mailing list
ath10k@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/ath10k
^ permalink raw reply related [flat|nested] 6+ messages in thread
* Re: ath10k: enable peer stats by default
2016-09-06 19:05 ` Thomas Pedersen
@ 2016-09-13 12:26 ` Kalle Valo
-1 siblings, 0 replies; 6+ messages in thread
From: Kalle Valo @ 2016-09-13 12:26 UTC (permalink / raw)
To: Pedersen, Thomas; +Cc: ath10k, Thomas Pedersen, linux-wireless
"Pedersen, Thomas" <twp@qca.qualcomm.com> wrote:
> IFTYPE_MESH_POINT need to rely on these for accurate path
> selection metrics. Other modes will probably also find
> them useful. Enabling peer stats has the side effect of
> reducing max number of STAs from 128 to 118. There should
> be negligible performance impact.
>
> If users really need 128 STAs and don't mind losing out on
> peer stats, they can still disable them:
>
> echo 0 > debugfs/ieee80211/phyn/ath10k/peer_stats
>
> Signed-off-by: Thomas Pedersen <twp@qca.qualcomm.com>
Thanks, 1 patch applied to ath-next branch of ath.git:
8c1d7fa53166 ath10k: enable peer stats by default
--
Sent by pwcli
https://patchwork.kernel.org/patch/9317865/
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: ath10k: enable peer stats by default
@ 2016-09-13 12:26 ` Kalle Valo
0 siblings, 0 replies; 6+ messages in thread
From: Kalle Valo @ 2016-09-13 12:26 UTC (permalink / raw)
To: Pedersen, Thomas; +Cc: linux-wireless, ath10k
"Pedersen, Thomas" <twp@qca.qualcomm.com> wrote:
> IFTYPE_MESH_POINT need to rely on these for accurate path
> selection metrics. Other modes will probably also find
> them useful. Enabling peer stats has the side effect of
> reducing max number of STAs from 128 to 118. There should
> be negligible performance impact.
>
> If users really need 128 STAs and don't mind losing out on
> peer stats, they can still disable them:
>
> echo 0 > debugfs/ieee80211/phyn/ath10k/peer_stats
>
> Signed-off-by: Thomas Pedersen <twp@qca.qualcomm.com>
Thanks, 1 patch applied to ath-next branch of ath.git:
8c1d7fa53166 ath10k: enable peer stats by default
--
Sent by pwcli
https://patchwork.kernel.org/patch/9317865/
_______________________________________________
ath10k mailing list
ath10k@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/ath10k
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH] ath10k: enable peer stats by default
2016-09-06 19:05 ` Thomas Pedersen
@ 2016-10-02 16:03 ` Yeoh Chun-Yeow
-1 siblings, 0 replies; 6+ messages in thread
From: Yeoh Chun-Yeow @ 2016-10-02 16:03 UTC (permalink / raw)
To: Thomas Pedersen; +Cc: ath10k, linux-wireless
Hi, Thomas
On Wed, Sep 7, 2016 at 3:05 AM, Thomas Pedersen <twp@qca.qualcomm.com> wrote:
> IFTYPE_MESH_POINT need to rely on these for accurate path
> selection metrics. Other modes will probably also find
Both get expected throughput or get txrate are not available to
mac80211. So, is this useful by enabling it?
----
Chun-Yeow
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH] ath10k: enable peer stats by default
@ 2016-10-02 16:03 ` Yeoh Chun-Yeow
0 siblings, 0 replies; 6+ messages in thread
From: Yeoh Chun-Yeow @ 2016-10-02 16:03 UTC (permalink / raw)
To: Thomas Pedersen; +Cc: linux-wireless, ath10k
Hi, Thomas
On Wed, Sep 7, 2016 at 3:05 AM, Thomas Pedersen <twp@qca.qualcomm.com> wrote:
> IFTYPE_MESH_POINT need to rely on these for accurate path
> selection metrics. Other modes will probably also find
Both get expected throughput or get txrate are not available to
mac80211. So, is this useful by enabling it?
----
Chun-Yeow
_______________________________________________
ath10k mailing list
ath10k@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/ath10k
^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2016-10-02 16:10 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2016-09-06 19:05 [PATCH] ath10k: enable peer stats by default Thomas Pedersen
2016-09-06 19:05 ` Thomas Pedersen
2016-09-13 12:26 ` Kalle Valo
2016-09-13 12:26 ` Kalle Valo
2016-10-02 16:03 ` [PATCH] " Yeoh Chun-Yeow
2016-10-02 16:03 ` Yeoh Chun-Yeow
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.