Re: [meta-browser][PATCH 1/2] firefox: remove nss private libs setting

[Max Krummenacher <max.oss.09@gmail.com>]

ping

Any comments on this one?

Max


2017-01-17 0:09 GMT+01:00 Max Krummenacher <max.oss.09@gmail.com>:
> Commit 8cc038d uses the system's nss rather than building a private
> one. So one should remove the nss libs from PRIVATE_LIBS also.
> Otherwise bitbake does not add nss to RDEPENDS automatically resulting
> in a potentially missing nss package in an image.
> Additianlly bitbake shows the following warning:
>
> | WARNING: firefox-45.6.0esr-r0 do_package_qa: QA Issue: /usr/lib/firefox/libxul.so
> |   contained in package firefox requires libnss3.so(NSS_3.12),
> |   but no providers found in RDEPENDS_firefox? [file-rdeps]
>
> Signed-off-by: Max Krummenacher <max.krummenacher@toradex.com>
> ---
>  recipes-mozilla/firefox/firefox_45.6.0esr.bb | 12 ------------
>  1 file changed, 12 deletions(-)
>
> diff --git a/recipes-mozilla/firefox/firefox_45.6.0esr.bb b/recipes-mozilla/firefox/firefox_45.6.0esr.bb
> index bed50dd..31b3353 100644
> --- a/recipes-mozilla/firefox/firefox_45.6.0esr.bb
> +++ b/recipes-mozilla/firefox/firefox_45.6.0esr.bb
> @@ -95,15 +95,3 @@ PRIVATE_LIBS = "libmozjs.so \
>                  libmozsqlite3.so \
>                  libbrowsercomps.so \
>                  libclearkey.so"
> -
> -# mark libraries also provided by nss as private too
> -PRIVATE_LIBS += " \
> -    libfreebl3.so \
> -    libnss3.so \
> -    libnssckbi.so \
> -    libsmime3.so \
> -    libnssutil3.so \
> -    libnssdbm3.so \
> -    libssl3.so \
> -    libsoftokn3.so \
> -"
> --
> 2.6.6
>