From: Otavio Salvador <otavio.salvador@ossystems.com.br>
To: OpenEmbedded Devel List <openembedded-devel@lists.openembedded.org>
Subject: Re: [meta-browser][PATCH 2/2] README: add -s to git send-email example
Date: Fri, 27 Jan 2017 09:55:09 -0200 [thread overview]
Message-ID: <CAP9ODKq0xKnunRytwo0FPLUD+15cXptb3E_BJuOUroXbwcVWhg@mail.gmail.com> (raw)
In-Reply-To: <1485515717.2825.12.camel@gmail.com>
On Fri, Jan 27, 2017 at 9:15 AM, Max Krummenacher <max.oss.09@gmail.com> wrote:
> Am Freitag, den 27.01.2017, 11:28 +0100 schrieb Anders Darander:
>> * Otavio Salvador <otavio.salvador@ossystems.com.br> [170127 11:12]:
>>
>> > On Thu, Jan 26, 2017 at 11:03 PM, Khem Raj <raj.khem@gmail.com> wrote:
>> > > what happens if commits are already having a sign-off ?
>>
>> > A new one is added.
>>
>> Then I don't think this change should be made.
>
> I tested it. That depends on who did the sign-off.
>
> You end up with two sign-off lines only if the are not identical, e.g. the committer and submitter
> are different.
>
> I went now through the READMEs of all installed layers and about half of them propose the '-s' while
> the other half does not.
> So I guess we should drop this patch.
I prefer if we adopt it.
--
Otavio Salvador O.S. Systems
http://www.ossystems.com.br http://code.ossystems.com.br
Mobile: +55 (53) 9981-7854 Mobile: +1 (347) 903-9750
next prev parent reply other threads:[~2017-01-27 11:55 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-01-16 23:09 [meta-browser][PATCH 1/2] firefox: remove nss private libs setting Max Krummenacher
2017-01-16 23:09 ` [meta-browser][PATCH 2/2] README: add -s to git send-email example Max Krummenacher
2017-01-26 22:27 ` Max Krummenacher
2017-01-27 1:03 ` Khem Raj
2017-01-27 10:10 ` Otavio Salvador
2017-01-27 10:28 ` Anders Darander
2017-01-27 11:15 ` Max Krummenacher
2017-01-27 11:55 ` Otavio Salvador [this message]
2017-01-27 17:40 ` Khem Raj
2017-01-26 22:27 ` [meta-browser][PATCH 1/2] firefox: remove nss private libs setting Max Krummenacher
2017-01-27 1:02 ` Khem Raj
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAP9ODKq0xKnunRytwo0FPLUD+15cXptb3E_BJuOUroXbwcVWhg@mail.gmail.com \
--to=otavio.salvador@ossystems.com.br \
--cc=openembedded-devel@lists.openembedded.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.