All of lore.kernel.org
 help / color / mirror / Atom feed
From: Jae hoon Chung <jh80.chung@gmail.com>
To: Will Newton <will.newton@gmail.com>
Cc: Seungwon Jeon <tgih.jun@samsung.com>,
	linux-mmc@vger.kernel.org, cjb@laptop.org,
	linux-kernel@vger.kernel.org
Subject: Re: [PATCH] mmc: dw_mmc: Fix DDR mode support.
Date: Fri, 5 Aug 2011 22:35:36 +0100	[thread overview]
Message-ID: <CAELcNGTNA83nD3kCh=-BJ6DxRqnNaRznn3mTd5PVY_fRArp+fA@mail.gmail.com> (raw)
In-Reply-To: <CAFbHwiT3p3pSC1q4xQRYkLzSG7tPuGLXB4KKwC-8HWMmtF+fhA@mail.gmail.com>

Hi Seungwon

This patch is looks fine to me..

Just ask to you...Don't you want to locate MMC_CAP_MMC_HIGHSPEED in platdata?

Regards,
Jaehoon Chung


2011/8/5 Will Newton <will.newton@gmail.com>:
> On Fri, Aug 5, 2011 at 4:35 AM, Seungwon Jeon <tgih.jun@samsung.com> wrote:
>> Host driver can't get a hint of DDR mode through ios->ddr flag anymore.
>> ios->timing is currently used to inform DDR mode as a substitute.
>> And capability of MMC_CAP_MMC_HIGHSPEED is added for DDR support.
>>
>> Signed-off-by: Seungwon Jeon <tgih.jun@samsung.com>
>> ---
>>  drivers/mmc/host/dw_mmc.c |    4 ++--
>>  1 files changed, 2 insertions(+), 2 deletions(-)
>>
>> diff --git a/drivers/mmc/host/dw_mmc.c b/drivers/mmc/host/dw_mmc.c
>> index d65511e..b412a1d 100644
>> --- a/drivers/mmc/host/dw_mmc.c
>> +++ b/drivers/mmc/host/dw_mmc.c
>> @@ -699,7 +699,7 @@ static void dw_mci_set_ios(struct mmc_host *mmc, struct mmc_ios *ios)
>>        }
>>
>>        /* DDR mode set */
>> -       if (ios->ddr) {
>> +       if (ios->timing == MMC_TIMING_UHS_DDR50) {
>>                regs = mci_readl(slot->host, UHS_REG);
>>                regs |= (0x1 << slot->id) << 16;
>>                mci_writel(slot->host, UHS_REG, regs);
>> @@ -1646,7 +1646,7 @@ static int __init dw_mci_init_slot(struct dw_mci *host, unsigned int id)
>>                        mmc->caps |= MMC_CAP_4_BIT_DATA;
>>
>>        if (host->pdata->quirks & DW_MCI_QUIRK_HIGHSPEED)
>> -               mmc->caps |= MMC_CAP_SD_HIGHSPEED;
>> +               mmc->caps |= MMC_CAP_SD_HIGHSPEED | MMC_CAP_MMC_HIGHSPEED;
>>
>>  #ifdef CONFIG_MMC_DW_IDMAC
>>        mmc->max_segs = host->ring_size;
>> --
>> 1.7.0.4
>
> Acked-by: Will Newton <will.newton@imgtec.com>
> --
> To unsubscribe from this list: send the line "unsubscribe linux-mmc" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at  http://vger.kernel.org/majordomo-info.html
>

  reply	other threads:[~2011-08-05 21:35 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-08-05  3:35 [PATCH] mmc: dw_mmc: Fix DDR mode support Seungwon Jeon
2011-08-05 10:20 ` Will Newton
2011-08-05 21:35   ` Jae hoon Chung [this message]
2011-08-08  1:38     ` Seungwon Jeon
2011-08-11 21:38 ` Chris Ball

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to='CAELcNGTNA83nD3kCh=-BJ6DxRqnNaRznn3mTd5PVY_fRArp+fA@mail.gmail.com' \
    --to=jh80.chung@gmail.com \
    --cc=cjb@laptop.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-mmc@vger.kernel.org \
    --cc=tgih.jun@samsung.com \
    --cc=will.newton@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.