All of lore.kernel.org
 help / color / mirror / Atom feed
* [PATCH] sched/rt: Fix build after c/s c3715dd8fb766
@ 2018-03-08 11:12 Andrew Cooper
  2018-03-08 16:58 ` George Dunlap
  2018-03-08 18:16 ` Meng Xu
  0 siblings, 2 replies; 3+ messages in thread
From: Andrew Cooper @ 2018-03-08 11:12 UTC (permalink / raw)
  To: Xen-devel; +Cc: George Dunlap, Andrew Cooper, Meng Xu, Dario Faggioli

Travis reports:

  sched_rt.c:241:30: error: unused function 'rt_dom' [-Werror,-Wunused-function]
  static inline struct rt_dom *rt_dom(const struct domain *dom)
                               ^
  1 error generated.

when compiling with Clang.  Drop the function.

Signed-off-by: Andrew Cooper <andrew.cooper3@citrix.com>
---
CC: George Dunlap <george.dunlap@eu.citrix.com>
CC: Dario Faggioli <dfaggioli@suse.com>
CC: Meng Xu <mengxu@cis.upenn.edu>
---
 xen/common/sched_rt.c | 5 -----
 1 file changed, 5 deletions(-)

diff --git a/xen/common/sched_rt.c b/xen/common/sched_rt.c
index 1c72ea8..ac79f15 100644
--- a/xen/common/sched_rt.c
+++ b/xen/common/sched_rt.c
@@ -238,11 +238,6 @@ static inline struct rt_vcpu *rt_vcpu(const struct vcpu *vcpu)
     return vcpu->sched_priv;
 }
 
-static inline struct rt_dom *rt_dom(const struct domain *dom)
-{
-    return dom->sched_priv;
-}
-
 static inline struct list_head *rt_runq(const struct scheduler *ops)
 {
     return &rt_priv(ops)->runq;
-- 
2.1.4


_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xenproject.org
https://lists.xenproject.org/mailman/listinfo/xen-devel

^ permalink raw reply related	[flat|nested] 3+ messages in thread

* Re: [PATCH] sched/rt: Fix build after c/s c3715dd8fb766
  2018-03-08 11:12 [PATCH] sched/rt: Fix build after c/s c3715dd8fb766 Andrew Cooper
@ 2018-03-08 16:58 ` George Dunlap
  2018-03-08 18:16 ` Meng Xu
  1 sibling, 0 replies; 3+ messages in thread
From: George Dunlap @ 2018-03-08 16:58 UTC (permalink / raw)
  To: Andrew Cooper, Xen-devel; +Cc: George Dunlap, Meng Xu, Dario Faggioli

On 03/08/2018 11:12 AM, Andrew Cooper wrote:
> Travis reports:
> 
>   sched_rt.c:241:30: error: unused function 'rt_dom' [-Werror,-Wunused-function]
>   static inline struct rt_dom *rt_dom(const struct domain *dom)
>                                ^
>   1 error generated.
> 
> when compiling with Clang.  Drop the function.
> 
> Signed-off-by: Andrew Cooper <andrew.cooper3@citrix.com>

Reviewed-by: George Dunlap <george.dunlap@citrix.com>


_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xenproject.org
https://lists.xenproject.org/mailman/listinfo/xen-devel

^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: [PATCH] sched/rt: Fix build after c/s c3715dd8fb766
  2018-03-08 11:12 [PATCH] sched/rt: Fix build after c/s c3715dd8fb766 Andrew Cooper
  2018-03-08 16:58 ` George Dunlap
@ 2018-03-08 18:16 ` Meng Xu
  1 sibling, 0 replies; 3+ messages in thread
From: Meng Xu @ 2018-03-08 18:16 UTC (permalink / raw)
  To: Andrew Cooper; +Cc: George Dunlap, Dario Faggioli, Xen-devel

On Thu, Mar 8, 2018 at 6:12 AM, Andrew Cooper <andrew.cooper3@citrix.com> wrote:
>
> Travis reports:
>
>   sched_rt.c:241:30: error: unused function 'rt_dom' [-Werror,-Wunused-function]
>   static inline struct rt_dom *rt_dom(const struct domain *dom)
>                                ^
>   1 error generated.
>
> when compiling with Clang.  Drop the function.
>
> Signed-off-by: Andrew Cooper <andrew.cooper3@citrix.com>
> ---


Reviewed-by: Meng Xu <mengxu@cis.upenn.edu>

Thank you very much!

Meng

_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xenproject.org
https://lists.xenproject.org/mailman/listinfo/xen-devel

^ permalink raw reply	[flat|nested] 3+ messages in thread

end of thread, other threads:[~2018-03-08 18:16 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2018-03-08 11:12 [PATCH] sched/rt: Fix build after c/s c3715dd8fb766 Andrew Cooper
2018-03-08 16:58 ` George Dunlap
2018-03-08 18:16 ` Meng Xu

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.