* [Patch] openvswitch: remove some useless comments
@ 2013-02-22 11:41 Cong Wang
2013-02-23 1:04 ` Jesse Gross
0 siblings, 1 reply; 2+ messages in thread
From: Cong Wang @ 2013-02-22 11:41 UTC (permalink / raw)
To: netdev; +Cc: David S. Miller, Jesse Gross, Cong Wang
From: Cong Wang <amwang@redhat.com>
These comments are useless in upstream kernel.
Cc: David S. Miller <davem@davemloft.net>
Cc: Jesse Gross <jesse@nicira.com>
Signed-off-by: Cong Wang <amwang@redhat.com>
---
diff --git a/net/openvswitch/vport-netdev.c b/net/openvswitch/vport-netdev.c
index 670cbc3..2130d61 100644
--- a/net/openvswitch/vport-netdev.c
+++ b/net/openvswitch/vport-netdev.c
@@ -43,8 +43,7 @@ static void netdev_port_receive(struct vport *vport, struct sk_buff *skb)
/* Make our own copy of the packet. Otherwise we will mangle the
* packet for anyone who came before us (e.g. tcpdump via AF_PACKET).
- * (No one comes after us, since we tell handle_bridge() that we took
- * the packet.) */
+ */
skb = skb_share_check(skb, GFP_ATOMIC);
if (unlikely(!skb))
return;
diff --git a/net/openvswitch/vport.c b/net/openvswitch/vport.c
index 70af0be..6255e48 100644
--- a/net/openvswitch/vport.c
+++ b/net/openvswitch/vport.c
@@ -326,8 +326,7 @@ int ovs_vport_get_options(const struct vport *vport, struct sk_buff *skb)
* @skb: skb that was received
*
* Must be called with rcu_read_lock. The packet cannot be shared and
- * skb->data should point to the Ethernet header. The caller must have already
- * called compute_ip_summed() to initialize the checksumming fields.
+ * skb->data should point to the Ethernet header.
*/
void ovs_vport_receive(struct vport *vport, struct sk_buff *skb)
{
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [Patch] openvswitch: remove some useless comments
2013-02-22 11:41 [Patch] openvswitch: remove some useless comments Cong Wang
@ 2013-02-23 1:04 ` Jesse Gross
0 siblings, 0 replies; 2+ messages in thread
From: Jesse Gross @ 2013-02-23 1:04 UTC (permalink / raw)
To: Cong Wang; +Cc: netdev, David S. Miller
On Fri, Feb 22, 2013 at 3:41 AM, Cong Wang <amwang@redhat.com> wrote:
> From: Cong Wang <amwang@redhat.com>
>
> These comments are useless in upstream kernel.
>
> Cc: David S. Miller <davem@davemloft.net>
> Cc: Jesse Gross <jesse@nicira.com>
> Signed-off-by: Cong Wang <amwang@redhat.com>
Also applied.
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2013-02-23 1:05 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2013-02-22 11:41 [Patch] openvswitch: remove some useless comments Cong Wang
2013-02-23 1:04 ` Jesse Gross
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.