* [Buildroot] squashfs-fuse: new package @ 2017-07-31 2:59 Dave Bender 2017-07-31 18:49 ` Thomas Petazzoni 0 siblings, 1 reply; 4+ messages in thread From: Dave Bender @ 2017-07-31 2:59 UTC (permalink / raw) To: buildroot Added FUSE squashfs utilities Signed-off-by: David Bender <codehero@gmail.com> --- package/Config.in | 1 + package/squashfs-fuse/Config.in | 14 ++++++++++++++ package/squashfs-fuse/squashfs-fuse.mk | 14 ++++++++++++++ 3 files changed, 29 insertions(+) create mode 100644 package/squashfs-fuse/Config.in create mode 100644 package/squashfs-fuse/squashfs-fuse.mk diff --git a/package/Config.in b/package/Config.in index 9e90d98..2691a47 100644 --- a/package/Config.in +++ b/package/Config.in @@ -191,6 +191,7 @@ menu "Filesystem and flash utilities" source "package/sunxi-tools/Config.in" source "package/unionfs/Config.in" source "package/xfsprogs/Config.in" + source "package/squashfs-fuse/Config.in" endmenu menu "Fonts, cursors, icons, sounds and themes" diff --git a/package/squashfs-fuse/Config.in b/package/squashfs-fuse/Config.in new file mode 100644 index 0000000..b5f3537 --- /dev/null +++ b/package/squashfs-fuse/Config.in @@ -0,0 +1,14 @@ +config BR2_PACKAGE_SQUASHFS_FUSE + bool "squashfs (FUSE)" + select BR2_PACKAGE_LIBFUSE + depends on BR2_TOOLCHAIN_HAS_THREADS # libfuse + depends on BR2_USE_MMU # libfuse + depends on !BR2_STATIC_LIBS # libfuse + help + A userspace squashfs implementation. + + https://github.com/vasi/squashfuse + +comment "squashfs needs a toolchain w/ threads, dynamic library" + depends on BR2_USE_MMU + depends on !BR2_TOOLCHAIN_HAS_THREADS || BR2_STATIC_LIBS diff --git a/package/squashfs-fuse/squashfs-fuse.mk b/package/squashfs-fuse/squashfs-fuse.mk new file mode 100644 index 0000000..812a197 --- /dev/null +++ b/package/squashfs-fuse/squashfs-fuse.mk @@ -0,0 +1,14 @@ +################################################################################ +# +# Squashfs-fuse +# +################################################################################ + +SQUASHFS_FUSE_VERSION = 1f980303b89c779eabfd0a0fdd36d6a7a311bf92 +SQUASHFS_FUSE_SITE = $(call github,vasi,squashfuse,$(SQUASHFS_FUSE_VERSION)) +SQUASHFS_FUSE_DEPENDENCIES = libfuse host-pkgconf +SQUASHFS_FUSE_LICENSE = BSD-2c +SQUASHFS_FUSE_LICENSE_FILES = LICENSE +SQUASHFS_FUSE_AUTORECONF = YES + +$(eval $(autotools-package)) -- 2.10.2 ^ permalink raw reply related [flat|nested] 4+ messages in thread
* [Buildroot] squashfs-fuse: new package 2017-07-31 2:59 [Buildroot] squashfs-fuse: new package Dave Bender @ 2017-07-31 18:49 ` Thomas Petazzoni 2017-08-01 10:25 ` Dave Bender 0 siblings, 1 reply; 4+ messages in thread From: Thomas Petazzoni @ 2017-07-31 18:49 UTC (permalink / raw) To: buildroot Hello, On Sun, 30 Jul 2017 22:59:24 -0400, Dave Bender wrote: > Added FUSE squashfs utilities > > Signed-off-by: David Bender <codehero@gmail.com> Thanks for a contribution! See below for a few comments/issues. If you could fix them, and send an updated version, it would be nice! > --- > package/Config.in | 1 + > package/squashfs-fuse/Config.in | 14 ++++++++++++++ > package/squashfs-fuse/squashfs-fuse.mk | 14 ++++++++++++++ Please add a .hash file in the package directory, and also an entry in the top-level DEVELOPERS file. > diff --git a/package/squashfs-fuse/Config.in b/package/squashfs-fuse/Config.in > new file mode 100644 > index 0000000..b5f3537 > --- /dev/null > +++ b/package/squashfs-fuse/Config.in Indentation in this file is wrong. Look at other packages, and run utils/check-package on your package to see the problems. > @@ -0,0 +1,14 @@ > +config BR2_PACKAGE_SQUASHFS_FUSE > + bool "squashfs (FUSE)" Should be: bool "squashfs-fuse" > + select BR2_PACKAGE_LIBFUSE > + depends on BR2_TOOLCHAIN_HAS_THREADS # libfuse > + depends on BR2_USE_MMU # libfuse > + depends on !BR2_STATIC_LIBS # libfuse "depends on" before "select" (that's just a convention). > + help > + A userspace squashfs implementation. > + > + https://github.com/vasi/squashfuse > + > +comment "squashfs needs a toolchain w/ threads, dynamic library" squashfs -> squashfs-fuse > + depends on BR2_USE_MMU > + depends on !BR2_TOOLCHAIN_HAS_THREADS || BR2_STATIC_LIBS > diff --git a/package/squashfs-fuse/squashfs-fuse.mk > b/package/squashfs-fuse/squashfs-fuse.mk > new file mode 100644 > index 0000000..812a197 > --- /dev/null > +++ b/package/squashfs-fuse/squashfs-fuse.mk > @@ -0,0 +1,14 @@ > +################################################################################ > +# > +# Squashfs-fuse squashfs-fuse (lower case) > +# > +################################################################################ > + > +SQUASHFS_FUSE_VERSION = 1f980303b89c779eabfd0a0fdd36d6a7a311bf92 > +SQUASHFS_FUSE_SITE = $(call github,vasi,squashfuse,$(SQUASHFS_FUSE_VERSION)) > +SQUASHFS_FUSE_DEPENDENCIES = libfuse host-pkgconf > +SQUASHFS_FUSE_LICENSE = BSD-2c BSD-2-Clause > +SQUASHFS_FUSE_LICENSE_FILES = LICENSE > +SQUASHFS_FUSE_AUTORECONF = YES > + > +$(eval $(autotools-package)) Other than that, looks good. Thanks! Thomas -- Thomas Petazzoni, CTO, Free Electrons Embedded Linux and Kernel engineering http://free-electrons.com ^ permalink raw reply [flat|nested] 4+ messages in thread
* [Buildroot] squashfs-fuse: new package 2017-07-31 18:49 ` Thomas Petazzoni @ 2017-08-01 10:25 ` Dave Bender 2017-08-01 11:26 ` Thomas Petazzoni 0 siblings, 1 reply; 4+ messages in thread From: Dave Bender @ 2017-08-01 10:25 UTC (permalink / raw) To: buildroot Added FUSE squashfs utilities Signed-off-by: David Bender <codehero@gmail.com> --- package/Config.in | 1 + package/squashfs-fuse/Config.in | 10 ++++++++++ package/squashfs-fuse/squashfs-fuse.hash | 2 ++ package/squashfs-fuse/squashfs-fuse.mk | 14 ++++++++++++++ 4 files changed, 27 insertions(+) create mode 100644 package/squashfs-fuse/Config.in create mode 100644 package/squashfs-fuse/squashfs-fuse.hash create mode 100644 package/squashfs-fuse/squashfs-fuse.mk diff --git a/package/Config.in b/package/Config.in index 86d714dae..34cb75238 100644 --- a/package/Config.in +++ b/package/Config.in @@ -191,6 +191,7 @@ menu "Filesystem and flash utilities" source "package/sunxi-tools/Config.in" source "package/unionfs/Config.in" source "package/xfsprogs/Config.in" + source "package/squashfs-fuse/Config.in" endmenu menu "Fonts, cursors, icons, sounds and themes" diff --git a/package/squashfs-fuse/Config.in b/package/squashfs-fuse/Config.in new file mode 100644 index 000000000..753d78883 --- /dev/null +++ b/package/squashfs-fuse/Config.in @@ -0,0 +1,10 @@ +config BR2_PACKAGE_SQUASHFS_FUSE + bool "squashfs (FUSE)" + depends on BR2_TOOLCHAIN_HAS_THREADS # libfuse + depends on BR2_USE_MMU # libfuse + depends on !BR2_STATIC_LIBS # libfuse + select BR2_PACKAGE_LIBFUSE + help + A userspace squashfs implementation. + + https://github.com/vasi/squashfuse diff --git a/package/squashfs-fuse/squashfs-fuse.hash b/package/squashfs-fuse/squashfs-fuse.hash new file mode 100644 index 000000000..28b9d4175 --- /dev/null +++ b/package/squashfs-fuse/squashfs-fuse.hash @@ -0,0 +1,2 @@ +# Locally computed +sha512 f7d62e23186c8f4ab52186ea5d0c0dc02db106ef6e1a9958a83ab87e05aca068ff94f75f26b8ee31b7d7359de3cc8c569ac5c604f87bd638c561d1cdaaa9177c squashfs-fuse-1f980303b89c779eabfd0a0fdd36d6a7a311bf92.tar.gz diff --git a/package/squashfs-fuse/squashfs-fuse.mk b/package/squashfs-fuse/squashfs-fuse.mk new file mode 100644 index 000000000..bb3ce2305 --- /dev/null +++ b/package/squashfs-fuse/squashfs-fuse.mk @@ -0,0 +1,14 @@ +################################################################################ +# +# squashfs-fuse +# +################################################################################ + +SQUASHFS_FUSE_VERSION = 1f980303b89c779eabfd0a0fdd36d6a7a311bf92 +SQUASHFS_FUSE_SITE = $(call github,vasi,squashfuse,$(SQUASHFS_FUSE_VERSION)) +SQUASHFS_FUSE_DEPENDENCIES = libfuse host-pkgconf +SQUASHFS_FUSE_LICENSE = BSD-2-Clause +SQUASHFS_FUSE_LICENSE_FILES = LICENSE +SQUASHFS_FUSE_AUTORECONF = YES + +$(eval $(autotools-package)) -- 2.13.0 On Mon, Jul 31, 2017 at 2:49 PM, Thomas Petazzoni <thomas.petazzoni@free-electrons.com> wrote: > Hello, > > On Sun, 30 Jul 2017 22:59:24 -0400, Dave Bender wrote: >> Added FUSE squashfs utilities >> >> Signed-off-by: David Bender <codehero@gmail.com> > > Thanks for a contribution! See below for a few comments/issues. If you > could fix them, and send an updated version, it would be nice! > >> --- >> package/Config.in | 1 + >> package/squashfs-fuse/Config.in | 14 ++++++++++++++ >> package/squashfs-fuse/squashfs-fuse.mk | 14 ++++++++++++++ > > Please add a .hash file in the package directory, and also an entry in > the top-level DEVELOPERS file. > >> diff --git a/package/squashfs-fuse/Config.in b/package/squashfs-fuse/Config.in >> new file mode 100644 >> index 0000000..b5f3537 >> --- /dev/null >> +++ b/package/squashfs-fuse/Config.in > > Indentation in this file is wrong. Look at other packages, and run > utils/check-package on your package to see the problems. > >> @@ -0,0 +1,14 @@ >> +config BR2_PACKAGE_SQUASHFS_FUSE >> + bool "squashfs (FUSE)" > > Should be: > > bool "squashfs-fuse" > >> + select BR2_PACKAGE_LIBFUSE >> + depends on BR2_TOOLCHAIN_HAS_THREADS # libfuse >> + depends on BR2_USE_MMU # libfuse >> + depends on !BR2_STATIC_LIBS # libfuse > > "depends on" before "select" (that's just a convention). > >> + help >> + A userspace squashfs implementation. >> + >> + https://github.com/vasi/squashfuse >> + >> +comment "squashfs needs a toolchain w/ threads, dynamic library" > > squashfs -> squashfs-fuse > >> + depends on BR2_USE_MMU >> + depends on !BR2_TOOLCHAIN_HAS_THREADS || BR2_STATIC_LIBS >> diff --git a/package/squashfs-fuse/squashfs-fuse.mk >> b/package/squashfs-fuse/squashfs-fuse.mk >> new file mode 100644 >> index 0000000..812a197 >> --- /dev/null >> +++ b/package/squashfs-fuse/squashfs-fuse.mk >> @@ -0,0 +1,14 @@ >> +################################################################################ >> +# >> +# Squashfs-fuse > > squashfs-fuse (lower case) > >> +# >> +################################################################################ >> + >> +SQUASHFS_FUSE_VERSION = 1f980303b89c779eabfd0a0fdd36d6a7a311bf92 >> +SQUASHFS_FUSE_SITE = $(call github,vasi,squashfuse,$(SQUASHFS_FUSE_VERSION)) >> +SQUASHFS_FUSE_DEPENDENCIES = libfuse host-pkgconf >> +SQUASHFS_FUSE_LICENSE = BSD-2c > > BSD-2-Clause > >> +SQUASHFS_FUSE_LICENSE_FILES = LICENSE >> +SQUASHFS_FUSE_AUTORECONF = YES >> + >> +$(eval $(autotools-package)) > > Other than that, looks good. Thanks! > > Thomas > -- > Thomas Petazzoni, CTO, Free Electrons > Embedded Linux and Kernel engineering > http://free-electrons.com ^ permalink raw reply related [flat|nested] 4+ messages in thread
* [Buildroot] squashfs-fuse: new package 2017-08-01 10:25 ` Dave Bender @ 2017-08-01 11:26 ` Thomas Petazzoni 0 siblings, 0 replies; 4+ messages in thread From: Thomas Petazzoni @ 2017-08-01 11:26 UTC (permalink / raw) To: buildroot Hello, I'm not sure what you have sent below. Is this supposed to be a new iteration? If so: - It should be sent as a separate e-mail, with [PATCHv2] as the title prefix ; - It should take into account all the comments that have been made during the review. Many of the comments I made in the review have been ignored. Best regards, Thomas On Tue, 1 Aug 2017 06:25:56 -0400, Dave Bender wrote: > Added FUSE squashfs utilities > > Signed-off-by: David Bender <codehero@gmail.com> > --- > package/Config.in | 1 + > package/squashfs-fuse/Config.in | 10 ++++++++++ > package/squashfs-fuse/squashfs-fuse.hash | 2 ++ > package/squashfs-fuse/squashfs-fuse.mk | 14 ++++++++++++++ > 4 files changed, 27 insertions(+) > create mode 100644 package/squashfs-fuse/Config.in > create mode 100644 package/squashfs-fuse/squashfs-fuse.hash > create mode 100644 package/squashfs-fuse/squashfs-fuse.mk > > diff --git a/package/Config.in b/package/Config.in > index 86d714dae..34cb75238 100644 > --- a/package/Config.in > +++ b/package/Config.in > @@ -191,6 +191,7 @@ menu "Filesystem and flash utilities" > source "package/sunxi-tools/Config.in" > source "package/unionfs/Config.in" > source "package/xfsprogs/Config.in" > + source "package/squashfs-fuse/Config.in" > endmenu > > menu "Fonts, cursors, icons, sounds and themes" > diff --git a/package/squashfs-fuse/Config.in b/package/squashfs-fuse/Config.in > new file mode 100644 > index 000000000..753d78883 > --- /dev/null > +++ b/package/squashfs-fuse/Config.in > @@ -0,0 +1,10 @@ > +config BR2_PACKAGE_SQUASHFS_FUSE > + bool "squashfs (FUSE)" > + depends on BR2_TOOLCHAIN_HAS_THREADS # libfuse > + depends on BR2_USE_MMU # libfuse > + depends on !BR2_STATIC_LIBS # libfuse > + select BR2_PACKAGE_LIBFUSE > + help > + A userspace squashfs implementation. > + > + https://github.com/vasi/squashfuse > diff --git a/package/squashfs-fuse/squashfs-fuse.hash > b/package/squashfs-fuse/squashfs-fuse.hash > new file mode 100644 > index 000000000..28b9d4175 > --- /dev/null > +++ b/package/squashfs-fuse/squashfs-fuse.hash > @@ -0,0 +1,2 @@ > +# Locally computed > +sha512 f7d62e23186c8f4ab52186ea5d0c0dc02db106ef6e1a9958a83ab87e05aca068ff94f75f26b8ee31b7d7359de3cc8c569ac5c604f87bd638c561d1cdaaa9177c > squashfs-fuse-1f980303b89c779eabfd0a0fdd36d6a7a311bf92.tar.gz > diff --git a/package/squashfs-fuse/squashfs-fuse.mk > b/package/squashfs-fuse/squashfs-fuse.mk > new file mode 100644 > index 000000000..bb3ce2305 > --- /dev/null > +++ b/package/squashfs-fuse/squashfs-fuse.mk > @@ -0,0 +1,14 @@ > +################################################################################ > +# > +# squashfs-fuse > +# > +################################################################################ > + > +SQUASHFS_FUSE_VERSION = 1f980303b89c779eabfd0a0fdd36d6a7a311bf92 > +SQUASHFS_FUSE_SITE = $(call github,vasi,squashfuse,$(SQUASHFS_FUSE_VERSION)) > +SQUASHFS_FUSE_DEPENDENCIES = libfuse host-pkgconf > +SQUASHFS_FUSE_LICENSE = BSD-2-Clause > +SQUASHFS_FUSE_LICENSE_FILES = LICENSE > +SQUASHFS_FUSE_AUTORECONF = YES > + > +$(eval $(autotools-package)) -- Thomas Petazzoni, CTO, Free Electrons Embedded Linux and Kernel engineering http://free-electrons.com ^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2017-08-01 11:26 UTC | newest] Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed) -- links below jump to the message on this page -- 2017-07-31 2:59 [Buildroot] squashfs-fuse: new package Dave Bender 2017-07-31 18:49 ` Thomas Petazzoni 2017-08-01 10:25 ` Dave Bender 2017-08-01 11:26 ` Thomas Petazzoni
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.