* [PATCH] usb: xhci-dwc3: Add support for USB 3.1 controllers
@ 2021-09-16 14:00 Mark Kettenis
2021-09-16 14:08 ` Bin Meng
0 siblings, 1 reply; 5+ messages in thread
From: Mark Kettenis @ 2021-09-16 14:00 UTC (permalink / raw)
To: u-boot; +Cc: Mark Kettenis, Bin Meng, Marek Vasut
This adds support for the DWC_sub31 controllers such as those
found on Apple's M1 SoC. This version of the controller
seems to work fine with the existing driver.
Signed-off-by: Mark Kettenis <kettenis@openbsd.org>
---
drivers/usb/host/xhci-dwc3.c | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/drivers/usb/host/xhci-dwc3.c b/drivers/usb/host/xhci-dwc3.c
index 3e0ae80cec..a2ea40bae0 100644
--- a/drivers/usb/host/xhci-dwc3.c
+++ b/drivers/usb/host/xhci-dwc3.c
@@ -70,7 +70,8 @@ int dwc3_core_init(struct dwc3 *dwc3_reg)
revision = readl(&dwc3_reg->g_snpsid);
/* This should read as U3 followed by revision number */
- if ((revision & DWC3_GSNPSID_MASK) != 0x55330000) {
+ if ((revision & DWC3_GSNPSID_MASK) != 0x55330000 &&
+ (revision & DWC3_GSNPSID_MASK) != 0x33310000) {
puts("this is not a DesignWare USB3 DRD Core\n");
return -1;
}
--
2.33.0
^ permalink raw reply related [flat|nested] 5+ messages in thread
* Re: [PATCH] usb: xhci-dwc3: Add support for USB 3.1 controllers
2021-09-16 14:00 [PATCH] usb: xhci-dwc3: Add support for USB 3.1 controllers Mark Kettenis
@ 2021-09-16 14:08 ` Bin Meng
2021-09-19 8:40 ` Bin Meng
0 siblings, 1 reply; 5+ messages in thread
From: Bin Meng @ 2021-09-16 14:08 UTC (permalink / raw)
To: Mark Kettenis; +Cc: U-Boot Mailing List, Marek Vasut
On Thu, Sep 16, 2021 at 10:00 PM Mark Kettenis <kettenis@openbsd.org> wrote:
>
> This adds support for the DWC_sub31 controllers such as those
> found on Apple's M1 SoC. This version of the controller
> seems to work fine with the existing driver.
>
> Signed-off-by: Mark Kettenis <kettenis@openbsd.org>
> ---
> drivers/usb/host/xhci-dwc3.c | 3 ++-
> 1 file changed, 2 insertions(+), 1 deletion(-)
>
Reviewed-by: Bin Meng <bmeng.cn@gmail.com>
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH] usb: xhci-dwc3: Add support for USB 3.1 controllers
2021-09-16 14:08 ` Bin Meng
@ 2021-09-19 8:40 ` Bin Meng
2021-09-19 22:44 ` Marek Vasut
0 siblings, 1 reply; 5+ messages in thread
From: Bin Meng @ 2021-09-19 8:40 UTC (permalink / raw)
To: Mark Kettenis; +Cc: U-Boot Mailing List, Marek Vasut
Hi Marek,
On Thu, Sep 16, 2021 at 10:08 PM Bin Meng <bmeng.cn@gmail.com> wrote:
>
> On Thu, Sep 16, 2021 at 10:00 PM Mark Kettenis <kettenis@openbsd.org> wrote:
> >
> > This adds support for the DWC_sub31 controllers such as those
> > found on Apple's M1 SoC. This version of the controller
> > seems to work fine with the existing driver.
> >
> > Signed-off-by: Mark Kettenis <kettenis@openbsd.org>
> > ---
> > drivers/usb/host/xhci-dwc3.c | 3 ++-
> > 1 file changed, 2 insertions(+), 1 deletion(-)
> >
>
> Reviewed-by: Bin Meng <bmeng.cn@gmail.com>
I see this is assigned to me on patchwork. Would you like this to go
via the x86 tree?
Regards,
Bin
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH] usb: xhci-dwc3: Add support for USB 3.1 controllers
2021-09-19 8:40 ` Bin Meng
@ 2021-09-19 22:44 ` Marek Vasut
2021-09-20 6:43 ` Bin Meng
0 siblings, 1 reply; 5+ messages in thread
From: Marek Vasut @ 2021-09-19 22:44 UTC (permalink / raw)
To: Bin Meng, Mark Kettenis; +Cc: U-Boot Mailing List, Tom Rini
On 9/19/21 10:40 AM, Bin Meng wrote:
> Hi Marek,
>
> On Thu, Sep 16, 2021 at 10:08 PM Bin Meng <bmeng.cn@gmail.com> wrote:
>>
>> On Thu, Sep 16, 2021 at 10:00 PM Mark Kettenis <kettenis@openbsd.org> wrote:
>>>
>>> This adds support for the DWC_sub31 controllers such as those
>>> found on Apple's M1 SoC. This version of the controller
>>> seems to work fine with the existing driver.
>>>
>>> Signed-off-by: Mark Kettenis <kettenis@openbsd.org>
>>> ---
>>> drivers/usb/host/xhci-dwc3.c | 3 ++-
>>> 1 file changed, 2 insertions(+), 1 deletion(-)
>>>
>>
>> Reviewed-by: Bin Meng <bmeng.cn@gmail.com>
>
> I see this is assigned to me on patchwork. Would you like this to go
> via the x86 tree?
Since it's just one patch, I suspect Tom can just pick it directly.
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH] usb: xhci-dwc3: Add support for USB 3.1 controllers
2021-09-19 22:44 ` Marek Vasut
@ 2021-09-20 6:43 ` Bin Meng
0 siblings, 0 replies; 5+ messages in thread
From: Bin Meng @ 2021-09-20 6:43 UTC (permalink / raw)
To: Marek Vasut; +Cc: Mark Kettenis, U-Boot Mailing List, Tom Rini
On Mon, Sep 20, 2021 at 6:44 AM Marek Vasut <marex@denx.de> wrote:
>
> On 9/19/21 10:40 AM, Bin Meng wrote:
> > Hi Marek,
> >
> > On Thu, Sep 16, 2021 at 10:08 PM Bin Meng <bmeng.cn@gmail.com> wrote:
> >>
> >> On Thu, Sep 16, 2021 at 10:00 PM Mark Kettenis <kettenis@openbsd.org> wrote:
> >>>
> >>> This adds support for the DWC_sub31 controllers such as those
> >>> found on Apple's M1 SoC. This version of the controller
> >>> seems to work fine with the existing driver.
> >>>
> >>> Signed-off-by: Mark Kettenis <kettenis@openbsd.org>
> >>> ---
> >>> drivers/usb/host/xhci-dwc3.c | 3 ++-
> >>> 1 file changed, 2 insertions(+), 1 deletion(-)
> >>>
> >>
> >> Reviewed-by: Bin Meng <bmeng.cn@gmail.com>
> >
> > I see this is assigned to me on patchwork. Would you like this to go
> > via the x86 tree?
>
> Since it's just one patch, I suspect Tom can just pick it directly.
Thanks, I have re-assigned it to Tom on patchwork.
Regards,
Bin
^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2021-09-20 6:43 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-09-16 14:00 [PATCH] usb: xhci-dwc3: Add support for USB 3.1 controllers Mark Kettenis
2021-09-16 14:08 ` Bin Meng
2021-09-19 8:40 ` Bin Meng
2021-09-19 22:44 ` Marek Vasut
2021-09-20 6:43 ` Bin Meng
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.