All of lore.kernel.org
 help / color / mirror / Atom feed
From: Bin Meng <bmeng.cn@gmail.com>
To: "Philippe Mathieu-Daudé" <philmd@linaro.org>
Cc: Bin Meng <bin.meng@windriver.com>,
	Christian Schoenebeck <qemu_oss@crudebyte.com>,
	 Greg Kurz <groug@kaod.org>,
	qemu-devel@nongnu.org,  Guohuai Shi <guohuai.shi@windriver.com>
Subject: Re: [PATCH v5 03/16] hw/9pfs: Replace the direct call to xxxdir() APIs with a wrapper
Date: Mon, 6 Mar 2023 17:35:03 +0800	[thread overview]
Message-ID: <CAEUhbmUN2_qT-fup=tXK9gezaEhxBeJPNWf4FZz=mz=wJy1rCg@mail.gmail.com> (raw)
In-Reply-To: <541532c2-9c92-87ba-b649-3440e65c83c5@linaro.org>

On Mon, Mar 6, 2023 at 5:32 PM Philippe Mathieu-Daudé <philmd@linaro.org> wrote:
>
> On 20/2/23 11:08, Bin Meng wrote:
> > From: Guohuai Shi <guohuai.shi@windriver.com>
> >
> > xxxdir() APIs are not safe on Windows host. For future extension to
> > Windows, let's replace the direct call to xxxdir() APIs with a wrapper.
> >
> > Signed-off-by: Guohuai Shi <guohuai.shi@windriver.com>
> > Signed-off-by: Bin Meng <bin.meng@windriver.com>
> > ---
> >
> >   hw/9pfs/9p-util.h  | 14 ++++++++++++++
> >   hw/9pfs/9p-local.c | 12 ++++++------
> >   2 files changed, 20 insertions(+), 6 deletions(-)
>
>
> > +#define qemu_opendir    opendir_win32
> > +#define qemu_closedir   closedir_win32
> > +#define qemu_readdir    readdir_win32
> > +#define qeme_rewinddir  rewinddir_win32
>
> Typo :)
>

Ouch! Thanks Philippe :)

Regards,
Bin


  reply	other threads:[~2023-03-06  9:35 UTC|newest]

Thread overview: 32+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-02-20 10:07 [PATCH v5 00/16] hw/9pfs: Add 9pfs support for Windows Bin Meng
2023-02-20 10:08 ` [PATCH v5 01/16] hw/9pfs: Add missing definitions " Bin Meng
2023-02-20 10:08 ` [PATCH v5 02/16] hw/9pfs: Implement Windows specific utilities functions for 9pfs Bin Meng
2023-02-20 10:08 ` [PATCH v5 03/16] hw/9pfs: Replace the direct call to xxxdir() APIs with a wrapper Bin Meng
2023-03-06  9:31   ` Philippe Mathieu-Daudé
2023-03-06  9:35     ` Bin Meng [this message]
2023-02-20 10:08 ` [PATCH v5 04/16] hw/9pfs: Implement Windows specific xxxdir() APIs Bin Meng
2023-03-14 16:05   ` Christian Schoenebeck
2023-03-15 19:05     ` Shi, Guohuai
2023-03-16 11:05       ` Christian Schoenebeck
2023-03-16 17:28         ` Shi, Guohuai
2023-03-17  4:36           ` Shi, Guohuai
2023-03-17 12:16             ` Christian Schoenebeck
2023-02-20 10:08 ` [PATCH v5 05/16] hw/9pfs: Update the local fs driver to support Windows Bin Meng
2023-02-20 10:08 ` [PATCH v5 06/16] hw/9pfs: Support getting current directory offset for Windows Bin Meng
2023-02-20 10:08 ` [PATCH v5 07/16] hw/9pfs: Update helper qemu_stat_rdev() Bin Meng
2023-02-20 10:08 ` [PATCH v5 08/16] hw/9pfs: Add a helper qemu_stat_blksize() Bin Meng
2023-02-20 10:08 ` [PATCH v5 09/16] hw/9pfs: Disable unsupported flags and features for Windows Bin Meng
2023-02-20 10:08 ` [PATCH v5 10/16] hw/9pfs: Update v9fs_set_fd_limit() " Bin Meng
2023-02-20 10:08 ` [PATCH v5 11/16] hw/9pfs: Add Linux error number definition Bin Meng
2023-02-20 10:08 ` [PATCH v5 12/16] hw/9pfs: Translate Windows errno to Linux value Bin Meng
2023-02-20 10:08 ` [PATCH v5 13/16] fsdev: Disable proxy fs driver on Windows Bin Meng
2023-03-06  9:28   ` Philippe Mathieu-Daudé
2023-02-20 10:08 ` [PATCH v5 14/16] hw/9pfs: Update synth fs driver for Windows Bin Meng
2023-02-20 10:08 ` [PATCH v5 15/16] tests/qtest: virtio-9p-test: Adapt the case for win32 Bin Meng
2023-02-20 10:08 ` [PATCH v5 16/16] meson.build: Turn on virtfs for Windows Bin Meng
2023-03-13 12:53   ` Christian Schoenebeck
2023-03-06  6:04 ` [PATCH v5 00/16] hw/9pfs: Add 9pfs support " Bin Meng
2023-03-06 14:15 ` Christian Schoenebeck
2023-03-06 14:30   ` Philippe Mathieu-Daudé
2023-03-06 14:56   ` Bin Meng
2023-03-07 12:44     ` Christian Schoenebeck

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to='CAEUhbmUN2_qT-fup=tXK9gezaEhxBeJPNWf4FZz=mz=wJy1rCg@mail.gmail.com' \
    --to=bmeng.cn@gmail.com \
    --cc=bin.meng@windriver.com \
    --cc=groug@kaod.org \
    --cc=guohuai.shi@windriver.com \
    --cc=philmd@linaro.org \
    --cc=qemu-devel@nongnu.org \
    --cc=qemu_oss@crudebyte.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.