From: Bin Meng <bmeng.cn@gmail.com>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH 3/4] qbman_portal.c: Update BUG_ON() call in qbman_swp_mc_submit
Date: Sun, 29 Nov 2015 17:34:33 +0800 [thread overview]
Message-ID: <CAEUhbmUVW=YR5HAvB_TLyyha+cbQ3hPUVgYCCUQYVSvZmo233Q@mail.gmail.com> (raw)
In-Reply-To: <1448715883-14099-3-git-send-email-trini@konsulko.com>
On Sat, Nov 28, 2015 at 9:04 PM, Tom Rini <trini@konsulko.com> wrote:
> With gcc-5.x we get a warning about the ambiguity of BUG_ON(!a != b) and
> becomes BUG_ON((!a) != b). In this case reading of the function leads to
> us wanting to rewrite this as BUG_ON(a != b).
>
> Cc: Prabhakar Kushwaha <prabhakar@freescale.com>
> Cc: Geoff Thorpe <Geoff.Thorpe@freescale.com>
> Cc: Haiying Wang <Haiying.Wang@freescale.com>
> Cc: Roy Pledge <Roy.Pledge@freescale.com>
> Cc: York Sun <yorksun@freescale.com>
> Signed-off-by: Tom Rini <trini@konsulko.com>
> ---
> drivers/net/fsl-mc/dpio/qbman_portal.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/net/fsl-mc/dpio/qbman_portal.c b/drivers/net/fsl-mc/dpio/qbman_portal.c
> index 5fa8d95..449ff8a 100644
> --- a/drivers/net/fsl-mc/dpio/qbman_portal.c
> +++ b/drivers/net/fsl-mc/dpio/qbman_portal.c
> @@ -117,7 +117,7 @@ void qbman_swp_mc_submit(struct qbman_swp *p, void *cmd, uint32_t cmd_verb)
> {
> uint32_t *v = cmd;
> #ifdef QBMAN_CHECKING
> - BUG_ON(!p->mc.check != swp_mc_can_submit);
> + BUG_ON(p->mc.check != swp_mc_can_submit);
> #endif
> lwsync();
> /* TBD: "|=" is going to hurt performance. Need to move as many fields
> --
Reviewed-by: Bin Meng <bmeng.cn@gmail.com>
next prev parent reply other threads:[~2015-11-29 9:34 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-11-28 13:04 [U-Boot] [PATCH 1/4] eth-raw-os.c: Add cast to bind(2) call Tom Rini
2015-11-28 13:04 ` [U-Boot] [PATCH 2/4] fsl_*_serdes.c: Modify memset call in serdes_init Tom Rini
2015-11-29 9:34 ` Bin Meng
2015-12-15 0:51 ` York Sun
2015-11-28 13:04 ` [U-Boot] [PATCH 3/4] qbman_portal.c: Update BUG_ON() call in qbman_swp_mc_submit Tom Rini
2015-11-29 9:34 ` Bin Meng [this message]
2015-12-15 0:52 ` York Sun
2015-11-28 13:04 ` [U-Boot] [PATCH 4/4] arch/arm/cpu/arm920t/ep93xx/led.c: Mark inline functions as static inline Tom Rini
2015-11-29 9:34 ` Bin Meng
2015-12-06 22:07 ` [U-Boot] [U-Boot, " Tom Rini
2015-11-29 9:34 ` [U-Boot] [PATCH 1/4] eth-raw-os.c: Add cast to bind(2) call Bin Meng
2015-11-30 22:13 ` Joe Hershberger
2016-01-15 3:45 ` Bin Meng
2016-01-15 12:28 ` Tom Rini
2016-01-15 13:10 ` [U-Boot] [U-Boot,1/4] " Tom Rini
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAEUhbmUVW=YR5HAvB_TLyyha+cbQ3hPUVgYCCUQYVSvZmo233Q@mail.gmail.com' \
--to=bmeng.cn@gmail.com \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.