All of lore.kernel.org
 help / color / mirror / Atom feed
* [U-Boot] [PATCH] x86: qemu: Add CMD_NET to qemu-x86_defconfig
@ 2015-06-02 10:40 Bin Meng
  2015-06-02 10:44 ` Bin Meng
  0 siblings, 1 reply; 5+ messages in thread
From: Bin Meng @ 2015-06-02 10:40 UTC (permalink / raw)
  To: u-boot

The following error is observed on QEMU x86.

=> print ipaddr
ipaddr=192.168.178.66
=> ping 192.168.178.1
*** ERROR: `ipaddr' not set
ping failed; host 192.168.178.1 is not alive

The issue was introduced in commit fd30563. Adding CMD_NET to
defconfig resolves this. Also reorder the config options to
match the order in Kconfig.

Signed-off-by: Bin Meng <bmeng.cn@gmail.com>
---

 configs/qemu-x86_defconfig | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/configs/qemu-x86_defconfig b/configs/qemu-x86_defconfig
index a5251b5..07b5176 100644
--- a/configs/qemu-x86_defconfig
+++ b/configs/qemu-x86_defconfig
@@ -1,9 +1,9 @@
 CONFIG_X86=y
 CONFIG_VENDOR_EMULATION=y
 CONFIG_TARGET_QEMU_X86=y
+CONFIG_GENERATE_PIRQ_TABLE=y
+CONFIG_CMD_NET=y
 CONFIG_OF_CONTROL=y
-CONFIG_OF_SEPARATE=y
 CONFIG_VIDEO_VESA=y
 CONFIG_FRAMEBUFFER_SET_VESA_MODE=y
 CONFIG_FRAMEBUFFER_VESA_MODE_111=y
-CONFIG_GENERATE_PIRQ_TABLE=y
-- 
1.8.2.1

^ permalink raw reply related	[flat|nested] 5+ messages in thread

* [U-Boot] [PATCH] x86: qemu: Add CMD_NET to qemu-x86_defconfig
  2015-06-02 10:40 [U-Boot] [PATCH] x86: qemu: Add CMD_NET to qemu-x86_defconfig Bin Meng
@ 2015-06-02 10:44 ` Bin Meng
  2015-06-02 14:41   ` Bin Meng
  0 siblings, 1 reply; 5+ messages in thread
From: Bin Meng @ 2015-06-02 10:44 UTC (permalink / raw)
  To: u-boot

Hi Simon,

On Tue, Jun 2, 2015 at 6:40 PM, Bin Meng <bmeng.cn@gmail.com> wrote:
> The following error is observed on QEMU x86.
>
> => print ipaddr
> ipaddr=192.168.178.66
> => ping 192.168.178.1
> *** ERROR: `ipaddr' not set
> ping failed; host 192.168.178.1 is not alive
>
> The issue was introduced in commit fd30563. Adding CMD_NET to
> defconfig resolves this. Also reorder the config options to
> match the order in Kconfig.
>
> Signed-off-by: Bin Meng <bmeng.cn@gmail.com>
> ---
>
>  configs/qemu-x86_defconfig | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/configs/qemu-x86_defconfig b/configs/qemu-x86_defconfig
> index a5251b5..07b5176 100644
> --- a/configs/qemu-x86_defconfig
> +++ b/configs/qemu-x86_defconfig
> @@ -1,9 +1,9 @@
>  CONFIG_X86=y
>  CONFIG_VENDOR_EMULATION=y
>  CONFIG_TARGET_QEMU_X86=y
> +CONFIG_GENERATE_PIRQ_TABLE=y
> +CONFIG_CMD_NET=y
>  CONFIG_OF_CONTROL=y
> -CONFIG_OF_SEPARATE=y
>  CONFIG_VIDEO_VESA=y
>  CONFIG_FRAMEBUFFER_SET_VESA_MODE=y
>  CONFIG_FRAMEBUFFER_VESA_MODE_111=y
> -CONFIG_GENERATE_PIRQ_TABLE=y
> --

After Joe's pull request [1] get applied by Tom, you can rebase
u-boot-x86/testing branch and apply this one to fix the qemu
networking issue. Thanks!

[1] http://patchwork.ozlabs.org/patch/479136/

Regards,
Bin

^ permalink raw reply	[flat|nested] 5+ messages in thread

* [U-Boot] [PATCH] x86: qemu: Add CMD_NET to qemu-x86_defconfig
  2015-06-02 10:44 ` Bin Meng
@ 2015-06-02 14:41   ` Bin Meng
  2015-06-02 18:38     ` Simon Glass
  0 siblings, 1 reply; 5+ messages in thread
From: Bin Meng @ 2015-06-02 14:41 UTC (permalink / raw)
  To: u-boot

Hi Simon,

On Tue, Jun 2, 2015 at 6:44 PM, Bin Meng <bmeng.cn@gmail.com> wrote:
> Hi Simon,
>
> On Tue, Jun 2, 2015 at 6:40 PM, Bin Meng <bmeng.cn@gmail.com> wrote:
>> The following error is observed on QEMU x86.
>>
>> => print ipaddr
>> ipaddr=192.168.178.66
>> => ping 192.168.178.1
>> *** ERROR: `ipaddr' not set
>> ping failed; host 192.168.178.1 is not alive
>>
>> The issue was introduced in commit fd30563. Adding CMD_NET to
>> defconfig resolves this. Also reorder the config options to
>> match the order in Kconfig.
>>
>> Signed-off-by: Bin Meng <bmeng.cn@gmail.com>
>> ---
>>
>>  configs/qemu-x86_defconfig | 4 ++--
>>  1 file changed, 2 insertions(+), 2 deletions(-)
>>
>> diff --git a/configs/qemu-x86_defconfig b/configs/qemu-x86_defconfig
>> index a5251b5..07b5176 100644
>> --- a/configs/qemu-x86_defconfig
>> +++ b/configs/qemu-x86_defconfig
>> @@ -1,9 +1,9 @@
>>  CONFIG_X86=y
>>  CONFIG_VENDOR_EMULATION=y
>>  CONFIG_TARGET_QEMU_X86=y
>> +CONFIG_GENERATE_PIRQ_TABLE=y
>> +CONFIG_CMD_NET=y
>>  CONFIG_OF_CONTROL=y
>> -CONFIG_OF_SEPARATE=y
>>  CONFIG_VIDEO_VESA=y
>>  CONFIG_FRAMEBUFFER_SET_VESA_MODE=y
>>  CONFIG_FRAMEBUFFER_VESA_MODE_111=y
>> -CONFIG_GENERATE_PIRQ_TABLE=y
>> --
>
> After Joe's pull request [1] get applied by Tom, you can rebase
> u-boot-x86/testing branch and apply this one to fix the qemu
> networking issue. Thanks!
>
> [1] http://patchwork.ozlabs.org/patch/479136/
>

I see Joe's pull request has been applied, but sorry I've noticed that
this patch has some dependencies on the qemu v2 patch series I am
working on. Please ignore this and I will resend it as part of my qemu
v2 patch series soon. Sorry about that.

Regards,
Bin

^ permalink raw reply	[flat|nested] 5+ messages in thread

* [U-Boot] [PATCH] x86: qemu: Add CMD_NET to qemu-x86_defconfig
  2015-06-02 14:41   ` Bin Meng
@ 2015-06-02 18:38     ` Simon Glass
  2015-06-03 13:28       ` Bin Meng
  0 siblings, 1 reply; 5+ messages in thread
From: Simon Glass @ 2015-06-02 18:38 UTC (permalink / raw)
  To: u-boot

Hi Bin,

On 2 June 2015 at 08:41, Bin Meng <bmeng.cn@gmail.com> wrote:
> Hi Simon,
>
> On Tue, Jun 2, 2015 at 6:44 PM, Bin Meng <bmeng.cn@gmail.com> wrote:
>> Hi Simon,
>>
>> On Tue, Jun 2, 2015 at 6:40 PM, Bin Meng <bmeng.cn@gmail.com> wrote:
>>> The following error is observed on QEMU x86.
>>>
>>> => print ipaddr
>>> ipaddr=192.168.178.66
>>> => ping 192.168.178.1
>>> *** ERROR: `ipaddr' not set
>>> ping failed; host 192.168.178.1 is not alive
>>>
>>> The issue was introduced in commit fd30563. Adding CMD_NET to
>>> defconfig resolves this. Also reorder the config options to
>>> match the order in Kconfig.
>>>
>>> Signed-off-by: Bin Meng <bmeng.cn@gmail.com>
>>> ---
>>>
>>>  configs/qemu-x86_defconfig | 4 ++--
>>>  1 file changed, 2 insertions(+), 2 deletions(-)
>>>
>>> diff --git a/configs/qemu-x86_defconfig b/configs/qemu-x86_defconfig
>>> index a5251b5..07b5176 100644
>>> --- a/configs/qemu-x86_defconfig
>>> +++ b/configs/qemu-x86_defconfig
>>> @@ -1,9 +1,9 @@
>>>  CONFIG_X86=y
>>>  CONFIG_VENDOR_EMULATION=y
>>>  CONFIG_TARGET_QEMU_X86=y
>>> +CONFIG_GENERATE_PIRQ_TABLE=y
>>> +CONFIG_CMD_NET=y
>>>  CONFIG_OF_CONTROL=y
>>> -CONFIG_OF_SEPARATE=y
>>>  CONFIG_VIDEO_VESA=y
>>>  CONFIG_FRAMEBUFFER_SET_VESA_MODE=y
>>>  CONFIG_FRAMEBUFFER_VESA_MODE_111=y
>>> -CONFIG_GENERATE_PIRQ_TABLE=y
>>> --
>>
>> After Joe's pull request [1] get applied by Tom, you can rebase
>> u-boot-x86/testing branch and apply this one to fix the qemu
>> networking issue. Thanks!
>>
>> [1] http://patchwork.ozlabs.org/patch/479136/
>>
>
> I see Joe's pull request has been applied, but sorry I've noticed that
> this patch has some dependencies on the qemu v2 patch series I am
> working on. Please ignore this and I will resend it as part of my qemu
> v2 patch series soon. Sorry about that.

OK I have it setting in x86/testing. Please let me know what commits
need changing, etc.

Regards,
Simon

^ permalink raw reply	[flat|nested] 5+ messages in thread

* [U-Boot] [PATCH] x86: qemu: Add CMD_NET to qemu-x86_defconfig
  2015-06-02 18:38     ` Simon Glass
@ 2015-06-03 13:28       ` Bin Meng
  0 siblings, 0 replies; 5+ messages in thread
From: Bin Meng @ 2015-06-03 13:28 UTC (permalink / raw)
  To: u-boot

Hi Simon,

On Wed, Jun 3, 2015 at 2:38 AM, Simon Glass <sjg@chromium.org> wrote:
> Hi Bin,
>
> On 2 June 2015 at 08:41, Bin Meng <bmeng.cn@gmail.com> wrote:
>> Hi Simon,
>>
>> On Tue, Jun 2, 2015 at 6:44 PM, Bin Meng <bmeng.cn@gmail.com> wrote:
>>> Hi Simon,
>>>
>>> On Tue, Jun 2, 2015 at 6:40 PM, Bin Meng <bmeng.cn@gmail.com> wrote:
>>>> The following error is observed on QEMU x86.
>>>>
>>>> => print ipaddr
>>>> ipaddr=192.168.178.66
>>>> => ping 192.168.178.1
>>>> *** ERROR: `ipaddr' not set
>>>> ping failed; host 192.168.178.1 is not alive
>>>>
>>>> The issue was introduced in commit fd30563. Adding CMD_NET to
>>>> defconfig resolves this. Also reorder the config options to
>>>> match the order in Kconfig.
>>>>
>>>> Signed-off-by: Bin Meng <bmeng.cn@gmail.com>
>>>> ---
>>>>
>>>>  configs/qemu-x86_defconfig | 4 ++--
>>>>  1 file changed, 2 insertions(+), 2 deletions(-)
>>>>
>>>> diff --git a/configs/qemu-x86_defconfig b/configs/qemu-x86_defconfig
>>>> index a5251b5..07b5176 100644
>>>> --- a/configs/qemu-x86_defconfig
>>>> +++ b/configs/qemu-x86_defconfig
>>>> @@ -1,9 +1,9 @@
>>>>  CONFIG_X86=y
>>>>  CONFIG_VENDOR_EMULATION=y
>>>>  CONFIG_TARGET_QEMU_X86=y
>>>> +CONFIG_GENERATE_PIRQ_TABLE=y
>>>> +CONFIG_CMD_NET=y
>>>>  CONFIG_OF_CONTROL=y
>>>> -CONFIG_OF_SEPARATE=y
>>>>  CONFIG_VIDEO_VESA=y
>>>>  CONFIG_FRAMEBUFFER_SET_VESA_MODE=y
>>>>  CONFIG_FRAMEBUFFER_VESA_MODE_111=y
>>>> -CONFIG_GENERATE_PIRQ_TABLE=y
>>>> --
>>>
>>> After Joe's pull request [1] get applied by Tom, you can rebase
>>> u-boot-x86/testing branch and apply this one to fix the qemu
>>> networking issue. Thanks!
>>>
>>> [1] http://patchwork.ozlabs.org/patch/479136/
>>>
>>
>> I see Joe's pull request has been applied, but sorry I've noticed that
>> this patch has some dependencies on the qemu v2 patch series I am
>> working on. Please ignore this and I will resend it as part of my qemu
>> v2 patch series soon. Sorry about that.
>
> OK I have it setting in x86/testing. Please let me know what commits
> need changing, etc.
>

Please check this v2 series: http://patchwork.ozlabs.org/patch/479745/

It is rebased on u-boot-x86/master.

Regards,
Bin

^ permalink raw reply	[flat|nested] 5+ messages in thread

end of thread, other threads:[~2015-06-03 13:28 UTC | newest]

Thread overview: 5+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2015-06-02 10:40 [U-Boot] [PATCH] x86: qemu: Add CMD_NET to qemu-x86_defconfig Bin Meng
2015-06-02 10:44 ` Bin Meng
2015-06-02 14:41   ` Bin Meng
2015-06-02 18:38     ` Simon Glass
2015-06-03 13:28       ` Bin Meng

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.