All of lore.kernel.org
 help / color / mirror / Atom feed
* [U-Boot] dtb build issue on U-Boot
@ 2017-06-06 11:45 Kever Yang
  2017-06-06 21:16 ` Simon Glass
  0 siblings, 1 reply; 5+ messages in thread
From: Kever Yang @ 2017-06-06 11:45 UTC (permalink / raw)
  To: u-boot


I notice that the dtb content in spl/u-boot-spl.bin and u-boot.bin not

able to update after I modify the dts file and make again, I have to

"make clean" first, and then the "make" can update the dtb content

to output binary, which lead to bad efficiency when try to modify dts.

I have try below command, the dtb file also not updated before "make clean".

dtc -I dtb -O dts spl/u-boot-spl.dtb

Is there any one can help fix this issue?


Thanks,

- Kever

^ permalink raw reply	[flat|nested] 5+ messages in thread

* [U-Boot] dtb build issue on U-Boot
  2017-06-06 11:45 [U-Boot] dtb build issue on U-Boot Kever Yang
@ 2017-06-06 21:16 ` Simon Glass
  2017-06-13  6:03   ` Masahiro Yamada
  0 siblings, 1 reply; 5+ messages in thread
From: Simon Glass @ 2017-06-06 21:16 UTC (permalink / raw)
  To: u-boot

+Masahiro

On 6 June 2017 at 05:45, Kever Yang <kever.yang@rock-chips.com> wrote:
>
> I notice that the dtb content in spl/u-boot-spl.bin and u-boot.bin not
>
> able to update after I modify the dts file and make again, I have to
>
> "make clean" first, and then the "make" can update the dtb content
>
> to output binary, which lead to bad efficiency when try to modify dts.
>
> I have try below command, the dtb file also not updated before "make clean".
>
> dtc -I dtb -O dts spl/u-boot-spl.dtb
>
> Is there any one can help fix this issue?

I have noticed this too, and also that changing a .dtsi file is not noticed.

Probably it is missing a dependency in the makefile.

Regards,
Simon

^ permalink raw reply	[flat|nested] 5+ messages in thread

* [U-Boot] dtb build issue on U-Boot
  2017-06-06 21:16 ` Simon Glass
@ 2017-06-13  6:03   ` Masahiro Yamada
  2017-06-13  7:28     ` Bin Meng
  2017-06-14  1:35     ` Kever Yang
  0 siblings, 2 replies; 5+ messages in thread
From: Masahiro Yamada @ 2017-06-13  6:03 UTC (permalink / raw)
  To: u-boot

Hi Kever, Simon,
Sorry for my late reply.

2017-06-07 6:16 GMT+09:00 Simon Glass <sjg@chromium.org>:
> +Masahiro
>
> On 6 June 2017 at 05:45, Kever Yang <kever.yang@rock-chips.com> wrote:
>>
>> I notice that the dtb content in spl/u-boot-spl.bin and u-boot.bin not
>>
>> able to update after I modify the dts file and make again, I have to
>>
>> "make clean" first, and then the "make" can update the dtb content
>>
>> to output binary, which lead to bad efficiency when try to modify dts.
>>
>> I have try below command, the dtb file also not updated before "make clean".
>>
>> dtc -I dtb -O dts spl/u-boot-spl.dtb
>>
>> Is there any one can help fix this issue?
>
> I have noticed this too, and also that changing a .dtsi file is not noticed.
>
> Probably it is missing a dependency in the makefile.


I could not reproduce the issue for me.

Editing a DT file and re-compiling gave me the expected result.


masahiro at pug:~/ref/u-boot$ make -s mrproper
masahiro at pug:~/ref/u-boot$ make -s CROSS_COMPILE=aarch64-linux-gnu-
uniphier_v8_defconfig all
masahiro at pug:~/ref/u-boot$ nano arch/arm/dts/uniphier-ld20.dtsi
(add hello-world property)
masahiro at pug:~/ref/u-boot$ make  CROSS_COMPILE=aarch64-linux-gnu-
  CHK     include/config/uboot.release
  CHK     include/generated/version_autogenerated.h
  CHK     include/generated/timestamp_autogenerated.h
  UPD     include/generated/timestamp_autogenerated.h
  CHK     include/generated/generic-asm-offsets.h
  CHK     include/generated/asm-offsets.h
  HOSTCC  tools/mkenvimage.o
  HOSTLD  tools/mkenvimage
  HOSTCC  tools/fit_image.o
  HOSTCC  tools/image-host.o
  HOSTCC  tools/dumpimage.o
  HOSTLD  tools/dumpimage
  HOSTCC  tools/mkimage.o
  HOSTLD  tools/mkimage
  CC      arch/arm/cpu/armv8/fwcall.o
  LD      arch/arm/cpu/armv8/built-in.o
  CC      cmd/version.o
  CHK     cmd/config_data_gz.h
  CHK     cmd/config_data_size.h
  LD      cmd/built-in.o
  CC      common/main.o
  LD      common/built-in.o
  CC      lib/efi_loader/helloworld.o
  LD      lib/efi_loader/helloworld.so
  OBJCOPY lib/efi_loader/helloworld.efi
  CC      lib/smbios.o
  CC      lib/display_options.o
  LD      lib/built-in.o
  LD      u-boot
  OBJCOPY u-boot.srec
  OBJCOPY u-boot-nodtb.bin
start=$(aarch64-linux-gnu-nm u-boot | grep __rel_dyn_start | cut -f 1
-d ' '); end=$(aarch64-linux-gnu-nm u-boot | grep __rel_dyn_end | cut
-f 1 -d ' '); tools/relocate-rela u-boot-nodtb.bin 0x84000000 $start
$end
  DTC     arch/arm/dts/uniphier-ld20-ref.dtb
make[2]: 'arch/arm/dts/uniphier-ld20-ref.dtb' is up to date.
  SHIPPED dts/dt.dtb
  CAT     u-boot-dtb.bin
  COPY    u-boot.bin
  SYM     u-boot.sym
  MKIMAGE u-boot.img
  COPY    u-boot.dtb
  MKIMAGE u-boot-dtb.img
  CFGCHK  u-boot.cfg
masahiro at pug:~/ref/u-boot$ dtc -I dtb -O dts  u-boot.dtb | grep hello-world
hello-world;



If I am missing something,
could you tell me the command
you used for reproducing the problem?




-- 
Best Regards
Masahiro Yamada

^ permalink raw reply	[flat|nested] 5+ messages in thread

* [U-Boot] dtb build issue on U-Boot
  2017-06-13  6:03   ` Masahiro Yamada
@ 2017-06-13  7:28     ` Bin Meng
  2017-06-14  1:35     ` Kever Yang
  1 sibling, 0 replies; 5+ messages in thread
From: Bin Meng @ 2017-06-13  7:28 UTC (permalink / raw)
  To: u-boot

Hi Masahiro,

On Tue, Jun 13, 2017 at 2:03 PM, Masahiro Yamada
<yamada.masahiro@socionext.com> wrote:
> Hi Kever, Simon,
> Sorry for my late reply.
>
> 2017-06-07 6:16 GMT+09:00 Simon Glass <sjg@chromium.org>:
>> +Masahiro
>>
>> On 6 June 2017 at 05:45, Kever Yang <kever.yang@rock-chips.com> wrote:
>>>
>>> I notice that the dtb content in spl/u-boot-spl.bin and u-boot.bin not
>>>
>>> able to update after I modify the dts file and make again, I have to
>>>
>>> "make clean" first, and then the "make" can update the dtb content
>>>
>>> to output binary, which lead to bad efficiency when try to modify dts.
>>>
>>> I have try below command, the dtb file also not updated before "make clean".
>>>
>>> dtc -I dtb -O dts spl/u-boot-spl.dtb
>>>
>>> Is there any one can help fix this issue?
>>
>> I have noticed this too, and also that changing a .dtsi file is not noticed.
>>
>> Probably it is missing a dependency in the makefile.
>
>
> I could not reproduce the issue for me.
>
> Editing a DT file and re-compiling gave me the expected result.
>
>
> masahiro at pug:~/ref/u-boot$ make -s mrproper
> masahiro at pug:~/ref/u-boot$ make -s CROSS_COMPILE=aarch64-linux-gnu-
> uniphier_v8_defconfig all
> masahiro at pug:~/ref/u-boot$ nano arch/arm/dts/uniphier-ld20.dtsi
> (add hello-world property)
> masahiro at pug:~/ref/u-boot$ make  CROSS_COMPILE=aarch64-linux-gnu-
>   CHK     include/config/uboot.release
>   CHK     include/generated/version_autogenerated.h
>   CHK     include/generated/timestamp_autogenerated.h
>   UPD     include/generated/timestamp_autogenerated.h
>   CHK     include/generated/generic-asm-offsets.h
>   CHK     include/generated/asm-offsets.h
>   HOSTCC  tools/mkenvimage.o
>   HOSTLD  tools/mkenvimage
>   HOSTCC  tools/fit_image.o
>   HOSTCC  tools/image-host.o
>   HOSTCC  tools/dumpimage.o
>   HOSTLD  tools/dumpimage
>   HOSTCC  tools/mkimage.o
>   HOSTLD  tools/mkimage
>   CC      arch/arm/cpu/armv8/fwcall.o
>   LD      arch/arm/cpu/armv8/built-in.o
>   CC      cmd/version.o
>   CHK     cmd/config_data_gz.h
>   CHK     cmd/config_data_size.h
>   LD      cmd/built-in.o
>   CC      common/main.o
>   LD      common/built-in.o
>   CC      lib/efi_loader/helloworld.o
>   LD      lib/efi_loader/helloworld.so
>   OBJCOPY lib/efi_loader/helloworld.efi
>   CC      lib/smbios.o
>   CC      lib/display_options.o
>   LD      lib/built-in.o
>   LD      u-boot
>   OBJCOPY u-boot.srec
>   OBJCOPY u-boot-nodtb.bin
> start=$(aarch64-linux-gnu-nm u-boot | grep __rel_dyn_start | cut -f 1
> -d ' '); end=$(aarch64-linux-gnu-nm u-boot | grep __rel_dyn_end | cut
> -f 1 -d ' '); tools/relocate-rela u-boot-nodtb.bin 0x84000000 $start
> $end
>   DTC     arch/arm/dts/uniphier-ld20-ref.dtb
> make[2]: 'arch/arm/dts/uniphier-ld20-ref.dtb' is up to date.
>   SHIPPED dts/dt.dtb
>   CAT     u-boot-dtb.bin
>   COPY    u-boot.bin
>   SYM     u-boot.sym
>   MKIMAGE u-boot.img
>   COPY    u-boot.dtb
>   MKIMAGE u-boot-dtb.img
>   CFGCHK  u-boot.cfg
> masahiro at pug:~/ref/u-boot$ dtc -I dtb -O dts  u-boot.dtb | grep hello-world
> hello-world;
>
>
>
> If I am missing something,
> could you tell me the command
> you used for reproducing the problem?

I just tried on x86 minnowmax, and looks the problem exists.

$ vim arch/x86/dts/minnowmax.dts
$ make -j
  CHK     include/config/uboot.release
  CHK     include/generated/timestamp_autogenerated.h
  UPD     include/generated/timestamp_autogenerated.h
  CHK     include/generated/version_autogenerated.h
  CHK     include/generated/generic-asm-offsets.h
  CHK     include/generated/asm-offsets.h
  HOSTCC  tools/mkenvimage.o
  HOSTCC  tools/fit_image.o
  HOSTCC  tools/image-host.o
  HOSTCC  tools/dumpimage.o
  HOSTCC  tools/mkimage.o
  HOSTLD  tools/mkenvimage
  HOSTLD  tools/dumpimage
  HOSTLD  tools/mkimage
  HOSTLD  tools/fit_info
  HOSTLD  tools/fit_check_sign
  CC      cmd/version.o
  CC      common/main.o
  LD      cmd/built-in.o
  LD      common/built-in.o
  CC      lib/smbios.o
  CC      lib/display_options.o
  CC      lib/efi_loader/helloworld.o
  LD      lib/efi_loader/helloworld.so
  OBJCOPY lib/efi_loader/helloworld.efi
  LD      lib/built-in.o
  LD      u-boot
  OBJCOPY u-boot.srec
  OBJCOPY u-boot-nodtb.bin
  SYM     u-boot.sym
  OBJCOPY u-boot-x86-16bit.bin
  DTC     arch/x86/dts/minnowmax.dtb
make[2]: `arch/x86/dts/minnowmax.dtb' is up to date.
  SHIPPED dts/dt.dtb
  CAT     u-boot-dtb.bin
  COPY    u-boot.dtb
  COPY    u-boot.bin
  BINMAN  u-boot.rom
  CFGCHK  u-boot.cfg

Regards,
Bin

^ permalink raw reply	[flat|nested] 5+ messages in thread

* [U-Boot] dtb build issue on U-Boot
  2017-06-13  6:03   ` Masahiro Yamada
  2017-06-13  7:28     ` Bin Meng
@ 2017-06-14  1:35     ` Kever Yang
  1 sibling, 0 replies; 5+ messages in thread
From: Kever Yang @ 2017-06-14  1:35 UTC (permalink / raw)
  To: u-boot

Hi Masahiro,


On 06/13/2017 02:03 PM, Masahiro Yamada wrote:
> Hi Kever, Simon,
> Sorry for my late reply.
>
> 2017-06-07 6:16 GMT+09:00 Simon Glass <sjg@chromium.org>:
>> +Masahiro
>>
>> On 6 June 2017 at 05:45, Kever Yang <kever.yang@rock-chips.com> wrote:
>>> I notice that the dtb content in spl/u-boot-spl.bin and u-boot.bin not
>>>
>>> able to update after I modify the dts file and make again, I have to
>>>
>>> "make clean" first, and then the "make" can update the dtb content
>>>
>>> to output binary, which lead to bad efficiency when try to modify dts.
>>>
>>> I have try below command, the dtb file also not updated before "make clean".
>>>
>>> dtc -I dtb -O dts spl/u-boot-spl.dtb
>>>
>>> Is there any one can help fix this issue?
>> I have noticed this too, and also that changing a .dtsi file is not noticed.
>>
>> Probably it is missing a dependency in the makefile.
>
> I could not reproduce the issue for me.
>
> Editing a DT file and re-compiling gave me the expected result.

I try with aarch64, and the dtb update when dts changed,
maybe issue only happen in armv7 for arm platform?

Thanks,
- Kever
>
>
> masahiro at pug:~/ref/u-boot$ make -s mrproper
> masahiro at pug:~/ref/u-boot$ make -s CROSS_COMPILE=aarch64-linux-gnu-
> uniphier_v8_defconfig all
> masahiro at pug:~/ref/u-boot$ nano arch/arm/dts/uniphier-ld20.dtsi
> (add hello-world property)
> masahiro at pug:~/ref/u-boot$ make  CROSS_COMPILE=aarch64-linux-gnu-
>    CHK     include/config/uboot.release
>    CHK     include/generated/version_autogenerated.h
>    CHK     include/generated/timestamp_autogenerated.h
>    UPD     include/generated/timestamp_autogenerated.h
>    CHK     include/generated/generic-asm-offsets.h
>    CHK     include/generated/asm-offsets.h
>    HOSTCC  tools/mkenvimage.o
>    HOSTLD  tools/mkenvimage
>    HOSTCC  tools/fit_image.o
>    HOSTCC  tools/image-host.o
>    HOSTCC  tools/dumpimage.o
>    HOSTLD  tools/dumpimage
>    HOSTCC  tools/mkimage.o
>    HOSTLD  tools/mkimage
>    CC      arch/arm/cpu/armv8/fwcall.o
>    LD      arch/arm/cpu/armv8/built-in.o
>    CC      cmd/version.o
>    CHK     cmd/config_data_gz.h
>    CHK     cmd/config_data_size.h
>    LD      cmd/built-in.o
>    CC      common/main.o
>    LD      common/built-in.o
>    CC      lib/efi_loader/helloworld.o
>    LD      lib/efi_loader/helloworld.so
>    OBJCOPY lib/efi_loader/helloworld.efi
>    CC      lib/smbios.o
>    CC      lib/display_options.o
>    LD      lib/built-in.o
>    LD      u-boot
>    OBJCOPY u-boot.srec
>    OBJCOPY u-boot-nodtb.bin
> start=$(aarch64-linux-gnu-nm u-boot | grep __rel_dyn_start | cut -f 1
> -d ' '); end=$(aarch64-linux-gnu-nm u-boot | grep __rel_dyn_end | cut
> -f 1 -d ' '); tools/relocate-rela u-boot-nodtb.bin 0x84000000 $start
> $end
>    DTC     arch/arm/dts/uniphier-ld20-ref.dtb
> make[2]: 'arch/arm/dts/uniphier-ld20-ref.dtb' is up to date.
>    SHIPPED dts/dt.dtb
>    CAT     u-boot-dtb.bin
>    COPY    u-boot.bin
>    SYM     u-boot.sym
>    MKIMAGE u-boot.img
>    COPY    u-boot.dtb
>    MKIMAGE u-boot-dtb.img
>    CFGCHK  u-boot.cfg
> masahiro at pug:~/ref/u-boot$ dtc -I dtb -O dts  u-boot.dtb | grep hello-world
> hello-world;
>
>
>
> If I am missing something,
> could you tell me the command
> you used for reproducing the problem?
>
>
>
>

^ permalink raw reply	[flat|nested] 5+ messages in thread

end of thread, other threads:[~2017-06-14  1:35 UTC | newest]

Thread overview: 5+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2017-06-06 11:45 [U-Boot] dtb build issue on U-Boot Kever Yang
2017-06-06 21:16 ` Simon Glass
2017-06-13  6:03   ` Masahiro Yamada
2017-06-13  7:28     ` Bin Meng
2017-06-14  1:35     ` Kever Yang

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.