* [PATCH v2] usb: xhci-brcm: Include header file needed for dev_err
@ 2021-10-06 12:05 Stefan Agner
2021-10-14 15:09 ` Simon Glass
` (2 more replies)
0 siblings, 3 replies; 4+ messages in thread
From: Stefan Agner @ 2021-10-06 12:05 UTC (permalink / raw)
To: u-boot; +Cc: sjg, seanga2, mbrugger, Stefan Agner, Bin Meng, Marek Vasut
dev_err seems to be moved to different header file. Include
dm/device_compat.h file to compile properly.
Fixes: 69dae8902b16 ("linux/compat.h: Remove redefinition of dev_xxx macros")
Signed-off-by: Stefan Agner <stefan@agner.ch>
---
Changes in v2:
- Correctly place include
drivers/usb/host/xhci-brcm.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/usb/host/xhci-brcm.c b/drivers/usb/host/xhci-brcm.c
index 27c4bbfcba..fe17924028 100644
--- a/drivers/usb/host/xhci-brcm.c
+++ b/drivers/usb/host/xhci-brcm.c
@@ -8,6 +8,7 @@
#include <fdtdec.h>
#include <usb.h>
#include <asm/io.h>
+#include <dm/device_compat.h>
#include <usb/xhci.h>
#define DRD2U3H_XHC_REGS_AXIWRA 0xC08
--
2.33.0
^ permalink raw reply related [flat|nested] 4+ messages in thread
* Re: [PATCH v2] usb: xhci-brcm: Include header file needed for dev_err
2021-10-06 12:05 [PATCH v2] usb: xhci-brcm: Include header file needed for dev_err Stefan Agner
@ 2021-10-14 15:09 ` Simon Glass
2021-10-27 3:41 ` Bin Meng
2021-10-27 5:12 ` Sean Anderson
2 siblings, 0 replies; 4+ messages in thread
From: Simon Glass @ 2021-10-14 15:09 UTC (permalink / raw)
To: Stefan Agner
Cc: U-Boot Mailing List, Sean Anderson, Matthias Brugger, Bin Meng,
Marek Vasut
On Wed, 6 Oct 2021 at 06:05, Stefan Agner <stefan@agner.ch> wrote:
>
> dev_err seems to be moved to different header file. Include
> dm/device_compat.h file to compile properly.
>
> Fixes: 69dae8902b16 ("linux/compat.h: Remove redefinition of dev_xxx macros")
> Signed-off-by: Stefan Agner <stefan@agner.ch>
> ---
>
> Changes in v2:
> - Correctly place include
>
> drivers/usb/host/xhci-brcm.c | 1 +
> 1 file changed, 1 insertion(+)
>
Reviewed-by: Simon Glass <sjg@chromium.org>
> diff --git a/drivers/usb/host/xhci-brcm.c b/drivers/usb/host/xhci-brcm.c
> index 27c4bbfcba..fe17924028 100644
> --- a/drivers/usb/host/xhci-brcm.c
> +++ b/drivers/usb/host/xhci-brcm.c
> @@ -8,6 +8,7 @@
> #include <fdtdec.h>
> #include <usb.h>
> #include <asm/io.h>
> +#include <dm/device_compat.h>
> #include <usb/xhci.h>
>
> #define DRD2U3H_XHC_REGS_AXIWRA 0xC08
> --
> 2.33.0
>
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH v2] usb: xhci-brcm: Include header file needed for dev_err
2021-10-06 12:05 [PATCH v2] usb: xhci-brcm: Include header file needed for dev_err Stefan Agner
2021-10-14 15:09 ` Simon Glass
@ 2021-10-27 3:41 ` Bin Meng
2021-10-27 5:12 ` Sean Anderson
2 siblings, 0 replies; 4+ messages in thread
From: Bin Meng @ 2021-10-27 3:41 UTC (permalink / raw)
To: Stefan Agner
Cc: U-Boot Mailing List, Simon Glass, Sean Anderson,
Matthias Brugger, Marek Vasut
On Wed, Oct 6, 2021 at 8:05 PM Stefan Agner <stefan@agner.ch> wrote:
>
> dev_err seems to be moved to different header file. Include
> dm/device_compat.h file to compile properly.
>
> Fixes: 69dae8902b16 ("linux/compat.h: Remove redefinition of dev_xxx macros")
> Signed-off-by: Stefan Agner <stefan@agner.ch>
> ---
>
> Changes in v2:
> - Correctly place include
>
Reviewed-by: Bin Meng <bmeng.cn@gmail.com>
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH v2] usb: xhci-brcm: Include header file needed for dev_err
2021-10-06 12:05 [PATCH v2] usb: xhci-brcm: Include header file needed for dev_err Stefan Agner
2021-10-14 15:09 ` Simon Glass
2021-10-27 3:41 ` Bin Meng
@ 2021-10-27 5:12 ` Sean Anderson
2 siblings, 0 replies; 4+ messages in thread
From: Sean Anderson @ 2021-10-27 5:12 UTC (permalink / raw)
To: Stefan Agner, u-boot; +Cc: sjg, mbrugger, Bin Meng, Marek Vasut
On 10/6/21 8:05 AM, Stefan Agner wrote:
> dev_err seems to be moved to different header file. Include
> dm/device_compat.h file to compile properly.
>
> Fixes: 69dae8902b16 ("linux/compat.h: Remove redefinition of dev_xxx macros")
> Signed-off-by: Stefan Agner <stefan@agner.ch>
> ---
>
> Changes in v2:
> - Correctly place include
>
> drivers/usb/host/xhci-brcm.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/drivers/usb/host/xhci-brcm.c b/drivers/usb/host/xhci-brcm.c
> index 27c4bbfcba..fe17924028 100644
> --- a/drivers/usb/host/xhci-brcm.c
> +++ b/drivers/usb/host/xhci-brcm.c
> @@ -8,6 +8,7 @@
> #include <fdtdec.h>
> #include <usb.h>
> #include <asm/io.h>
> +#include <dm/device_compat.h>
> #include <usb/xhci.h>
>
> #define DRD2U3H_XHC_REGS_AXIWRA 0xC08
>
Does no defconfig compile this module? How was this include missing for so long?
--Sean
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2021-10-27 5:12 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-10-06 12:05 [PATCH v2] usb: xhci-brcm: Include header file needed for dev_err Stefan Agner
2021-10-14 15:09 ` Simon Glass
2021-10-27 3:41 ` Bin Meng
2021-10-27 5:12 ` Sean Anderson
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.