* [PATCH] riscv: dts: sifive: Add missing "clock-frequency" to cpu0/cpu1 nodes
@ 2019-08-07 6:22 ` Bin Meng
0 siblings, 0 replies; 8+ messages in thread
From: Bin Meng @ 2019-08-07 6:22 UTC (permalink / raw)
To: Albert Ou, Palmer Dabbelt, Paul Walmsley, devicetree,
linux-kernel, linux-riscv
Add the missing "clock-frequency" property to the cpu0/cpu1 nodes
for consistency with other cpu nodes.
Signed-off-by: Bin Meng <bmeng.cn@gmail.com>
---
arch/riscv/boot/dts/sifive/fu540-c000.dtsi | 2 ++
1 file changed, 2 insertions(+)
diff --git a/arch/riscv/boot/dts/sifive/fu540-c000.dtsi b/arch/riscv/boot/dts/sifive/fu540-c000.dtsi
index 42b5ec2..4befc70 100644
--- a/arch/riscv/boot/dts/sifive/fu540-c000.dtsi
+++ b/arch/riscv/boot/dts/sifive/fu540-c000.dtsi
@@ -22,6 +22,7 @@
#address-cells = <1>;
#size-cells = <0>;
cpu0: cpu@0 {
+ clock-frequency = <0>;
compatible = "sifive,e51", "sifive,rocket0", "riscv";
device_type = "cpu";
i-cache-block-size = <64>;
@@ -37,6 +38,7 @@
};
};
cpu1: cpu@1 {
+ clock-frequency = <0>;
compatible = "sifive,u54-mc", "sifive,rocket0", "riscv";
d-cache-block-size = <64>;
d-cache-sets = <64>;
--
2.7.4
^ permalink raw reply related [flat|nested] 8+ messages in thread
* [PATCH] riscv: dts: sifive: Add missing "clock-frequency" to cpu0/cpu1 nodes
@ 2019-08-07 6:22 ` Bin Meng
0 siblings, 0 replies; 8+ messages in thread
From: Bin Meng @ 2019-08-07 6:22 UTC (permalink / raw)
To: Albert Ou, Palmer Dabbelt, Paul Walmsley, devicetree,
linux-kernel, linux-riscv
Add the missing "clock-frequency" property to the cpu0/cpu1 nodes
for consistency with other cpu nodes.
Signed-off-by: Bin Meng <bmeng.cn@gmail.com>
---
arch/riscv/boot/dts/sifive/fu540-c000.dtsi | 2 ++
1 file changed, 2 insertions(+)
diff --git a/arch/riscv/boot/dts/sifive/fu540-c000.dtsi b/arch/riscv/boot/dts/sifive/fu540-c000.dtsi
index 42b5ec2..4befc70 100644
--- a/arch/riscv/boot/dts/sifive/fu540-c000.dtsi
+++ b/arch/riscv/boot/dts/sifive/fu540-c000.dtsi
@@ -22,6 +22,7 @@
#address-cells = <1>;
#size-cells = <0>;
cpu0: cpu@0 {
+ clock-frequency = <0>;
compatible = "sifive,e51", "sifive,rocket0", "riscv";
device_type = "cpu";
i-cache-block-size = <64>;
@@ -37,6 +38,7 @@
};
};
cpu1: cpu@1 {
+ clock-frequency = <0>;
compatible = "sifive,u54-mc", "sifive,rocket0", "riscv";
d-cache-block-size = <64>;
d-cache-sets = <64>;
--
2.7.4
_______________________________________________
linux-riscv mailing list
linux-riscv@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-riscv
^ permalink raw reply related [flat|nested] 8+ messages in thread
* Re: [PATCH] riscv: dts: sifive: Add missing "clock-frequency" to cpu0/cpu1 nodes
2019-08-07 6:22 ` Bin Meng
@ 2019-08-13 1:06 ` Bin Meng
-1 siblings, 0 replies; 8+ messages in thread
From: Bin Meng @ 2019-08-13 1:06 UTC (permalink / raw)
To: Albert Ou, Palmer Dabbelt, Paul Walmsley, devicetree,
linux-kernel, linux-riscv
On Wed, Aug 7, 2019 at 2:22 PM Bin Meng <bmeng.cn@gmail.com> wrote:
>
> Add the missing "clock-frequency" property to the cpu0/cpu1 nodes
> for consistency with other cpu nodes.
>
> Signed-off-by: Bin Meng <bmeng.cn@gmail.com>
> ---
>
> arch/riscv/boot/dts/sifive/fu540-c000.dtsi | 2 ++
> 1 file changed, 2 insertions(+)
>
ping
^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: [PATCH] riscv: dts: sifive: Add missing "clock-frequency" to cpu0/cpu1 nodes
@ 2019-08-13 1:06 ` Bin Meng
0 siblings, 0 replies; 8+ messages in thread
From: Bin Meng @ 2019-08-13 1:06 UTC (permalink / raw)
To: Albert Ou, Palmer Dabbelt, Paul Walmsley, devicetree,
linux-kernel, linux-riscv
On Wed, Aug 7, 2019 at 2:22 PM Bin Meng <bmeng.cn@gmail.com> wrote:
>
> Add the missing "clock-frequency" property to the cpu0/cpu1 nodes
> for consistency with other cpu nodes.
>
> Signed-off-by: Bin Meng <bmeng.cn@gmail.com>
> ---
>
> arch/riscv/boot/dts/sifive/fu540-c000.dtsi | 2 ++
> 1 file changed, 2 insertions(+)
>
ping
_______________________________________________
linux-riscv mailing list
linux-riscv@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-riscv
^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: [PATCH] riscv: dts: sifive: Add missing "clock-frequency" to cpu0/cpu1 nodes
2019-08-07 6:22 ` Bin Meng
@ 2019-08-13 15:00 ` Paul Walmsley
-1 siblings, 0 replies; 8+ messages in thread
From: Paul Walmsley @ 2019-08-13 15:00 UTC (permalink / raw)
To: Bin Meng; +Cc: Albert Ou, Palmer Dabbelt, devicetree, linux-kernel, linux-riscv
On Tue, 6 Aug 2019, Bin Meng wrote:
> Add the missing "clock-frequency" property to the cpu0/cpu1 nodes
> for consistency with other cpu nodes.
>
> Signed-off-by: Bin Meng <bmeng.cn@gmail.com>
Is this being driven by a schema validator warning? If not, and this
property isn't required, it seems better just to drop it. It seems
useless?
- Paul
^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: [PATCH] riscv: dts: sifive: Add missing "clock-frequency" to cpu0/cpu1 nodes
@ 2019-08-13 15:00 ` Paul Walmsley
0 siblings, 0 replies; 8+ messages in thread
From: Paul Walmsley @ 2019-08-13 15:00 UTC (permalink / raw)
To: Bin Meng; +Cc: devicetree, linux-riscv, Albert Ou, Palmer Dabbelt, linux-kernel
On Tue, 6 Aug 2019, Bin Meng wrote:
> Add the missing "clock-frequency" property to the cpu0/cpu1 nodes
> for consistency with other cpu nodes.
>
> Signed-off-by: Bin Meng <bmeng.cn@gmail.com>
Is this being driven by a schema validator warning? If not, and this
property isn't required, it seems better just to drop it. It seems
useless?
- Paul
_______________________________________________
linux-riscv mailing list
linux-riscv@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-riscv
^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: [PATCH] riscv: dts: sifive: Add missing "clock-frequency" to cpu0/cpu1 nodes
2019-08-13 15:00 ` Paul Walmsley
@ 2019-09-05 12:01 ` Bin Meng
-1 siblings, 0 replies; 8+ messages in thread
From: Bin Meng @ 2019-09-05 12:01 UTC (permalink / raw)
To: Paul Walmsley
Cc: Albert Ou, Palmer Dabbelt, devicetree, linux-kernel, linux-riscv
On Tue, Aug 13, 2019 at 11:00 PM Paul Walmsley <paul.walmsley@sifive.com> wrote:
>
> On Tue, 6 Aug 2019, Bin Meng wrote:
>
> > Add the missing "clock-frequency" property to the cpu0/cpu1 nodes
> > for consistency with other cpu nodes.
> >
> > Signed-off-by: Bin Meng <bmeng.cn@gmail.com>
>
> Is this being driven by a schema validator warning? If not, and this
> property isn't required, it seems better just to drop it. It seems
> useless?
>
Yes, I think we can drop it. I will send v2.
Regards,
Bin
^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: [PATCH] riscv: dts: sifive: Add missing "clock-frequency" to cpu0/cpu1 nodes
@ 2019-09-05 12:01 ` Bin Meng
0 siblings, 0 replies; 8+ messages in thread
From: Bin Meng @ 2019-09-05 12:01 UTC (permalink / raw)
To: Paul Walmsley
Cc: devicetree, linux-riscv, Albert Ou, Palmer Dabbelt, linux-kernel
On Tue, Aug 13, 2019 at 11:00 PM Paul Walmsley <paul.walmsley@sifive.com> wrote:
>
> On Tue, 6 Aug 2019, Bin Meng wrote:
>
> > Add the missing "clock-frequency" property to the cpu0/cpu1 nodes
> > for consistency with other cpu nodes.
> >
> > Signed-off-by: Bin Meng <bmeng.cn@gmail.com>
>
> Is this being driven by a schema validator warning? If not, and this
> property isn't required, it seems better just to drop it. It seems
> useless?
>
Yes, I think we can drop it. I will send v2.
Regards,
Bin
_______________________________________________
linux-riscv mailing list
linux-riscv@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-riscv
^ permalink raw reply [flat|nested] 8+ messages in thread
end of thread, other threads:[~2019-09-05 12:01 UTC | newest]
Thread overview: 8+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2019-08-07 6:22 [PATCH] riscv: dts: sifive: Add missing "clock-frequency" to cpu0/cpu1 nodes Bin Meng
2019-08-07 6:22 ` Bin Meng
2019-08-13 1:06 ` Bin Meng
2019-08-13 1:06 ` Bin Meng
2019-08-13 15:00 ` Paul Walmsley
2019-08-13 15:00 ` Paul Walmsley
2019-09-05 12:01 ` Bin Meng
2019-09-05 12:01 ` Bin Meng
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.