All of lore.kernel.org
 help / color / mirror / Atom feed
* [U-Boot] [PATCH] x86: som-db5800-som-6867: fix SERIRQ on reset
@ 2016-07-27 22:01 George McCollister
  2016-07-28  6:36 ` Bin Meng
  0 siblings, 1 reply; 3+ messages in thread
From: George McCollister @ 2016-07-27 22:01 UTC (permalink / raw)
  To: u-boot

Pad configuration for SERIRQ is not set to enable the SERIRQ function
on soft reset though strangely, it is on initial boot.

Signed-off-by: George McCollister <george.mccollister@gmail.com>
---
 arch/x86/dts/baytrail_som-db5800-som-6867.dts | 6 ++++++
 1 file changed, 6 insertions(+)

diff --git a/arch/x86/dts/baytrail_som-db5800-som-6867.dts b/arch/x86/dts/baytrail_som-db5800-som-6867.dts
index 64e2e52..e1d81a7 100644
--- a/arch/x86/dts/baytrail_som-db5800-som-6867.dts
+++ b/arch/x86/dts/baytrail_som-db5800-som-6867.dts
@@ -63,6 +63,12 @@
 			pad-offset = <0x270>;
 			mode-func = <2>;
 		};
+
+		/* SERIRQ */
+		soc_gpio_s0_50 at 0 {
+			pad-offset = <0x560>;
+			mode-func = <1>;
+		};
 	};
 
 	chosen {
-- 
2.8.0

^ permalink raw reply related	[flat|nested] 3+ messages in thread

* [U-Boot] [PATCH] x86: som-db5800-som-6867: fix SERIRQ on reset
  2016-07-27 22:01 [U-Boot] [PATCH] x86: som-db5800-som-6867: fix SERIRQ on reset George McCollister
@ 2016-07-28  6:36 ` Bin Meng
  2016-07-28 14:27   ` George McCollister
  0 siblings, 1 reply; 3+ messages in thread
From: Bin Meng @ 2016-07-28  6:36 UTC (permalink / raw)
  To: u-boot

On Thu, Jul 28, 2016 at 6:01 AM, George McCollister
<george.mccollister@gmail.com> wrote:
> Pad configuration for SERIRQ is not set to enable the SERIRQ function
> on soft reset though strangely, it is on initial boot.
>

What does "soft reset" mean?

> Signed-off-by: George McCollister <george.mccollister@gmail.com>
> ---
>  arch/x86/dts/baytrail_som-db5800-som-6867.dts | 6 ++++++
>  1 file changed, 6 insertions(+)
>

Reviewed-by: Bin Meng <bmeng.cn@gmail.com>

^ permalink raw reply	[flat|nested] 3+ messages in thread

* [U-Boot] [PATCH] x86: som-db5800-som-6867: fix SERIRQ on reset
  2016-07-28  6:36 ` Bin Meng
@ 2016-07-28 14:27   ` George McCollister
  0 siblings, 0 replies; 3+ messages in thread
From: George McCollister @ 2016-07-28 14:27 UTC (permalink / raw)
  To: u-boot

On Thu, Jul 28, 2016 at 1:36 AM, Bin Meng <bmeng.cn@gmail.com> wrote:
> On Thu, Jul 28, 2016 at 6:01 AM, George McCollister
> <george.mccollister@gmail.com> wrote:
>> Pad configuration for SERIRQ is not set to enable the SERIRQ function
>> on soft reset though strangely, it is on initial boot.
>>
>
> What does "soft reset" mean?

My apologies, this is misleading/incorrect. Rebooting from Linux,
reset command in u-boot and even pushing the reset button on the
development board all lead to this condition (address 0xfed0c560 with
value of 0x2003cc80). On first boot, address 0xfed0c560 has a value of
0x2003cc81 (SERIRQ function selected).

I'll update the commit message, add your reviewed-by and post a v2.

>
>> Signed-off-by: George McCollister <george.mccollister@gmail.com>
>> ---
>>  arch/x86/dts/baytrail_som-db5800-som-6867.dts | 6 ++++++
>>  1 file changed, 6 insertions(+)
>>
>
> Reviewed-by: Bin Meng <bmeng.cn@gmail.com>

^ permalink raw reply	[flat|nested] 3+ messages in thread

end of thread, other threads:[~2016-07-28 14:27 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2016-07-27 22:01 [U-Boot] [PATCH] x86: som-db5800-som-6867: fix SERIRQ on reset George McCollister
2016-07-28  6:36 ` Bin Meng
2016-07-28 14:27   ` George McCollister

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.