[U-Boot] [PATCH] poplar: increase SYS_MALLOC_F_LEN for DM_FLAG_PRE_RELOC support

[U-Boot] [PATCH] poplar: increase SYS_MALLOC_F_LEN for DM_FLAG_PRE_RELOC support

[Shawn Guo]

There is a regression seen on Poplar platform, which doesn't even show
a U-Boot version banner on booting.  It turns out that due to landing
of commit 3a7c45f6a772 ("simple-bus: add DM_FLAG_PRE_RELOC flag to
simple-bus driver"), we need to increase SYS_MALLOC_F_LEN from its
default size 0x400, as pre-relocation requires more memory there.  Let's
increase SYS_MALLOC_F_LEN to 0x4000 to fix the regression.

Thanks to Andreas Färber <afaerber@suse.de> for reporting, and Bin Meng
<bmeng.cn@gmail.com> for trouble shooting.

Reported-by: Andreas Färber <afaerber@suse.de>
Signed-off-by: Shawn Guo <shawn.guo@linaro.org>
---
 configs/poplar_defconfig | 1 +
 1 file changed, 1 insertion(+)

diff --git a/configs/poplar_defconfig b/configs/poplar_defconfig
index dfde6541c25a..62eaaee370f3 100644
--- a/configs/poplar_defconfig
+++ b/configs/poplar_defconfig
@@ -1,6 +1,7 @@
 CONFIG_ARM=y
 CONFIG_TARGET_POPLAR=y
 CONFIG_SYS_TEXT_BASE=0x37000000
+CONFIG_SYS_MALLOC_F_LEN=0x4000
 CONFIG_NR_DRAM_BANKS=2
 CONFIG_IDENT_STRING="poplar"
 CONFIG_DISTRO_DEFAULTS=y
-- 
2.18.0

[U-Boot] [PATCH] poplar: increase SYS_MALLOC_F_LEN for DM_FLAG_PRE_RELOC support

[Bin Meng]

On Mon, Jun 17, 2019 at 11:09 AM Shawn Guo <shawn.guo@linaro.org> wrote:
>
> There is a regression seen on Poplar platform, which doesn't even show
> a U-Boot version banner on booting.  It turns out that due to landing
> of commit 3a7c45f6a772 ("simple-bus: add DM_FLAG_PRE_RELOC flag to
> simple-bus driver"), we need to increase SYS_MALLOC_F_LEN from its
> default size 0x400, as pre-relocation requires more memory there.  Let's
> increase SYS_MALLOC_F_LEN to 0x4000 to fix the regression.
>
> Thanks to Andreas Färber <afaerber@suse.de> for reporting, and Bin Meng
> <bmeng.cn@gmail.com> for trouble shooting.
>
> Reported-by: Andreas Färber <afaerber@suse.de>
> Signed-off-by: Shawn Guo <shawn.guo@linaro.org>
> ---
>  configs/poplar_defconfig | 1 +
>  1 file changed, 1 insertion(+)
>

Reviewed-by: Bin Meng <bmeng.cn@gmail.com>

[U-Boot] [PATCH] poplar: increase SYS_MALLOC_F_LEN for DM_FLAG_PRE_RELOC support

[Andreas Färber]

Am 17.06.19 um 05:08 schrieb Shawn Guo:
> There is a regression seen on Poplar platform, which doesn't even show
> a U-Boot version banner on booting.  It turns out that due to landing
> of commit 3a7c45f6a772 ("simple-bus: add DM_FLAG_PRE_RELOC flag to
> simple-bus driver"), we need to increase SYS_MALLOC_F_LEN from its
> default size 0x400, as pre-relocation requires more memory there.  Let's
> increase SYS_MALLOC_F_LEN to 0x4000 to fix the regression.
> 
> Thanks to Andreas Färber <afaerber@suse.de> for reporting, and Bin Meng
> <bmeng.cn@gmail.com> for trouble shooting.

Thanks - you could add a Suggested-by for Bin after Reported-by and drop
the paragraph, if there's any other changes needed.

> 
> Reported-by: Andreas Färber <afaerber@suse.de>
> Signed-off-by: Shawn Guo <shawn.guo@linaro.org>

Tested-by: Andreas Färber <afaerber@suse.de>

Thanks for the quick solution,
Andreas

-- 
SUSE Linux GmbH, Maxfeldstr. 5, 90409 Nürnberg, Germany
GF: Felix Imendörffer, Mary Higgins, Sri Rasiah
HRB 21284 (AG Nürnberg)

[U-Boot] [PATCH] poplar: increase SYS_MALLOC_F_LEN for DM_FLAG_PRE_RELOC support

[Shawn Guo]

On Mon, Jun 17, 2019 at 11:09 AM Shawn Guo <shawn.guo@linaro.org> wrote:
>
> There is a regression seen on Poplar platform, which doesn't even show
> a U-Boot version banner on booting.  It turns out that due to landing
> of commit 3a7c45f6a772 ("simple-bus: add DM_FLAG_PRE_RELOC flag to
> simple-bus driver"), we need to increase SYS_MALLOC_F_LEN from its
> default size 0x400, as pre-relocation requires more memory there.  Let's
> increase SYS_MALLOC_F_LEN to 0x4000 to fix the regression.
>
> Thanks to Andreas Färber <afaerber@suse.de> for reporting, and Bin Meng
> <bmeng.cn@gmail.com> for trouble shooting.
>
> Reported-by: Andreas Färber <afaerber@suse.de>
> Signed-off-by: Shawn Guo <shawn.guo@linaro.org>

Hi Tom,

Can you please have a look at this?  Thanks.

Shawn

> ---
>  configs/poplar_defconfig | 1 +
>  1 file changed, 1 insertion(+)
>
> diff --git a/configs/poplar_defconfig b/configs/poplar_defconfig
> index dfde6541c25a..62eaaee370f3 100644
> --- a/configs/poplar_defconfig
> +++ b/configs/poplar_defconfig
> @@ -1,6 +1,7 @@
>  CONFIG_ARM=y
>  CONFIG_TARGET_POPLAR=y
>  CONFIG_SYS_TEXT_BASE=0x37000000
> +CONFIG_SYS_MALLOC_F_LEN=0x4000
>  CONFIG_NR_DRAM_BANKS=2
>  CONFIG_IDENT_STRING="poplar"
>  CONFIG_DISTRO_DEFAULTS=y
> --
> 2.18.0
>

[U-Boot] [PATCH] poplar: increase SYS_MALLOC_F_LEN for DM_FLAG_PRE_RELOC support

[Tom Rini]

On Mon, Jun 17, 2019 at 11:08:34AM +0800, Shawn Guo wrote:

> There is a regression seen on Poplar platform, which doesn't even show
> a U-Boot version banner on booting.  It turns out that due to landing
> of commit 3a7c45f6a772 ("simple-bus: add DM_FLAG_PRE_RELOC flag to
> simple-bus driver"), we need to increase SYS_MALLOC_F_LEN from its
> default size 0x400, as pre-relocation requires more memory there.  Let's
> increase SYS_MALLOC_F_LEN to 0x4000 to fix the regression.
> 
> Thanks to Andreas Färber <afaerber@suse.de> for reporting, and Bin Meng
> <bmeng.cn@gmail.com> for trouble shooting.
> 
> Reported-by: Andreas Färber <afaerber@suse.de>
> Signed-off-by: Shawn Guo <shawn.guo@linaro.org>
> Reviewed-by: Bin Meng <bmeng.cn@gmail.com>
> Tested-by: Andreas Färber <afaerber@suse.de>

Applied to u-boot/master, thanks!

-- 
Tom
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 819 bytes
Desc: not available
URL: <http://lists.denx.de/pipermail/u-boot/attachments/20190701/5a22f377/attachment.sig>