* [U-Boot] [u-boot-denx-usb] Build break on current u-boot-usb master
@ 2017-07-22 18:18 Łukasz Majewski
2017-07-22 18:36 ` Marek Vasut
0 siblings, 1 reply; 8+ messages in thread
From: Łukasz Majewski @ 2017-07-22 18:18 UTC (permalink / raw)
To: u-boot
Hi Marek,
When I was "cleaning up" my patchwork todo list I've found following
problem (s):
A lot of boards are broken with message:
LD u-boot
drivers/usb/host/built-in.o: In function `xhci_dwc3_remove':
/home/lukma/work/embedded/u-boot-denx/drivers/usb/host/xhci-dwc3.c:161:
undefined reference to `generic_phy_exit'
drivers/usb/host/built-in.o: In function `xhci_dwc3_probe':
/home/lukma/work/embedded/u-boot-denx/drivers/usb/host/xhci-dwc3.c:127:
undefined reference to `generic_phy_get_by_index'
/home/lukma/work/embedded/u-boot-denx/drivers/usb/host/xhci-dwc3.c:134:
undefined reference to `generic_phy_init'
/opt/tfk-sc58x/2.3/sysroots/x86_64-pokysdk-linux/usr/bin/arm-poky-linux-gnueabi/arm-poky-linux-gnueabi-ld.bfd:
BFD (GNU Binutils) 2.28.0.20170307 assertion fail ../../bfd/elf32-arm.c:9512
/opt/tfk-sc58x/2.3/sysroots/x86_64-pokysdk-linux/usr/bin/arm-poky-linux-gnueabi/arm-poky-linux-gnueabi-ld.bfd:
BFD (GNU Binutils) 2.28.0.20170307 assertion fail ../../bfd/elf32-arm.c:9512
/opt/tfk-sc58x/2.3/sysroots/x86_64-pokysdk-linux/usr/bin/arm-poky-linux-gnueabi/arm-poky-linux-gnueabi-ld.bfd:
BFD (GNU Binutils) 2.28.0.20170307 assertion fail ../../bfd/elf32-arm.c:9512
Makefile:1248: recipe for target 'u-boot' failed
The branch is:
u-boot-usb/master
I've tried to do "bisect" but another error showed up:
drivers/usb/host/xhci-dwc3.c: In function ‘xhci_dwc3_probe’:
drivers/usb/host/xhci-dwc3.c:109:29: warning: unused variable ‘plat’
[-Wunused-variable]
struct xhci_dwc3_platdata *plat = dev_get_platdata(dev);
^~~~
drivers/usb/host/xhci-dwc3.c: At top level:
drivers/usb/host/xhci-dwc3.c:143:37: error: invalid application of
‘sizeof’ to incomplete type ‘struct xhci_dwc3_platdata’
.platdata_auto_alloc_size = sizeof(struct xhci_dwc3_platdata),
^~~~~~
scripts/Makefile.build:280: recipe for target
'drivers/usb/host/xhci-dwc3.o' failed
make[1]: *** [drivers/usb/host/xhci-dwc3.o] Error 1
Patrice and Bin - please fix those errors and make the u-boot-usb tree
bisectable again.
The last working commit:
commit 041a8808fd06b4a276dd6fbbb5153deb3b5d391c
Author: Masahiro Yamada <yamada.masahiro@socionext.com>
Date: Thu Jun 22 16:35:14 2017 +0900
usb: add static to local symbols
Sparse reports "... was not declared. Should it be static?"
Signed-off-by: Masahiro Yamada <yamada.masahiro@socionext.com>
For easy reproduction please use odroid-xu3_defconfig.
--
Best regards,
Lukasz Majewski
--
DENX Software Engineering GmbH, Managing Director: Wolfgang Denk
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd at denx.de
^ permalink raw reply [flat|nested] 8+ messages in thread
* [U-Boot] [u-boot-denx-usb] Build break on current u-boot-usb master
2017-07-22 18:18 [U-Boot] [u-boot-denx-usb] Build break on current u-boot-usb master Łukasz Majewski
@ 2017-07-22 18:36 ` Marek Vasut
2017-07-22 18:39 ` Łukasz Majewski
2017-07-24 6:48 ` Patrice CHOTARD
0 siblings, 2 replies; 8+ messages in thread
From: Marek Vasut @ 2017-07-22 18:36 UTC (permalink / raw)
To: u-boot
On 07/22/2017 08:18 PM, Łukasz Majewski wrote:
> Hi Marek,
>
> When I was "cleaning up" my patchwork todo list I've found following
> problem (s):
>
> A lot of boards are broken with message:
>
> LD u-boot
> drivers/usb/host/built-in.o: In function `xhci_dwc3_remove':
> /home/lukma/work/embedded/u-boot-denx/drivers/usb/host/xhci-dwc3.c:161:
> undefined reference to `generic_phy_exit'
> drivers/usb/host/built-in.o: In function `xhci_dwc3_probe':
> /home/lukma/work/embedded/u-boot-denx/drivers/usb/host/xhci-dwc3.c:127:
> undefined reference to `generic_phy_get_by_index'
> /home/lukma/work/embedded/u-boot-denx/drivers/usb/host/xhci-dwc3.c:134:
> undefined reference to `generic_phy_init'
> /opt/tfk-sc58x/2.3/sysroots/x86_64-pokysdk-linux/usr/bin/arm-poky-linux-gnueabi/arm-poky-linux-gnueabi-ld.bfd:
> BFD (GNU Binutils) 2.28.0.20170307 assertion fail
> ../../bfd/elf32-arm.c:9512
> /opt/tfk-sc58x/2.3/sysroots/x86_64-pokysdk-linux/usr/bin/arm-poky-linux-gnueabi/arm-poky-linux-gnueabi-ld.bfd:
> BFD (GNU Binutils) 2.28.0.20170307 assertion fail
> ../../bfd/elf32-arm.c:9512
> /opt/tfk-sc58x/2.3/sysroots/x86_64-pokysdk-linux/usr/bin/arm-poky-linux-gnueabi/arm-poky-linux-gnueabi-ld.bfd:
> BFD (GNU Binutils) 2.28.0.20170307 assertion fail
> ../../bfd/elf32-arm.c:9512
> Makefile:1248: recipe for target 'u-boot' failed
>
> The branch is:
>
> u-boot-usb/master
>
>
> I've tried to do "bisect" but another error showed up:
>
> drivers/usb/host/xhci-dwc3.c: In function ‘xhci_dwc3_probe’:
> drivers/usb/host/xhci-dwc3.c:109:29: warning: unused variable ‘plat’
> [-Wunused-variable]
> struct xhci_dwc3_platdata *plat = dev_get_platdata(dev);
> ^~~~
> drivers/usb/host/xhci-dwc3.c: At top level:
> drivers/usb/host/xhci-dwc3.c:143:37: error: invalid application of
> ‘sizeof’ to incomplete type ‘struct xhci_dwc3_platdata’
> .platdata_auto_alloc_size = sizeof(struct xhci_dwc3_platdata),
> ^~~~~~
> scripts/Makefile.build:280: recipe for target
> 'drivers/usb/host/xhci-dwc3.o' failed
> make[1]: *** [drivers/usb/host/xhci-dwc3.o] Error 1
>
>
> Patrice and Bin - please fix those errors and make the u-boot-usb tree
> bisectable again.
I believe this is already underway since 2 days ago:
https://www.mail-archive.com/u-boot at lists.denx.de/msg256611.html
--
Best regards,
Marek Vasut
^ permalink raw reply [flat|nested] 8+ messages in thread
* [U-Boot] [u-boot-denx-usb] Build break on current u-boot-usb master
2017-07-22 18:36 ` Marek Vasut
@ 2017-07-22 18:39 ` Łukasz Majewski
2017-07-24 6:48 ` Patrice CHOTARD
1 sibling, 0 replies; 8+ messages in thread
From: Łukasz Majewski @ 2017-07-22 18:39 UTC (permalink / raw)
To: u-boot
On 07/22/2017 08:36 PM, Marek Vasut wrote:
> On 07/22/2017 08:18 PM, Łukasz Majewski wrote:
>> Hi Marek,
>>
>> When I was "cleaning up" my patchwork todo list I've found following
>> problem (s):
>>
>> A lot of boards are broken with message:
>>
>> LD u-boot
>> drivers/usb/host/built-in.o: In function `xhci_dwc3_remove':
>> /home/lukma/work/embedded/u-boot-denx/drivers/usb/host/xhci-dwc3.c:161:
>> undefined reference to `generic_phy_exit'
>> drivers/usb/host/built-in.o: In function `xhci_dwc3_probe':
>> /home/lukma/work/embedded/u-boot-denx/drivers/usb/host/xhci-dwc3.c:127:
>> undefined reference to `generic_phy_get_by_index'
>> /home/lukma/work/embedded/u-boot-denx/drivers/usb/host/xhci-dwc3.c:134:
>> undefined reference to `generic_phy_init'
>> /opt/tfk-sc58x/2.3/sysroots/x86_64-pokysdk-linux/usr/bin/arm-poky-linux-gnueabi/arm-poky-linux-gnueabi-ld.bfd:
>> BFD (GNU Binutils) 2.28.0.20170307 assertion fail
>> ../../bfd/elf32-arm.c:9512
>> /opt/tfk-sc58x/2.3/sysroots/x86_64-pokysdk-linux/usr/bin/arm-poky-linux-gnueabi/arm-poky-linux-gnueabi-ld.bfd:
>> BFD (GNU Binutils) 2.28.0.20170307 assertion fail
>> ../../bfd/elf32-arm.c:9512
>> /opt/tfk-sc58x/2.3/sysroots/x86_64-pokysdk-linux/usr/bin/arm-poky-linux-gnueabi/arm-poky-linux-gnueabi-ld.bfd:
>> BFD (GNU Binutils) 2.28.0.20170307 assertion fail
>> ../../bfd/elf32-arm.c:9512
>> Makefile:1248: recipe for target 'u-boot' failed
>>
>> The branch is:
>>
>> u-boot-usb/master
>>
>>
>> I've tried to do "bisect" but another error showed up:
>>
>> drivers/usb/host/xhci-dwc3.c: In function ‘xhci_dwc3_probe’:
>> drivers/usb/host/xhci-dwc3.c:109:29: warning: unused variable ‘plat’
>> [-Wunused-variable]
>> struct xhci_dwc3_platdata *plat = dev_get_platdata(dev);
>> ^~~~
>> drivers/usb/host/xhci-dwc3.c: At top level:
>> drivers/usb/host/xhci-dwc3.c:143:37: error: invalid application of
>> ‘sizeof’ to incomplete type ‘struct xhci_dwc3_platdata’
>> .platdata_auto_alloc_size = sizeof(struct xhci_dwc3_platdata),
>> ^~~~~~
>> scripts/Makefile.build:280: recipe for target
>> 'drivers/usb/host/xhci-dwc3.o' failed
>> make[1]: *** [drivers/usb/host/xhci-dwc3.o] Error 1
>>
>>
>> Patrice and Bin - please fix those errors and make the u-boot-usb tree
>> bisectable again.
> I believe this is already underway since 2 days ago:
> https://www.mail-archive.com/u-boot at lists.denx.de/msg256611.html
Ok. Good :-) Thanks
>
--
Best regards,
Lukasz Majewski
--
DENX Software Engineering GmbH, Managing Director: Wolfgang Denk
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd at denx.de
^ permalink raw reply [flat|nested] 8+ messages in thread
* [U-Boot] [u-boot-denx-usb] Build break on current u-boot-usb master
2017-07-22 18:36 ` Marek Vasut
2017-07-22 18:39 ` Łukasz Majewski
@ 2017-07-24 6:48 ` Patrice CHOTARD
2017-07-24 7:02 ` Bin Meng
1 sibling, 1 reply; 8+ messages in thread
From: Patrice CHOTARD @ 2017-07-24 6:48 UTC (permalink / raw)
To: u-boot
Hi Marek
On 07/22/2017 08:36 PM, Marek Vasut wrote:
> On 07/22/2017 08:18 PM, Łukasz Majewski wrote:
>> Hi Marek,
>>
>> When I was "cleaning up" my patchwork todo list I've found following
>> problem (s):
>>
>> A lot of boards are broken with message:
>>
>> LD u-boot
>> drivers/usb/host/built-in.o: In function `xhci_dwc3_remove':
>> /home/lukma/work/embedded/u-boot-denx/drivers/usb/host/xhci-dwc3.c:161:
>> undefined reference to `generic_phy_exit'
>> drivers/usb/host/built-in.o: In function `xhci_dwc3_probe':
>> /home/lukma/work/embedded/u-boot-denx/drivers/usb/host/xhci-dwc3.c:127:
>> undefined reference to `generic_phy_get_by_index'
>> /home/lukma/work/embedded/u-boot-denx/drivers/usb/host/xhci-dwc3.c:134:
>> undefined reference to `generic_phy_init'
>> /opt/tfk-sc58x/2.3/sysroots/x86_64-pokysdk-linux/usr/bin/arm-poky-linux-gnueabi/arm-poky-linux-gnueabi-ld.bfd:
>> BFD (GNU Binutils) 2.28.0.20170307 assertion fail
>> ../../bfd/elf32-arm.c:9512
>> /opt/tfk-sc58x/2.3/sysroots/x86_64-pokysdk-linux/usr/bin/arm-poky-linux-gnueabi/arm-poky-linux-gnueabi-ld.bfd:
>> BFD (GNU Binutils) 2.28.0.20170307 assertion fail
>> ../../bfd/elf32-arm.c:9512
>> /opt/tfk-sc58x/2.3/sysroots/x86_64-pokysdk-linux/usr/bin/arm-poky-linux-gnueabi/arm-poky-linux-gnueabi-ld.bfd:
>> BFD (GNU Binutils) 2.28.0.20170307 assertion fail
>> ../../bfd/elf32-arm.c:9512
>> Makefile:1248: recipe for target 'u-boot' failed
>>
>> The branch is:
>>
>> u-boot-usb/master
>>
>>
>> I've tried to do "bisect" but another error showed up:
>>
>> drivers/usb/host/xhci-dwc3.c: In function ‘xhci_dwc3_probe’:
>> drivers/usb/host/xhci-dwc3.c:109:29: warning: unused variable ‘plat’
>> [-Wunused-variable]
>> struct xhci_dwc3_platdata *plat = dev_get_platdata(dev);
>> ^~~~
>> drivers/usb/host/xhci-dwc3.c: At top level:
>> drivers/usb/host/xhci-dwc3.c:143:37: error: invalid application of
>> ‘sizeof’ to incomplete type ‘struct xhci_dwc3_platdata’
>> .platdata_auto_alloc_size = sizeof(struct xhci_dwc3_platdata),
>> ^~~~~~
>> scripts/Makefile.build:280: recipe for target
>> 'drivers/usb/host/xhci-dwc3.o' failed
>> make[1]: *** [drivers/usb/host/xhci-dwc3.o] Error 1
>>
>>
>> Patrice and Bin - please fix those errors and make the u-boot-usb tree
>> bisectable again.
> I believe this is already underway since 2 days ago:
> https://www.mail-archive.com/u-boot at lists.denx.de/msg256611.html
>
Regarding the bisection issue detected by Łukasz, it will imposed to
replace my "Extend xhci-dwc3" series already merged into your
u-boot-usb branch.
How do you want to proceed ?
I can resubmit the full 2 series with all fixes (bisection + compilation
issue) for "usb: Extend ehci and ohci generic driver" and "Extend
xhci-dwc3"
Patrice
^ permalink raw reply [flat|nested] 8+ messages in thread
* [U-Boot] [u-boot-denx-usb] Build break on current u-boot-usb master
2017-07-24 6:48 ` Patrice CHOTARD
@ 2017-07-24 7:02 ` Bin Meng
2017-07-24 10:56 ` Łukasz Majewski
0 siblings, 1 reply; 8+ messages in thread
From: Bin Meng @ 2017-07-24 7:02 UTC (permalink / raw)
To: u-boot
On Mon, Jul 24, 2017 at 2:48 PM, Patrice CHOTARD <patrice.chotard@st.com> wrote:
> Hi Marek
>
> On 07/22/2017 08:36 PM, Marek Vasut wrote:
>> On 07/22/2017 08:18 PM, Łukasz Majewski wrote:
>>> Hi Marek,
>>>
>>> When I was "cleaning up" my patchwork todo list I've found following
>>> problem (s):
>>>
>>> A lot of boards are broken with message:
>>>
>>> LD u-boot
>>> drivers/usb/host/built-in.o: In function `xhci_dwc3_remove':
>>> /home/lukma/work/embedded/u-boot-denx/drivers/usb/host/xhci-dwc3.c:161:
>>> undefined reference to `generic_phy_exit'
>>> drivers/usb/host/built-in.o: In function `xhci_dwc3_probe':
>>> /home/lukma/work/embedded/u-boot-denx/drivers/usb/host/xhci-dwc3.c:127:
>>> undefined reference to `generic_phy_get_by_index'
>>> /home/lukma/work/embedded/u-boot-denx/drivers/usb/host/xhci-dwc3.c:134:
>>> undefined reference to `generic_phy_init'
>>> /opt/tfk-sc58x/2.3/sysroots/x86_64-pokysdk-linux/usr/bin/arm-poky-linux-gnueabi/arm-poky-linux-gnueabi-ld.bfd:
>>> BFD (GNU Binutils) 2.28.0.20170307 assertion fail
>>> ../../bfd/elf32-arm.c:9512
>>> /opt/tfk-sc58x/2.3/sysroots/x86_64-pokysdk-linux/usr/bin/arm-poky-linux-gnueabi/arm-poky-linux-gnueabi-ld.bfd:
>>> BFD (GNU Binutils) 2.28.0.20170307 assertion fail
>>> ../../bfd/elf32-arm.c:9512
>>> /opt/tfk-sc58x/2.3/sysroots/x86_64-pokysdk-linux/usr/bin/arm-poky-linux-gnueabi/arm-poky-linux-gnueabi-ld.bfd:
>>> BFD (GNU Binutils) 2.28.0.20170307 assertion fail
>>> ../../bfd/elf32-arm.c:9512
>>> Makefile:1248: recipe for target 'u-boot' failed
>>>
>>> The branch is:
>>>
>>> u-boot-usb/master
>>>
>>>
>>> I've tried to do "bisect" but another error showed up:
>>>
>>> drivers/usb/host/xhci-dwc3.c: In function ‘xhci_dwc3_probe’:
>>> drivers/usb/host/xhci-dwc3.c:109:29: warning: unused variable ‘plat’
>>> [-Wunused-variable]
>>> struct xhci_dwc3_platdata *plat = dev_get_platdata(dev);
>>> ^~~~
>>> drivers/usb/host/xhci-dwc3.c: At top level:
>>> drivers/usb/host/xhci-dwc3.c:143:37: error: invalid application of
>>> ‘sizeof’ to incomplete type ‘struct xhci_dwc3_platdata’
>>> .platdata_auto_alloc_size = sizeof(struct xhci_dwc3_platdata),
>>> ^~~~~~
>>> scripts/Makefile.build:280: recipe for target
>>> 'drivers/usb/host/xhci-dwc3.o' failed
>>> make[1]: *** [drivers/usb/host/xhci-dwc3.o] Error 1
>>>
>>>
>>> Patrice and Bin - please fix those errors and make the u-boot-usb tree
>>> bisectable again.
>> I believe this is already underway since 2 days ago:
>> https://www.mail-archive.com/u-boot at lists.denx.de/msg256611.html
>>
>
> Regarding the bisection issue detected by Łukasz, it will imposed to
> replace my "Extend xhci-dwc3" series already merged into your
> u-boot-usb branch.
>
> How do you want to proceed ?
> I can resubmit the full 2 series with all fixes (bisection + compilation
> issue) for "usb: Extend ehci and ohci generic driver" and "Extend
> xhci-dwc3"
I think Marek can drop your previous series on u-boot-usb/master
completely then reapply your new series. After all, it's not on
u-boot/master yet, so everything can change.
Regards,
Bin
^ permalink raw reply [flat|nested] 8+ messages in thread
* [U-Boot] [u-boot-denx-usb] Build break on current u-boot-usb master
2017-07-24 7:02 ` Bin Meng
@ 2017-07-24 10:56 ` Łukasz Majewski
2017-07-24 12:05 ` Marek Vasut
0 siblings, 1 reply; 8+ messages in thread
From: Łukasz Majewski @ 2017-07-24 10:56 UTC (permalink / raw)
To: u-boot
On 07/24/2017 09:02 AM, Bin Meng wrote:
> On Mon, Jul 24, 2017 at 2:48 PM, Patrice CHOTARD <patrice.chotard@st.com> wrote:
>> Hi Marek
>>
>> On 07/22/2017 08:36 PM, Marek Vasut wrote:
>>> On 07/22/2017 08:18 PM, Łukasz Majewski wrote:
>>>> Hi Marek,
>>>>
>>>> When I was "cleaning up" my patchwork todo list I've found following
>>>> problem (s):
>>>>
>>>> A lot of boards are broken with message:
>>>>
>>>> LD u-boot
>>>> drivers/usb/host/built-in.o: In function `xhci_dwc3_remove':
>>>> /home/lukma/work/embedded/u-boot-denx/drivers/usb/host/xhci-dwc3.c:161:
>>>> undefined reference to `generic_phy_exit'
>>>> drivers/usb/host/built-in.o: In function `xhci_dwc3_probe':
>>>> /home/lukma/work/embedded/u-boot-denx/drivers/usb/host/xhci-dwc3.c:127:
>>>> undefined reference to `generic_phy_get_by_index'
>>>> /home/lukma/work/embedded/u-boot-denx/drivers/usb/host/xhci-dwc3.c:134:
>>>> undefined reference to `generic_phy_init'
>>>> /opt/tfk-sc58x/2.3/sysroots/x86_64-pokysdk-linux/usr/bin/arm-poky-linux-gnueabi/arm-poky-linux-gnueabi-ld.bfd:
>>>> BFD (GNU Binutils) 2.28.0.20170307 assertion fail
>>>> ../../bfd/elf32-arm.c:9512
>>>> /opt/tfk-sc58x/2.3/sysroots/x86_64-pokysdk-linux/usr/bin/arm-poky-linux-gnueabi/arm-poky-linux-gnueabi-ld.bfd:
>>>> BFD (GNU Binutils) 2.28.0.20170307 assertion fail
>>>> ../../bfd/elf32-arm.c:9512
>>>> /opt/tfk-sc58x/2.3/sysroots/x86_64-pokysdk-linux/usr/bin/arm-poky-linux-gnueabi/arm-poky-linux-gnueabi-ld.bfd:
>>>> BFD (GNU Binutils) 2.28.0.20170307 assertion fail
>>>> ../../bfd/elf32-arm.c:9512
>>>> Makefile:1248: recipe for target 'u-boot' failed
>>>>
>>>> The branch is:
>>>>
>>>> u-boot-usb/master
>>>>
>>>>
>>>> I've tried to do "bisect" but another error showed up:
>>>>
>>>> drivers/usb/host/xhci-dwc3.c: In function ‘xhci_dwc3_probe’:
>>>> drivers/usb/host/xhci-dwc3.c:109:29: warning: unused variable ‘plat’
>>>> [-Wunused-variable]
>>>> struct xhci_dwc3_platdata *plat = dev_get_platdata(dev);
>>>> ^~~~
>>>> drivers/usb/host/xhci-dwc3.c: At top level:
>>>> drivers/usb/host/xhci-dwc3.c:143:37: error: invalid application of
>>>> ‘sizeof’ to incomplete type ‘struct xhci_dwc3_platdata’
>>>> .platdata_auto_alloc_size = sizeof(struct xhci_dwc3_platdata),
>>>> ^~~~~~
>>>> scripts/Makefile.build:280: recipe for target
>>>> 'drivers/usb/host/xhci-dwc3.o' failed
>>>> make[1]: *** [drivers/usb/host/xhci-dwc3.o] Error 1
>>>>
>>>>
>>>> Patrice and Bin - please fix those errors and make the u-boot-usb tree
>>>> bisectable again.
>>> I believe this is already underway since 2 days ago:
>>> https://www.mail-archive.com/u-boot at lists.denx.de/msg256611.html
>>>
>>
>> Regarding the bisection issue detected by Łukasz, it will imposed to
>> replace my "Extend xhci-dwc3" series already merged into your
>> u-boot-usb branch.
>>
>> How do you want to proceed ?
>> I can resubmit the full 2 series with all fixes (bisection + compilation
>> issue) for "usb: Extend ehci and ohci generic driver" and "Extend
>> xhci-dwc3"
>
> I think Marek can drop your previous series on u-boot-usb/master
> completely then reapply your new series. After all, it's not on
> u-boot/master yet, so everything can change.
+1
>
> Regards,
> Bin
>
--
Best regards,
Lukasz Majewski
--
DENX Software Engineering GmbH, Managing Director: Wolfgang Denk
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd at denx.de
^ permalink raw reply [flat|nested] 8+ messages in thread
* [U-Boot] [u-boot-denx-usb] Build break on current u-boot-usb master
2017-07-24 10:56 ` Łukasz Majewski
@ 2017-07-24 12:05 ` Marek Vasut
2017-07-24 12:06 ` Marek Vasut
0 siblings, 1 reply; 8+ messages in thread
From: Marek Vasut @ 2017-07-24 12:05 UTC (permalink / raw)
To: u-boot
On 07/24/2017 12:56 PM, Łukasz Majewski wrote:
> On 07/24/2017 09:02 AM, Bin Meng wrote:
>> On Mon, Jul 24, 2017 at 2:48 PM, Patrice CHOTARD
>> <patrice.chotard@st.com> wrote:
>>> Hi Marek
>>>
>>> On 07/22/2017 08:36 PM, Marek Vasut wrote:
>>>> On 07/22/2017 08:18 PM, Łukasz Majewski wrote:
>>>>> Hi Marek,
>>>>>
>>>>> When I was "cleaning up" my patchwork todo list I've found following
>>>>> problem (s):
>>>>>
>>>>> A lot of boards are broken with message:
>>>>>
>>>>> LD u-boot
>>>>> drivers/usb/host/built-in.o: In function `xhci_dwc3_remove':
>>>>> /home/lukma/work/embedded/u-boot-denx/drivers/usb/host/xhci-dwc3.c:161:
>>>>>
>>>>> undefined reference to `generic_phy_exit'
>>>>> drivers/usb/host/built-in.o: In function `xhci_dwc3_probe':
>>>>> /home/lukma/work/embedded/u-boot-denx/drivers/usb/host/xhci-dwc3.c:127:
>>>>>
>>>>> undefined reference to `generic_phy_get_by_index'
>>>>> /home/lukma/work/embedded/u-boot-denx/drivers/usb/host/xhci-dwc3.c:134:
>>>>>
>>>>> undefined reference to `generic_phy_init'
>>>>> /opt/tfk-sc58x/2.3/sysroots/x86_64-pokysdk-linux/usr/bin/arm-poky-linux-gnueabi/arm-poky-linux-gnueabi-ld.bfd:
>>>>>
>>>>> BFD (GNU Binutils) 2.28.0.20170307 assertion fail
>>>>> ../../bfd/elf32-arm.c:9512
>>>>> /opt/tfk-sc58x/2.3/sysroots/x86_64-pokysdk-linux/usr/bin/arm-poky-linux-gnueabi/arm-poky-linux-gnueabi-ld.bfd:
>>>>>
>>>>> BFD (GNU Binutils) 2.28.0.20170307 assertion fail
>>>>> ../../bfd/elf32-arm.c:9512
>>>>> /opt/tfk-sc58x/2.3/sysroots/x86_64-pokysdk-linux/usr/bin/arm-poky-linux-gnueabi/arm-poky-linux-gnueabi-ld.bfd:
>>>>>
>>>>> BFD (GNU Binutils) 2.28.0.20170307 assertion fail
>>>>> ../../bfd/elf32-arm.c:9512
>>>>> Makefile:1248: recipe for target 'u-boot' failed
>>>>>
>>>>> The branch is:
>>>>>
>>>>> u-boot-usb/master
>>>>>
>>>>>
>>>>> I've tried to do "bisect" but another error showed up:
>>>>>
>>>>> drivers/usb/host/xhci-dwc3.c: In function ‘xhci_dwc3_probe’:
>>>>> drivers/usb/host/xhci-dwc3.c:109:29: warning: unused variable ‘plat’
>>>>> [-Wunused-variable]
>>>>> struct xhci_dwc3_platdata *plat = dev_get_platdata(dev);
>>>>> ^~~~
>>>>> drivers/usb/host/xhci-dwc3.c: At top level:
>>>>> drivers/usb/host/xhci-dwc3.c:143:37: error: invalid application of
>>>>> ‘sizeof’ to incomplete type ‘struct xhci_dwc3_platdata’
>>>>> .platdata_auto_alloc_size = sizeof(struct xhci_dwc3_platdata),
>>>>> ^~~~~~
>>>>> scripts/Makefile.build:280: recipe for target
>>>>> 'drivers/usb/host/xhci-dwc3.o' failed
>>>>> make[1]: *** [drivers/usb/host/xhci-dwc3.o] Error 1
>>>>>
>>>>>
>>>>> Patrice and Bin - please fix those errors and make the u-boot-usb tree
>>>>> bisectable again.
>>>> I believe this is already underway since 2 days ago:
>>>> https://www.mail-archive.com/u-boot at lists.denx.de/msg256611.html
>>>>
>>>
>>> Regarding the bisection issue detected by Łukasz, it will imposed to
>>> replace my "Extend xhci-dwc3" series already merged into your
>>> u-boot-usb branch.
>>>
>>> How do you want to proceed ?
>>> I can resubmit the full 2 series with all fixes (bisection + compilation
>>> issue) for "usb: Extend ehci and ohci generic driver" and "Extend
>>> xhci-dwc3"
>>
>> I think Marek can drop your previous series on u-boot-usb/master
>> completely then reapply your new series. After all, it's not on
>> u-boot/master yet, so everything can change.
>
> +1
I'd prefer incremental changes, so it's easier to review .
--
Best regards,
Marek Vasut
^ permalink raw reply [flat|nested] 8+ messages in thread
* [U-Boot] [u-boot-denx-usb] Build break on current u-boot-usb master
2017-07-24 12:05 ` Marek Vasut
@ 2017-07-24 12:06 ` Marek Vasut
0 siblings, 0 replies; 8+ messages in thread
From: Marek Vasut @ 2017-07-24 12:06 UTC (permalink / raw)
To: u-boot
On 07/24/2017 02:05 PM, Marek Vasut wrote:
> On 07/24/2017 12:56 PM, Łukasz Majewski wrote:
>> On 07/24/2017 09:02 AM, Bin Meng wrote:
>>> On Mon, Jul 24, 2017 at 2:48 PM, Patrice CHOTARD
>>> <patrice.chotard@st.com> wrote:
>>>> Hi Marek
>>>>
>>>> On 07/22/2017 08:36 PM, Marek Vasut wrote:
>>>>> On 07/22/2017 08:18 PM, Łukasz Majewski wrote:
>>>>>> Hi Marek,
>>>>>>
>>>>>> When I was "cleaning up" my patchwork todo list I've found following
>>>>>> problem (s):
>>>>>>
>>>>>> A lot of boards are broken with message:
>>>>>>
>>>>>> LD u-boot
>>>>>> drivers/usb/host/built-in.o: In function `xhci_dwc3_remove':
>>>>>> /home/lukma/work/embedded/u-boot-denx/drivers/usb/host/xhci-dwc3.c:161:
>>>>>>
>>>>>> undefined reference to `generic_phy_exit'
>>>>>> drivers/usb/host/built-in.o: In function `xhci_dwc3_probe':
>>>>>> /home/lukma/work/embedded/u-boot-denx/drivers/usb/host/xhci-dwc3.c:127:
>>>>>>
>>>>>> undefined reference to `generic_phy_get_by_index'
>>>>>> /home/lukma/work/embedded/u-boot-denx/drivers/usb/host/xhci-dwc3.c:134:
>>>>>>
>>>>>> undefined reference to `generic_phy_init'
>>>>>> /opt/tfk-sc58x/2.3/sysroots/x86_64-pokysdk-linux/usr/bin/arm-poky-linux-gnueabi/arm-poky-linux-gnueabi-ld.bfd:
>>>>>>
>>>>>> BFD (GNU Binutils) 2.28.0.20170307 assertion fail
>>>>>> ../../bfd/elf32-arm.c:9512
>>>>>> /opt/tfk-sc58x/2.3/sysroots/x86_64-pokysdk-linux/usr/bin/arm-poky-linux-gnueabi/arm-poky-linux-gnueabi-ld.bfd:
>>>>>>
>>>>>> BFD (GNU Binutils) 2.28.0.20170307 assertion fail
>>>>>> ../../bfd/elf32-arm.c:9512
>>>>>> /opt/tfk-sc58x/2.3/sysroots/x86_64-pokysdk-linux/usr/bin/arm-poky-linux-gnueabi/arm-poky-linux-gnueabi-ld.bfd:
>>>>>>
>>>>>> BFD (GNU Binutils) 2.28.0.20170307 assertion fail
>>>>>> ../../bfd/elf32-arm.c:9512
>>>>>> Makefile:1248: recipe for target 'u-boot' failed
>>>>>>
>>>>>> The branch is:
>>>>>>
>>>>>> u-boot-usb/master
>>>>>>
>>>>>>
>>>>>> I've tried to do "bisect" but another error showed up:
>>>>>>
>>>>>> drivers/usb/host/xhci-dwc3.c: In function ‘xhci_dwc3_probe’:
>>>>>> drivers/usb/host/xhci-dwc3.c:109:29: warning: unused variable ‘plat’
>>>>>> [-Wunused-variable]
>>>>>> struct xhci_dwc3_platdata *plat = dev_get_platdata(dev);
>>>>>> ^~~~
>>>>>> drivers/usb/host/xhci-dwc3.c: At top level:
>>>>>> drivers/usb/host/xhci-dwc3.c:143:37: error: invalid application of
>>>>>> ‘sizeof’ to incomplete type ‘struct xhci_dwc3_platdata’
>>>>>> .platdata_auto_alloc_size = sizeof(struct xhci_dwc3_platdata),
>>>>>> ^~~~~~
>>>>>> scripts/Makefile.build:280: recipe for target
>>>>>> 'drivers/usb/host/xhci-dwc3.o' failed
>>>>>> make[1]: *** [drivers/usb/host/xhci-dwc3.o] Error 1
>>>>>>
>>>>>>
>>>>>> Patrice and Bin - please fix those errors and make the u-boot-usb tree
>>>>>> bisectable again.
>>>>> I believe this is already underway since 2 days ago:
>>>>> https://www.mail-archive.com/u-boot at lists.denx.de/msg256611.html
>>>>>
>>>>
>>>> Regarding the bisection issue detected by Łukasz, it will imposed to
>>>> replace my "Extend xhci-dwc3" series already merged into your
>>>> u-boot-usb branch.
>>>>
>>>> How do you want to proceed ?
>>>> I can resubmit the full 2 series with all fixes (bisection + compilation
>>>> issue) for "usb: Extend ehci and ohci generic driver" and "Extend
>>>> xhci-dwc3"
>>>
>>> I think Marek can drop your previous series on u-boot-usb/master
>>> completely then reapply your new series. After all, it's not on
>>> u-boot/master yet, so everything can change.
>>
>> +1
>
> I'd prefer incremental changes, so it's easier to review .
Oh, and please, do NOT resubmit patches before getting feedback from me,
it really doesn't help. I just deleted both series I had from you.
--
Best regards,
Marek Vasut
^ permalink raw reply [flat|nested] 8+ messages in thread
end of thread, other threads:[~2017-07-24 12:06 UTC | newest]
Thread overview: 8+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2017-07-22 18:18 [U-Boot] [u-boot-denx-usb] Build break on current u-boot-usb master Łukasz Majewski
2017-07-22 18:36 ` Marek Vasut
2017-07-22 18:39 ` Łukasz Majewski
2017-07-24 6:48 ` Patrice CHOTARD
2017-07-24 7:02 ` Bin Meng
2017-07-24 10:56 ` Łukasz Majewski
2017-07-24 12:05 ` Marek Vasut
2017-07-24 12:06 ` Marek Vasut
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.