All of lore.kernel.org
 help / color / mirror / Atom feed
From: Bin Meng <bmeng.cn@gmail.com>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH 02/10] x86: ivybridge: Add FSP support
Date: Thu, 24 Dec 2015 06:48:24 +0800	[thread overview]
Message-ID: <CAEUhbmWh_tfxLsKy6wTV922JbSGJ4Zzs-YD0_LJTqe5-C898AA@mail.gmail.com> (raw)
In-Reply-To: <CAPnjgZ10NNFZKyz8zBOzePOwrUNW2m75Z09OeK1zv3aR8JdsdA@mail.gmail.com>

Hi Simon,

On Thu, Dec 24, 2015 at 12:44 AM, Simon Glass <sjg@chromium.org> wrote:
> Hi Bin,
>
> On 20 December 2015 at 19:27, Bin Meng <bmeng.cn@gmail.com> wrote:
>> Hi Simon,
>>
>> On Sat, Dec 19, 2015 at 10:52 AM, Simon Glass <sjg@chromium.org> wrote:
>>> On 11 December 2015 at 03:55, Bin Meng <bmeng.cn@gmail.com> wrote:
>>>> IvyBridge FSP package is built with a base address at 0xfff80000,
>>>> and does not use UPD data region. This adds basic FSP support.
>>>>
>>>> Signed-off-by: Bin Meng <bmeng.cn@gmail.com>
>>>> ---
>>>>
>>>>  arch/x86/cpu/ivybridge/Kconfig                     |  8 ++++
>>>>  arch/x86/cpu/ivybridge/Makefile                    |  4 ++
>>>>  arch/x86/cpu/ivybridge/fsp_configs.c               | 45 ++++++++++++++++++++++
>>>>  arch/x86/cpu/ivybridge/ivybridge.c                 | 22 +++++++++++
>>>>  .../include/asm/arch-ivybridge/fsp/fsp_configs.h   | 40 +++++++++++++++++++
>>>>  arch/x86/include/asm/arch-ivybridge/fsp/fsp_vpd.h  | 12 ++++++
>>>>  6 files changed, 131 insertions(+)
>>>>  create mode 100644 arch/x86/cpu/ivybridge/fsp_configs.c
>>>>  create mode 100644 arch/x86/cpu/ivybridge/ivybridge.c
>>>>  create mode 100644 arch/x86/include/asm/arch-ivybridge/fsp/fsp_configs.h
>>>>  create mode 100644 arch/x86/include/asm/arch-ivybridge/fsp/fsp_vpd.h
>>>
>>> Acked-by: Simon Glass <sjg@chromium.org>
>>> Tested on link (ivybridge non-FSP)
>>> Tested-by: Simon Glass <sjg@chromium.org>
>>>
>>> One question: why do we need an Intel license on this code?
>>>
>>
>> It was a copy and paste from other platform (queensbay and baytrail)
>> files. Do you think we should change it to GPLv2+?
>
> Hmm - is it using this license because it was written by Intel, or
> because you modified it from the FSP code that was written by Intel?
> If so, then I suppose it is reasonable to use the Intel license.
>

The file was not written by Intel. Current U-Boot implementation is
our own. I will change the license in v2.

Regards,
Bin

  reply	other threads:[~2015-12-23 22:48 UTC|newest]

Thread overview: 39+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-12-11 10:55 [U-Boot] [PATCH 00/10] x86: ivybridge: Add Intel FSP support Bin Meng
2015-12-11 10:55 ` [U-Boot] [PATCH 01/10] fdtdec: Add compatible string for Intel IvyBridge FSP Bin Meng
2015-12-19  2:51   ` Simon Glass
2015-12-21  2:33     ` Bin Meng
2016-02-06  4:29       ` Bin Meng
2016-02-19 20:56         ` Simon Glass
2015-12-21  7:50     ` Bin Meng
2015-12-11 10:55 ` [U-Boot] [PATCH 02/10] x86: ivybridge: Add FSP support Bin Meng
2015-12-19  2:52   ` Simon Glass
2015-12-21  2:27     ` Bin Meng
2015-12-23 16:44       ` Simon Glass
2015-12-23 22:48         ` Bin Meng [this message]
2015-12-11 10:55 ` [U-Boot] [PATCH 03/10] tools: microcode-tool: Support parsing header file with a license block Bin Meng
2015-12-19  2:52   ` Simon Glass
2015-12-21  7:50     ` Bin Meng
2015-12-11 10:55 ` [U-Boot] [PATCH 04/10] x86: ivybridge: Add microcode blobs for all the steppings Bin Meng
2015-12-19  2:52   ` Simon Glass
2015-12-21  7:50     ` Bin Meng
2015-12-11 10:55 ` [U-Boot] [PATCH 05/10] superio: Add SMSC SIO1007 driver Bin Meng
2015-12-19  2:52   ` Simon Glass
2015-12-21  2:42     ` Bin Meng
2016-01-06  0:24       ` Simon Glass
2016-01-26  8:29         ` Bin Meng
2016-01-26 17:03           ` Simon Glass
2015-12-11 10:55 ` [U-Boot] [PATCH 06/10] x86: ivybridge: Do not require HAVE_INTEL_ME Bin Meng
2015-12-19  2:52   ` Simon Glass
2015-12-21  7:50     ` Bin Meng
2015-12-11 10:55 ` [U-Boot] [PATCH 07/10] x86: fsp: Make sure HOB list is not overwritten by U-Boot Bin Meng
2015-12-19  2:52   ` Simon Glass
2015-12-21  2:36     ` Bin Meng
2015-12-11 10:55 ` [U-Boot] [PATCH 08/10] x86: fsp: Always use hex numbers in the hob command output Bin Meng
2015-12-19  2:52   ` Simon Glass
2015-12-21  7:50     ` Bin Meng
2015-12-11 10:55 ` [U-Boot] [PATCH 09/10] x86: ivybridge: Add macros for LPC decode ranges Bin Meng
2015-12-19  2:52   ` Simon Glass
2015-12-21  7:50     ` Bin Meng
2015-12-11 10:55 ` [U-Boot] [PATCH 10/10] x86: Add Intel Cougar Canyon 2 board Bin Meng
2015-12-19  2:52   ` Simon Glass
2015-12-21  2:34     ` Bin Meng

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=CAEUhbmWh_tfxLsKy6wTV922JbSGJ4Zzs-YD0_LJTqe5-C898AA@mail.gmail.com \
    --to=bmeng.cn@gmail.com \
    --cc=u-boot@lists.denx.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.