[U-Boot] [PATCH] coreboot: only init usb if necessary

* [U-Boot] [PATCH] coreboot: only init usb if necessary
@ 2018-11-12 12:44 Christian Gmeiner
  2018-11-12 13:44 ` Bin Meng
  0 siblings, 1 reply; 5+ messages in thread
From: Christian Gmeiner @ 2018-11-12 12:44 UTC (permalink / raw)
  To: u-boot

From: Thomas RIENOESSL <thomas.rienoessl@bachmann.info>

Up until now the call to initialize the USB subsystem
was hardcoded for U-Boot running as a coreboot payload.
This was used to enable the use of a USB keyboard
in the U-Boot shell. However not all boards might need
this functionality. As initializing the USB subsystem
can take a considerable amount of time (several
seconds on some boards), we now initialize the
USB subsystem only if U-Boot is configured to use
USB keyboards.

Signed-off-by: Thomas RIENOESSL <thomas.rienoessl@bachmann.info>
---
 arch/x86/cpu/coreboot/coreboot.c | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/arch/x86/cpu/coreboot/coreboot.c b/arch/x86/cpu/coreboot/coreboot.c
index a6fd3a849a..915341fe12 100644
--- a/arch/x86/cpu/coreboot/coreboot.c
+++ b/arch/x86/cpu/coreboot/coreboot.c
@@ -77,7 +77,8 @@ int last_stage_init(void)
 		timestamp_add_to_bootstage();
 
 	/* start usb so that usb keyboard can be used as input device */
-	usb_init();
+	if (IS_ENABLED(CONFIG_USB_KEYBOARD))
+		usb_init();
 
 	board_final_cleanup();
 
-- 
2.19.1

^ permalink raw reply related	[flat|nested] 5+ messages in thread