From: Bin Meng <bmeng.cn@gmail.com>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH] x86: kconfig: Remove meaningless 'select n'
Date: Tue, 30 Jan 2018 21:04:38 +0800 [thread overview]
Message-ID: <CAEUhbmWzKbPxVqQdrmtFSpOCnxgrPzBht2=2EzMVCKSOz87-HA@mail.gmail.com> (raw)
In-Reply-To: <20180130125903.5920-1-ulfalizer@gmail.com>
On Tue, Jan 30, 2018 at 8:59 PM, Ulf Magnusson <ulfalizer@gmail.com> wrote:
> 'select n' selects a constant symbol, which is meaningless and has no
> effect. Maybe this was meant to be a 'default n', though bool and
> tristate symbols already implicitly default to n.
>
> Discovered in Kconfiglib (https://github.com/ulfalizer/Kconfiglib),
> which does more strict checking here:
>
> kconfiglib.KconfigSyntaxError: board/google/Kconfig:34: Couldn't parse ' select n': expected nonconstant symbol
>
> Signed-off-by: Ulf Magnusson <ulfalizer@gmail.com>
> ---
> board/google/Kconfig | 1 -
> 1 file changed, 1 deletion(-)
>
Reviewed-by: Bin Meng <bmeng.cn@gmail.com>
next prev parent reply other threads:[~2018-01-30 13:04 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-01-30 12:59 [U-Boot] [PATCH] x86: kconfig: Remove meaningless 'select n' Ulf Magnusson
2018-01-30 13:04 ` Bin Meng [this message]
2018-01-30 14:42 ` Bin Meng
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAEUhbmWzKbPxVqQdrmtFSpOCnxgrPzBht2=2EzMVCKSOz87-HA@mail.gmail.com' \
--to=bmeng.cn@gmail.com \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.