* [U-Boot] [PATCH] x86: kconfig: Remove meaningless 'select n'
@ 2018-01-30 12:59 Ulf Magnusson
2018-01-30 13:04 ` Bin Meng
0 siblings, 1 reply; 3+ messages in thread
From: Ulf Magnusson @ 2018-01-30 12:59 UTC (permalink / raw)
To: u-boot
'select n' selects a constant symbol, which is meaningless and has no
effect. Maybe this was meant to be a 'default n', though bool and
tristate symbols already implicitly default to n.
Discovered in Kconfiglib (https://github.com/ulfalizer/Kconfiglib),
which does more strict checking here:
kconfiglib.KconfigSyntaxError: board/google/Kconfig:34: Couldn't parse ' select n': expected nonconstant symbol
Signed-off-by: Ulf Magnusson <ulfalizer@gmail.com>
---
board/google/Kconfig | 1 -
1 file changed, 1 deletion(-)
diff --git a/board/google/Kconfig b/board/google/Kconfig
index e56c026ef6..766db1b449 100644
--- a/board/google/Kconfig
+++ b/board/google/Kconfig
@@ -31,7 +31,6 @@ config TARGET_CHROMEBOOK_LINK64
config TARGET_CHROMEBOX_PANTHER
bool "Chromebox panther (not available)"
- select n
help
Note: At present this must be used with coreboot. See README.x86
for instructions.
--
2.14.1
^ permalink raw reply related [flat|nested] 3+ messages in thread
* [U-Boot] [PATCH] x86: kconfig: Remove meaningless 'select n'
2018-01-30 12:59 [U-Boot] [PATCH] x86: kconfig: Remove meaningless 'select n' Ulf Magnusson
@ 2018-01-30 13:04 ` Bin Meng
2018-01-30 14:42 ` Bin Meng
0 siblings, 1 reply; 3+ messages in thread
From: Bin Meng @ 2018-01-30 13:04 UTC (permalink / raw)
To: u-boot
On Tue, Jan 30, 2018 at 8:59 PM, Ulf Magnusson <ulfalizer@gmail.com> wrote:
> 'select n' selects a constant symbol, which is meaningless and has no
> effect. Maybe this was meant to be a 'default n', though bool and
> tristate symbols already implicitly default to n.
>
> Discovered in Kconfiglib (https://github.com/ulfalizer/Kconfiglib),
> which does more strict checking here:
>
> kconfiglib.KconfigSyntaxError: board/google/Kconfig:34: Couldn't parse ' select n': expected nonconstant symbol
>
> Signed-off-by: Ulf Magnusson <ulfalizer@gmail.com>
> ---
> board/google/Kconfig | 1 -
> 1 file changed, 1 deletion(-)
>
Reviewed-by: Bin Meng <bmeng.cn@gmail.com>
^ permalink raw reply [flat|nested] 3+ messages in thread
* [U-Boot] [PATCH] x86: kconfig: Remove meaningless 'select n'
2018-01-30 13:04 ` Bin Meng
@ 2018-01-30 14:42 ` Bin Meng
0 siblings, 0 replies; 3+ messages in thread
From: Bin Meng @ 2018-01-30 14:42 UTC (permalink / raw)
To: u-boot
On Tue, Jan 30, 2018 at 9:04 PM, Bin Meng <bmeng.cn@gmail.com> wrote:
> On Tue, Jan 30, 2018 at 8:59 PM, Ulf Magnusson <ulfalizer@gmail.com> wrote:
>> 'select n' selects a constant symbol, which is meaningless and has no
>> effect. Maybe this was meant to be a 'default n', though bool and
>> tristate symbols already implicitly default to n.
>>
>> Discovered in Kconfiglib (https://github.com/ulfalizer/Kconfiglib),
>> which does more strict checking here:
>>
>> kconfiglib.KconfigSyntaxError: board/google/Kconfig:34: Couldn't parse ' select n': expected nonconstant symbol
>>
>> Signed-off-by: Ulf Magnusson <ulfalizer@gmail.com>
>> ---
>> board/google/Kconfig | 1 -
>> 1 file changed, 1 deletion(-)
>>
>
> Reviewed-by: Bin Meng <bmeng.cn@gmail.com>
applied to u-boot-x86, thanks!
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2018-01-30 14:42 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2018-01-30 12:59 [U-Boot] [PATCH] x86: kconfig: Remove meaningless 'select n' Ulf Magnusson
2018-01-30 13:04 ` Bin Meng
2018-01-30 14:42 ` Bin Meng
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.