All of lore.kernel.org
 help / color / mirror / Atom feed
From: Bin Meng <bmeng.cn@gmail.com>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH 8/9] pci: layerscape: rewrite pci driver based on DM
Date: Mon, 10 Oct 2016 19:49:27 +0800	[thread overview]
Message-ID: <CAEUhbmX7RSkrhq6Eiym3xu7ko3=XQqb=bw05bO52nMYjBswU-Q@mail.gmail.com> (raw)
In-Reply-To: <1476089269-28697-8-git-send-email-Minghuan.Lian@nxp.com>

Hi Minghuan,

On Mon, Oct 10, 2016 at 4:47 PM, Minghuan Lian <Minghuan.Lian@nxp.com> wrote:
> There are more than five kinds of Layerscape SoCs. unfortunately,
> PCIe controller of each SoC is a little bit different. In order
> to avoid too many macro definitions, the patch re-implement PCIe
> driver based on DM. PCIe dts node is to describe the difference.
>
> Signed-off-by: Minghuan Lian <Minghuan.Lian@nxp.com>
> ---
>  .../include/asm/arch-fsl-layerscape/immap_lsch3.h  |   8 -
>  drivers/pci/Kconfig                                |   8 +
>  drivers/pci/pcie_layerscape.c                      | 958 +++++++++++----------
>  include/configs/ls1012a_common.h                   |  12 +
>  include/configs/ls1012aqds.h                       |  24 -
>  include/configs/ls1012ardb.h                       |  24 -
>  include/configs/ls1021aqds.h                       |  18 +-
>  include/configs/ls1021atwr.h                       |  18 +-
>  include/configs/ls1043a_common.h                   |  23 +-
>  include/configs/ls2080a_common.h                   |  27 +-
>  include/configs/ls2080aqds.h                       |   8 -
>  include/configs/ls2080ardb.h                       |   8 -

These header file changes should not be put in the same commit of the
layerscape PCIe driver conversion. They should be in a separate
commit. So you are likely to have 3 commits: firstly add DM codes with
#ifdef CONFIG_DM_PCI #endif in the layerscape PCIe driver, without
breaking the existing board support. 2nd commit to update the boards
configuration files (defconfig and the header), and 3rd commit to
remove the #ifdef CONFIG_DM_PCI #endif, only leaving the DM version
codes.

>  12 files changed, 526 insertions(+), 610 deletions(-)
>
> diff --git a/arch/arm/include/asm/arch-fsl-layerscape/immap_lsch3.h b/arch/arm/include/asm/arch-fsl-layerscape/immap_lsch3.h
> index 7acba27..bd07808 100644
> --- a/arch/arm/include/asm/arch-fsl-layerscape/immap_lsch3.h
> +++ b/arch/arm/include/asm/arch-fsl-layerscape/immap_lsch3.h
> @@ -104,14 +104,6 @@
>  #define CONFIG_SYS_PCIE2_PHYS_ADDR             0x1200000000ULL
>  #define CONFIG_SYS_PCIE3_PHYS_ADDR             0x1400000000ULL
>  #define CONFIG_SYS_PCIE4_PHYS_ADDR             0x1600000000ULL
> -/* LUT registers */
> -#define PCIE_LUT_BASE                          0x80000
> -#define PCIE_LUT_LCTRL0                                0x7F8
> -#define PCIE_LUT_DBG                           0x7FC
> -#define PCIE_LUT_UDR(n)         (0x800 + (n) * 8)
> -#define PCIE_LUT_LDR(n)         (0x804 + (n) * 8)
> -#define PCIE_LUT_ENABLE         (1 << 31)
> -#define PCIE_LUT_ENTRY_COUNT    32
>

[snip]

Regards,
Bin

  reply	other threads:[~2016-10-10 11:49 UTC|newest]

Thread overview: 26+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-10-10  8:47 [U-Boot] [PATCH 1/9] dm: pci: return the real controller in pci_bus_to_hose() Minghuan Lian
2016-10-10  8:47 ` [U-Boot] [PATCH 2/9] dm: pci: remove pci_bus_to_hose(0) calling Minghuan Lian
2016-10-10 11:54   ` Bin Meng
2016-10-11  7:26     ` M.H. Lian
2016-10-10  8:47 ` [U-Boot] [PATCH 3/9] arm: ls1021a: add PCIe dts node Minghuan Lian
2016-10-10  8:47 ` [U-Boot] [PATCH 4/9] arm: ls1012a: " Minghuan Lian
2016-10-10  8:47 ` [U-Boot] [PATCH 5/9] armv8: ls1043a: " Minghuan Lian
2016-10-10  8:47 ` [U-Boot] [PATCH 6/9] armv8: ls1046a: " Minghuan Lian
2016-10-10  8:47 ` [U-Boot] [PATCH 7/9] armv8: ls2080a: " Minghuan Lian
2016-10-10  8:47 ` [U-Boot] [PATCH 8/9] pci: layerscape: rewrite pci driver based on DM Minghuan Lian
2016-10-10 11:49   ` Bin Meng [this message]
2016-10-11  7:21     ` M.H. Lian
2016-10-11  7:28       ` Bin Meng
2016-10-10  8:47 ` [U-Boot] [PATCH 9/9] armv8: ls1046a: Enable PCIe support Minghuan Lian
2016-10-10  8:47 ` Minghuan Lian
2016-10-10 11:41   ` Bin Meng
2016-10-11  7:14     ` M.H. Lian
2016-10-10  9:03 ` [U-Boot] [PATCH 1/9] dm: pci: return the real controller in pci_bus_to_hose() Bin Meng
2016-10-10  9:09   ` M.H. Lian
2016-10-10 10:37     ` Bin Meng
2016-10-11  7:12       ` M.H. Lian
2016-10-11  7:43         ` Bin Meng
2016-10-11  9:36           ` M.H. Lian
2016-10-11 10:35             ` Bin Meng
2016-10-11 11:01               ` M.H. Lian
2016-11-07 18:13             ` york sun

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to='CAEUhbmX7RSkrhq6Eiym3xu7ko3=XQqb=bw05bO52nMYjBswU-Q@mail.gmail.com' \
    --to=bmeng.cn@gmail.com \
    --cc=u-boot@lists.denx.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.