[U-Boot] [PATCH 1/5] pci: xilinx: Fix doc comments on config space accessors

[U-Boot] [PATCH 1/5] pci: xilinx: Fix doc comments on config space accessors

[Tuomas Tynkkynen]

These take the 'struct udevice *' as an argument, not the
'struct xilinx_pcie *` which is a local variable. Fix the comments to
match the code.

Signed-off-by: Tuomas Tynkkynen <tuomas.tynkkynen@iki.fi>
---
 drivers/pci/pcie_xilinx.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/drivers/pci/pcie_xilinx.c b/drivers/pci/pcie_xilinx.c
index 08e2e93445..e31ba8bd51 100644
--- a/drivers/pci/pcie_xilinx.c
+++ b/drivers/pci/pcie_xilinx.c
@@ -87,7 +87,7 @@ static int pcie_xilinx_config_address(struct xilinx_pcie *pcie, pci_dev_t bdf,
 
 /**
  * pcie_xilinx_read_config() - Read from configuration space
- * @pcie: Pointer to the PCI controller state
+ * @bus: Pointer to the PCI bus
  * @bdf: Identifies the PCIe device to access
  * @offset: The offset into the device's configuration space
  * @valuep: A pointer at which to store the read value
@@ -130,7 +130,7 @@ static int pcie_xilinx_read_config(struct udevice *bus, pci_dev_t bdf,
 
 /**
  * pcie_xilinx_write_config() - Write to configuration space
- * @pcie: Pointer to the PCI controller state
+ * @bus: Pointer to the PCI bus
  * @bdf: Identifies the PCIe device to access
  * @offset: The offset into the device's configuration space
  * @value: The value to write
-- 
2.13.0

[U-Boot] [PATCH 2/5] pci: xilinx: Remove unused field 'hose' from struct xilinx_pcie

[Tuomas Tynkkynen]

This field has never been used as the driver has been DM-based since the
beginning. Drop it.

Signed-off-by: Tuomas Tynkkynen <tuomas.tynkkynen@iki.fi>
---
 drivers/pci/pcie_xilinx.c | 2 --
 1 file changed, 2 deletions(-)

diff --git a/drivers/pci/pcie_xilinx.c b/drivers/pci/pcie_xilinx.c
index e31ba8bd51..4ba32df516 100644
--- a/drivers/pci/pcie_xilinx.c
+++ b/drivers/pci/pcie_xilinx.c
@@ -14,11 +14,9 @@
 
 /**
  * struct xilinx_pcie - Xilinx PCIe controller state
- * @hose: The parent classes PCI controller state
  * @cfg_base: The base address of memory mapped configuration space
  */
 struct xilinx_pcie {
-	struct pci_controller hose;
 	void *cfg_base;
 };
 
-- 
2.13.0

[U-Boot] [PATCH 3/5] pci: tegra: Remove unused field 'hose' from struct tegra_pcie

[Tuomas Tynkkynen]

This field is no longer used since the DM conversion. Drop it.

Signed-off-by: Tuomas Tynkkynen <tuomas.tynkkynen@iki.fi>
---
 drivers/pci/pci_tegra.c | 2 --
 1 file changed, 2 deletions(-)

diff --git a/drivers/pci/pci_tegra.c b/drivers/pci/pci_tegra.c
index cb5cf8b043..7d920d423d 100644
--- a/drivers/pci/pci_tegra.c
+++ b/drivers/pci/pci_tegra.c
@@ -218,8 +218,6 @@ struct tegra_pcie_soc {
 };
 
 struct tegra_pcie {
-	struct pci_controller hose;
-
 	struct resource pads;
 	struct resource afi;
 	struct resource cs;
-- 
2.13.0

[U-Boot] [PATCH 4/5] pci: layerscape: Remove unused field 'hose' from struct ls_pcie

[Tuomas Tynkkynen]

This field is no longer used since the DM conversion. Drop it.

Signed-off-by: Tuomas Tynkkynen <tuomas.tynkkynen@iki.fi>
---
 drivers/pci/pcie_layerscape.h | 1 -
 1 file changed, 1 deletion(-)

diff --git a/drivers/pci/pcie_layerscape.h b/drivers/pci/pcie_layerscape.h
index 782e3ab7ad..3a6cecb07d 100644
--- a/drivers/pci/pcie_layerscape.h
+++ b/drivers/pci/pcie_layerscape.h
@@ -145,7 +145,6 @@ struct ls_pcie {
 	bool big_endian;
 	bool enabled;
 	int next_lut_index;
-	struct pci_controller hose;
 };
 
 extern struct list_head ls_pcie_list;
-- 
2.13.0

[U-Boot] [PATCH 5/5] pci: Remove unnecessary 'default n' from Kconfig

[Tuomas Tynkkynen]

'default n' is the default anyway so it doesn't need to be specified
explicitly, and the rest of the file doesn't specify it either anywhere.
Drop it.

Signed-off-by: Tuomas Tynkkynen <tuomas.tynkkynen@iki.fi>
---
 drivers/pci/Kconfig | 1 -
 1 file changed, 1 deletion(-)

diff --git a/drivers/pci/Kconfig b/drivers/pci/Kconfig
index e2a1c0a409..8af2470268 100644
--- a/drivers/pci/Kconfig
+++ b/drivers/pci/Kconfig
@@ -35,7 +35,6 @@ config PCI_PNP
 
 config PCIE_DW_MVEBU
 	bool "Enable Armada-8K PCIe driver (DesignWare core)"
-	default n
 	depends on DM_PCI
 	depends on ARMADA_8K
 	help
-- 
2.13.0

[U-Boot] [PATCH 1/5] pci: xilinx: Fix doc comments on config space accessors

[Bin Meng]

On Fri, Sep 1, 2017 at 10:25 PM, Tuomas Tynkkynen
<tuomas.tynkkynen@iki.fi> wrote:
> These take the 'struct udevice *' as an argument, not the
> 'struct xilinx_pcie *` which is a local variable. Fix the comments to
> match the code.
>
> Signed-off-by: Tuomas Tynkkynen <tuomas.tynkkynen@iki.fi>
> ---
>  drivers/pci/pcie_xilinx.c | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
>

Reviewed-by: Bin Meng <bmeng.cn@gmail.com>

[U-Boot] [PATCH 2/5] pci: xilinx: Remove unused field 'hose' from struct xilinx_pcie

[Bin Meng]

On Fri, Sep 1, 2017 at 10:25 PM, Tuomas Tynkkynen
<tuomas.tynkkynen@iki.fi> wrote:
> This field has never been used as the driver has been DM-based since the
> beginning. Drop it.
>
> Signed-off-by: Tuomas Tynkkynen <tuomas.tynkkynen@iki.fi>
> ---
>  drivers/pci/pcie_xilinx.c | 2 --
>  1 file changed, 2 deletions(-)
>

Reviewed-by: Bin Meng <bmeng.cn@gmail.com>

[U-Boot] [PATCH 3/5] pci: tegra: Remove unused field 'hose' from struct tegra_pcie

[Bin Meng]

On Fri, Sep 1, 2017 at 10:26 PM, Tuomas Tynkkynen
<tuomas.tynkkynen@iki.fi> wrote:
> This field is no longer used since the DM conversion. Drop it.
>
> Signed-off-by: Tuomas Tynkkynen <tuomas.tynkkynen@iki.fi>
> ---
>  drivers/pci/pci_tegra.c | 2 --
>  1 file changed, 2 deletions(-)
>

Reviewed-by: Bin Meng <bmeng.cn@gmail.com>

[U-Boot] [PATCH 4/5] pci: layerscape: Remove unused field 'hose' from struct ls_pcie

[Bin Meng]

On Fri, Sep 1, 2017 at 10:26 PM, Tuomas Tynkkynen
<tuomas.tynkkynen@iki.fi> wrote:
> This field is no longer used since the DM conversion. Drop it.
>
> Signed-off-by: Tuomas Tynkkynen <tuomas.tynkkynen@iki.fi>
> ---
>  drivers/pci/pcie_layerscape.h | 1 -
>  1 file changed, 1 deletion(-)
>

Reviewed-by: Bin Meng <bmeng.cn@gmail.com>

[U-Boot] [PATCH 5/5] pci: Remove unnecessary 'default n' from Kconfig

[Bin Meng]

On Fri, Sep 1, 2017 at 10:26 PM, Tuomas Tynkkynen
<tuomas.tynkkynen@iki.fi> wrote:
> 'default n' is the default anyway so it doesn't need to be specified
> explicitly, and the rest of the file doesn't specify it either anywhere.
> Drop it.
>
> Signed-off-by: Tuomas Tynkkynen <tuomas.tynkkynen@iki.fi>
> ---
>  drivers/pci/Kconfig | 1 -
>  1 file changed, 1 deletion(-)
>

Reviewed-by: Bin Meng <bmeng.cn@gmail.com>

[U-Boot] [U-Boot, 1/5] pci: xilinx: Fix doc comments on config space accessors

[Tom Rini]

On Fri, Sep 01, 2017 at 05:25:58PM +0300, Tuomas Tynkkynen wrote:

> These take the 'struct udevice *' as an argument, not the
> 'struct xilinx_pcie *` which is a local variable. Fix the comments to
> match the code.
> 
> Signed-off-by: Tuomas Tynkkynen <tuomas.tynkkynen@iki.fi>
> Reviewed-by: Bin Meng <bmeng.cn@gmail.com>

Applied to u-boot/master, thanks!

-- 
Tom
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 819 bytes
Desc: Digital signature
URL: <http://lists.denx.de/pipermail/u-boot/attachments/20170922/fe1dc3c0/attachment.sig>

[U-Boot] [U-Boot, 2/5] pci: xilinx: Remove unused field 'hose' from struct xilinx_pcie

[Tom Rini]

On Fri, Sep 01, 2017 at 05:25:59PM +0300, Tuomas Tynkkynen wrote:

> This field has never been used as the driver has been DM-based since the
> beginning. Drop it.
> 
> Signed-off-by: Tuomas Tynkkynen <tuomas.tynkkynen@iki.fi>
> Reviewed-by: Bin Meng <bmeng.cn@gmail.com>

Applied to u-boot/master, thanks!

-- 
Tom
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 819 bytes
Desc: Digital signature
URL: <http://lists.denx.de/pipermail/u-boot/attachments/20170922/79cc2764/attachment.sig>

[U-Boot] [U-Boot, 3/5] pci: tegra: Remove unused field 'hose' from struct tegra_pcie

[Tom Rini]

On Fri, Sep 01, 2017 at 05:26:00PM +0300, Tuomas Tynkkynen wrote:

> This field is no longer used since the DM conversion. Drop it.
> 
> Signed-off-by: Tuomas Tynkkynen <tuomas.tynkkynen@iki.fi>
> Reviewed-by: Bin Meng <bmeng.cn@gmail.com>

Applied to u-boot/master, thanks!

-- 
Tom
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 819 bytes
Desc: Digital signature
URL: <http://lists.denx.de/pipermail/u-boot/attachments/20170922/01075c56/attachment.sig>

[U-Boot] [U-Boot, 4/5] pci: layerscape: Remove unused field 'hose' from struct ls_pcie

[Tom Rini]

On Fri, Sep 01, 2017 at 05:26:01PM +0300, Tuomas Tynkkynen wrote:

> This field is no longer used since the DM conversion. Drop it.
> 
> Signed-off-by: Tuomas Tynkkynen <tuomas.tynkkynen@iki.fi>
> Reviewed-by: Bin Meng <bmeng.cn@gmail.com>

Applied to u-boot/master, thanks!

-- 
Tom
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 819 bytes
Desc: Digital signature
URL: <http://lists.denx.de/pipermail/u-boot/attachments/20170922/33df9c6c/attachment.sig>

[U-Boot] [U-Boot, 5/5] pci: Remove unnecessary 'default n' from Kconfig

[Tom Rini]

On Fri, Sep 01, 2017 at 05:26:02PM +0300, Tuomas Tynkkynen wrote:

> 'default n' is the default anyway so it doesn't need to be specified
> explicitly, and the rest of the file doesn't specify it either anywhere.
> Drop it.
> 
> Signed-off-by: Tuomas Tynkkynen <tuomas.tynkkynen@iki.fi>
> Reviewed-by: Bin Meng <bmeng.cn@gmail.com>

Applied to u-boot/master, thanks!

-- 
Tom
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 819 bytes
Desc: Digital signature
URL: <http://lists.denx.de/pipermail/u-boot/attachments/20170922/8c874173/attachment.sig>