All of lore.kernel.org
 help / color / mirror / Atom feed
From: Bin Meng <bmeng.cn@gmail.com>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH 01/20] Fix comment nits in board_f.c
Date: Tue, 28 Apr 2015 09:54:54 +0800	[thread overview]
Message-ID: <CAEUhbmXPtWFOQ0uFdmzuXb0xxFHzgEqfBB3zxodnOFmsvY4UZw@mail.gmail.com> (raw)
In-Reply-To: <1430174911-27538-2-git-send-email-sjg@chromium.org>

On Tue, Apr 28, 2015 at 6:48 AM, Simon Glass <sjg@chromium.org> wrote:
> Try to make it a little clearer.
>
> Signed-off-by: Simon Glass <sjg@chromium.org>
> ---
>
>  common/board_f.c | 9 ++++-----
>  1 file changed, 4 insertions(+), 5 deletions(-)
>
> diff --git a/common/board_f.c b/common/board_f.c
> index 322e070..fbbad1b 100644
> --- a/common/board_f.c
> +++ b/common/board_f.c
> @@ -73,7 +73,7 @@ DECLARE_GLOBAL_DATA_PTR;
>  #endif
>
>  /*
> - * sjg: IMO this code should be
> + * TODO(sjg at chromium.org): IMO this code should be
>   * refactored to a single function, something like:
>   *
>   * void led_set_state(enum led_colour_t colour, int on);
> @@ -300,7 +300,7 @@ __weak ulong board_get_usable_ram_top(ulong total_size)
>  {
>  #ifdef CONFIG_SYS_SDRAM_BASE
>         /*
> -        * Detect whether we have so much RAM it goes past the end of our
> +        * Detect whether we have so much RAM that it goes past the end of our
>          * 32-bit address space. If so, clip the usable RAM so it doesn't.
>          */
>         if (gd->ram_top < CONFIG_SYS_SDRAM_BASE)
> @@ -507,7 +507,7 @@ static int reserve_global_data(void)
>  static int reserve_fdt(void)
>  {
>         /*
> -        * If the device tree is sitting immediate above our image then we
> +        * If the device tree is sitting immediately above our image then we
>          * must relocate it. If it is embedded in the data section, then it
>          * will be relocated with other data.
>          */
> @@ -535,7 +535,7 @@ static int reserve_stacks(void)
>         gd->start_addr_sp &= ~0xf;
>
>         /*
> -        * let the architecture specific code tailor gd->start_addr_sp and
> +        * let the architecture-specific code tailor gd->start_addr_sp and
>          * gd->irq_sp
>          */
>         return arch_reserve_stacks();
> @@ -556,7 +556,6 @@ static int setup_board_part1(void)
>         /*
>          * Save local variables to board info struct
>          */
> -
>         bd->bi_memstart = CONFIG_SYS_SDRAM_BASE;        /* start of memory */
>         bd->bi_memsize = gd->ram_size;                  /* size in bytes */
>
> --

Reviewed-by: Bin Meng <bmeng.cn@gmail.com>

  reply	other threads:[~2015-04-28  1:54 UTC|newest]

Thread overview: 36+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-04-27 22:48 [U-Boot] [PATCH 00/20] x86: Add CPU uclass and multi-core support for Minnowboard MAX Simon Glass
2015-04-27 22:48 ` [U-Boot] [PATCH 01/20] Fix comment nits in board_f.c Simon Glass
2015-04-28  1:54   ` Bin Meng [this message]
2015-04-27 22:48 ` [U-Boot] [PATCH 02/20] dm: core: Add a function to bind a driver for a device tree node Simon Glass
2015-04-27 22:48 ` [U-Boot] [PATCH 03/20] x86: Remove unwanted MMC debugging Simon Glass
2015-04-28  1:59   ` Bin Meng
2015-04-27 22:48 ` [U-Boot] [PATCH 04/20] x86: Disable -Werror Simon Glass
2015-04-28  1:59   ` Bin Meng
2015-04-27 22:48 ` [U-Boot] [PATCH 05/20] Move display_options functions to their own header Simon Glass
2015-04-28  2:10   ` Bin Meng
2015-04-27 22:48 ` [U-Boot] [PATCH 06/20] Add print_freq() to display frequencies nicely Simon Glass
2015-04-28  4:13   ` Bin Meng
2015-04-27 22:48 ` [U-Boot] [PATCH 07/20] x86: Add support for the Simple Firmware Interface (SFI) Simon Glass
2015-04-28  6:51   ` Bin Meng
2015-04-27 22:48 ` [U-Boot] [PATCH 08/20] dm: Implement a CPU uclass Simon Glass
2015-04-28  7:24   ` Bin Meng
2015-04-27 22:48 ` [U-Boot] [PATCH 09/20] Add a 'cpu' command to print CPU information Simon Glass
2015-04-28  7:34   ` Bin Meng
2015-04-27 22:48 ` [U-Boot] [PATCH 10/20] x86: Add atomic operations Simon Glass
2015-04-28  7:38   ` Bin Meng
2015-04-27 22:48 ` [U-Boot] [PATCH 11/20] x86: Add defines for fixed MTRRs Simon Glass
2015-04-28  7:45   ` Bin Meng
2015-04-27 22:48 ` [U-Boot] [PATCH 12/20] x86: Add an mfence macro Simon Glass
2015-04-28  7:48   ` Bin Meng
2015-04-27 22:48 ` [U-Boot] [PATCH 13/20] x86: Store the GDT pointer in global_data Simon Glass
2015-04-28  7:55   ` Bin Meng
2015-04-27 22:48 ` [U-Boot] [PATCH 14/20] x86: Provide access to the IDT Simon Glass
2015-04-28  8:16   ` Bin Meng
2015-04-29  2:08     ` Simon Glass
2015-04-29  5:23       ` Bin Meng
2015-04-27 22:48 ` [U-Boot] [PATCH 15/20] x86: Add multi-processor init Simon Glass
2015-04-27 22:48 ` [U-Boot] [PATCH 16/20] x86: Add functions to set and clear bits on MSRs Simon Glass
2015-04-27 22:48 ` [U-Boot] [PATCH 17/20] x86: Allow CPUs to be set up after relocation Simon Glass
2015-04-27 22:48 ` [U-Boot] [PATCH 18/20] x86: Add a CPU driver for baytrail Simon Glass
2015-04-27 22:48 ` [U-Boot] [PATCH 19/20] x86: Tidy up the LAPIC init code Simon Glass
2015-04-27 22:48 ` [U-Boot] [PATCH 20/20] x86: Enable multi-core init for Minnowboard MAX Simon Glass

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=CAEUhbmXPtWFOQ0uFdmzuXb0xxFHzgEqfBB3zxodnOFmsvY4UZw@mail.gmail.com \
    --to=bmeng.cn@gmail.com \
    --cc=u-boot@lists.denx.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.