All of lore.kernel.org
 help / color / mirror / Atom feed
* [U-Boot] [PATCH] drivers: hierarchize drivers Kconfig menu
@ 2015-07-25 17:46 Masahiro Yamada
  2015-07-27 12:33 ` Paul Kocialkowski
                   ` (3 more replies)
  0 siblings, 4 replies; 10+ messages in thread
From: Masahiro Yamada @ 2015-07-25 17:46 UTC (permalink / raw)
  To: u-boot

The menuconfig for drivers are getting more and more cluttered
and unreadable because too many entries are displayed in a single
flat menu.  Use hierarchic menu for each category.

Signed-off-by: Masahiro Yamada <yamada.masahiro@socionext.com>
---

 drivers/core/Kconfig   | 4 ++++
 drivers/crypto/Kconfig | 4 ++++
 drivers/demo/Kconfig   | 4 ++++
 drivers/gpio/Kconfig   | 8 ++++++++
 drivers/i2c/Kconfig    | 8 ++++++++
 drivers/led/Kconfig    | 4 ++++
 drivers/misc/Kconfig   | 8 ++++++++
 drivers/rtc/Kconfig    | 8 ++++++++
 drivers/serial/Kconfig | 8 ++++++++
 drivers/sound/Kconfig  | 4 ++++
 drivers/usb/Kconfig    | 8 ++++++++
 drivers/video/Kconfig  | 8 ++++++++
 12 files changed, 76 insertions(+)

diff --git a/drivers/core/Kconfig b/drivers/core/Kconfig
index e40372d..9cc888d 100644
--- a/drivers/core/Kconfig
+++ b/drivers/core/Kconfig
@@ -1,3 +1,5 @@
+menu "Generic Driver Options"
+
 config DM
 	bool "Enable Driver Model"
 	help
@@ -59,3 +61,5 @@ config DM_SEQ_ALIAS
 	  Most boards will have a '/aliases' node containing the path to
 	  numbered devices (e.g. serial0 = &serial0). This feature can be
 	  disabled if it is not required, to save code space in SPL.
+
+endmenu
diff --git a/drivers/crypto/Kconfig b/drivers/crypto/Kconfig
index bd26a2b..1ea116b 100644
--- a/drivers/crypto/Kconfig
+++ b/drivers/crypto/Kconfig
@@ -1 +1,5 @@
+menu "Hardware crypto devices"
+
 source drivers/crypto/fsl/Kconfig
+
+endmenu
diff --git a/drivers/demo/Kconfig b/drivers/demo/Kconfig
index 7a8ce18..98bb633 100644
--- a/drivers/demo/Kconfig
+++ b/drivers/demo/Kconfig
@@ -1,3 +1,5 @@
+menu "Demo for driver model"
+
 config DM_DEMO
 	bool "Enable demo uclass support"
 	depends on DM
@@ -24,3 +26,5 @@ config DM_DEMO_SHAPE
 	  a shape when the 'demo hello' command is executed which targets
 	  this device. It can be used to help understand how driver model
 	  works.
+
+endmenu
diff --git a/drivers/gpio/Kconfig b/drivers/gpio/Kconfig
index 0c43777..5934597 100644
--- a/drivers/gpio/Kconfig
+++ b/drivers/gpio/Kconfig
@@ -1,3 +1,9 @@
+#
+# GPIO infrastructure and drivers
+#
+
+menu "GPIO Support"
+
 config DM_GPIO
 	bool "Enable Driver Model for GPIO drivers"
 	depends on DM
@@ -42,3 +48,5 @@ config VYBRID_GPIO
 	default n
 	help
 	  Say yes here to support Vybrid vf610 GPIOs.
+
+endmenu
diff --git a/drivers/i2c/Kconfig b/drivers/i2c/Kconfig
index 86fb36b..b8b2250 100644
--- a/drivers/i2c/Kconfig
+++ b/drivers/i2c/Kconfig
@@ -1,3 +1,9 @@
+#
+# I2C subsystem configuration
+#
+
+menu "I2C support"
+
 config DM_I2C
 	bool "Enable Driver Model for I2C drivers"
 	depends on DM
@@ -73,3 +79,5 @@ config SYS_I2C_UNIPHIER_F
 	help
 	  Support for UniPhier FIFO-builtin I2C controller driver.
 	  This I2C controller is used on PH1-Pro4 or newer UniPhier SoCs.
+
+endmenu
diff --git a/drivers/led/Kconfig b/drivers/led/Kconfig
index de5feea..b21bc94 100644
--- a/drivers/led/Kconfig
+++ b/drivers/led/Kconfig
@@ -1,3 +1,5 @@
+menu "LED Support"
+
 config LED
 	bool "Enable LED support"
 	depends on DM
@@ -24,3 +26,5 @@ config LED_GPIO
 	  GPIOs may be on the SoC or some other device which provides GPIOs.
 	  The GPIO driver must used driver model. LEDs are configured using
 	  the device tree.
+
+endmenu
diff --git a/drivers/misc/Kconfig b/drivers/misc/Kconfig
index 3b7f76a..f29a169 100644
--- a/drivers/misc/Kconfig
+++ b/drivers/misc/Kconfig
@@ -1,3 +1,9 @@
+#
+# Multifunction miscellaneous devices
+#
+
+menu "Multifunction device drivers"
+
 config CMD_CROS_EC
 	bool "Enable crosec command"
 	depends on CROS_EC
@@ -82,3 +88,5 @@ config RESET
 	  Each driver can provide a reset method which will be called to
 	  effect a reset. The uclass will try all available drivers when
 	  reset_walk() is called.
+
+endmenu
diff --git a/drivers/rtc/Kconfig b/drivers/rtc/Kconfig
index bd63621..b5d9048 100644
--- a/drivers/rtc/Kconfig
+++ b/drivers/rtc/Kconfig
@@ -1,3 +1,9 @@
+#
+# RTC drivers configuration
+#
+
+menu "Real Time Clock"
+
 config DM_RTC
 	bool "Enable Driver Model for RTC drivers"
 	depends on DM
@@ -6,3 +12,5 @@ config DM_RTC
 	  then provides the rtc_get()/rtc_set() interface, delegating to
 	  drivers to perform the actual functions. See rtc.h for a
 	  description of the API.
+
+endmenu
diff --git a/drivers/serial/Kconfig b/drivers/serial/Kconfig
index 4829284..b87eb01 100644
--- a/drivers/serial/Kconfig
+++ b/drivers/serial/Kconfig
@@ -1,3 +1,9 @@
+#
+# Serial device configuration
+#
+
+menu "Serial drivers"
+
 config DM_SERIAL
 	bool "Enable Driver Model for serial drivers"
 	depends on DM
@@ -102,3 +108,5 @@ config UNIPHIER_SERIAL
 	help
 	  If you have a UniPhier based board and want to use the on-chip
 	  serial ports, say Y to this option. If unsure, say N.
+
+endmenu
diff --git a/drivers/sound/Kconfig b/drivers/sound/Kconfig
index 3b96e84..5de86c0 100644
--- a/drivers/sound/Kconfig
+++ b/drivers/sound/Kconfig
@@ -1,3 +1,5 @@
+menu "Sound support"
+
 config SOUND
 	bool "Enable sound support"
 	help
@@ -53,3 +55,5 @@ config SOUND_WM8994
 	  Enable the wm8994 audio codec. This is connected via I2S for
 	  audio data and I2C for codec control. At present it only works
 	  with the Samsung I2S driver.
+
+endmenu
diff --git a/drivers/usb/Kconfig b/drivers/usb/Kconfig
index 3fa5b2e..19b1b3d 100644
--- a/drivers/usb/Kconfig
+++ b/drivers/usb/Kconfig
@@ -1,3 +1,9 @@
+#
+# USB device configuration
+#
+
+menu "USB support"
+
 config USB_ARCH_HAS_HCD
 	def_bool y
 
@@ -60,3 +66,5 @@ config USB_STORAGE
 	  board's USB port.
 
 endif
+
+endmenu
diff --git a/drivers/video/Kconfig b/drivers/video/Kconfig
index 9ae23e8..892781d 100644
--- a/drivers/video/Kconfig
+++ b/drivers/video/Kconfig
@@ -1,3 +1,9 @@
+#
+# Video configuration
+#
+
+menu "Graphics support"
+
 config VIDEO_VESA
 	bool "Enable VESA video driver support"
 	default n
@@ -240,3 +246,5 @@ config VIDEO_TEGRA124
 	   HDMI. At present only eDP is supported by U-Boot. This option
 	   enables this support which can be used on devices which
 	   have an eDP display connected.
+
+endmenu
-- 
1.9.1

^ permalink raw reply related	[flat|nested] 10+ messages in thread

* [U-Boot] [PATCH] drivers: hierarchize drivers Kconfig menu
  2015-07-25 17:46 [U-Boot] [PATCH] drivers: hierarchize drivers Kconfig menu Masahiro Yamada
@ 2015-07-27 12:33 ` Paul Kocialkowski
  2015-08-01  9:08   ` Paul Kocialkowski
  2015-08-01 11:11 ` Bin Meng
                   ` (2 subsequent siblings)
  3 siblings, 1 reply; 10+ messages in thread
From: Paul Kocialkowski @ 2015-07-27 12:33 UTC (permalink / raw)
  To: u-boot

Hi,

Le dimanche 26 juillet 2015 ? 02:46 +0900, Masahiro Yamada a ?crit :
> The menuconfig for drivers are getting more and more cluttered
> and unreadable because too many entries are displayed in a single
> flat menu.  Use hierarchic menu for each category.

That looks like a valuable addition to me!

I had started dealing with the USB side of this in a series currently
under review. I'll drop the USB bits from my series and base the next
version on top of this patch.

Thanks!

> Signed-off-by: Masahiro Yamada <yamada.masahiro@socionext.com>
> ---
> 
>  drivers/core/Kconfig   | 4 ++++
>  drivers/crypto/Kconfig | 4 ++++
>  drivers/demo/Kconfig   | 4 ++++
>  drivers/gpio/Kconfig   | 8 ++++++++
>  drivers/i2c/Kconfig    | 8 ++++++++
>  drivers/led/Kconfig    | 4 ++++
>  drivers/misc/Kconfig   | 8 ++++++++
>  drivers/rtc/Kconfig    | 8 ++++++++
>  drivers/serial/Kconfig | 8 ++++++++
>  drivers/sound/Kconfig  | 4 ++++
>  drivers/usb/Kconfig    | 8 ++++++++
>  drivers/video/Kconfig  | 8 ++++++++
>  12 files changed, 76 insertions(+)
> 
> diff --git a/drivers/core/Kconfig b/drivers/core/Kconfig
> index e40372d..9cc888d 100644
> --- a/drivers/core/Kconfig
> +++ b/drivers/core/Kconfig
> @@ -1,3 +1,5 @@
> +menu "Generic Driver Options"
> +
>  config DM
>  	bool "Enable Driver Model"
>  	help
> @@ -59,3 +61,5 @@ config DM_SEQ_ALIAS
>  	  Most boards will have a '/aliases' node containing the path to
>  	  numbered devices (e.g. serial0 = &serial0). This feature can be
>  	  disabled if it is not required, to save code space in SPL.
> +
> +endmenu
> diff --git a/drivers/crypto/Kconfig b/drivers/crypto/Kconfig
> index bd26a2b..1ea116b 100644
> --- a/drivers/crypto/Kconfig
> +++ b/drivers/crypto/Kconfig
> @@ -1 +1,5 @@
> +menu "Hardware crypto devices"
> +
>  source drivers/crypto/fsl/Kconfig
> +
> +endmenu
> diff --git a/drivers/demo/Kconfig b/drivers/demo/Kconfig
> index 7a8ce18..98bb633 100644
> --- a/drivers/demo/Kconfig
> +++ b/drivers/demo/Kconfig
> @@ -1,3 +1,5 @@
> +menu "Demo for driver model"
> +
>  config DM_DEMO
>  	bool "Enable demo uclass support"
>  	depends on DM
> @@ -24,3 +26,5 @@ config DM_DEMO_SHAPE
>  	  a shape when the 'demo hello' command is executed which targets
>  	  this device. It can be used to help understand how driver model
>  	  works.
> +
> +endmenu
> diff --git a/drivers/gpio/Kconfig b/drivers/gpio/Kconfig
> index 0c43777..5934597 100644
> --- a/drivers/gpio/Kconfig
> +++ b/drivers/gpio/Kconfig
> @@ -1,3 +1,9 @@
> +#
> +# GPIO infrastructure and drivers
> +#
> +
> +menu "GPIO Support"
> +
>  config DM_GPIO
>  	bool "Enable Driver Model for GPIO drivers"
>  	depends on DM
> @@ -42,3 +48,5 @@ config VYBRID_GPIO
>  	default n
>  	help
>  	  Say yes here to support Vybrid vf610 GPIOs.
> +
> +endmenu
> diff --git a/drivers/i2c/Kconfig b/drivers/i2c/Kconfig
> index 86fb36b..b8b2250 100644
> --- a/drivers/i2c/Kconfig
> +++ b/drivers/i2c/Kconfig
> @@ -1,3 +1,9 @@
> +#
> +# I2C subsystem configuration
> +#
> +
> +menu "I2C support"
> +
>  config DM_I2C
>  	bool "Enable Driver Model for I2C drivers"
>  	depends on DM
> @@ -73,3 +79,5 @@ config SYS_I2C_UNIPHIER_F
>  	help
>  	  Support for UniPhier FIFO-builtin I2C controller driver.
>  	  This I2C controller is used on PH1-Pro4 or newer UniPhier SoCs.
> +
> +endmenu
> diff --git a/drivers/led/Kconfig b/drivers/led/Kconfig
> index de5feea..b21bc94 100644
> --- a/drivers/led/Kconfig
> +++ b/drivers/led/Kconfig
> @@ -1,3 +1,5 @@
> +menu "LED Support"
> +
>  config LED
>  	bool "Enable LED support"
>  	depends on DM
> @@ -24,3 +26,5 @@ config LED_GPIO
>  	  GPIOs may be on the SoC or some other device which provides GPIOs.
>  	  The GPIO driver must used driver model. LEDs are configured using
>  	  the device tree.
> +
> +endmenu
> diff --git a/drivers/misc/Kconfig b/drivers/misc/Kconfig
> index 3b7f76a..f29a169 100644
> --- a/drivers/misc/Kconfig
> +++ b/drivers/misc/Kconfig
> @@ -1,3 +1,9 @@
> +#
> +# Multifunction miscellaneous devices
> +#
> +
> +menu "Multifunction device drivers"
> +
>  config CMD_CROS_EC
>  	bool "Enable crosec command"
>  	depends on CROS_EC
> @@ -82,3 +88,5 @@ config RESET
>  	  Each driver can provide a reset method which will be called to
>  	  effect a reset. The uclass will try all available drivers when
>  	  reset_walk() is called.
> +
> +endmenu
> diff --git a/drivers/rtc/Kconfig b/drivers/rtc/Kconfig
> index bd63621..b5d9048 100644
> --- a/drivers/rtc/Kconfig
> +++ b/drivers/rtc/Kconfig
> @@ -1,3 +1,9 @@
> +#
> +# RTC drivers configuration
> +#
> +
> +menu "Real Time Clock"
> +
>  config DM_RTC
>  	bool "Enable Driver Model for RTC drivers"
>  	depends on DM
> @@ -6,3 +12,5 @@ config DM_RTC
>  	  then provides the rtc_get()/rtc_set() interface, delegating to
>  	  drivers to perform the actual functions. See rtc.h for a
>  	  description of the API.
> +
> +endmenu
> diff --git a/drivers/serial/Kconfig b/drivers/serial/Kconfig
> index 4829284..b87eb01 100644
> --- a/drivers/serial/Kconfig
> +++ b/drivers/serial/Kconfig
> @@ -1,3 +1,9 @@
> +#
> +# Serial device configuration
> +#
> +
> +menu "Serial drivers"
> +
>  config DM_SERIAL
>  	bool "Enable Driver Model for serial drivers"
>  	depends on DM
> @@ -102,3 +108,5 @@ config UNIPHIER_SERIAL
>  	help
>  	  If you have a UniPhier based board and want to use the on-chip
>  	  serial ports, say Y to this option. If unsure, say N.
> +
> +endmenu
> diff --git a/drivers/sound/Kconfig b/drivers/sound/Kconfig
> index 3b96e84..5de86c0 100644
> --- a/drivers/sound/Kconfig
> +++ b/drivers/sound/Kconfig
> @@ -1,3 +1,5 @@
> +menu "Sound support"
> +
>  config SOUND
>  	bool "Enable sound support"
>  	help
> @@ -53,3 +55,5 @@ config SOUND_WM8994
>  	  Enable the wm8994 audio codec. This is connected via I2S for
>  	  audio data and I2C for codec control. At present it only works
>  	  with the Samsung I2S driver.
> +
> +endmenu
> diff --git a/drivers/usb/Kconfig b/drivers/usb/Kconfig
> index 3fa5b2e..19b1b3d 100644
> --- a/drivers/usb/Kconfig
> +++ b/drivers/usb/Kconfig
> @@ -1,3 +1,9 @@
> +#
> +# USB device configuration
> +#
> +
> +menu "USB support"
> +
>  config USB_ARCH_HAS_HCD
>  	def_bool y
>  
> @@ -60,3 +66,5 @@ config USB_STORAGE
>  	  board's USB port.
>  
>  endif
> +
> +endmenu
> diff --git a/drivers/video/Kconfig b/drivers/video/Kconfig
> index 9ae23e8..892781d 100644
> --- a/drivers/video/Kconfig
> +++ b/drivers/video/Kconfig
> @@ -1,3 +1,9 @@
> +#
> +# Video configuration
> +#
> +
> +menu "Graphics support"
> +
>  config VIDEO_VESA
>  	bool "Enable VESA video driver support"
>  	default n
> @@ -240,3 +246,5 @@ config VIDEO_TEGRA124
>  	   HDMI. At present only eDP is supported by U-Boot. This option
>  	   enables this support which can be used on devices which
>  	   have an eDP display connected.
> +
> +endmenu

-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 819 bytes
Desc: This is a digitally signed message part
URL: <http://lists.denx.de/pipermail/u-boot/attachments/20150727/65ff3357/attachment.sig>

^ permalink raw reply	[flat|nested] 10+ messages in thread

* [U-Boot] [PATCH] drivers: hierarchize drivers Kconfig menu
  2015-07-27 12:33 ` Paul Kocialkowski
@ 2015-08-01  9:08   ` Paul Kocialkowski
  2015-08-01 15:18     ` Marek Vasut
  0 siblings, 1 reply; 10+ messages in thread
From: Paul Kocialkowski @ 2015-08-01  9:08 UTC (permalink / raw)
  To: u-boot

Hi, 

Le lundi 27 juillet 2015 ? 14:33 +0200, Paul Kocialkowski a ?crit :
> Le dimanche 26 juillet 2015 ? 02:46 +0900, Masahiro Yamada a ?crit :
> > The menuconfig for drivers are getting more and more cluttered
> > and unreadable because too many entries are displayed in a single
> > flat menu.  Use hierarchic menu for each category.
> 
> That looks like a valuable addition to me!

This patch was submitted a week ago and I need it for merging another
series of mine, that was already accepted.

Is there anything preventing this patch from being merged at this point?

Thanks!

> I had started dealing with the USB side of this in a series currently
> under review. I'll drop the USB bits from my series and base the next
> version on top of this patch.
> 
> Thanks!
> 
> > Signed-off-by: Masahiro Yamada <yamada.masahiro@socionext.com>
> > ---
> > 
> >  drivers/core/Kconfig   | 4 ++++
> >  drivers/crypto/Kconfig | 4 ++++
> >  drivers/demo/Kconfig   | 4 ++++
> >  drivers/gpio/Kconfig   | 8 ++++++++
> >  drivers/i2c/Kconfig    | 8 ++++++++
> >  drivers/led/Kconfig    | 4 ++++
> >  drivers/misc/Kconfig   | 8 ++++++++
> >  drivers/rtc/Kconfig    | 8 ++++++++
> >  drivers/serial/Kconfig | 8 ++++++++
> >  drivers/sound/Kconfig  | 4 ++++
> >  drivers/usb/Kconfig    | 8 ++++++++
> >  drivers/video/Kconfig  | 8 ++++++++
> >  12 files changed, 76 insertions(+)
> > 
> > diff --git a/drivers/core/Kconfig b/drivers/core/Kconfig
> > index e40372d..9cc888d 100644
> > --- a/drivers/core/Kconfig
> > +++ b/drivers/core/Kconfig
> > @@ -1,3 +1,5 @@
> > +menu "Generic Driver Options"
> > +
> >  config DM
> >  	bool "Enable Driver Model"
> >  	help
> > @@ -59,3 +61,5 @@ config DM_SEQ_ALIAS
> >  	  Most boards will have a '/aliases' node containing the path to
> >  	  numbered devices (e.g. serial0 = &serial0). This feature can be
> >  	  disabled if it is not required, to save code space in SPL.
> > +
> > +endmenu
> > diff --git a/drivers/crypto/Kconfig b/drivers/crypto/Kconfig
> > index bd26a2b..1ea116b 100644
> > --- a/drivers/crypto/Kconfig
> > +++ b/drivers/crypto/Kconfig
> > @@ -1 +1,5 @@
> > +menu "Hardware crypto devices"
> > +
> >  source drivers/crypto/fsl/Kconfig
> > +
> > +endmenu
> > diff --git a/drivers/demo/Kconfig b/drivers/demo/Kconfig
> > index 7a8ce18..98bb633 100644
> > --- a/drivers/demo/Kconfig
> > +++ b/drivers/demo/Kconfig
> > @@ -1,3 +1,5 @@
> > +menu "Demo for driver model"
> > +
> >  config DM_DEMO
> >  	bool "Enable demo uclass support"
> >  	depends on DM
> > @@ -24,3 +26,5 @@ config DM_DEMO_SHAPE
> >  	  a shape when the 'demo hello' command is executed which targets
> >  	  this device. It can be used to help understand how driver model
> >  	  works.
> > +
> > +endmenu
> > diff --git a/drivers/gpio/Kconfig b/drivers/gpio/Kconfig
> > index 0c43777..5934597 100644
> > --- a/drivers/gpio/Kconfig
> > +++ b/drivers/gpio/Kconfig
> > @@ -1,3 +1,9 @@
> > +#
> > +# GPIO infrastructure and drivers
> > +#
> > +
> > +menu "GPIO Support"
> > +
> >  config DM_GPIO
> >  	bool "Enable Driver Model for GPIO drivers"
> >  	depends on DM
> > @@ -42,3 +48,5 @@ config VYBRID_GPIO
> >  	default n
> >  	help
> >  	  Say yes here to support Vybrid vf610 GPIOs.
> > +
> > +endmenu
> > diff --git a/drivers/i2c/Kconfig b/drivers/i2c/Kconfig
> > index 86fb36b..b8b2250 100644
> > --- a/drivers/i2c/Kconfig
> > +++ b/drivers/i2c/Kconfig
> > @@ -1,3 +1,9 @@
> > +#
> > +# I2C subsystem configuration
> > +#
> > +
> > +menu "I2C support"
> > +
> >  config DM_I2C
> >  	bool "Enable Driver Model for I2C drivers"
> >  	depends on DM
> > @@ -73,3 +79,5 @@ config SYS_I2C_UNIPHIER_F
> >  	help
> >  	  Support for UniPhier FIFO-builtin I2C controller driver.
> >  	  This I2C controller is used on PH1-Pro4 or newer UniPhier SoCs.
> > +
> > +endmenu
> > diff --git a/drivers/led/Kconfig b/drivers/led/Kconfig
> > index de5feea..b21bc94 100644
> > --- a/drivers/led/Kconfig
> > +++ b/drivers/led/Kconfig
> > @@ -1,3 +1,5 @@
> > +menu "LED Support"
> > +
> >  config LED
> >  	bool "Enable LED support"
> >  	depends on DM
> > @@ -24,3 +26,5 @@ config LED_GPIO
> >  	  GPIOs may be on the SoC or some other device which provides GPIOs.
> >  	  The GPIO driver must used driver model. LEDs are configured using
> >  	  the device tree.
> > +
> > +endmenu
> > diff --git a/drivers/misc/Kconfig b/drivers/misc/Kconfig
> > index 3b7f76a..f29a169 100644
> > --- a/drivers/misc/Kconfig
> > +++ b/drivers/misc/Kconfig
> > @@ -1,3 +1,9 @@
> > +#
> > +# Multifunction miscellaneous devices
> > +#
> > +
> > +menu "Multifunction device drivers"
> > +
> >  config CMD_CROS_EC
> >  	bool "Enable crosec command"
> >  	depends on CROS_EC
> > @@ -82,3 +88,5 @@ config RESET
> >  	  Each driver can provide a reset method which will be called to
> >  	  effect a reset. The uclass will try all available drivers when
> >  	  reset_walk() is called.
> > +
> > +endmenu
> > diff --git a/drivers/rtc/Kconfig b/drivers/rtc/Kconfig
> > index bd63621..b5d9048 100644
> > --- a/drivers/rtc/Kconfig
> > +++ b/drivers/rtc/Kconfig
> > @@ -1,3 +1,9 @@
> > +#
> > +# RTC drivers configuration
> > +#
> > +
> > +menu "Real Time Clock"
> > +
> >  config DM_RTC
> >  	bool "Enable Driver Model for RTC drivers"
> >  	depends on DM
> > @@ -6,3 +12,5 @@ config DM_RTC
> >  	  then provides the rtc_get()/rtc_set() interface, delegating to
> >  	  drivers to perform the actual functions. See rtc.h for a
> >  	  description of the API.
> > +
> > +endmenu
> > diff --git a/drivers/serial/Kconfig b/drivers/serial/Kconfig
> > index 4829284..b87eb01 100644
> > --- a/drivers/serial/Kconfig
> > +++ b/drivers/serial/Kconfig
> > @@ -1,3 +1,9 @@
> > +#
> > +# Serial device configuration
> > +#
> > +
> > +menu "Serial drivers"
> > +
> >  config DM_SERIAL
> >  	bool "Enable Driver Model for serial drivers"
> >  	depends on DM
> > @@ -102,3 +108,5 @@ config UNIPHIER_SERIAL
> >  	help
> >  	  If you have a UniPhier based board and want to use the on-chip
> >  	  serial ports, say Y to this option. If unsure, say N.
> > +
> > +endmenu
> > diff --git a/drivers/sound/Kconfig b/drivers/sound/Kconfig
> > index 3b96e84..5de86c0 100644
> > --- a/drivers/sound/Kconfig
> > +++ b/drivers/sound/Kconfig
> > @@ -1,3 +1,5 @@
> > +menu "Sound support"
> > +
> >  config SOUND
> >  	bool "Enable sound support"
> >  	help
> > @@ -53,3 +55,5 @@ config SOUND_WM8994
> >  	  Enable the wm8994 audio codec. This is connected via I2S for
> >  	  audio data and I2C for codec control. At present it only works
> >  	  with the Samsung I2S driver.
> > +
> > +endmenu
> > diff --git a/drivers/usb/Kconfig b/drivers/usb/Kconfig
> > index 3fa5b2e..19b1b3d 100644
> > --- a/drivers/usb/Kconfig
> > +++ b/drivers/usb/Kconfig
> > @@ -1,3 +1,9 @@
> > +#
> > +# USB device configuration
> > +#
> > +
> > +menu "USB support"
> > +
> >  config USB_ARCH_HAS_HCD
> >  	def_bool y
> >  
> > @@ -60,3 +66,5 @@ config USB_STORAGE
> >  	  board's USB port.
> >  
> >  endif
> > +
> > +endmenu
> > diff --git a/drivers/video/Kconfig b/drivers/video/Kconfig
> > index 9ae23e8..892781d 100644
> > --- a/drivers/video/Kconfig
> > +++ b/drivers/video/Kconfig
> > @@ -1,3 +1,9 @@
> > +#
> > +# Video configuration
> > +#
> > +
> > +menu "Graphics support"
> > +
> >  config VIDEO_VESA
> >  	bool "Enable VESA video driver support"
> >  	default n
> > @@ -240,3 +246,5 @@ config VIDEO_TEGRA124
> >  	   HDMI. At present only eDP is supported by U-Boot. This option
> >  	   enables this support which can be used on devices which
> >  	   have an eDP display connected.
> > +
> > +endmenu
> 
> _______________________________________________
> U-Boot mailing list
> U-Boot at lists.denx.de
> http://lists.denx.de/mailman/listinfo/u-boot

-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 819 bytes
Desc: This is a digitally signed message part
URL: <http://lists.denx.de/pipermail/u-boot/attachments/20150801/694ee1bc/attachment.sig>

^ permalink raw reply	[flat|nested] 10+ messages in thread

* [U-Boot] [PATCH] drivers: hierarchize drivers Kconfig menu
  2015-07-25 17:46 [U-Boot] [PATCH] drivers: hierarchize drivers Kconfig menu Masahiro Yamada
  2015-07-27 12:33 ` Paul Kocialkowski
@ 2015-08-01 11:11 ` Bin Meng
  2015-08-01 13:27   ` Masahiro Yamada
  2015-08-02 21:21 ` Simon Glass
  2015-08-13 13:19 ` [U-Boot] " Tom Rini
  3 siblings, 1 reply; 10+ messages in thread
From: Bin Meng @ 2015-08-01 11:11 UTC (permalink / raw)
  To: u-boot

Hi Masahiro,

On Sun, Jul 26, 2015 at 1:46 AM, Masahiro Yamada
<yamada.masahiro@socionext.com> wrote:
> The menuconfig for drivers are getting more and more cluttered
> and unreadable because too many entries are displayed in a single
> flat menu.  Use hierarchic menu for each category.
>
> Signed-off-by: Masahiro Yamada <yamada.masahiro@socionext.com>
> ---
>
>  drivers/core/Kconfig   | 4 ++++
>  drivers/crypto/Kconfig | 4 ++++
>  drivers/demo/Kconfig   | 4 ++++
>  drivers/gpio/Kconfig   | 8 ++++++++
>  drivers/i2c/Kconfig    | 8 ++++++++
>  drivers/led/Kconfig    | 4 ++++
>  drivers/misc/Kconfig   | 8 ++++++++
>  drivers/rtc/Kconfig    | 8 ++++++++
>  drivers/serial/Kconfig | 8 ++++++++
>  drivers/sound/Kconfig  | 4 ++++
>  drivers/usb/Kconfig    | 8 ++++++++
>  drivers/video/Kconfig  | 8 ++++++++
>  12 files changed, 76 insertions(+)
>
> diff --git a/drivers/core/Kconfig b/drivers/core/Kconfig
> index e40372d..9cc888d 100644
> --- a/drivers/core/Kconfig
> +++ b/drivers/core/Kconfig
> @@ -1,3 +1,5 @@
> +menu "Generic Driver Options"
> +
>  config DM
>         bool "Enable Driver Model"
>         help
> @@ -59,3 +61,5 @@ config DM_SEQ_ALIAS
>           Most boards will have a '/aliases' node containing the path to
>           numbered devices (e.g. serial0 = &serial0). This feature can be
>           disabled if it is not required, to save code space in SPL.
> +
> +endmenu
> diff --git a/drivers/crypto/Kconfig b/drivers/crypto/Kconfig
> index bd26a2b..1ea116b 100644
> --- a/drivers/crypto/Kconfig
> +++ b/drivers/crypto/Kconfig
> @@ -1 +1,5 @@
> +menu "Hardware crypto devices"
> +
>  source drivers/crypto/fsl/Kconfig
> +
> +endmenu
> diff --git a/drivers/demo/Kconfig b/drivers/demo/Kconfig
> index 7a8ce18..98bb633 100644
> --- a/drivers/demo/Kconfig
> +++ b/drivers/demo/Kconfig
> @@ -1,3 +1,5 @@
> +menu "Demo for driver model"
> +
>  config DM_DEMO
>         bool "Enable demo uclass support"
>         depends on DM
> @@ -24,3 +26,5 @@ config DM_DEMO_SHAPE
>           a shape when the 'demo hello' command is executed which targets
>           this device. It can be used to help understand how driver model
>           works.
> +
> +endmenu
> diff --git a/drivers/gpio/Kconfig b/drivers/gpio/Kconfig
> index 0c43777..5934597 100644
> --- a/drivers/gpio/Kconfig
> +++ b/drivers/gpio/Kconfig
> @@ -1,3 +1,9 @@
> +#
> +# GPIO infrastructure and drivers
> +#
> +
> +menu "GPIO Support"
> +
>  config DM_GPIO
>         bool "Enable Driver Model for GPIO drivers"
>         depends on DM
> @@ -42,3 +48,5 @@ config VYBRID_GPIO
>         default n
>         help
>           Say yes here to support Vybrid vf610 GPIOs.
> +
> +endmenu
> diff --git a/drivers/i2c/Kconfig b/drivers/i2c/Kconfig
> index 86fb36b..b8b2250 100644
> --- a/drivers/i2c/Kconfig
> +++ b/drivers/i2c/Kconfig
> @@ -1,3 +1,9 @@
> +#
> +# I2C subsystem configuration
> +#
> +
> +menu "I2C support"
> +
>  config DM_I2C
>         bool "Enable Driver Model for I2C drivers"
>         depends on DM
> @@ -73,3 +79,5 @@ config SYS_I2C_UNIPHIER_F
>         help
>           Support for UniPhier FIFO-builtin I2C controller driver.
>           This I2C controller is used on PH1-Pro4 or newer UniPhier SoCs.
> +
> +endmenu
> diff --git a/drivers/led/Kconfig b/drivers/led/Kconfig
> index de5feea..b21bc94 100644
> --- a/drivers/led/Kconfig
> +++ b/drivers/led/Kconfig
> @@ -1,3 +1,5 @@
> +menu "LED Support"
> +
>  config LED
>         bool "Enable LED support"
>         depends on DM
> @@ -24,3 +26,5 @@ config LED_GPIO
>           GPIOs may be on the SoC or some other device which provides GPIOs.
>           The GPIO driver must used driver model. LEDs are configured using
>           the device tree.
> +
> +endmenu
> diff --git a/drivers/misc/Kconfig b/drivers/misc/Kconfig
> index 3b7f76a..f29a169 100644
> --- a/drivers/misc/Kconfig
> +++ b/drivers/misc/Kconfig
> @@ -1,3 +1,9 @@
> +#
> +# Multifunction miscellaneous devices
> +#
> +
> +menu "Multifunction device drivers"
> +
>  config CMD_CROS_EC
>         bool "Enable crosec command"
>         depends on CROS_EC
> @@ -82,3 +88,5 @@ config RESET
>           Each driver can provide a reset method which will be called to
>           effect a reset. The uclass will try all available drivers when
>           reset_walk() is called.
> +
> +endmenu
> diff --git a/drivers/rtc/Kconfig b/drivers/rtc/Kconfig
> index bd63621..b5d9048 100644
> --- a/drivers/rtc/Kconfig
> +++ b/drivers/rtc/Kconfig
> @@ -1,3 +1,9 @@
> +#
> +# RTC drivers configuration
> +#
> +
> +menu "Real Time Clock"
> +
>  config DM_RTC
>         bool "Enable Driver Model for RTC drivers"
>         depends on DM
> @@ -6,3 +12,5 @@ config DM_RTC
>           then provides the rtc_get()/rtc_set() interface, delegating to
>           drivers to perform the actual functions. See rtc.h for a
>           description of the API.
> +
> +endmenu
> diff --git a/drivers/serial/Kconfig b/drivers/serial/Kconfig
> index 4829284..b87eb01 100644
> --- a/drivers/serial/Kconfig
> +++ b/drivers/serial/Kconfig
> @@ -1,3 +1,9 @@
> +#
> +# Serial device configuration
> +#
> +
> +menu "Serial drivers"
> +
>  config DM_SERIAL
>         bool "Enable Driver Model for serial drivers"
>         depends on DM
> @@ -102,3 +108,5 @@ config UNIPHIER_SERIAL
>         help
>           If you have a UniPhier based board and want to use the on-chip
>           serial ports, say Y to this option. If unsure, say N.
> +
> +endmenu
> diff --git a/drivers/sound/Kconfig b/drivers/sound/Kconfig
> index 3b96e84..5de86c0 100644
> --- a/drivers/sound/Kconfig
> +++ b/drivers/sound/Kconfig
> @@ -1,3 +1,5 @@
> +menu "Sound support"
> +
>  config SOUND
>         bool "Enable sound support"
>         help
> @@ -53,3 +55,5 @@ config SOUND_WM8994
>           Enable the wm8994 audio codec. This is connected via I2S for
>           audio data and I2C for codec control. At present it only works
>           with the Samsung I2S driver.
> +
> +endmenu
> diff --git a/drivers/usb/Kconfig b/drivers/usb/Kconfig
> index 3fa5b2e..19b1b3d 100644
> --- a/drivers/usb/Kconfig
> +++ b/drivers/usb/Kconfig
> @@ -1,3 +1,9 @@
> +#
> +# USB device configuration
> +#
> +
> +menu "USB support"
> +
>  config USB_ARCH_HAS_HCD
>         def_bool y
>
> @@ -60,3 +66,5 @@ config USB_STORAGE
>           board's USB port.
>
>  endif
> +
> +endmenu
> diff --git a/drivers/video/Kconfig b/drivers/video/Kconfig
> index 9ae23e8..892781d 100644
> --- a/drivers/video/Kconfig
> +++ b/drivers/video/Kconfig
> @@ -1,3 +1,9 @@
> +#
> +# Video configuration
> +#
> +
> +menu "Graphics support"
> +
>  config VIDEO_VESA
>         bool "Enable VESA video driver support"
>         default n
> @@ -240,3 +246,5 @@ config VIDEO_TEGRA124
>            HDMI. At present only eDP is supported by U-Boot. This option
>            enables this support which can be used on devices which
>            have an eDP display connected.
> +
> +endmenu
> --

With this patch, there are still single entries under Device Drivers
main menu like:

[] Enable clock driver support
[] Enable CPU drivers using Driver Model
[] Enable Driver Model for Ethernet drivers
[] Network device support  ----
[] Enable Chrome OS EC keyboard support
[] Enable sandbox TPM driver
[] Enable RAM drivers using Driver Model
[] Driver support for thermal devices

Can we make those into sub-menus as well?

Regards,
Bin

^ permalink raw reply	[flat|nested] 10+ messages in thread

* [U-Boot] [PATCH] drivers: hierarchize drivers Kconfig menu
  2015-08-01 11:11 ` Bin Meng
@ 2015-08-01 13:27   ` Masahiro Yamada
  2015-08-01 14:09     ` Bin Meng
  0 siblings, 1 reply; 10+ messages in thread
From: Masahiro Yamada @ 2015-08-01 13:27 UTC (permalink / raw)
  To: u-boot

Hi Bin,


Looks like I missed some items..
Anyway, they do not have many drivers below them,
so menuconfig is not so messy.


Do you want me send v2,
or will you send a follow-up patch?



2015-08-01 20:11 GMT+09:00 Bin Meng <bmeng.cn@gmail.com>:
> Hi Masahiro,
>
> On Sun, Jul 26, 2015 at 1:46 AM, Masahiro Yamada
> <yamada.masahiro@socionext.com> wrote:
>> The menuconfig for drivers are getting more and more cluttered
>> and unreadable because too many entries are displayed in a single
>> flat menu.  Use hierarchic menu for each category.
>>
>> Signed-off-by: Masahiro Yamada <yamada.masahiro@socionext.com>
>> ---
>>
>>  drivers/core/Kconfig   | 4 ++++
>>  drivers/crypto/Kconfig | 4 ++++
>>  drivers/demo/Kconfig   | 4 ++++
>>  drivers/gpio/Kconfig   | 8 ++++++++
>>  drivers/i2c/Kconfig    | 8 ++++++++
>>  drivers/led/Kconfig    | 4 ++++
>>  drivers/misc/Kconfig   | 8 ++++++++
>>  drivers/rtc/Kconfig    | 8 ++++++++
>>  drivers/serial/Kconfig | 8 ++++++++
>>  drivers/sound/Kconfig  | 4 ++++
>>  drivers/usb/Kconfig    | 8 ++++++++
>>  drivers/video/Kconfig  | 8 ++++++++
>>  12 files changed, 76 insertions(+)
>>
>> diff --git a/drivers/core/Kconfig b/drivers/core/Kconfig
>> index e40372d..9cc888d 100644
>> --- a/drivers/core/Kconfig
>> +++ b/drivers/core/Kconfig
>> @@ -1,3 +1,5 @@
>> +menu "Generic Driver Options"
>> +
>>  config DM
>>         bool "Enable Driver Model"
>>         help
>> @@ -59,3 +61,5 @@ config DM_SEQ_ALIAS
>>           Most boards will have a '/aliases' node containing the path to
>>           numbered devices (e.g. serial0 = &serial0). This feature can be
>>           disabled if it is not required, to save code space in SPL.
>> +
>> +endmenu
>> diff --git a/drivers/crypto/Kconfig b/drivers/crypto/Kconfig
>> index bd26a2b..1ea116b 100644
>> --- a/drivers/crypto/Kconfig
>> +++ b/drivers/crypto/Kconfig
>> @@ -1 +1,5 @@
>> +menu "Hardware crypto devices"
>> +
>>  source drivers/crypto/fsl/Kconfig
>> +
>> +endmenu
>> diff --git a/drivers/demo/Kconfig b/drivers/demo/Kconfig
>> index 7a8ce18..98bb633 100644
>> --- a/drivers/demo/Kconfig
>> +++ b/drivers/demo/Kconfig
>> @@ -1,3 +1,5 @@
>> +menu "Demo for driver model"
>> +
>>  config DM_DEMO
>>         bool "Enable demo uclass support"
>>         depends on DM
>> @@ -24,3 +26,5 @@ config DM_DEMO_SHAPE
>>           a shape when the 'demo hello' command is executed which targets
>>           this device. It can be used to help understand how driver model
>>           works.
>> +
>> +endmenu
>> diff --git a/drivers/gpio/Kconfig b/drivers/gpio/Kconfig
>> index 0c43777..5934597 100644
>> --- a/drivers/gpio/Kconfig
>> +++ b/drivers/gpio/Kconfig
>> @@ -1,3 +1,9 @@
>> +#
>> +# GPIO infrastructure and drivers
>> +#
>> +
>> +menu "GPIO Support"
>> +
>>  config DM_GPIO
>>         bool "Enable Driver Model for GPIO drivers"
>>         depends on DM
>> @@ -42,3 +48,5 @@ config VYBRID_GPIO
>>         default n
>>         help
>>           Say yes here to support Vybrid vf610 GPIOs.
>> +
>> +endmenu
>> diff --git a/drivers/i2c/Kconfig b/drivers/i2c/Kconfig
>> index 86fb36b..b8b2250 100644
>> --- a/drivers/i2c/Kconfig
>> +++ b/drivers/i2c/Kconfig
>> @@ -1,3 +1,9 @@
>> +#
>> +# I2C subsystem configuration
>> +#
>> +
>> +menu "I2C support"
>> +
>>  config DM_I2C
>>         bool "Enable Driver Model for I2C drivers"
>>         depends on DM
>> @@ -73,3 +79,5 @@ config SYS_I2C_UNIPHIER_F
>>         help
>>           Support for UniPhier FIFO-builtin I2C controller driver.
>>           This I2C controller is used on PH1-Pro4 or newer UniPhier SoCs.
>> +
>> +endmenu
>> diff --git a/drivers/led/Kconfig b/drivers/led/Kconfig
>> index de5feea..b21bc94 100644
>> --- a/drivers/led/Kconfig
>> +++ b/drivers/led/Kconfig
>> @@ -1,3 +1,5 @@
>> +menu "LED Support"
>> +
>>  config LED
>>         bool "Enable LED support"
>>         depends on DM
>> @@ -24,3 +26,5 @@ config LED_GPIO
>>           GPIOs may be on the SoC or some other device which provides GPIOs.
>>           The GPIO driver must used driver model. LEDs are configured using
>>           the device tree.
>> +
>> +endmenu
>> diff --git a/drivers/misc/Kconfig b/drivers/misc/Kconfig
>> index 3b7f76a..f29a169 100644
>> --- a/drivers/misc/Kconfig
>> +++ b/drivers/misc/Kconfig
>> @@ -1,3 +1,9 @@
>> +#
>> +# Multifunction miscellaneous devices
>> +#
>> +
>> +menu "Multifunction device drivers"
>> +
>>  config CMD_CROS_EC
>>         bool "Enable crosec command"
>>         depends on CROS_EC
>> @@ -82,3 +88,5 @@ config RESET
>>           Each driver can provide a reset method which will be called to
>>           effect a reset. The uclass will try all available drivers when
>>           reset_walk() is called.
>> +
>> +endmenu
>> diff --git a/drivers/rtc/Kconfig b/drivers/rtc/Kconfig
>> index bd63621..b5d9048 100644
>> --- a/drivers/rtc/Kconfig
>> +++ b/drivers/rtc/Kconfig
>> @@ -1,3 +1,9 @@
>> +#
>> +# RTC drivers configuration
>> +#
>> +
>> +menu "Real Time Clock"
>> +
>>  config DM_RTC
>>         bool "Enable Driver Model for RTC drivers"
>>         depends on DM
>> @@ -6,3 +12,5 @@ config DM_RTC
>>           then provides the rtc_get()/rtc_set() interface, delegating to
>>           drivers to perform the actual functions. See rtc.h for a
>>           description of the API.
>> +
>> +endmenu
>> diff --git a/drivers/serial/Kconfig b/drivers/serial/Kconfig
>> index 4829284..b87eb01 100644
>> --- a/drivers/serial/Kconfig
>> +++ b/drivers/serial/Kconfig
>> @@ -1,3 +1,9 @@
>> +#
>> +# Serial device configuration
>> +#
>> +
>> +menu "Serial drivers"
>> +
>>  config DM_SERIAL
>>         bool "Enable Driver Model for serial drivers"
>>         depends on DM
>> @@ -102,3 +108,5 @@ config UNIPHIER_SERIAL
>>         help
>>           If you have a UniPhier based board and want to use the on-chip
>>           serial ports, say Y to this option. If unsure, say N.
>> +
>> +endmenu
>> diff --git a/drivers/sound/Kconfig b/drivers/sound/Kconfig
>> index 3b96e84..5de86c0 100644
>> --- a/drivers/sound/Kconfig
>> +++ b/drivers/sound/Kconfig
>> @@ -1,3 +1,5 @@
>> +menu "Sound support"
>> +
>>  config SOUND
>>         bool "Enable sound support"
>>         help
>> @@ -53,3 +55,5 @@ config SOUND_WM8994
>>           Enable the wm8994 audio codec. This is connected via I2S for
>>           audio data and I2C for codec control. At present it only works
>>           with the Samsung I2S driver.
>> +
>> +endmenu
>> diff --git a/drivers/usb/Kconfig b/drivers/usb/Kconfig
>> index 3fa5b2e..19b1b3d 100644
>> --- a/drivers/usb/Kconfig
>> +++ b/drivers/usb/Kconfig
>> @@ -1,3 +1,9 @@
>> +#
>> +# USB device configuration
>> +#
>> +
>> +menu "USB support"
>> +
>>  config USB_ARCH_HAS_HCD
>>         def_bool y
>>
>> @@ -60,3 +66,5 @@ config USB_STORAGE
>>           board's USB port.
>>
>>  endif
>> +
>> +endmenu
>> diff --git a/drivers/video/Kconfig b/drivers/video/Kconfig
>> index 9ae23e8..892781d 100644
>> --- a/drivers/video/Kconfig
>> +++ b/drivers/video/Kconfig
>> @@ -1,3 +1,9 @@
>> +#
>> +# Video configuration
>> +#
>> +
>> +menu "Graphics support"
>> +
>>  config VIDEO_VESA
>>         bool "Enable VESA video driver support"
>>         default n
>> @@ -240,3 +246,5 @@ config VIDEO_TEGRA124
>>            HDMI. At present only eDP is supported by U-Boot. This option
>>            enables this support which can be used on devices which
>>            have an eDP display connected.
>> +
>> +endmenu
>> --
>
> With this patch, there are still single entries under Device Drivers
> main menu like:
>
> [] Enable clock driver support
> [] Enable CPU drivers using Driver Model
> [] Enable Driver Model for Ethernet drivers
> [] Network device support  ----
> [] Enable Chrome OS EC keyboard support
> [] Enable sandbox TPM driver
> [] Enable RAM drivers using Driver Model
> [] Driver support for thermal devices
>
> Can we make those into sub-menus as well?
>
> Regards,
> Bin
> _______________________________________________
> U-Boot mailing list
> U-Boot at lists.denx.de
> http://lists.denx.de/mailman/listinfo/u-boot



-- 
Best Regards
Masahiro Yamada

^ permalink raw reply	[flat|nested] 10+ messages in thread

* [U-Boot] [PATCH] drivers: hierarchize drivers Kconfig menu
  2015-08-01 13:27   ` Masahiro Yamada
@ 2015-08-01 14:09     ` Bin Meng
  0 siblings, 0 replies; 10+ messages in thread
From: Bin Meng @ 2015-08-01 14:09 UTC (permalink / raw)
  To: u-boot

Hi Masahiro,

On Sat, Aug 1, 2015 at 9:27 PM, Masahiro Yamada
<yamada.masahiro@socionext.com> wrote:
> Hi Bin,
>
>
> Looks like I missed some items..
> Anyway, they do not have many drivers below them,
> so menuconfig is not so messy.
>
>
> Do you want me send v2,
> or will you send a follow-up patch?
>

I can send a follow-up patch.

>
>
> 2015-08-01 20:11 GMT+09:00 Bin Meng <bmeng.cn@gmail.com>:
>> Hi Masahiro,
>>
>> On Sun, Jul 26, 2015 at 1:46 AM, Masahiro Yamada
>> <yamada.masahiro@socionext.com> wrote:
>>> The menuconfig for drivers are getting more and more cluttered
>>> and unreadable because too many entries are displayed in a single
>>> flat menu.  Use hierarchic menu for each category.
>>>
>>> Signed-off-by: Masahiro Yamada <yamada.masahiro@socionext.com>
>>> ---

[snip]

>> With this patch, there are still single entries under Device Drivers
>> main menu like:
>>
>> [] Enable clock driver support
>> [] Enable CPU drivers using Driver Model
>> [] Enable Driver Model for Ethernet drivers
>> [] Network device support  ----
>> [] Enable Chrome OS EC keyboard support
>> [] Enable sandbox TPM driver
>> [] Enable RAM drivers using Driver Model
>> [] Driver support for thermal devices
>>
>> Can we make those into sub-menus as well?
>>

Regards,
Bin

^ permalink raw reply	[flat|nested] 10+ messages in thread

* [U-Boot] [PATCH] drivers: hierarchize drivers Kconfig menu
  2015-08-01  9:08   ` Paul Kocialkowski
@ 2015-08-01 15:18     ` Marek Vasut
  2015-08-01 18:38       ` Paul Kocialkowski
  0 siblings, 1 reply; 10+ messages in thread
From: Marek Vasut @ 2015-08-01 15:18 UTC (permalink / raw)
  To: u-boot

On Saturday, August 01, 2015 at 11:08:10 AM, Paul Kocialkowski wrote:
> Hi,
> 
> Le lundi 27 juillet 2015 ? 14:33 +0200, Paul Kocialkowski a ?crit :
> > Le dimanche 26 juillet 2015 ? 02:46 +0900, Masahiro Yamada a ?crit :
> > > The menuconfig for drivers are getting more and more cluttered
> > > and unreadable because too many entries are displayed in a single
> > > flat menu.  Use hierarchic menu for each category.
> > 
> > That looks like a valuable addition to me!
> 
> This patch was submitted a week ago and I need it for merging another
> series of mine, that was already accepted.
> 
> Is there anything preventing this patch from being merged at this point?

People not having just one patch on their plate and thus being busy ;-)

Best regards,
Marek Vasut

^ permalink raw reply	[flat|nested] 10+ messages in thread

* [U-Boot] [PATCH] drivers: hierarchize drivers Kconfig menu
  2015-08-01 15:18     ` Marek Vasut
@ 2015-08-01 18:38       ` Paul Kocialkowski
  0 siblings, 0 replies; 10+ messages in thread
From: Paul Kocialkowski @ 2015-08-01 18:38 UTC (permalink / raw)
  To: u-boot

Le samedi 01 ao?t 2015 ? 17:18 +0200, Marek Vasut a ?crit :
> On Saturday, August 01, 2015 at 11:08:10 AM, Paul Kocialkowski wrote:
> > Hi,
> > 
> > Le lundi 27 juillet 2015 ? 14:33 +0200, Paul Kocialkowski a ?crit :
> > > Le dimanche 26 juillet 2015 ? 02:46 +0900, Masahiro Yamada a ?crit :
> > > > The menuconfig for drivers are getting more and more cluttered
> > > > and unreadable because too many entries are displayed in a single
> > > > flat menu.  Use hierarchic menu for each category.
> > > 
> > > That looks like a valuable addition to me!
> > 
> > This patch was submitted a week ago and I need it for merging another
> > series of mine, that was already accepted.
> > 
> > Is there anything preventing this patch from being merged at this point?
> 
> People not having just one patch on their plate and thus being busy ;-)

Of course, I'm just sending this as a reminder, to get the discussion
started on this patch. I know that everyone's busy around here and I
fully understand that the process takes some time. Still, I believe a
reminder once in a while (a week seems fair enough) is good thing, too!

-- 
Paul Kocialkowski, Replicant developer

Replicant is a fully free Android distribution running on several
devices, a free software mobile operating system putting the emphasis on
freedom and privacy/security.

Website: http://www.replicant.us/
Blog: http://blog.replicant.us/
Wiki/tracker/forums: http://redmine.replicant.us/
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 819 bytes
Desc: This is a digitally signed message part
URL: <http://lists.denx.de/pipermail/u-boot/attachments/20150801/7097b7d7/attachment.sig>

^ permalink raw reply	[flat|nested] 10+ messages in thread

* [U-Boot] [PATCH] drivers: hierarchize drivers Kconfig menu
  2015-07-25 17:46 [U-Boot] [PATCH] drivers: hierarchize drivers Kconfig menu Masahiro Yamada
  2015-07-27 12:33 ` Paul Kocialkowski
  2015-08-01 11:11 ` Bin Meng
@ 2015-08-02 21:21 ` Simon Glass
  2015-08-13 13:19 ` [U-Boot] " Tom Rini
  3 siblings, 0 replies; 10+ messages in thread
From: Simon Glass @ 2015-08-02 21:21 UTC (permalink / raw)
  To: u-boot

On 25 July 2015 at 11:46, Masahiro Yamada <yamada.masahiro@socionext.com> wrote:
> The menuconfig for drivers are getting more and more cluttered
> and unreadable because too many entries are displayed in a single
> flat menu.  Use hierarchic menu for each category.
>
> Signed-off-by: Masahiro Yamada <yamada.masahiro@socionext.com>
> ---
>
>  drivers/core/Kconfig   | 4 ++++
>  drivers/crypto/Kconfig | 4 ++++
>  drivers/demo/Kconfig   | 4 ++++
>  drivers/gpio/Kconfig   | 8 ++++++++
>  drivers/i2c/Kconfig    | 8 ++++++++
>  drivers/led/Kconfig    | 4 ++++
>  drivers/misc/Kconfig   | 8 ++++++++
>  drivers/rtc/Kconfig    | 8 ++++++++
>  drivers/serial/Kconfig | 8 ++++++++
>  drivers/sound/Kconfig  | 4 ++++
>  drivers/usb/Kconfig    | 8 ++++++++
>  drivers/video/Kconfig  | 8 ++++++++
>  12 files changed, 76 insertions(+)

Reviewed-by: Simon Glass <sjg@chromium.org>

^ permalink raw reply	[flat|nested] 10+ messages in thread

* [U-Boot] drivers: hierarchize drivers Kconfig menu
  2015-07-25 17:46 [U-Boot] [PATCH] drivers: hierarchize drivers Kconfig menu Masahiro Yamada
                   ` (2 preceding siblings ...)
  2015-08-02 21:21 ` Simon Glass
@ 2015-08-13 13:19 ` Tom Rini
  3 siblings, 0 replies; 10+ messages in thread
From: Tom Rini @ 2015-08-13 13:19 UTC (permalink / raw)
  To: u-boot

On Sun, Jul 26, 2015 at 02:46:26AM +0900, Masahiro Yamada wrote:

> The menuconfig for drivers are getting more and more cluttered
> and unreadable because too many entries are displayed in a single
> flat menu.  Use hierarchic menu for each category.
> 
> Signed-off-by: Masahiro Yamada <yamada.masahiro@socionext.com>
> Reviewed-by: Simon Glass <sjg@chromium.org>

Applied to u-boot/master, thanks!

-- 
Tom
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 836 bytes
Desc: Digital signature
URL: <http://lists.denx.de/pipermail/u-boot/attachments/20150813/213d642e/attachment.sig>

^ permalink raw reply	[flat|nested] 10+ messages in thread

end of thread, other threads:[~2015-08-13 13:19 UTC | newest]

Thread overview: 10+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2015-07-25 17:46 [U-Boot] [PATCH] drivers: hierarchize drivers Kconfig menu Masahiro Yamada
2015-07-27 12:33 ` Paul Kocialkowski
2015-08-01  9:08   ` Paul Kocialkowski
2015-08-01 15:18     ` Marek Vasut
2015-08-01 18:38       ` Paul Kocialkowski
2015-08-01 11:11 ` Bin Meng
2015-08-01 13:27   ` Masahiro Yamada
2015-08-01 14:09     ` Bin Meng
2015-08-02 21:21 ` Simon Glass
2015-08-13 13:19 ` [U-Boot] " Tom Rini

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.