[U-Boot] [PATCH] tools: binman: Add missing filenames for various x86 rom tests

[U-Boot] [PATCH] tools: binman: Add missing filenames for various x86 rom tests

[Bin Meng]

With recent changes, some x86-specific rom tests of binman fail to
run. Fix it by adding missing filenames in corresponding entries.

Signed-off-by: Bin Meng <bmeng.cn@gmail.com>
---

 tools/binman/test/30_x86-rom-me-no-desc.dts | 1 +
 tools/binman/test/31_x86-rom-me.dts         | 2 ++
 tools/binman/test/32_intel-vga.dts          | 1 +
 tools/binman/test/42_intel-fsp.dts          | 1 +
 tools/binman/test/43_intel-cmc.dts          | 1 +
 5 files changed, 6 insertions(+)

diff --git a/tools/binman/test/30_x86-rom-me-no-desc.dts b/tools/binman/test/30_x86-rom-me-no-desc.dts
index 4578f66..68d3ce0 100644
--- a/tools/binman/test/30_x86-rom-me-no-desc.dts
+++ b/tools/binman/test/30_x86-rom-me-no-desc.dts
@@ -9,6 +9,7 @@
 		end-at-4gb;
 		size = <16>;
 		intel-me {
+			filename = "me.bin";
 			pos-unset;
 		};
 	};
diff --git a/tools/binman/test/31_x86-rom-me.dts b/tools/binman/test/31_x86-rom-me.dts
index b484ab3..ee3dac8 100644
--- a/tools/binman/test/31_x86-rom-me.dts
+++ b/tools/binman/test/31_x86-rom-me.dts
@@ -9,9 +9,11 @@
 		end-at-4gb;
 		size = <0x800000>;
 		intel-descriptor {
+			filename = "descriptor.bin";
 		};
 
 		intel-me {
+			filename = "me.bin";
 			pos-unset;
 		};
 	};
diff --git a/tools/binman/test/32_intel-vga.dts b/tools/binman/test/32_intel-vga.dts
index 1790833..9c532d0 100644
--- a/tools/binman/test/32_intel-vga.dts
+++ b/tools/binman/test/32_intel-vga.dts
@@ -8,6 +8,7 @@
 		size = <16>;
 
 		intel-vga {
+			filename = "vga.bin";
 		};
 	};
 };
diff --git a/tools/binman/test/42_intel-fsp.dts b/tools/binman/test/42_intel-fsp.dts
index e0a1e76..8a7c889 100644
--- a/tools/binman/test/42_intel-fsp.dts
+++ b/tools/binman/test/42_intel-fsp.dts
@@ -8,6 +8,7 @@
 		size = <16>;
 
 		intel-fsp {
+			filename = "fsp.bin";
 		};
 	};
 };
diff --git a/tools/binman/test/43_intel-cmc.dts b/tools/binman/test/43_intel-cmc.dts
index 26c456d..5a56c7d 100644
--- a/tools/binman/test/43_intel-cmc.dts
+++ b/tools/binman/test/43_intel-cmc.dts
@@ -8,6 +8,7 @@
 		size = <16>;
 
 		intel-cmc {
+			filename = "cmc.bin";
 		};
 	};
 };
-- 
2.9.2

[U-Boot] [PATCH] tools: binman: Add missing filenames for various x86 rom tests

[Simon Glass]

On 4 April 2017 at 22:17, Bin Meng <bmeng.cn@gmail.com> wrote:
> With recent changes, some x86-specific rom tests of binman fail to
> run. Fix it by adding missing filenames in corresponding entries.
>
> Signed-off-by: Bin Meng <bmeng.cn@gmail.com>
> ---
>
>  tools/binman/test/30_x86-rom-me-no-desc.dts | 1 +
>  tools/binman/test/31_x86-rom-me.dts         | 2 ++
>  tools/binman/test/32_intel-vga.dts          | 1 +
>  tools/binman/test/42_intel-fsp.dts          | 1 +
>  tools/binman/test/43_intel-cmc.dts          | 1 +
>  5 files changed, 6 insertions(+)

Reviewed-by: Simon Glass <sjg@chromium.org>

[U-Boot] [PATCH] tools: binman: Add missing filenames for various x86 rom tests

[Bin Meng]

On Mon, Apr 10, 2017 at 3:27 AM, Simon Glass <sjg@chromium.org> wrote:
> On 4 April 2017 at 22:17, Bin Meng <bmeng.cn@gmail.com> wrote:
>> With recent changes, some x86-specific rom tests of binman fail to
>> run. Fix it by adding missing filenames in corresponding entries.
>>
>> Signed-off-by: Bin Meng <bmeng.cn@gmail.com>
>> ---
>>
>>  tools/binman/test/30_x86-rom-me-no-desc.dts | 1 +
>>  tools/binman/test/31_x86-rom-me.dts         | 2 ++
>>  tools/binman/test/32_intel-vga.dts          | 1 +
>>  tools/binman/test/42_intel-fsp.dts          | 1 +
>>  tools/binman/test/43_intel-cmc.dts          | 1 +
>>  5 files changed, 6 insertions(+)
>
> Reviewed-by: Simon Glass <sjg@chromium.org>

applied to u-boot-x86, thanks!