All of lore.kernel.org
 help / color / mirror / Atom feed
From: Bin Meng <bmeng.cn@gmail.com>
To: Alistair Francis <alistair.francis@opensource.wdc.com>
Cc: Peter Maydell <peter.maydell@linaro.org>,
	Alistair Francis <alistair.francis@wdc.com>,
	Alistair Francis <alistair@alistair23.me>,
	"open list:RISC-V" <qemu-riscv@nongnu.org>,
	Bin Meng <bin.meng@windriver.com>,
	"qemu-devel@nongnu.org Developers" <qemu-devel@nongnu.org>,
	qemu-arm <qemu-arm@nongnu.org>,
	Palmer Dabbelt <palmer@dabbelt.com>,
	"Edgar E. Iglesias" <edgar.iglesias@gmail.com>,
	Alistair Francis <alistair23@gmail.com>
Subject: Re: [PATCH v4 2/6] hw/core: Move the ARM sysbus-fdt to core
Date: Thu, 21 Apr 2022 16:39:53 +0800	[thread overview]
Message-ID: <CAEUhbmXjYMXKm3cZzkedro208ny+0wFKjyZE=8mtomfdvkD65w@mail.gmail.com> (raw)
In-Reply-To: <20220420055248.960491-3-alistair.francis@opensource.wdc.com>

On Wed, Apr 20, 2022 at 1:53 PM Alistair Francis
<alistair.francis@opensource.wdc.com> wrote:
>
> From: Alistair Francis <alistair.francis@wdc.com>
>
> The ARM virt machine currently uses sysbus-fdt to create device tree
> entries for dynamically created MMIO devices.
>
> The RISC-V virt machine can also benefit from this, so move the code to
> the core directory.
>
> Signed-off-by: Alistair Francis <alistair.francis@wdc.com>
> Reviewed-by: Edgar E. Iglesias <edgar.iglesias@amd.com>
> ---
>  include/hw/{arm => core}/sysbus-fdt.h | 0
>  hw/arm/virt.c                         | 2 +-
>  hw/arm/xlnx-versal-virt.c             | 1 -
>  hw/{arm => core}/sysbus-fdt.c         | 2 +-
>  hw/arm/meson.build                    | 1 -
>  hw/core/meson.build                   | 1 +
>  6 files changed, 3 insertions(+), 4 deletions(-)
>  rename include/hw/{arm => core}/sysbus-fdt.h (100%)
>  rename hw/{arm => core}/sysbus-fdt.c (99%)
>

Reviewed-by: Bin Meng <bmeng.cn@gmail.com>

I believe you can do some refactor to let hw/ppc/e500.c to use this
platform bus too.

Regards,
Bin


WARNING: multiple messages have this Message-ID (diff)
From: Bin Meng <bmeng.cn@gmail.com>
To: Alistair Francis <alistair.francis@opensource.wdc.com>
Cc: "open list:RISC-V" <qemu-riscv@nongnu.org>,
	 "qemu-devel@nongnu.org Developers" <qemu-devel@nongnu.org>,
	Palmer Dabbelt <palmer@dabbelt.com>,
	 Alistair Francis <alistair@alistair23.me>,
	Alistair Francis <alistair23@gmail.com>,
	 Bin Meng <bin.meng@windriver.com>,
	Alistair Francis <alistair.francis@wdc.com>,
	qemu-arm <qemu-arm@nongnu.org>,
	Peter Maydell <peter.maydell@linaro.org>,
	 "Edgar E. Iglesias" <edgar.iglesias@gmail.com>
Subject: Re: [PATCH v4 2/6] hw/core: Move the ARM sysbus-fdt to core
Date: Thu, 21 Apr 2022 16:39:53 +0800	[thread overview]
Message-ID: <CAEUhbmXjYMXKm3cZzkedro208ny+0wFKjyZE=8mtomfdvkD65w@mail.gmail.com> (raw)
In-Reply-To: <20220420055248.960491-3-alistair.francis@opensource.wdc.com>

On Wed, Apr 20, 2022 at 1:53 PM Alistair Francis
<alistair.francis@opensource.wdc.com> wrote:
>
> From: Alistair Francis <alistair.francis@wdc.com>
>
> The ARM virt machine currently uses sysbus-fdt to create device tree
> entries for dynamically created MMIO devices.
>
> The RISC-V virt machine can also benefit from this, so move the code to
> the core directory.
>
> Signed-off-by: Alistair Francis <alistair.francis@wdc.com>
> Reviewed-by: Edgar E. Iglesias <edgar.iglesias@amd.com>
> ---
>  include/hw/{arm => core}/sysbus-fdt.h | 0
>  hw/arm/virt.c                         | 2 +-
>  hw/arm/xlnx-versal-virt.c             | 1 -
>  hw/{arm => core}/sysbus-fdt.c         | 2 +-
>  hw/arm/meson.build                    | 1 -
>  hw/core/meson.build                   | 1 +
>  6 files changed, 3 insertions(+), 4 deletions(-)
>  rename include/hw/{arm => core}/sysbus-fdt.h (100%)
>  rename hw/{arm => core}/sysbus-fdt.c (99%)
>

Reviewed-by: Bin Meng <bmeng.cn@gmail.com>

I believe you can do some refactor to let hw/ppc/e500.c to use this
platform bus too.

Regards,
Bin


  reply	other threads:[~2022-04-21  9:15 UTC|newest]

Thread overview: 24+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-04-20  5:52 [PATCH v4 0/6] hw/riscv: Add TPM support to the virt board Alistair Francis
2022-04-20  5:52 ` [PATCH v4 1/6] hw/riscv: virt: Add a machine done notifier Alistair Francis
2022-04-21  8:33   ` Bin Meng
2022-04-21  8:33     ` Bin Meng
2022-04-20  5:52 ` [PATCH v4 2/6] hw/core: Move the ARM sysbus-fdt to core Alistair Francis
2022-04-21  8:39   ` Bin Meng [this message]
2022-04-21  8:39     ` Bin Meng
2022-04-20  5:52 ` [PATCH v4 3/6] hw/riscv: virt: Create a platform bus Alistair Francis
2022-04-22  1:42   ` Bin Meng
2022-04-22  1:42     ` Bin Meng
2022-04-20  5:52 ` [PATCH v4 4/6] hw/riscv: virt: Add support for generating platform FDT entries Alistair Francis
2022-04-22  1:50   ` Bin Meng
2022-04-22  1:50     ` Bin Meng
2022-04-20  5:52 ` [PATCH v4 5/6] hw/riscv: virt: Add device plug support Alistair Francis
2022-04-22  2:07   ` Bin Meng
2022-04-22  2:07     ` Bin Meng
2022-04-20  5:52 ` [PATCH v4 6/6] hw/riscv: Enable TPM backends Alistair Francis
2022-04-22  2:13   ` Bin Meng
2022-04-22  2:13     ` Bin Meng
2023-06-19 20:32   ` Guenter Roeck
2023-06-21  6:34     ` Guenter Roeck
2023-07-03  3:10       ` Alistair Francis
2022-04-21  2:19 ` [PATCH v4 0/6] hw/riscv: Add TPM support to the virt board Bin Meng
2022-04-21  2:19   ` Bin Meng

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to='CAEUhbmXjYMXKm3cZzkedro208ny+0wFKjyZE=8mtomfdvkD65w@mail.gmail.com' \
    --to=bmeng.cn@gmail.com \
    --cc=alistair.francis@opensource.wdc.com \
    --cc=alistair.francis@wdc.com \
    --cc=alistair23@gmail.com \
    --cc=alistair@alistair23.me \
    --cc=bin.meng@windriver.com \
    --cc=edgar.iglesias@gmail.com \
    --cc=palmer@dabbelt.com \
    --cc=peter.maydell@linaro.org \
    --cc=qemu-arm@nongnu.org \
    --cc=qemu-devel@nongnu.org \
    --cc=qemu-riscv@nongnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.