All of lore.kernel.org
 help / color / mirror / Atom feed
From: Dylan Reid <dgreid@chromium.org>
To: alsa-devel@alsa-project.org
Cc: Chih-Chung Chang <chihchung@chromium.org>,
	Evan Ragsdale <Evan.Ragsdale@maxim-ic.com>,
	patch@alsa-project.org, lgirdwood@gmail.com,
	Mark Brown <broonie@opensource.wolfsonmicro.com>
Subject: Re: [PATCH 1/1] ASoC: max98088 - fix element type of the register cache.
Date: Fri, 12 Jul 2013 10:31:57 -0700	[thread overview]
Message-ID: <CAEUnVG7b7sE5=Cg2fsgGUNeeJPecxHq_M1TSGPQ=TXDGynrupA@mail.gmail.com> (raw)

+Maintainers and Maxim,

Chih-Chung, please CC maintainers on patches.

On Tue, Jun 25, 2013 at 12:47 AM,  <me@google.com> wrote:
> From: Chih-Chung Chang <chihchung@chromium.org>
>
> The registers of max98088 are 8 bits, not 16 bits. This bug causes the
> contents of registers to be overwritten with bad values when the codec
> is suspended and then resumed.
>
> Signed-off-by: Chih-Chung Chang <chihchung@chromium.org>
>
> diff --git a/sound/soc/codecs/max98088.c b/sound/soc/codecs/max98088.c
> index 3eeada5..566a367 100644
> --- a/sound/soc/codecs/max98088.c
> +++ b/sound/soc/codecs/max98088.c
> @@ -1612,7 +1612,7 @@ static int max98088_dai2_digital_mute(struct snd_soc_dai *codec_dai, int mute)
>
>  static void max98088_sync_cache(struct snd_soc_codec *codec)
>  {
> -       u16 *reg_cache = codec->reg_cache;
> +       u8 *reg_cache = codec->reg_cache;
>         int i;
>
>         if (!codec->cache_sync)
> --
> 1.8.3
>

             reply	other threads:[~2013-07-12 17:32 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-07-12 17:31 Dylan Reid [this message]
2013-07-15 16:11 ` [PATCH 1/1] ASoC: max98088 - fix element type of the register cache Mark Brown

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to='CAEUnVG7b7sE5=Cg2fsgGUNeeJPecxHq_M1TSGPQ=TXDGynrupA@mail.gmail.com' \
    --to=dgreid@chromium.org \
    --cc=Evan.Ragsdale@maxim-ic.com \
    --cc=alsa-devel@alsa-project.org \
    --cc=broonie@opensource.wolfsonmicro.com \
    --cc=chihchung@chromium.org \
    --cc=lgirdwood@gmail.com \
    --cc=patch@alsa-project.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.