Re: [PATCH 1/1] ASoC: max98088 - fix element type of the register cache.

Re: [PATCH 1/1] ASoC: max98088 - fix element type of the register cache.

[Dylan Reid]

+Maintainers and Maxim,

Chih-Chung, please CC maintainers on patches.

On Tue, Jun 25, 2013 at 12:47 AM,  <me@google.com> wrote:
> From: Chih-Chung Chang <chihchung@chromium.org>
>
> The registers of max98088 are 8 bits, not 16 bits. This bug causes the
> contents of registers to be overwritten with bad values when the codec
> is suspended and then resumed.
>
> Signed-off-by: Chih-Chung Chang <chihchung@chromium.org>
>
> diff --git a/sound/soc/codecs/max98088.c b/sound/soc/codecs/max98088.c
> index 3eeada5..566a367 100644
> --- a/sound/soc/codecs/max98088.c
> +++ b/sound/soc/codecs/max98088.c
> @@ -1612,7 +1612,7 @@ static int max98088_dai2_digital_mute(struct snd_soc_dai *codec_dai, int mute)
>
>  static void max98088_sync_cache(struct snd_soc_codec *codec)
>  {
> -       u16 *reg_cache = codec->reg_cache;
> +       u8 *reg_cache = codec->reg_cache;
>         int i;
>
>         if (!codec->cache_sync)
> --
> 1.8.3
>

Re: [PATCH 1/1] ASoC: max98088 - fix element type of the register cache.

[Mark Brown]

[-- Attachment #1.1: Type: text/plain, Size: 259 bytes --]

On Fri, Jul 12, 2013 at 10:31:57AM -0700, Dylan Reid wrote:
> +Maintainers and Maxim,
> 
> Chih-Chung, please CC maintainers on patches.

Someone is going to need to resend this as I appear not to have the
patch (it's probably waiting for moderation).

[-- Attachment #1.2: Digital signature --]
[-- Type: application/pgp-signature, Size: 836 bytes --]

[-- Attachment #2: Type: text/plain, Size: 0 bytes --]