All of lore.kernel.org
 help / color / mirror / Atom feed
* [linux-next:master 6722/7300] drivers/hid/hid-nintendo.c:371:13: error: initializer element is not constant
@ 2023-12-14  4:59 kernel test robot
  2023-12-14 17:25 ` [PATCH] HID: nintendo: fix initializer element is not constant error Ryan McClelland
  0 siblings, 1 reply; 4+ messages in thread
From: kernel test robot @ 2023-12-14  4:59 UTC (permalink / raw)
  To: Ryan McClelland
  Cc: oe-kbuild-all, Linux Memory Management List, Jiri Kosina,
	Daniel J. Ogorchock

tree:   https://git.kernel.org/pub/scm/linux/kernel/git/next/linux-next.git master
head:   48e8992e33abf054bcc0bb2e77b2d43bb899212e
commit: 94f18bb19945915fcdfd1903841020ef1b6af44a [6722/7300] HID: nintendo: add support for nso controllers
config: x86_64-randconfig-016-20231214 (https://download.01.org/0day-ci/archive/20231214/202312141227.C2h1IzfI-lkp@intel.com/config)
compiler: gcc-7 (Ubuntu 7.5.0-6ubuntu2) 7.5.0
reproduce (this is a W=1 build): (https://download.01.org/0day-ci/archive/20231214/202312141227.C2h1IzfI-lkp@intel.com/reproduce)

If you fix the issue in a separate patch/commit (i.e. not just a new version of
the same patch/commit), kindly add following tags
| Reported-by: kernel test robot <lkp@intel.com>
| Closes: https://lore.kernel.org/oe-kbuild-all/202312141227.C2h1IzfI-lkp@intel.com/

All errors (new ones prefixed by >>):

>> drivers/hid/hid-nintendo.c:371:13: error: initializer element is not constant
     { BTN_TL,  JC_BTN_L, },
                ^~~~~~~~
   drivers/hid/hid-nintendo.c:371:13: note: (near initialization for 'left_joycon_button_mappings[0].bit')
   drivers/hid/hid-nintendo.c:372:14: error: initializer element is not constant
     { BTN_TL2,  JC_BTN_ZL, },
                 ^~~~~~~~~
   drivers/hid/hid-nintendo.c:372:14: note: (near initialization for 'left_joycon_button_mappings[1].bit')
   drivers/hid/hid-nintendo.c:373:17: error: initializer element is not constant
     { BTN_SELECT,  JC_BTN_MINUS, },
                    ^~~~~~~~~~~~
   drivers/hid/hid-nintendo.c:373:17: note: (near initialization for 'left_joycon_button_mappings[2].bit')
   drivers/hid/hid-nintendo.c:374:17: error: initializer element is not constant
     { BTN_THUMBL,  JC_BTN_LSTICK, },
                    ^~~~~~~~~~~~~
   drivers/hid/hid-nintendo.c:374:17: note: (near initialization for 'left_joycon_button_mappings[3].bit')
   drivers/hid/hid-nintendo.c:375:18: error: initializer element is not constant
     { BTN_DPAD_UP,  JC_BTN_UP, },
                     ^~~~~~~~~
   drivers/hid/hid-nintendo.c:375:18: note: (near initialization for 'left_joycon_button_mappings[4].bit')
   drivers/hid/hid-nintendo.c:376:19: error: initializer element is not constant
     { BTN_DPAD_DOWN, JC_BTN_DOWN, },
                      ^~~~~~~~~~~
   drivers/hid/hid-nintendo.c:376:19: note: (near initialization for 'left_joycon_button_mappings[5].bit')
   drivers/hid/hid-nintendo.c:377:19: error: initializer element is not constant
     { BTN_DPAD_LEFT, JC_BTN_LEFT, },
                      ^~~~~~~~~~~
   drivers/hid/hid-nintendo.c:377:19: note: (near initialization for 'left_joycon_button_mappings[6].bit')
   drivers/hid/hid-nintendo.c:378:20: error: initializer element is not constant
     { BTN_DPAD_RIGHT, JC_BTN_RIGHT, },
                       ^~~~~~~~~~~~
   drivers/hid/hid-nintendo.c:378:20: note: (near initialization for 'left_joycon_button_mappings[7].bit')
   drivers/hid/hid-nintendo.c:379:12: error: initializer element is not constant
     { BTN_Z,  JC_BTN_CAP, },
               ^~~~~~~~~~
   drivers/hid/hid-nintendo.c:379:12: note: (near initialization for 'left_joycon_button_mappings[8].bit')
   drivers/hid/hid-nintendo.c:388:12: error: initializer element is not constant
     { BTN_TR, JC_BTN_SL_L, },
               ^~~~~~~~~~~
   drivers/hid/hid-nintendo.c:388:12: note: (near initialization for 'left_joycon_s_button_mappings[0].bit')
   drivers/hid/hid-nintendo.c:389:13: error: initializer element is not constant
     { BTN_TR2, JC_BTN_SR_L, },
                ^~~~~~~~~~~
   drivers/hid/hid-nintendo.c:389:13: note: (near initialization for 'left_joycon_s_button_mappings[1].bit')
   drivers/hid/hid-nintendo.c:394:14: error: initializer element is not constant
     { BTN_EAST, JC_BTN_A, },
                 ^~~~~~~~
   drivers/hid/hid-nintendo.c:394:14: note: (near initialization for 'right_joycon_button_mappings[0].bit')
   drivers/hid/hid-nintendo.c:395:15: error: initializer element is not constant
     { BTN_SOUTH, JC_BTN_B, },
                  ^~~~~~~~
   drivers/hid/hid-nintendo.c:395:15: note: (near initialization for 'right_joycon_button_mappings[1].bit')
   drivers/hid/hid-nintendo.c:396:15: error: initializer element is not constant
     { BTN_NORTH, JC_BTN_X, },
                  ^~~~~~~~
   drivers/hid/hid-nintendo.c:396:15: note: (near initialization for 'right_joycon_button_mappings[2].bit')
   drivers/hid/hid-nintendo.c:397:14: error: initializer element is not constant
     { BTN_WEST, JC_BTN_Y, },
                 ^~~~~~~~
   drivers/hid/hid-nintendo.c:397:14: note: (near initialization for 'right_joycon_button_mappings[3].bit')
   drivers/hid/hid-nintendo.c:398:12: error: initializer element is not constant
     { BTN_TR, JC_BTN_R, },
               ^~~~~~~~
   drivers/hid/hid-nintendo.c:398:12: note: (near initialization for 'right_joycon_button_mappings[4].bit')
   drivers/hid/hid-nintendo.c:399:13: error: initializer element is not constant
     { BTN_TR2, JC_BTN_ZR, },
                ^~~~~~~~~
   drivers/hid/hid-nintendo.c:399:13: note: (near initialization for 'right_joycon_button_mappings[5].bit')
   drivers/hid/hid-nintendo.c:400:15: error: initializer element is not constant
     { BTN_START, JC_BTN_PLUS, },
                  ^~~~~~~~~~~
   drivers/hid/hid-nintendo.c:400:15: note: (near initialization for 'right_joycon_button_mappings[6].bit')
   drivers/hid/hid-nintendo.c:401:16: error: initializer element is not constant
     { BTN_THUMBR, JC_BTN_RSTICK, },
                   ^~~~~~~~~~~~~
   drivers/hid/hid-nintendo.c:401:16: note: (near initialization for 'right_joycon_button_mappings[7].bit')
   drivers/hid/hid-nintendo.c:402:14: error: initializer element is not constant
     { BTN_MODE, JC_BTN_HOME, },
                 ^~~~~~~~~~~
   drivers/hid/hid-nintendo.c:402:14: note: (near initialization for 'right_joycon_button_mappings[8].bit')
   drivers/hid/hid-nintendo.c:411:12: error: initializer element is not constant
     { BTN_TL, JC_BTN_SL_R, },
               ^~~~~~~~~~~
   drivers/hid/hid-nintendo.c:411:12: note: (near initialization for 'right_joycon_s_button_mappings[0].bit')
   drivers/hid/hid-nintendo.c:412:13: error: initializer element is not constant
     { BTN_TL2, JC_BTN_SR_R, },
                ^~~~~~~~~~~
   drivers/hid/hid-nintendo.c:412:13: note: (near initialization for 'right_joycon_s_button_mappings[1].bit')
   drivers/hid/hid-nintendo.c:417:14: error: initializer element is not constant
     { BTN_EAST, JC_BTN_A, },
                 ^~~~~~~~
   drivers/hid/hid-nintendo.c:417:14: note: (near initialization for 'procon_button_mappings[0].bit')
   drivers/hid/hid-nintendo.c:418:15: error: initializer element is not constant
     { BTN_SOUTH, JC_BTN_B, },
                  ^~~~~~~~
   drivers/hid/hid-nintendo.c:418:15: note: (near initialization for 'procon_button_mappings[1].bit')
   drivers/hid/hid-nintendo.c:419:15: error: initializer element is not constant
     { BTN_NORTH, JC_BTN_X, },
                  ^~~~~~~~
   drivers/hid/hid-nintendo.c:419:15: note: (near initialization for 'procon_button_mappings[2].bit')
   drivers/hid/hid-nintendo.c:420:14: error: initializer element is not constant


vim +371 drivers/hid/hid-nintendo.c

   366	
   367	/*
   368	 * D-pad is configured as buttons for the left Joy-Con only!
   369	 */
   370	static const struct joycon_ctlr_button_mapping left_joycon_button_mappings[] = {
 > 371		{ BTN_TL,		JC_BTN_L,	},
   372		{ BTN_TL2,		JC_BTN_ZL,	},
   373		{ BTN_SELECT,		JC_BTN_MINUS,	},
   374		{ BTN_THUMBL,		JC_BTN_LSTICK,	},
   375		{ BTN_DPAD_UP,		JC_BTN_UP,	},
   376		{ BTN_DPAD_DOWN,	JC_BTN_DOWN,	},
   377		{ BTN_DPAD_LEFT,	JC_BTN_LEFT,	},
   378		{ BTN_DPAD_RIGHT,	JC_BTN_RIGHT,	},
   379		{ BTN_Z,		JC_BTN_CAP,	},
   380		{ /* sentinel */ },
   381	};
   382	

-- 
0-DAY CI Kernel Test Service
https://github.com/intel/lkp-tests/wiki

^ permalink raw reply	[flat|nested] 4+ messages in thread
* [PATCH] HID: nintendo: fix initializer element is not constant error
  2023-12-14  4:59 [linux-next:master 6722/7300] drivers/hid/hid-nintendo.c:371:13: error: initializer element is not constant kernel test robot
@ 2023-12-14 17:25 ` Ryan McClelland
  2023-12-18  7:33   ` Daniel Ogorchock
  2023-12-18  8:55   ` Jiri Kosina
  0 siblings, 2 replies; 4+ messages in thread
From: Ryan McClelland @ 2023-12-14 17:25 UTC (permalink / raw)
  To: lkp, linux-input
  Cc: jkosina, linux-mm, oe-kbuild-all, djogorchock,
	benjamin.tissoires, jikos, Ryan McClelland

With gcc-7 builds, an error happens with the controller button values being
defined as const. Change to a define.

Reported-by: kernel test robot <lkp@intel.com>
Closes: https://lore.kernel.org/oe-kbuild-all/202312141227.C2h1IzfI-lkp@intel.com/

Signed-off-by: Ryan McClelland <rymcclel@gmail.com>
---
 drivers/hid/hid-nintendo.c | 44 +++++++++++++++++++-------------------
 1 file changed, 22 insertions(+), 22 deletions(-)

diff --git a/drivers/hid/hid-nintendo.c b/drivers/hid/hid-nintendo.c
index 47af111ef3a2..2987083785f9 100644
--- a/drivers/hid/hid-nintendo.c
+++ b/drivers/hid/hid-nintendo.c
@@ -336,28 +336,28 @@ struct joycon_imu_cal {
  * All the controller's button values are stored in a u32.
  * They can be accessed with bitwise ANDs.
  */
-static const u32 JC_BTN_Y	= BIT(0);
-static const u32 JC_BTN_X	= BIT(1);
-static const u32 JC_BTN_B	= BIT(2);
-static const u32 JC_BTN_A	= BIT(3);
-static const u32 JC_BTN_SR_R	= BIT(4);
-static const u32 JC_BTN_SL_R	= BIT(5);
-static const u32 JC_BTN_R	= BIT(6);
-static const u32 JC_BTN_ZR	= BIT(7);
-static const u32 JC_BTN_MINUS	= BIT(8);
-static const u32 JC_BTN_PLUS	= BIT(9);
-static const u32 JC_BTN_RSTICK	= BIT(10);
-static const u32 JC_BTN_LSTICK	= BIT(11);
-static const u32 JC_BTN_HOME	= BIT(12);
-static const u32 JC_BTN_CAP	= BIT(13); /* capture button */
-static const u32 JC_BTN_DOWN	= BIT(16);
-static const u32 JC_BTN_UP	= BIT(17);
-static const u32 JC_BTN_RIGHT	= BIT(18);
-static const u32 JC_BTN_LEFT	= BIT(19);
-static const u32 JC_BTN_SR_L	= BIT(20);
-static const u32 JC_BTN_SL_L	= BIT(21);
-static const u32 JC_BTN_L	= BIT(22);
-static const u32 JC_BTN_ZL	= BIT(23);
+#define JC_BTN_Y	 BIT(0)
+#define JC_BTN_X	 BIT(1)
+#define JC_BTN_B	 BIT(2)
+#define JC_BTN_A	 BIT(3)
+#define JC_BTN_SR_R	 BIT(4)
+#define JC_BTN_SL_R	 BIT(5)
+#define JC_BTN_R	 BIT(6)
+#define JC_BTN_ZR	 BIT(7)
+#define JC_BTN_MINUS	 BIT(8)
+#define JC_BTN_PLUS	 BIT(9)
+#define JC_BTN_RSTICK	 BIT(10)
+#define JC_BTN_LSTICK	 BIT(11)
+#define JC_BTN_HOME	 BIT(12)
+#define JC_BTN_CAP	 BIT(13) /* capture button */
+#define JC_BTN_DOWN	 BIT(16)
+#define JC_BTN_UP	 BIT(17)
+#define JC_BTN_RIGHT	 BIT(18)
+#define JC_BTN_LEFT	 BIT(19)
+#define JC_BTN_SR_L	 BIT(20)
+#define JC_BTN_SL_L	 BIT(21)
+#define JC_BTN_L	 BIT(22)
+#define JC_BTN_ZL	 BIT(23)
 
 struct joycon_ctlr_button_mapping {
 	u32 code;
-- 
2.25.1


^ permalink raw reply related	[flat|nested] 4+ messages in thread
* Re: [PATCH] HID: nintendo: fix initializer element is not constant error
  2023-12-14 17:25 ` [PATCH] HID: nintendo: fix initializer element is not constant error Ryan McClelland
@ 2023-12-18  7:33   ` Daniel Ogorchock
  2023-12-18  8:55   ` Jiri Kosina
  1 sibling, 0 replies; 4+ messages in thread
From: Daniel Ogorchock @ 2023-12-18  7:33 UTC (permalink / raw)
  To: Ryan McClelland
  Cc: lkp, linux-input, jkosina, linux-mm, oe-kbuild-all,
	benjamin.tissoires, jikos

Hi Ryan,

On Thu, Dec 14, 2023 at 12:26 PM Ryan McClelland <rymcclel@gmail.com> wrote:
>
> With gcc-7 builds, an error happens with the controller button values being
> defined as const. Change to a define.
>
> Reported-by: kernel test robot <lkp@intel.com>
> Closes: https://lore.kernel.org/oe-kbuild-all/202312141227.C2h1IzfI-lkp@intel.com/
>
> Signed-off-by: Ryan McClelland <rymcclel@gmail.com>
> ---
>  drivers/hid/hid-nintendo.c | 44 +++++++++++++++++++-------------------
>  1 file changed, 22 insertions(+), 22 deletions(-)
>
> diff --git a/drivers/hid/hid-nintendo.c b/drivers/hid/hid-nintendo.c
> index 47af111ef3a2..2987083785f9 100644
> --- a/drivers/hid/hid-nintendo.c
> +++ b/drivers/hid/hid-nintendo.c
> @@ -336,28 +336,28 @@ struct joycon_imu_cal {
>   * All the controller's button values are stored in a u32.
>   * They can be accessed with bitwise ANDs.
>   */
> -static const u32 JC_BTN_Y      = BIT(0);
> -static const u32 JC_BTN_X      = BIT(1);
> -static const u32 JC_BTN_B      = BIT(2);
> -static const u32 JC_BTN_A      = BIT(3);
> -static const u32 JC_BTN_SR_R   = BIT(4);
> -static const u32 JC_BTN_SL_R   = BIT(5);
> -static const u32 JC_BTN_R      = BIT(6);
> -static const u32 JC_BTN_ZR     = BIT(7);
> -static const u32 JC_BTN_MINUS  = BIT(8);
> -static const u32 JC_BTN_PLUS   = BIT(9);
> -static const u32 JC_BTN_RSTICK = BIT(10);
> -static const u32 JC_BTN_LSTICK = BIT(11);
> -static const u32 JC_BTN_HOME   = BIT(12);
> -static const u32 JC_BTN_CAP    = BIT(13); /* capture button */
> -static const u32 JC_BTN_DOWN   = BIT(16);
> -static const u32 JC_BTN_UP     = BIT(17);
> -static const u32 JC_BTN_RIGHT  = BIT(18);
> -static const u32 JC_BTN_LEFT   = BIT(19);
> -static const u32 JC_BTN_SR_L   = BIT(20);
> -static const u32 JC_BTN_SL_L   = BIT(21);
> -static const u32 JC_BTN_L      = BIT(22);
> -static const u32 JC_BTN_ZL     = BIT(23);
> +#define JC_BTN_Y        BIT(0)
> +#define JC_BTN_X        BIT(1)
> +#define JC_BTN_B        BIT(2)
> +#define JC_BTN_A        BIT(3)
> +#define JC_BTN_SR_R     BIT(4)
> +#define JC_BTN_SL_R     BIT(5)
> +#define JC_BTN_R        BIT(6)
> +#define JC_BTN_ZR       BIT(7)
> +#define JC_BTN_MINUS    BIT(8)
> +#define JC_BTN_PLUS     BIT(9)
> +#define JC_BTN_RSTICK   BIT(10)
> +#define JC_BTN_LSTICK   BIT(11)
> +#define JC_BTN_HOME     BIT(12)
> +#define JC_BTN_CAP      BIT(13) /* capture button */
> +#define JC_BTN_DOWN     BIT(16)
> +#define JC_BTN_UP       BIT(17)
> +#define JC_BTN_RIGHT    BIT(18)
> +#define JC_BTN_LEFT     BIT(19)
> +#define JC_BTN_SR_L     BIT(20)
> +#define JC_BTN_SL_L     BIT(21)
> +#define JC_BTN_L        BIT(22)
> +#define JC_BTN_ZL       BIT(23)
>
>  struct joycon_ctlr_button_mapping {
>         u32 code;
> --
> 2.25.1
>

Thanks for the quick fix.

Reviewed-by: Daniel J. Ogorchock <djogorchock@gmail.com>

-Daniel

^ permalink raw reply	[flat|nested] 4+ messages in thread
* Re: [PATCH] HID: nintendo: fix initializer element is not constant error
  2023-12-14 17:25 ` [PATCH] HID: nintendo: fix initializer element is not constant error Ryan McClelland
  2023-12-18  7:33   ` Daniel Ogorchock
@ 2023-12-18  8:55   ` Jiri Kosina
  1 sibling, 0 replies; 4+ messages in thread
From: Jiri Kosina @ 2023-12-18  8:55 UTC (permalink / raw)
  To: Ryan McClelland
  Cc: lkp, linux-input, linux-mm, oe-kbuild-all, djogorchock,
	benjamin.tissoires

On Thu, 14 Dec 2023, Ryan McClelland wrote:

> With gcc-7 builds, an error happens with the controller button values being
> defined as const. Change to a define.
> 
> Reported-by: kernel test robot <lkp@intel.com>
> Closes: https://lore.kernel.org/oe-kbuild-all/202312141227.C2h1IzfI-lkp@intel.com/
> 
> Signed-off-by: Ryan McClelland <rymcclel@gmail.com>

Applied, thanks.

-- 
Jiri Kosina
SUSE Labs


^ permalink raw reply	[flat|nested] 4+ messages in thread
end of thread, other threads:[~2023-12-18  8:55 UTC | newest]

Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2023-12-14  4:59 [linux-next:master 6722/7300] drivers/hid/hid-nintendo.c:371:13: error: initializer element is not constant kernel test robot
2023-12-14 17:25 ` [PATCH] HID: nintendo: fix initializer element is not constant error Ryan McClelland
2023-12-18  7:33   ` Daniel Ogorchock
2023-12-18  8:55   ` Jiri Kosina

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.