* [PATCH] qemu-kvm: Fix build without VNC support
@ 2011-09-13 13:13 Boris Dolgov
2011-09-14 11:16 ` Marcelo Tosatti
0 siblings, 1 reply; 3+ messages in thread
From: Boris Dolgov @ 2011-09-13 13:13 UTC (permalink / raw)
To: kvm
Hello!
Qemu-kvm 0.15.0 doesn't build with vnc support disabled. The following
patch fixes the problem:
Signed-off-by: Boris Dolgov <boris@dolgov.name>
----- monitor.c~ 2011-08-09 12:40:29.000000000 +0000
+++ monitor.c 2011-09-13 13:02:40.000000000 +0000
@@ -1221,10 +1221,12 @@ static int add_graphics_client(Monitor *
}
qerror_report(QERR_ADD_CLIENT_FAILED);
return -1;
+#ifdef CONFIG_VNC
} else if (strcmp(protocol, "vnc") == 0) {
int fd = monitor_get_fd(mon, fdname);
vnc_display_add_client(NULL, fd, skipauth);
return 0;
+#endif
} else if ((s = qemu_chr_find(protocol)) != NULL) {
int fd = monitor_get_fd(mon, fdname);
if (qemu_chr_add_client(s, fd) < 0) {
--
Boris Dolgov.
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] qemu-kvm: Fix build without VNC support
2011-09-13 13:13 [PATCH] qemu-kvm: Fix build without VNC support Boris Dolgov
@ 2011-09-14 11:16 ` Marcelo Tosatti
2011-09-14 14:18 ` Boris Dolgov
0 siblings, 1 reply; 3+ messages in thread
From: Marcelo Tosatti @ 2011-09-14 11:16 UTC (permalink / raw)
To: Boris Dolgov; +Cc: kvm
On Tue, Sep 13, 2011 at 05:13:41PM +0400, Boris Dolgov wrote:
> Hello!
>
> Qemu-kvm 0.15.0 doesn't build with vnc support disabled. The following
> patch fixes the problem:
>
> Signed-off-by: Boris Dolgov <boris@dolgov.name>
>
> ----- monitor.c~ 2011-08-09 12:40:29.000000000 +0000
> +++ monitor.c 2011-09-13 13:02:40.000000000 +0000
> @@ -1221,10 +1221,12 @@ static int add_graphics_client(Monitor *
> }
> qerror_report(QERR_ADD_CLIENT_FAILED);
> return -1;
> +#ifdef CONFIG_VNC
> } else if (strcmp(protocol, "vnc") == 0) {
> int fd = monitor_get_fd(mon, fdname);
> vnc_display_add_client(NULL, fd, skipauth);
> return 0;
> +#endif
> } else if ((s = qemu_chr_find(protocol)) != NULL) {
> int fd = monitor_get_fd(mon, fdname);
> if (qemu_chr_add_client(s, fd) < 0) {
>
> --
> Boris Dolgov.
Boris,
Does QEMU upstream suffer from the same problem? If so, it should be
fixed there (patch sent to qemu-devel@nongnu.org).
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] qemu-kvm: Fix build without VNC support
2011-09-14 11:16 ` Marcelo Tosatti
@ 2011-09-14 14:18 ` Boris Dolgov
0 siblings, 0 replies; 3+ messages in thread
From: Boris Dolgov @ 2011-09-14 14:18 UTC (permalink / raw)
To: Marcelo Tosatti; +Cc: kvm
On Wed, Sep 14, 2011 at 15:16, Marcelo Tosatti <mtosatti@redhat.com> wrote:
> Does QEMU upstream suffer from the same problem? If so, it should be
> fixed there (patch sent to qemu-devel@nongnu.org).
Yes, it is. I have sent the patch to the correct maillist, thanks for your help.
--
Boris Dolgov.
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2011-09-14 14:22 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2011-09-13 13:13 [PATCH] qemu-kvm: Fix build without VNC support Boris Dolgov
2011-09-14 11:16 ` Marcelo Tosatti
2011-09-14 14:18 ` Boris Dolgov
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.