* GRUB stdint.h is "leaky"
@ 2016-11-30 15:42 Bjørn Forsman
2016-11-30 16:54 ` Andrei Borzenkov
0 siblings, 1 reply; 3+ messages in thread
From: Bjørn Forsman @ 2016-11-30 15:42 UTC (permalink / raw)
To: The development of GNU GRUB
Hi all,
I noticed that grub-core/lib/posix_wrap/stdint.h leaks symbols. It
pulls in <sys/types.h>, which in turn pulls in <grub/misc.h>. And that
is how we end up with symbols like "grub_printf" from stdint.h.
That's not what I'd expect :-)
Best regards,
Bjørn Forsman
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: GRUB stdint.h is "leaky"
2016-11-30 15:42 GRUB stdint.h is "leaky" Bjørn Forsman
@ 2016-11-30 16:54 ` Andrei Borzenkov
2016-11-30 17:46 ` Bjørn Forsman
0 siblings, 1 reply; 3+ messages in thread
From: Andrei Borzenkov @ 2016-11-30 16:54 UTC (permalink / raw)
To: grub-devel
30.11.2016 18:42, Bjørn Forsman пишет:
> Hi all,
>
> I noticed that grub-core/lib/posix_wrap/stdint.h leaks symbols. It
> pulls in <sys/types.h>, which in turn pulls in <grub/misc.h>. And that
> is how we end up with symbols like "grub_printf" from stdint.h.
>
What exact problem does it cause?
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: GRUB stdint.h is "leaky"
2016-11-30 16:54 ` Andrei Borzenkov
@ 2016-11-30 17:46 ` Bjørn Forsman
0 siblings, 0 replies; 3+ messages in thread
From: Bjørn Forsman @ 2016-11-30 17:46 UTC (permalink / raw)
To: The development of GNU GRUB
On 30 November 2016 at 17:54, Andrei Borzenkov <arvidjaar@gmail.com> wrote:
> 30.11.2016 18:42, Bjørn Forsman пишет:
>> Hi all,
>>
>> I noticed that grub-core/lib/posix_wrap/stdint.h leaks symbols. It
>> pulls in <sys/types.h>, which in turn pulls in <grub/misc.h>. And that
>> is how we end up with symbols like "grub_printf" from stdint.h.
>
> What exact problem does it cause?
It just feels sloppy. I was purging some dependencies from a source
file and thought I had fixed it all (by only depending on <stdint.h>),
but later found out I had some "grub_printf" in there even though I
didn't pull in any GRUB headers. In other words, it makes writing code
which cares for it's dependencies more error prone.
Best regards,
Bjørn Forsman
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2016-11-30 17:47 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2016-11-30 15:42 GRUB stdint.h is "leaky" Bjørn Forsman
2016-11-30 16:54 ` Andrei Borzenkov
2016-11-30 17:46 ` Bjørn Forsman
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.