[PATCH] serial: 8250_dw: fix 'cts-override'

[PATCH] serial: 8250_dw: fix 'cts-override'

[Dmitry Torokhov]

We are dealing with CTS, not DSR here (we dealt with DSR a few lines
above), so set appropriate bits.

Reported-by: Kevin Cernekee <cernekee@chromium.org>
Signed-off-by: Dmitry Torokhov <dtor@chromium.org>
---
 drivers/tty/serial/8250/8250_dw.c | 6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)

diff --git a/drivers/tty/serial/8250/8250_dw.c b/drivers/tty/serial/8250/8250_dw.c
index 2ab229d..eb0a511 100644
--- a/drivers/tty/serial/8250/8250_dw.c
+++ b/drivers/tty/serial/8250/8250_dw.c
@@ -355,9 +355,9 @@ static int dw8250_probe_of(struct uart_port *p,
 	}
 
 	if (of_property_read_bool(np, "cts-override")) {
-		/* Always report DSR as active */
-		data->msr_mask_on |= UART_MSR_DSR;
-		data->msr_mask_off |= UART_MSR_DDSR;
+		/* Always report CTS as active */
+		data->msr_mask_on |= UART_MSR_CTS;
+		data->msr_mask_off |= UART_MSR_DCTS;
 	}
 
 	if (of_property_read_bool(np, "ri-override")) {
-- 
2.2.0.rc0.207.ga3a616c


-- 
Dmitry

Re: [PATCH] serial: 8250_dw: fix 'cts-override'

[Greg Kroah-Hartman]

On Mon, Mar 09, 2015 at 05:37:31PM -0700, Dmitry Torokhov wrote:
> We are dealing with CTS, not DSR here (we dealt with DSR a few lines
> above), so set appropriate bits.
> 
> Reported-by: Kevin Cernekee <cernekee@chromium.org>
> Signed-off-by: Dmitry Torokhov <dtor@chromium.org>
> ---
>  drivers/tty/serial/8250/8250_dw.c | 6 +++---
>  1 file changed, 3 insertions(+), 3 deletions(-)

Should this go into 4.0-final, or can it wait for 4.1-rc1?
I'm guessing 4.0-final, but want to make sure.

thanks,

greg k-h

Re: [PATCH] serial: 8250_dw: fix 'cts-override'

[Dmitry Torokhov]

Hi Greg,

On Wed, Mar 11, 2015 at 6:00 AM, Greg Kroah-Hartman
<gregkh@linuxfoundation.org> wrote:
> On Mon, Mar 09, 2015 at 05:37:31PM -0700, Dmitry Torokhov wrote:
>> We are dealing with CTS, not DSR here (we dealt with DSR a few lines
>> above), so set appropriate bits.
>>
>> Reported-by: Kevin Cernekee <cernekee@chromium.org>
>> Signed-off-by: Dmitry Torokhov <dtor@chromium.org>
>> ---
>>  drivers/tty/serial/8250/8250_dw.c | 6 +++---
>>  1 file changed, 3 insertions(+), 3 deletions(-)
>
> Should this go into 4.0-final, or can it wait for 4.1-rc1?
> I'm guessing 4.0-final, but want to make sure.

I'd like to have it in 4.0 but since there are no users of the feature
in mainline yet I think it can wait.

Thanks,
Dmitry

Re: [PATCH] serial: 8250_dw: fix 'cts-override'

[Dmitry Torokhov]

Hi Greg,

On Wed, Mar 11, 2015 at 10:25 AM, Dmitry Torokhov <dtor@chromium.org> wrote:
> Hi Greg,
>
> On Wed, Mar 11, 2015 at 6:00 AM, Greg Kroah-Hartman
> <gregkh@linuxfoundation.org> wrote:
>> On Mon, Mar 09, 2015 at 05:37:31PM -0700, Dmitry Torokhov wrote:
>>> We are dealing with CTS, not DSR here (we dealt with DSR a few lines
>>> above), so set appropriate bits.
>>>
>>> Reported-by: Kevin Cernekee <cernekee@chromium.org>
>>> Signed-off-by: Dmitry Torokhov <dtor@chromium.org>
>>> ---
>>>  drivers/tty/serial/8250/8250_dw.c | 6 +++---
>>>  1 file changed, 3 insertions(+), 3 deletions(-)
>>
>> Should this go into 4.0-final, or can it wait for 4.1-rc1?
>> I'm guessing 4.0-final, but want to make sure.
>
> I'd like to have it in 4.0 but since there are no users of the feature
> in mainline yet I think it can wait.
>

Could you please pick it for 4.1?

Thanks,
Dmitry

Re: [PATCH] serial: 8250_dw: fix 'cts-override'

[Greg Kroah-Hartman]

On Fri, Mar 20, 2015 at 11:00:43AM -0700, Dmitry Torokhov wrote:
> Hi Greg,
> 
> On Wed, Mar 11, 2015 at 10:25 AM, Dmitry Torokhov <dtor@chromium.org> wrote:
> > Hi Greg,
> >
> > On Wed, Mar 11, 2015 at 6:00 AM, Greg Kroah-Hartman
> > <gregkh@linuxfoundation.org> wrote:
> >> On Mon, Mar 09, 2015 at 05:37:31PM -0700, Dmitry Torokhov wrote:
> >>> We are dealing with CTS, not DSR here (we dealt with DSR a few lines
> >>> above), so set appropriate bits.
> >>>
> >>> Reported-by: Kevin Cernekee <cernekee@chromium.org>
> >>> Signed-off-by: Dmitry Torokhov <dtor@chromium.org>
> >>> ---
> >>>  drivers/tty/serial/8250/8250_dw.c | 6 +++---
> >>>  1 file changed, 3 insertions(+), 3 deletions(-)
> >>
> >> Should this go into 4.0-final, or can it wait for 4.1-rc1?
> >> I'm guessing 4.0-final, but want to make sure.
> >
> > I'd like to have it in 4.0 but since there are no users of the feature
> > in mainline yet I think it can wait.
> >
> 
> Could you please pick it for 4.1?

Will do, thanks.

greg k-h