All of lore.kernel.org
 help / color / mirror / Atom feed
From: Frank Chang <frank.chang@sifive.com>
To: Richard Henderson <richard.henderson@linaro.org>
Cc: "open list:RISC-V" <qemu-riscv@nongnu.org>,
	Sagar Karandikar <sagark@eecs.berkeley.edu>,
	Bastian Koppelmann <kbastian@mail.uni-paderborn.de>,
	"qemu-devel@nongnu.org Developers" <qemu-devel@nongnu.org>,
	Alistair Francis <Alistair.Francis@wdc.com>,
	Palmer Dabbelt <palmer@dabbelt.com>
Subject: Re: [PATCH] target/riscv: fix TB_FLAGS bits overlapping bug for rvv/rvh
Date: Sat, 20 Feb 2021 13:14:09 +0800	[thread overview]
Message-ID: <CAE_xrPgyccR9QnoR-Rc7R=gq8vSvOEWZv1U4XAFbO80_ncQUuw@mail.gmail.com> (raw)
In-Reply-To: <3cd7260d-4c09-696c-6a8d-0a74920adcdd@linaro.org>

[-- Attachment #1: Type: text/plain, Size: 478 bytes --]

On Sat, Feb 20, 2021 at 12:12 AM Richard Henderson <
richard.henderson@linaro.org> wrote:

> On 2/19/21 1:59 AM, frank.chang@sifive.com wrote:
> > +/* Skip mem_idx bits */
> > +FIELD(TB_FLAGS, VL_EQ_VLMAX, 3, 1)
>
> Why not just add the mem_idx field to the list?
>
> The separation between the FIELDs and TB_FLAG_*_MASK is unfortunate, and
> will
> be a continuing source of errors.
>
>
Sure, I will edit it and send out the next version patch.

Thanks,
Frank Chang


>
> r~
>

[-- Attachment #2: Type: text/html, Size: 1045 bytes --]

WARNING: multiple messages have this Message-ID (diff)
From: Frank Chang <frank.chang@sifive.com>
To: Richard Henderson <richard.henderson@linaro.org>
Cc: "qemu-devel@nongnu.org Developers" <qemu-devel@nongnu.org>,
	"open list:RISC-V" <qemu-riscv@nongnu.org>,
	 Alistair Francis <Alistair.Francis@wdc.com>,
	Palmer Dabbelt <palmer@dabbelt.com>,
	 Sagar Karandikar <sagark@eecs.berkeley.edu>,
	 Bastian Koppelmann <kbastian@mail.uni-paderborn.de>
Subject: Re: [PATCH] target/riscv: fix TB_FLAGS bits overlapping bug for rvv/rvh
Date: Sat, 20 Feb 2021 13:14:09 +0800	[thread overview]
Message-ID: <CAE_xrPgyccR9QnoR-Rc7R=gq8vSvOEWZv1U4XAFbO80_ncQUuw@mail.gmail.com> (raw)
In-Reply-To: <3cd7260d-4c09-696c-6a8d-0a74920adcdd@linaro.org>

[-- Attachment #1: Type: text/plain, Size: 478 bytes --]

On Sat, Feb 20, 2021 at 12:12 AM Richard Henderson <
richard.henderson@linaro.org> wrote:

> On 2/19/21 1:59 AM, frank.chang@sifive.com wrote:
> > +/* Skip mem_idx bits */
> > +FIELD(TB_FLAGS, VL_EQ_VLMAX, 3, 1)
>
> Why not just add the mem_idx field to the list?
>
> The separation between the FIELDs and TB_FLAG_*_MASK is unfortunate, and
> will
> be a continuing source of errors.
>
>
Sure, I will edit it and send out the next version patch.

Thanks,
Frank Chang


>
> r~
>

[-- Attachment #2: Type: text/html, Size: 1045 bytes --]

  reply	other threads:[~2021-02-20  5:15 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-02-19  9:59 [PATCH] target/riscv: fix TB_FLAGS bits overlapping bug for rvv/rvh frank.chang
2021-02-19  9:59 ` frank.chang
2021-02-19 16:11 ` Richard Henderson
2021-02-19 16:11   ` Richard Henderson
2021-02-20  5:14   ` Frank Chang [this message]
2021-02-20  5:14     ` Frank Chang

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to='CAE_xrPgyccR9QnoR-Rc7R=gq8vSvOEWZv1U4XAFbO80_ncQUuw@mail.gmail.com' \
    --to=frank.chang@sifive.com \
    --cc=Alistair.Francis@wdc.com \
    --cc=kbastian@mail.uni-paderborn.de \
    --cc=palmer@dabbelt.com \
    --cc=qemu-devel@nongnu.org \
    --cc=qemu-riscv@nongnu.org \
    --cc=richard.henderson@linaro.org \
    --cc=sagark@eecs.berkeley.edu \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.