cursor position does not follow output

cursor position does not follow output

[Olaf Hering]

In my testing with a PV guest I notice that the cursor during input
remains at the 24th row. The actual output of the help command for
example lists all possible commands and causes scrolling. If I enter
something the input does not appear at the bottom but at the 24 row.

Where is the code which controls the cursor position?


Olaf

Re: cursor position does not follow output

[Olaf Hering]

On Fri, May 08, Olaf Hering wrote:

> In my testing with a PV guest I notice that the cursor during input
> remains at the 24th row. The actual output of the help command for
> example lists all possible commands and causes scrolling. If I enter
> something the input does not appear at the bottom but at the 24 row.

The output looks like that:


                          GNU GRUB  version 2.02~beta2

   Minimal BASH-like line editing is supported. For the first word, TAB   
   lists possible command completions. Anywhere else TAB lists possible   
   device or file completions.                                            


grub> s
error: can't find command `s'.
grub> s
error: can't find command `s'.
grub> s
error: can't find command `s'.
grub> s
error: can't find command `s'.
grub> s
error: can't find command `s'.
grub> s
error: can't find command `s'.
grub> s
error: can't find command `s'.
grub> s
error:ssssss find command `s'.
error: can't find command `ssss'.'.
grub> 


That is, whatever I do the input appears in the line with all the 'sss'.
Happens within a screen session and with a plain xterm.

Olaf

Re: cursor position does not follow output

[Andrei Borzenkov]

В Fri, 8 May 2015 20:05:51 +0200
Olaf Hering <olaf@aepfle.de> пишет:

> 
> In my testing with a PV guest I notice that the cursor during input
> remains at the 24th row. The actual output of the help command for
> example lists all possible commands and causes scrolling. If I enter
> something the input does not appear at the bottom but at the 24 row.
> 
> Where is the code which controls the cursor position?
> 

If you are using serial output this is in grub-core/term/terminfo.c.

Re: cursor position does not follow output

[Vladimir 'phcoder' Serbinenko]

[-- Attachment #1: Type: text/plain, Size: 1478 bytes --]

What do you use as terminal on host side? Does it support vt100? Can you
enable recoding to see what sequence was sent?
On May 8, 2015 20:09, "Olaf Hering" <olaf@aepfle.de> wrote:

> On Fri, May 08, Olaf Hering wrote:
>
> > In my testing with a PV guest I notice that the cursor during input
> > remains at the 24th row. The actual output of the help command for
> > example lists all possible commands and causes scrolling. If I enter
> > something the input does not appear at the bottom but at the 24 row.
>
> The output looks like that:
>
>
>                           GNU GRUB  version 2.02~beta2
>
>    Minimal BASH-like line editing is supported. For the first word, TAB
>    lists possible command completions. Anywhere else TAB lists possible
>    device or file completions.
>
>
> grub> s
> error: can't find command `s'.
> grub> s
> error: can't find command `s'.
> grub> s
> error: can't find command `s'.
> grub> s
> error: can't find command `s'.
> grub> s
> error: can't find command `s'.
> grub> s
> error: can't find command `s'.
> grub> s
> error: can't find command `s'.
> grub> s
> error:ssssss find command `s'.
> error: can't find command `ssss'.'.
> grub>
>
>
> That is, whatever I do the input appears in the line with all the 'sss'.
> Happens within a screen session and with a plain xterm.
>
> Olaf
>
> _______________________________________________
> Grub-devel mailing list
> Grub-devel@gnu.org
> https://lists.gnu.org/mailman/listinfo/grub-devel
>

[-- Attachment #2: Type: text/html, Size: 2123 bytes --]

Re: cursor position does not follow output

[Olaf Hering]

On Fri, May 08, Olaf Hering wrote:

> Where is the code which controls the cursor position?

Looks like the issue is this forced size:
struct grub_terminfo_output_state grub_console_terminfo_output = {
  .put = put,
  .size = {80, 24}
};

Is grub supposed to do all its scrolling within those margins?
If so that is likely broken.

Olaf

Re: cursor position does not follow output

[Vladimir 'phcoder' Serbinenko]

[-- Attachment #1: Type: text/plain, Size: 754 bytes --]

It's not forced, it's default. Unfortunately there is no way to know
terminal size on xen, so we assume 80x24 size. You cab specify a different
size with terminfo -g parameter
On May 11, 2015 9:52 AM, "Olaf Hering" <olaf@aepfle.de> wrote:

> On Fri, May 08, Olaf Hering wrote:
>
> > Where is the code which controls the cursor position?
>
> Looks like the issue is this forced size:
> struct grub_terminfo_output_state grub_console_terminfo_output = {
>   .put = put,
>   .size = {80, 24}
> };
>
> Is grub supposed to do all its scrolling within those margins?
> If so that is likely broken.
>
> Olaf
>
> _______________________________________________
> Grub-devel mailing list
> Grub-devel@gnu.org
> https://lists.gnu.org/mailman/listinfo/grub-devel
>

[-- Attachment #2: Type: text/html, Size: 1186 bytes --]

Re: cursor position does not follow output

[Olaf Hering]

On Mon, May 11, Vladimir 'phcoder' Serbinenko wrote:

> It's not forced, it's default. Unfortunately there is no way to know terminal
> size on xen, so we assume 80x24 size.

In the environment where grub runs doing a query for the terminal size
should be reliable. I will see if whatever initviocons does can be
ported to grub.

> You cab specify a different size with terminfo -g parameter

Does that cmd actually work for you? With 'terminfo -g 200x50'
grub_cmd_terminfo gets called with argc == 0.

Olaf

Re: cursor position does not follow output

[Olaf Hering]

On Mon, May 11, Olaf Hering wrote:

> Does that cmd actually work for you? With 'terminfo -g 200x50'
> grub_cmd_terminfo gets called with argc == 0.

I misunderstodd the cmd syntax, its like:

        if [ -n "${rows}" -a -n "${columns}" ];then
        terminfo -g ${rows}x${columns} console
        fi

Now it works if booted with domU.cfg like:
        kernel = "/path/to/grub.xen"
        extra = "rows=263 columns=64"

Olaf