Re: [PATCH net-next 1/1] tc-testing: initial version of tunnel_key unit tests

From: Keara Leibovitz <kleib@mojatatu.com>
To: Davide Caratti <dcaratti@redhat.com>
Cc: Lucas Bates <lucasb@mojatatu.com>,
	David Miller <davem@davemloft.net>,
	Linux Kernel Network Developers <netdev@vger.kernel.org>,
	Jamal Hadi Salim <jhs@mojatatu.com>,
	Cong Wang <xiyou.wangcong@gmail.com>,
	Jiri Pirko <jiri@resnulli.us>
Subject: Re: [PATCH net-next 1/1] tc-testing: initial version of tunnel_key unit tests
Date: Thu, 28 Jun 2018 15:58:11 -0400	[thread overview]
Message-ID: <CAEbXskW8g-pnXCfo+7yy0c912UaVH0yE7Nb88W+B3KFGqyEtUA@mail.gmail.com> (raw)
In-Reply-To: <2ebd38dd2f1772b73f53cb5ea6c562652bb127bb.camel@redhat.com>

>> Until I'm able to submit everything, I'd be OK with having Keara add
>> the non-zero exit codes to the teardown on her tests.  In the meantime
>> we'll get the README updated and config file added as well.
>>
>> How does this sound?
>
> it sounds good to me, but at this point we can also leave the code of
> tunnel_key as-is. there are many other items failing in this script:
>
> for act in $ACT; do
> while IFS=':' read -r id _ ; do modprobe -r act_${act} ; sleep 1 ; [ -n "$id" ] && ./tdc.py -p /home/davide/iproute2/tc/tc -e $id ; done <<EOF
> `./tdc.py -l | grep ${act}`
> EOF
> done
>
> So, it's ok for me if they are fixed all together in a series, and I
> volunteer for testing it when they land on netdev list.

Hi Davide,

I will add the non-zero exit codes and resubmit version 2 tomorrow.

Keara