* [PATCH] nds32: vdso: drop unnecessary cc-ldoption
@ 2019-04-23 21:19 Nick Desaulniers
2019-04-24 6:56 ` Greentime Hu
0 siblings, 1 reply; 4+ messages in thread
From: Nick Desaulniers @ 2019-04-23 21:19 UTC (permalink / raw)
To: green.hu, deanbo422
Cc: Nick Desaulniers, clang-built-linux, Masahiro Yamada, linux-kernel
Towards the goal of removing cc-ldoption, it seems that --hash-style=
was added to binutils 2.17.50.0.2 in 2006. The minimal required version
of binutils for the kernel according to
Documentation/process/changes.rst is 2.20.
Link: https://gcc.gnu.org/ml/gcc/2007-01/msg01141.html
Cc: clang-built-linux@googlegroups.com
Suggested-by: Masahiro Yamada <yamada.masahiro@socionext.com>
Signed-off-by: Nick Desaulniers <ndesaulniers@google.com>
---
arch/nds32/kernel/vdso/Makefile | 6 ++----
1 file changed, 2 insertions(+), 4 deletions(-)
diff --git a/arch/nds32/kernel/vdso/Makefile b/arch/nds32/kernel/vdso/Makefile
index e6c50a701313..d379645cad74 100644
--- a/arch/nds32/kernel/vdso/Makefile
+++ b/arch/nds32/kernel/vdso/Makefile
@@ -11,10 +11,8 @@ obj-vdso := note.o datapage.o sigreturn.o gettimeofday.o
targets := $(obj-vdso) vdso.so vdso.so.dbg
obj-vdso := $(addprefix $(obj)/, $(obj-vdso))
-ccflags-y := -shared -fno-common -fno-builtin
-ccflags-y += -nostdlib -Wl,-soname=linux-vdso.so.1 \
- $(call cc-ldoption, -Wl$(comma)--hash-style=sysv)
-ccflags-y += -fPIC -Wl,-shared -g
+ccflags-y := -shared -fno-common -fno-builtin -nostdlib -fPIC -Wl,-shared -g \
+ -Wl,-soname=linux-vdso.so.1 -Wl,--hash-style=sysv
# Disable gcov profiling for VDSO code
GCOV_PROFILE := n
--
2.21.0.593.g511ec345e18-goog
^ permalink raw reply related [flat|nested] 4+ messages in thread
* Re: [PATCH] nds32: vdso: drop unnecessary cc-ldoption
2019-04-23 21:19 [PATCH] nds32: vdso: drop unnecessary cc-ldoption Nick Desaulniers
@ 2019-04-24 6:56 ` Greentime Hu
2019-04-24 7:53 ` Masahiro Yamada
0 siblings, 1 reply; 4+ messages in thread
From: Greentime Hu @ 2019-04-24 6:56 UTC (permalink / raw)
To: Nick Desaulniers
Cc: Vincent Chen, clang-built-linux, Masahiro Yamada,
Linux Kernel Mailing List
Hi Nick & Yamada,
Nick Desaulniers <ndesaulniers@google.com> 於 2019年4月24日 週三 上午5:19寫道:
>
> Towards the goal of removing cc-ldoption, it seems that --hash-style=
> was added to binutils 2.17.50.0.2 in 2006. The minimal required version
> of binutils for the kernel according to
> Documentation/process/changes.rst is 2.20.
>
> Link: https://gcc.gnu.org/ml/gcc/2007-01/msg01141.html
> Cc: clang-built-linux@googlegroups.com
> Suggested-by: Masahiro Yamada <yamada.masahiro@socionext.com>
> Signed-off-by: Nick Desaulniers <ndesaulniers@google.com>
> ---
> arch/nds32/kernel/vdso/Makefile | 6 ++----
> 1 file changed, 2 insertions(+), 4 deletions(-)
>
> diff --git a/arch/nds32/kernel/vdso/Makefile b/arch/nds32/kernel/vdso/Makefile
> index e6c50a701313..d379645cad74 100644
> --- a/arch/nds32/kernel/vdso/Makefile
> +++ b/arch/nds32/kernel/vdso/Makefile
> @@ -11,10 +11,8 @@ obj-vdso := note.o datapage.o sigreturn.o gettimeofday.o
> targets := $(obj-vdso) vdso.so vdso.so.dbg
> obj-vdso := $(addprefix $(obj)/, $(obj-vdso))
>
> -ccflags-y := -shared -fno-common -fno-builtin
> -ccflags-y += -nostdlib -Wl,-soname=linux-vdso.so.1 \
> - $(call cc-ldoption, -Wl$(comma)--hash-style=sysv)
> -ccflags-y += -fPIC -Wl,-shared -g
> +ccflags-y := -shared -fno-common -fno-builtin -nostdlib -fPIC -Wl,-shared -g \
> + -Wl,-soname=linux-vdso.so.1 -Wl,--hash-style=sysv
>
> # Disable gcov profiling for VDSO code
> GCOV_PROFILE := n
Thank you.
Acked-by: Greentime Hu <greentime@andestech.com>
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] nds32: vdso: drop unnecessary cc-ldoption
2019-04-24 6:56 ` Greentime Hu
@ 2019-04-24 7:53 ` Masahiro Yamada
2019-04-24 8:04 ` Greentime Hu
0 siblings, 1 reply; 4+ messages in thread
From: Masahiro Yamada @ 2019-04-24 7:53 UTC (permalink / raw)
To: Greentime Hu
Cc: Nick Desaulniers, Vincent Chen, clang-built-linux,
Linux Kernel Mailing List
On Wed, Apr 24, 2019 at 3:59 PM Greentime Hu <green.hu@gmail.com> wrote:
>
> Hi Nick & Yamada,
>
> Nick Desaulniers <ndesaulniers@google.com> 於 2019年4月24日 週三 上午5:19寫道:
> >
> > Towards the goal of removing cc-ldoption, it seems that --hash-style=
> > was added to binutils 2.17.50.0.2 in 2006. The minimal required version
> > of binutils for the kernel according to
> > Documentation/process/changes.rst is 2.20.
> >
> > Link: https://gcc.gnu.org/ml/gcc/2007-01/msg01141.html
> > Cc: clang-built-linux@googlegroups.com
> > Suggested-by: Masahiro Yamada <yamada.masahiro@socionext.com>
> > Signed-off-by: Nick Desaulniers <ndesaulniers@google.com>
> > ---
> > arch/nds32/kernel/vdso/Makefile | 6 ++----
> > 1 file changed, 2 insertions(+), 4 deletions(-)
> >
> > diff --git a/arch/nds32/kernel/vdso/Makefile b/arch/nds32/kernel/vdso/Makefile
> > index e6c50a701313..d379645cad74 100644
> > --- a/arch/nds32/kernel/vdso/Makefile
> > +++ b/arch/nds32/kernel/vdso/Makefile
> > @@ -11,10 +11,8 @@ obj-vdso := note.o datapage.o sigreturn.o gettimeofday.o
> > targets := $(obj-vdso) vdso.so vdso.so.dbg
> > obj-vdso := $(addprefix $(obj)/, $(obj-vdso))
> >
> > -ccflags-y := -shared -fno-common -fno-builtin
> > -ccflags-y += -nostdlib -Wl,-soname=linux-vdso.so.1 \
> > - $(call cc-ldoption, -Wl$(comma)--hash-style=sysv)
> > -ccflags-y += -fPIC -Wl,-shared -g
> > +ccflags-y := -shared -fno-common -fno-builtin -nostdlib -fPIC -Wl,-shared -g \
> > + -Wl,-soname=linux-vdso.so.1 -Wl,--hash-style=sysv
> >
> > # Disable gcov profiling for VDSO code
> > GCOV_PROFILE := n
>
> Thank you.
> Acked-by: Greentime Hu <greentime@andestech.com>
Who do you expect to pick up this patch?
You are the NDS32 maintainer
according to MAINTAINERS.
ANDES ARCHITECTURE
M: Greentime Hu <green.hu@gmail.com>
M: Vincent Chen <deanbo422@gmail.com>
T: git https://github.com/andestech/linux.git
S: Supported
F: arch/nds32/
F: Documentation/devicetree/bindings/interrupt-controller/andestech,ativic32.txt
F: Documentation/devicetree/bindings/nds32/
K: nds32
N: nds32
You do not maintain https://github.com/andestech/linux.git any more, do you?
--
Best Regards
Masahiro Yamada
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] nds32: vdso: drop unnecessary cc-ldoption
2019-04-24 7:53 ` Masahiro Yamada
@ 2019-04-24 8:04 ` Greentime Hu
0 siblings, 0 replies; 4+ messages in thread
From: Greentime Hu @ 2019-04-24 8:04 UTC (permalink / raw)
To: Masahiro Yamada
Cc: Nick Desaulniers, Vincent Chen, clang-built-linux,
Linux Kernel Mailing List
Masahiro Yamada <yamada.masahiro@socionext.com> 於 2019年4月24日 週三 下午3:54寫道:
>
> On Wed, Apr 24, 2019 at 3:59 PM Greentime Hu <green.hu@gmail.com> wrote:
> >
> > Hi Nick & Yamada,
> >
> > Nick Desaulniers <ndesaulniers@google.com> 於 2019年4月24日 週三 上午5:19寫道:
> > >
> > > Towards the goal of removing cc-ldoption, it seems that --hash-style=
> > > was added to binutils 2.17.50.0.2 in 2006. The minimal required version
> > > of binutils for the kernel according to
> > > Documentation/process/changes.rst is 2.20.
> > >
> > > Link: https://gcc.gnu.org/ml/gcc/2007-01/msg01141.html
> > > Cc: clang-built-linux@googlegroups.com
> > > Suggested-by: Masahiro Yamada <yamada.masahiro@socionext.com>
> > > Signed-off-by: Nick Desaulniers <ndesaulniers@google.com>
> > > ---
> > > arch/nds32/kernel/vdso/Makefile | 6 ++----
> > > 1 file changed, 2 insertions(+), 4 deletions(-)
> > >
> > > diff --git a/arch/nds32/kernel/vdso/Makefile b/arch/nds32/kernel/vdso/Makefile
> > > index e6c50a701313..d379645cad74 100644
> > > --- a/arch/nds32/kernel/vdso/Makefile
> > > +++ b/arch/nds32/kernel/vdso/Makefile
> > > @@ -11,10 +11,8 @@ obj-vdso := note.o datapage.o sigreturn.o gettimeofday.o
> > > targets := $(obj-vdso) vdso.so vdso.so.dbg
> > > obj-vdso := $(addprefix $(obj)/, $(obj-vdso))
> > >
> > > -ccflags-y := -shared -fno-common -fno-builtin
> > > -ccflags-y += -nostdlib -Wl,-soname=linux-vdso.so.1 \
> > > - $(call cc-ldoption, -Wl$(comma)--hash-style=sysv)
> > > -ccflags-y += -fPIC -Wl,-shared -g
> > > +ccflags-y := -shared -fno-common -fno-builtin -nostdlib -fPIC -Wl,-shared -g \
> > > + -Wl,-soname=linux-vdso.so.1 -Wl,--hash-style=sysv
> > >
> > > # Disable gcov profiling for VDSO code
> > > GCOV_PROFILE := n
> >
> > Thank you.
> > Acked-by: Greentime Hu <greentime@andestech.com>
>
>
> Who do you expect to pick up this patch?
>
> You are the NDS32 maintainer
> according to MAINTAINERS.
>
>
> ANDES ARCHITECTURE
> M: Greentime Hu <green.hu@gmail.com>
> M: Vincent Chen <deanbo422@gmail.com>
> T: git https://github.com/andestech/linux.git
> S: Supported
> F: arch/nds32/
> F: Documentation/devicetree/bindings/interrupt-controller/andestech,ativic32.txt
> F: Documentation/devicetree/bindings/nds32/
> K: nds32
> N: nds32
>
>
> You do not maintain https://github.com/andestech/linux.git any more, do you?
Hi Yamada,
I think I should update this MAINTAINERS file.
I will pick it in this repo
https://git.kernel.org/pub/scm/linux/kernel/git/greentime/linux.git
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2019-04-24 8:04 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2019-04-23 21:19 [PATCH] nds32: vdso: drop unnecessary cc-ldoption Nick Desaulniers
2019-04-24 6:56 ` Greentime Hu
2019-04-24 7:53 ` Masahiro Yamada
2019-04-24 8:04 ` Greentime Hu
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.