All of lore.kernel.org
 help / color / mirror / Atom feed
* [bisected] semctl/shmctl/msgctl broken on sparc64
@ 2019-09-03  5:02 Matt Turner
  2019-09-05 15:25 ` Arnd Bergmann
  0 siblings, 1 reply; 2+ messages in thread
From: Matt Turner @ 2019-09-03  5:02 UTC (permalink / raw)
  To: sparclinux

Hi Arnd,

The following commit breaks the semctl/shmctl/msgctl syscalls on
64-bit sparc userland (but not on 32-bit sparc userland)

commit 275f22148e8720e84b180d9e0cdf8abfd69bac5b
Author: Arnd Bergmann <arnd@arndb.de>
Date:   Mon Dec 31 22:22:40 2018 +0100

    ipc: rename old-style shmctl/semctl/msgctl syscalls

The LTP test case semctl01 can quickly reproduce the failure, but I
initially noticed this failure in the Perl test suite. Looks like the
syscalls always return EINVAL now. Funny, the commit doesn't even
touch arch/sparc :)

arch/sparc/include/uapi/asm/unistd.h
    Defines __32bit_syscall_numbers__ if __arch64__

arch/sparc/include/asm/unistd.h
    Includes arch/sparc/include/uapi/asm/unistd.h
    Defines __ARCH_WANT_SYS_IPC if __32bit_syscall_numbers__

ipc/syscall.c
    Looks like it defines different paths for __ARCH_WANT_SYS_IPC vs not

I get lost at this point, but I'm guessing that's where the difference
between 32-bit and 64-bit comes from.

Any ideas? I'm happy to test patches.

Thanks,
Matt

^ permalink raw reply	[flat|nested] 2+ messages in thread

* Re: [bisected] semctl/shmctl/msgctl broken on sparc64
  2019-09-03  5:02 [bisected] semctl/shmctl/msgctl broken on sparc64 Matt Turner
@ 2019-09-05 15:25 ` Arnd Bergmann
  0 siblings, 0 replies; 2+ messages in thread
From: Arnd Bergmann @ 2019-09-05 15:25 UTC (permalink / raw)
  To: sparclinux

On Tue, Sep 3, 2019 at 7:02 AM Matt Turner <mattst88@gmail.com> wrote:
>
>
> arch/sparc/include/uapi/asm/unistd.h
>     Defines __32bit_syscall_numbers__ if __arch64__
>
> arch/sparc/include/asm/unistd.h
>     Includes arch/sparc/include/uapi/asm/unistd.h
>     Defines __ARCH_WANT_SYS_IPC if __32bit_syscall_numbers__
>
> ipc/syscall.c
>     Looks like it defines different paths for __ARCH_WANT_SYS_IPC vs not
>
> I get lost at this point, but I'm guessing that's where the difference
> between 32-bit and 64-bit comes from.
>
> Any ideas? I'm happy to test patches.

I found the issue and sent a patch now, see
https://lore.kernel.org/lkml/20190905152155.1392871-2-arnd@arndb.de/

     Arnd

^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2019-09-05 15:25 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2019-09-03  5:02 [bisected] semctl/shmctl/msgctl broken on sparc64 Matt Turner
2019-09-05 15:25 ` Arnd Bergmann

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.