* [LTP] [PATCH 1/1] lib/tests: Remove tst_fuzzy_sync02
@ 2021-08-31 12:12 Petr Vorel
2021-08-31 12:29 ` Cyril Hrubis
` (2 more replies)
0 siblings, 3 replies; 5+ messages in thread
From: Petr Vorel @ 2021-08-31 12:12 UTC (permalink / raw)
To: ltp
tst_fuzzy_sync02 is not stable enough [1]:
../../include/tst_fuzzy_sync.h:346: TINFO: loop = 10001, delay_bias = 3960
../../include/tst_fuzzy_sync.h:335: TINFO: start_a - start_b: { avg = -8859ns, avg_dev = 66ns, dev_ratio = 0.01 }
../../include/tst_fuzzy_sync.h:335: TINFO: end_a - start_a : { avg = 17160ns, avg_dev = 85ns, dev_ratio = 0.00 }
../../include/tst_fuzzy_sync.h:335: TINFO: end_b - start_b : { avg = 18474ns, avg_dev = 55ns, dev_ratio = 0.00 }
../../include/tst_fuzzy_sync.h:335: TINFO: end_a - end_b : { avg = -10173ns, avg_dev = 124ns, dev_ratio = 0.01 }
../../include/tst_fuzzy_sync.h:335: TINFO: spins : { avg = 2751 , avg_dev = 31 , dev_ratio = 0.01 }
../../include/tst_fuzzy_sync.h:685: TINFO: Exceeded execution loops, requesting exit
tst_fuzzy_sync02.c:169: TFAIL: 2| =:48
...
runtest TINFO: === C TEST RESULTS ===
...
runtest TINFO: 1x TFAIL: tst_fuzzy_sync02
Both tst_fuzzy_sync0{1,2} occasionally fails (restart helps). But
tst_fuzzy_sync03 is stable thus we have at least smoke test for fuzzy
sync.
[1] https://github.com/linux-test-project/ltp/runs/3471271675
Signed-off-by: Petr Vorel <pvorel@suse.cz>
---
lib/newlib_tests/runtest.sh | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/lib/newlib_tests/runtest.sh b/lib/newlib_tests/runtest.sh
index 70fbffb6c..05c76228b 100755
--- a/lib/newlib_tests/runtest.sh
+++ b/lib/newlib_tests/runtest.sh
@@ -2,8 +2,8 @@
# Copyright (c) 2021 Petr Vorel <pvorel@suse.cz>
LTP_C_API_TESTS="${LTP_C_API_TESTS:-test05 test07 test09 test12 test15 test18
-tst_bool_expr test_exec test_timer tst_res_hexd tst_strstatus tst_fuzzy_sync02
-tst_fuzzy_sync03 test_zero_hugepage.sh}"
+tst_bool_expr test_exec test_timer tst_res_hexd tst_strstatus tst_fuzzy_sync03
+test_zero_hugepage.sh}"
LTP_SHELL_API_TESTS="${LTP_SHELL_API_TESTS:-shell/tst_check_driver.sh shell/net/*.sh}"
--
2.33.0
^ permalink raw reply related [flat|nested] 5+ messages in thread
* [LTP] [PATCH 1/1] lib/tests: Remove tst_fuzzy_sync02
2021-08-31 12:12 [LTP] [PATCH 1/1] lib/tests: Remove tst_fuzzy_sync02 Petr Vorel
@ 2021-08-31 12:29 ` Cyril Hrubis
2021-08-31 12:35 ` Richard Palethorpe
2021-08-31 12:43 ` Li Wang
2 siblings, 0 replies; 5+ messages in thread
From: Cyril Hrubis @ 2021-08-31 12:29 UTC (permalink / raw)
To: ltp
Hi!
Sounds good to me:
Reviewed-by: Cyril Hrubis <chrubis@suse.cz>
--
Cyril Hrubis
chrubis@suse.cz
^ permalink raw reply [flat|nested] 5+ messages in thread
* [LTP] [PATCH 1/1] lib/tests: Remove tst_fuzzy_sync02
2021-08-31 12:12 [LTP] [PATCH 1/1] lib/tests: Remove tst_fuzzy_sync02 Petr Vorel
2021-08-31 12:29 ` Cyril Hrubis
@ 2021-08-31 12:35 ` Richard Palethorpe
2021-08-31 12:43 ` Li Wang
2 siblings, 0 replies; 5+ messages in thread
From: Richard Palethorpe @ 2021-08-31 12:35 UTC (permalink / raw)
To: ltp
Hello Petr,
Petr Vorel <pvorel@suse.cz> writes:
> tst_fuzzy_sync02 is not stable enough [1]:
>
> ../../include/tst_fuzzy_sync.h:346: TINFO: loop = 10001, delay_bias = 3960
> ../../include/tst_fuzzy_sync.h:335: TINFO: start_a - start_b: { avg = -8859ns, avg_dev = 66ns, dev_ratio = 0.01 }
> ../../include/tst_fuzzy_sync.h:335: TINFO: end_a - start_a : { avg = 17160ns, avg_dev = 85ns, dev_ratio = 0.00 }
> ../../include/tst_fuzzy_sync.h:335: TINFO: end_b - start_b : { avg = 18474ns, avg_dev = 55ns, dev_ratio = 0.00 }
> ../../include/tst_fuzzy_sync.h:335: TINFO: end_a - end_b : { avg = -10173ns, avg_dev = 124ns, dev_ratio = 0.01 }
> ../../include/tst_fuzzy_sync.h:335: TINFO: spins : { avg = 2751 , avg_dev = 31 , dev_ratio = 0.01 }
> ../../include/tst_fuzzy_sync.h:685: TINFO: Exceeded execution loops, requesting exit
> tst_fuzzy_sync02.c:169: TFAIL: 2| =:48
> ...
> runtest TINFO: === C TEST RESULTS ===
> ...
> runtest TINFO: 1x TFAIL: tst_fuzzy_sync02
>
> Both tst_fuzzy_sync0{1,2} occasionally fails (restart helps). But
> tst_fuzzy_sync03 is stable thus we have at least smoke test for fuzzy
> sync.
Yes, there is probably some work to do on the algorithm itself. At least
to make it stable in this kind of environment.
Reviewed-by: Richard Palethorpe <rpalethorpe@suse.com>
--
Thank you,
Richard.
^ permalink raw reply [flat|nested] 5+ messages in thread
* [LTP] [PATCH 1/1] lib/tests: Remove tst_fuzzy_sync02
2021-08-31 12:12 [LTP] [PATCH 1/1] lib/tests: Remove tst_fuzzy_sync02 Petr Vorel
2021-08-31 12:29 ` Cyril Hrubis
2021-08-31 12:35 ` Richard Palethorpe
@ 2021-08-31 12:43 ` Li Wang
2021-08-31 12:54 ` Petr Vorel
2 siblings, 1 reply; 5+ messages in thread
From: Li Wang @ 2021-08-31 12:43 UTC (permalink / raw)
To: ltp
Hi Petr,
I have no objection to disable it too.
Reviewed-by: Li Wang <liwang@redhat.com>
--
Regards,
Li Wang
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.linux.it/pipermail/ltp/attachments/20210831/fb25f87a/attachment-0001.htm>
^ permalink raw reply [flat|nested] 5+ messages in thread
* [LTP] [PATCH 1/1] lib/tests: Remove tst_fuzzy_sync02
2021-08-31 12:43 ` Li Wang
@ 2021-08-31 12:54 ` Petr Vorel
0 siblings, 0 replies; 5+ messages in thread
From: Petr Vorel @ 2021-08-31 12:54 UTC (permalink / raw)
To: ltp
Hi all,
thanks, merged!
Kind regards,
Petr
^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2021-08-31 12:54 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-08-31 12:12 [LTP] [PATCH 1/1] lib/tests: Remove tst_fuzzy_sync02 Petr Vorel
2021-08-31 12:29 ` Cyril Hrubis
2021-08-31 12:35 ` Richard Palethorpe
2021-08-31 12:43 ` Li Wang
2021-08-31 12:54 ` Petr Vorel
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.