All of lore.kernel.org
 help / color / mirror / Atom feed
* [LTP] [PATCH 1/1] doc: Document .min_cpus
@ 2020-12-07 14:56 Petr Vorel
  2020-12-08  2:44 ` Li Wang
  0 siblings, 1 reply; 5+ messages in thread
From: Petr Vorel @ 2020-12-07 14:56 UTC (permalink / raw)
  To: ltp

Recently added (in fa32a727d).

Signed-off-by: Petr Vorel <pvorel@suse.cz>
---
Feel free to document it more.

Kind regards,
Petr

 doc/test-writing-guidelines.txt | 8 +++++++-
 1 file changed, 7 insertions(+), 1 deletion(-)

diff --git a/doc/test-writing-guidelines.txt b/doc/test-writing-guidelines.txt
index 3c2ab7166..dcb5d9d43 100644
--- a/doc/test-writing-guidelines.txt
+++ b/doc/test-writing-guidelines.txt
@@ -2134,8 +2134,14 @@ struct tst_test test = {
 	.test_all = run,
 	...
 };
-
 -------------------------------------------------------------------------------
+
+2.2.37 Require minimum numbers of CPU for a testcase
+^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
+
+Some tests require more than single CPU. It can be defined with
+`.min_cpus = N`.
+
 2.3 Writing a testcase in shell
 ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
 
-- 
2.29.2


^ permalink raw reply related	[flat|nested] 5+ messages in thread

* [LTP] [PATCH 1/1] doc: Document .min_cpus
  2020-12-07 14:56 [LTP] [PATCH 1/1] doc: Document .min_cpus Petr Vorel
@ 2020-12-08  2:44 ` Li Wang
  2020-12-08  6:44   ` Petr Vorel
  0 siblings, 1 reply; 5+ messages in thread
From: Li Wang @ 2020-12-08  2:44 UTC (permalink / raw)
  To: ltp

Hi Petr,

I didn't write down this since I thought it's easy to understand the
.min_cpus.
(sounds like an excuse to mask my lazy :)
But it's nice to have, thanks for writing this!

Just a minor comment below.

On Mon, Dec 7, 2020 at 10:56 PM Petr Vorel <pvorel@suse.cz> wrote:

> Recently added (in fa32a727d).
>
> Signed-off-by: Petr Vorel <pvorel@suse.cz>
>
Acked-by: Li Wang <liwang@redhat.com>


> ---
> Feel free to document it more.
>
> Kind regards,
> Petr
>
>  doc/test-writing-guidelines.txt | 8 +++++++-
>  1 file changed, 7 insertions(+), 1 deletion(-)
>
> diff --git a/doc/test-writing-guidelines.txt
> b/doc/test-writing-guidelines.txt
> index 3c2ab7166..dcb5d9d43 100644
> --- a/doc/test-writing-guidelines.txt
> +++ b/doc/test-writing-guidelines.txt
> @@ -2134,8 +2134,14 @@ struct tst_test test = {
>         .test_all = run,
>         ...
>  };
> -
>
>  -------------------------------------------------------------------------------
> +
> +2.2.37 Require minimum numbers of CPU for a testcase
> +^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
> +
> +Some tests require more than single CPU. It can be defined with
>

single --> specific number of



> +`.min_cpus = N`.
> +
>  2.3 Writing a testcase in shell
>  ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
>
> --
> 2.29.2
>
>

-- 
Regards,
Li Wang
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.linux.it/pipermail/ltp/attachments/20201208/afc8b782/attachment-0001.htm>

^ permalink raw reply	[flat|nested] 5+ messages in thread

* [LTP] [PATCH 1/1] doc: Document .min_cpus
  2020-12-08  2:44 ` Li Wang
@ 2020-12-08  6:44   ` Petr Vorel
  2020-12-09  6:24     ` Li Wang
  0 siblings, 1 reply; 5+ messages in thread
From: Petr Vorel @ 2020-12-08  6:44 UTC (permalink / raw)
  To: ltp

Hi Li,

> Hi Petr,

> I didn't write down this since I thought it's easy to understand the
> .min_cpus.
> (sounds like an excuse to mask my lazy :)
I'm lazy to grep library sources, I look into docs :).

> But it's nice to have, thanks for writing this!

> Just a minor comment below.

> On Mon, Dec 7, 2020 at 10:56 PM Petr Vorel <pvorel@suse.cz> wrote:

> > Recently added (in fa32a727d).

> > Signed-off-by: Petr Vorel <pvorel@suse.cz>

> Acked-by: Li Wang <liwang@redhat.com>
Thanks!

...
> > +2.2.37 Require minimum numbers of CPU for a testcase
> > +^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
> > +
> > +Some tests require more than single CPU. It can be defined with


> single --> specific number of

+1

Kind regards,
Petr

^ permalink raw reply	[flat|nested] 5+ messages in thread

* [LTP] [PATCH 1/1] doc: Document .min_cpus
  2020-12-08  6:44   ` Petr Vorel
@ 2020-12-09  6:24     ` Li Wang
  2020-12-09  7:15       ` Petr Vorel
  0 siblings, 1 reply; 5+ messages in thread
From: Li Wang @ 2020-12-09  6:24 UTC (permalink / raw)
  To: ltp

On Tue, Dec 8, 2020 at 2:45 PM Petr Vorel <pvorel@suse.cz> wrote:

> [...]
>
> > single --> specific number of
>
> +1
>

I help to modified and pushed, thanks Petr.

-- 
Regards,
Li Wang
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.linux.it/pipermail/ltp/attachments/20201209/1ebf5a91/attachment.htm>

^ permalink raw reply	[flat|nested] 5+ messages in thread

* [LTP] [PATCH 1/1] doc: Document .min_cpus
  2020-12-09  6:24     ` Li Wang
@ 2020-12-09  7:15       ` Petr Vorel
  0 siblings, 0 replies; 5+ messages in thread
From: Petr Vorel @ 2020-12-09  7:15 UTC (permalink / raw)
  To: ltp

> > > single --> specific number of

> > +1

> I help to modified and pushed, thanks Petr.
Thanks, Li!

Kind regards,
Petr

^ permalink raw reply	[flat|nested] 5+ messages in thread

end of thread, other threads:[~2020-12-09  7:15 UTC | newest]

Thread overview: 5+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-12-07 14:56 [LTP] [PATCH 1/1] doc: Document .min_cpus Petr Vorel
2020-12-08  2:44 ` Li Wang
2020-12-08  6:44   ` Petr Vorel
2020-12-09  6:24     ` Li Wang
2020-12-09  7:15       ` Petr Vorel

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.