All of lore.kernel.org
 help / color / mirror / Atom feed
* [PATCH] btrfs-progs: Update README.md with editorconfig hint
@ 2020-07-31  1:03 Daniel Xu
  2020-07-31  3:40 ` Neal Gompa
  2020-07-31 13:47 ` David Sterba
  0 siblings, 2 replies; 3+ messages in thread
From: Daniel Xu @ 2020-07-31  1:03 UTC (permalink / raw)
  To: linux-btrfs; +Cc: Daniel Xu, kernel-team

Add a helpful hint in the README to encourage contributors to install an
editorconfig plugin. This should help maintain source file consistency
in the long term (eg tabs instead of spaces).

Signed-off-by: Daniel Xu <dxu@dxuuu.xyz>
---
 README.md | 4 ++++
 1 file changed, 4 insertions(+)

diff --git a/README.md b/README.md
index 537c77c5..2d5f360f 100644
--- a/README.md
+++ b/README.md
@@ -82,6 +82,10 @@ the patches meet some criteria (often lacking in github contributions):
     substitute in order to allow contributions without much bothering with
     formalities
 
+btrfs-progs is configured with an `.editorconfig`. Please consider installing an
+[EditorConfig](https://editorconfig.org/) plugin for your text editor to help
+maintain source file format consistency.
+
 Documentation updates
 ---------------------
 
-- 
2.27.0


^ permalink raw reply related	[flat|nested] 3+ messages in thread

* Re: [PATCH] btrfs-progs: Update README.md with editorconfig hint
  2020-07-31  1:03 [PATCH] btrfs-progs: Update README.md with editorconfig hint Daniel Xu
@ 2020-07-31  3:40 ` Neal Gompa
  2020-07-31 13:47 ` David Sterba
  1 sibling, 0 replies; 3+ messages in thread
From: Neal Gompa @ 2020-07-31  3:40 UTC (permalink / raw)
  To: Daniel Xu; +Cc: Btrfs BTRFS, kernel-team

On Thu, Jul 30, 2020 at 9:05 PM Daniel Xu <dxu@dxuuu.xyz> wrote:
>
> Add a helpful hint in the README to encourage contributors to install an
> editorconfig plugin. This should help maintain source file consistency
> in the long term (eg tabs instead of spaces).
>
> Signed-off-by: Daniel Xu <dxu@dxuuu.xyz>
> ---
>  README.md | 4 ++++
>  1 file changed, 4 insertions(+)
>
> diff --git a/README.md b/README.md
> index 537c77c5..2d5f360f 100644
> --- a/README.md
> +++ b/README.md
> @@ -82,6 +82,10 @@ the patches meet some criteria (often lacking in github contributions):
>      substitute in order to allow contributions without much bothering with
>      formalities
>
> +btrfs-progs is configured with an `.editorconfig`. Please consider installing an
> +[EditorConfig](https://editorconfig.org/) plugin for your text editor to help
> +maintain source file format consistency.
> +
>  Documentation updates
>  ---------------------
>
> --
> 2.27.0
>

LGTM.

Reviewed-by: Neal Gompa <ngompa13@gmail.com>

-- 
真実はいつも一つ!/ Always, there's only one truth!

^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: [PATCH] btrfs-progs: Update README.md with editorconfig hint
  2020-07-31  1:03 [PATCH] btrfs-progs: Update README.md with editorconfig hint Daniel Xu
  2020-07-31  3:40 ` Neal Gompa
@ 2020-07-31 13:47 ` David Sterba
  1 sibling, 0 replies; 3+ messages in thread
From: David Sterba @ 2020-07-31 13:47 UTC (permalink / raw)
  To: Daniel Xu; +Cc: linux-btrfs, kernel-team

On Thu, Jul 30, 2020 at 06:03:34PM -0700, Daniel Xu wrote:
> Add a helpful hint in the README to encourage contributors to install an
> editorconfig plugin. This should help maintain source file consistency
> in the long term (eg tabs instead of spaces).
> 
> Signed-off-by: Daniel Xu <dxu@dxuuu.xyz>

Thanks, I've added references to the coding style and reworded the
paragraph a bit.

^ permalink raw reply	[flat|nested] 3+ messages in thread

end of thread, other threads:[~2020-07-31 13:48 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-07-31  1:03 [PATCH] btrfs-progs: Update README.md with editorconfig hint Daniel Xu
2020-07-31  3:40 ` Neal Gompa
2020-07-31 13:47 ` David Sterba

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.