* [Buildroot] [PATCH] package/linux-firmware: Add Qualcomm video firmware option
@ 2018-03-11 21:57 Andre Renaud
2018-03-26 21:32 ` Thomas Petazzoni
0 siblings, 1 reply; 5+ messages in thread
From: Andre Renaud @ 2018-03-11 21:57 UTC (permalink / raw)
To: buildroot
Added Qualcomm video firmware option.
Signed-off-by: Andre Renaud <andre@ignavus.net>
---
package/linux-firmware/Config.in | 5 +++++
package/linux-firmware/linux-firmware.mk | 5 +++++
2 files changed, 10 insertions(+)
diff --git a/package/linux-firmware/Config.in
b/package/linux-firmware/Config.in
index 4e77a3f9a3..61164e101c 100644
--- a/package/linux-firmware/Config.in
+++ b/package/linux-firmware/Config.in
@@ -29,6 +29,11 @@ config BR2_PACKAGE_LINUX_FIRMWARE_RADEON
help
Firmware files for AMD Radeon video cards.
+config BR2_PACKAGE_LINUX_FIRMWARE_QCOM
+ bool "Qualcomm video card firmware"
+ help
+ Firmware files for Qualcomm/Snapdragon video cards.
+
endmenu # Video
menu "Bluetooth firmware"
diff --git a/package/linux-firmware/linux-firmware.mk
b/package/linux-firmware/linux-firmware.mk
index a6fd8ebba4..da106a9941 100644
--- a/package/linux-firmware/linux-firmware.mk
+++ b/package/linux-firmware/linux-firmware.mk
@@ -24,6 +24,11 @@ LINUX_FIRMWARE_DIRS += radeon
LINUX_FIRMWARE_ALL_LICENSE_FILES += LICENSE.radeon
endif
+ifeq ($(BR2_PACKAGE_LINUX_FIRMWARE_QCOM),y)
+LINUX_FIRMWARE_DIRS += qcom
+LINUX_FIRMWARE_ALL_LICENSE_FILES += LICENSE.qcom
+endif
+
# Intel Wireless Bluetooth
ifeq ($(BR2_PACKAGE_LINUX_FIRMWARE_IBT),y)
LINUX_FIRMWARE_FILES += intel/ibt-*
--
2.15.1
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.busybox.net/pipermail/buildroot/attachments/20180311/c383ca05/attachment.html>
^ permalink raw reply related [flat|nested] 5+ messages in thread
* [Buildroot] [PATCH] package/linux-firmware: Add Qualcomm video firmware option
2018-03-11 21:57 [Buildroot] [PATCH] package/linux-firmware: Add Qualcomm video firmware option Andre Renaud
@ 2018-03-26 21:32 ` Thomas Petazzoni
2018-04-11 2:09 ` Andre Renaud
0 siblings, 1 reply; 5+ messages in thread
From: Thomas Petazzoni @ 2018-03-26 21:32 UTC (permalink / raw)
To: buildroot
Hello Andre,
Thanks for this contribution! See below for some comments.
On Sun, 11 Mar 2018 21:57:15 +0000, Andre Renaud wrote:
> Added Qualcomm video firmware option.
>
> Signed-off-by: Andre Renaud <andre@ignavus.net>
> ---
> package/linux-firmware/Config.in | 5 +++++
> package/linux-firmware/linux-firmware.mk | 5 +++++
> 2 files changed, 10 insertions(+)
>
> diff --git a/package/linux-firmware/Config.in
> b/package/linux-firmware/Config.in
> index 4e77a3f9a3..61164e101c 100644
> --- a/package/linux-firmware/Config.in
> +++ b/package/linux-firmware/Config.in
> @@ -29,6 +29,11 @@ config BR2_PACKAGE_LINUX_FIRMWARE_RADEON
> help
> Firmware files for AMD Radeon video cards.
>
> +config BR2_PACKAGE_LINUX_FIRMWARE_QCOM
> + bool "Qualcomm video card firmware"
> + help
> + Firmware files for Qualcomm/Snapdragon video cards.
"video cards" doesn't mean much. Are you talking about GPU, VPU?
And in fact, if you look at the "WHENCE" file in the linux-firmware
project, you'll see:
--------------------------------------------------------------------------
Driver: venus - Qualcomm Venus video codec accelerator
File: qcom/venus-1.8/venus.mdt
File: qcom/venus-1.8/venus.b00
File: qcom/venus-1.8/venus.b01
File: qcom/venus-1.8/venus.b02
File: qcom/venus-1.8/venus.b03
File: qcom/venus-1.8/venus.b04
Version: 1.8-00109
File: qcom/venus-4.2/venus.mdt
File: qcom/venus-4.2/venus.b00
File: qcom/venus-4.2/venus.b01
File: qcom/venus-4.2/venus.b02
File: qcom/venus-4.2/venus.b03
File: qcom/venus-4.2/venus.b04
Version: 4.2
Licence: Redistributable. See LICENSE.qcom and qcom/NOTICE.txt for details
Binary files supplied originally from
https://developer.qualcomm.com/hardware/dragonboard-410c/tools
--------------------------------------------------------------------------
--------------------------------------------------------------------------
Driver: adreno - Qualcomm Adreno GPU firmware
File: qcom/a300_pfp.fw
Link: a300_pfp.fw -> qcom/a300_pfp.fw
File: qcom/a300_pm4.fw
Link: a300_pm4.fw -> qcom/a300_pm4.fw
File: qcom/a530_pfp.fw
File: qcom/a530_pm4.fw
File: qcom/a530v3_gpmu.fw2
File: qcom/a530_zap.b00
File: qcom/a530_zap.b01
File: qcom/a530_zap.b02
File: qcom/a530_zap.mdt
Licence: Redistributable. See LICENSE.qcom and qcom/NOTICE.txt for details
Binary files supplied originally from
https://developer.qualcomm.com/hardware/dragonboard-410c/tools
--------------------------------------------------------------------------
So the files in qcom/venus/ are for a video processing unit (doing
video encoding/decoding acceleration), while the qcom/a* files are for
the Adreno GPUs.
So, I believe we need two sub-options:
BR2_PACKAGE_LINUX_FIRMWARE_QCOM_VENUS
BR2_PACKAGE_LINUX_FIRMWARE_QCOM_ADRENO
Could you rework your patch to add those two options instead ?
Thanks!
Thomas Petazzoni
--
Thomas Petazzoni, CTO, Bootlin (formerly Free Electrons)
Embedded Linux and Kernel engineering
https://bootlin.com
^ permalink raw reply [flat|nested] 5+ messages in thread
* [Buildroot] [PATCH] package/linux-firmware: Add Qualcomm video firmware option
2018-03-26 21:32 ` Thomas Petazzoni
@ 2018-04-11 2:09 ` Andre Renaud
2018-04-11 5:09 ` Baruch Siach
2018-04-11 7:03 ` Thomas Petazzoni
0 siblings, 2 replies; 5+ messages in thread
From: Andre Renaud @ 2018-04-11 2:09 UTC (permalink / raw)
To: buildroot
Added Qualcomm video accelerator and GPU firmware option.
Signed-off-by: Andre Renaud <andre@ignavus.net>
---
package/linux-firmware/Config.in | 10 ++++++++++
package/linux-firmware/linux-firmware.mk | 10 ++++++++++
2 files changed, 20 insertions(+)
diff --git a/package/linux-firmware/Config.in
b/package/linux-firmware/Config.in
index 4e77a3f9a3..9d8d8b340b 100644
--- a/package/linux-firmware/Config.in
+++ b/package/linux-firmware/Config.in
@@ -29,6 +29,16 @@ config BR2_PACKAGE_LINUX_FIRMWARE_RADEON
help
Firmware files for AMD Radeon video cards.
+config BR2_PACKAGE_LINUX_FIRMWARE_QCOM_VENUS
+ bool "Qualcomm Venus video codec accelerator"
+ help
+ Firmware files for Qualcomm Venus video codec accelerator
+
+config BR2_PACKAGE_LINUX_FIRMWARE_QCOM_ADRENO
+ bool "Qualcomm Adreno GPU firmware"
+ help
+ Firmware files for Qualcomm Adreno GPU firmware
+
endmenu # Video
menu "Bluetooth firmware"
diff --git a/package/linux-firmware/linux-firmware.mk
b/package/linux-firmware/linux-firmware.mk
index 6f0ba53800..03c4b2c576 100644
--- a/package/linux-firmware/linux-firmware.mk
+++ b/package/linux-firmware/linux-firmware.mk
@@ -24,6 +24,16 @@ LINUX_FIRMWARE_DIRS += radeon
LINUX_FIRMWARE_ALL_LICENSE_FILES += LICENSE.radeon
endif
+ifeq ($(BR2_PACKAGE_LINUX_FIRMWARE_QCOM_VENUS),y)
+LINUX_FIRMWARE_DIRS += qcom/venus-1.8 qcom/venus-4.2
+LINUX_FIRMWARE_ALL_LICENSE_FILES += LICENSE.qcom
+endif
+
+ifeq ($(BR2_PACKAGE_LINUX_FIRMWARE_QCOM_ADRENO),y)
+LINUX_FIRMWARE_FILES += qcom/a*
+LINUX_FIRMWARE_ALL_LICENSE_FILES += LICENSE.qcom
+endif
+
# Intel Wireless Bluetooth
ifeq ($(BR2_PACKAGE_LINUX_FIRMWARE_IBT),y)
LINUX_FIRMWARE_FILES += intel/ibt-*
On Tue, 27 Mar 2018 at 10:33 Thomas Petazzoni <thomas.petazzoni@bootlin.com>
wrote:
> Hello Andre,
>
> Thanks for this contribution! See below for some comments.
>
> On Sun, 11 Mar 2018 21:57:15 +0000, Andre Renaud wrote:
> > Added Qualcomm video firmware option.
> >
> > Signed-off-by: Andre Renaud <andre@ignavus.net>
> > ---
> > package/linux-firmware/Config.in | 5 +++++
> > package/linux-firmware/linux-firmware.mk | 5 +++++
> > 2 files changed, 10 insertions(+)
> >
> > diff --git a/package/linux-firmware/Config.in
> > b/package/linux-firmware/Config.in
> > index 4e77a3f9a3..61164e101c 100644
> > --- a/package/linux-firmware/Config.in
> > +++ b/package/linux-firmware/Config.in
> > @@ -29,6 +29,11 @@ config BR2_PACKAGE_LINUX_FIRMWARE_RADEON
> > help
> > Firmware files for AMD Radeon video cards.
> >
> > +config BR2_PACKAGE_LINUX_FIRMWARE_QCOM
> > + bool "Qualcomm video card firmware"
> > + help
> > + Firmware files for Qualcomm/Snapdragon video cards.
>
> "video cards" doesn't mean much. Are you talking about GPU, VPU?
>
> And in fact, if you look at the "WHENCE" file in the linux-firmware
> project, you'll see:
>
> --------------------------------------------------------------------------
>
> Driver: venus - Qualcomm Venus video codec accelerator
>
> File: qcom/venus-1.8/venus.mdt
> File: qcom/venus-1.8/venus.b00
> File: qcom/venus-1.8/venus.b01
> File: qcom/venus-1.8/venus.b02
> File: qcom/venus-1.8/venus.b03
> File: qcom/venus-1.8/venus.b04
>
> Version: 1.8-00109
>
> File: qcom/venus-4.2/venus.mdt
> File: qcom/venus-4.2/venus.b00
> File: qcom/venus-4.2/venus.b01
> File: qcom/venus-4.2/venus.b02
> File: qcom/venus-4.2/venus.b03
> File: qcom/venus-4.2/venus.b04
>
> Version: 4.2
>
> Licence: Redistributable. See LICENSE.qcom and qcom/NOTICE.txt for details
>
> Binary files supplied originally from
> https://developer.qualcomm.com/hardware/dragonboard-410c/tools
>
> --------------------------------------------------------------------------
>
> --------------------------------------------------------------------------
>
> Driver: adreno - Qualcomm Adreno GPU firmware
>
> File: qcom/a300_pfp.fw
> Link: a300_pfp.fw -> qcom/a300_pfp.fw
> File: qcom/a300_pm4.fw
> Link: a300_pm4.fw -> qcom/a300_pm4.fw
> File: qcom/a530_pfp.fw
> File: qcom/a530_pm4.fw
> File: qcom/a530v3_gpmu.fw2
> File: qcom/a530_zap.b00
> File: qcom/a530_zap.b01
> File: qcom/a530_zap.b02
> File: qcom/a530_zap.mdt
>
> Licence: Redistributable. See LICENSE.qcom and qcom/NOTICE.txt for details
>
> Binary files supplied originally from
> https://developer.qualcomm.com/hardware/dragonboard-410c/tools
>
> --------------------------------------------------------------------------
>
> So the files in qcom/venus/ are for a video processing unit (doing
> video encoding/decoding acceleration), while the qcom/a* files are for
> the Adreno GPUs.
>
> So, I believe we need two sub-options:
>
> BR2_PACKAGE_LINUX_FIRMWARE_QCOM_VENUS
> BR2_PACKAGE_LINUX_FIRMWARE_QCOM_ADRENO
>
> Could you rework your patch to add those two options instead ?
>
> Thanks!
>
> Thomas Petazzoni
> --
> Thomas Petazzoni, CTO, Bootlin (formerly Free Electrons)
> Embedded Linux and Kernel engineering
> https://bootlin.com
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.busybox.net/pipermail/buildroot/attachments/20180411/73131dda/attachment.html>
^ permalink raw reply related [flat|nested] 5+ messages in thread
* [Buildroot] [PATCH] package/linux-firmware: Add Qualcomm video firmware option
2018-04-11 2:09 ` Andre Renaud
@ 2018-04-11 5:09 ` Baruch Siach
2018-04-11 7:03 ` Thomas Petazzoni
1 sibling, 0 replies; 5+ messages in thread
From: Baruch Siach @ 2018-04-11 5:09 UTC (permalink / raw)
To: buildroot
Hi Andre,
On Wed, Apr 11, 2018 at 02:09:46AM +0000, Andre Renaud wrote:
> Added Qualcomm video accelerator and GPU firmware option.
>
> Signed-off-by: Andre Renaud <andre@ignavus.net>
...
> +ifeq ($(BR2_PACKAGE_LINUX_FIRMWARE_QCOM_VENUS),y)
> +LINUX_FIRMWARE_DIRS += qcom/venus-1.8 qcom/venus-4.2
> +LINUX_FIRMWARE_ALL_LICENSE_FILES += LICENSE.qcom
qcom/NOTICE.txt is also applicable, I think. Don't forget to update the .hash
file.
> +endif
> +
> +ifeq ($(BR2_PACKAGE_LINUX_FIRMWARE_QCOM_ADRENO),y)
> +LINUX_FIRMWARE_FILES += qcom/a*
> +LINUX_FIRMWARE_ALL_LICENSE_FILES += LICENSE.qcom
> +endif
baruch
--
http://baruch.siach.name/blog/ ~. .~ Tk Open Systems
=}------------------------------------------------ooO--U--Ooo------------{=
- baruch at tkos.co.il - tel: +972.2.679.5364, http://www.tkos.co.il -
^ permalink raw reply [flat|nested] 5+ messages in thread
* [Buildroot] [PATCH] package/linux-firmware: Add Qualcomm video firmware option
2018-04-11 2:09 ` Andre Renaud
2018-04-11 5:09 ` Baruch Siach
@ 2018-04-11 7:03 ` Thomas Petazzoni
1 sibling, 0 replies; 5+ messages in thread
From: Thomas Petazzoni @ 2018-04-11 7:03 UTC (permalink / raw)
To: buildroot
Hello Andre,
On Wed, 11 Apr 2018 02:09:46 +0000, Andre Renaud wrote:
> Added Qualcomm video accelerator and GPU firmware option.
>
> Signed-off-by: Andre Renaud <andre@ignavus.net>
> ---
> package/linux-firmware/Config.in | 10 ++++++++++
> package/linux-firmware/linux-firmware.mk | 10 ++++++++++
> 2 files changed, 20 insertions(+)
Thanks for this new version! Could you please sent this as a proper new
patch with git send-email, and not pasted above the previous patch?
Also, see beloiw.
> diff --git a/package/linux-firmware/Config.in
> b/package/linux-firmware/Config.in
> index 4e77a3f9a3..9d8d8b340b 100644
> --- a/package/linux-firmware/Config.in
> +++ b/package/linux-firmware/Config.in
> @@ -29,6 +29,16 @@ config BR2_PACKAGE_LINUX_FIRMWARE_RADEON
> help
> Firmware files for AMD Radeon video cards.
>
> +config BR2_PACKAGE_LINUX_FIRMWARE_QCOM_VENUS
> + bool "Qualcomm Venus video codec accelerator"
> + help
Indentation should be done with tabs
> + Firmware files for Qualcomm Venus video codec accelerator
And here one tab + 2 spaces.
You can run ./utils/check-package package/linux-firmware/Config.in,
which well validate this kind of trivial coding style issues.
Thanks!
Thomas
--
Thomas Petazzoni, CTO, Bootlin (formerly Free Electrons)
Embedded Linux and Kernel engineering
https://bootlin.com
^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2018-04-11 7:03 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2018-03-11 21:57 [Buildroot] [PATCH] package/linux-firmware: Add Qualcomm video firmware option Andre Renaud
2018-03-26 21:32 ` Thomas Petazzoni
2018-04-11 2:09 ` Andre Renaud
2018-04-11 5:09 ` Baruch Siach
2018-04-11 7:03 ` Thomas Petazzoni
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.