* [PATCH 1/2] staging: csr: Remove CsrEventHandle
@ 2012-10-27 18:45 SeongJae Park
2012-10-27 18:45 ` [PATCH 2/2] staging: csr: Remove struct CsrEvent SeongJae Park
2012-10-29 21:58 ` [PATCH 1/2] staging: csr: Remove CsrEventHandle Greg KH
0 siblings, 2 replies; 4+ messages in thread
From: SeongJae Park @ 2012-10-27 18:45 UTC (permalink / raw)
To: linux-kernel; +Cc: gregkh, SeongJae Park
No one use CsrEventHandle, No one call functions using it as parameter.
So those are not need to be here.
Signed-off-by: SeongJae Park <sj38.park@gmail.com>
---
drivers/staging/csr/csr_framework_ext.h | 61 -------------------------
drivers/staging/csr/csr_framework_ext_types.h | 2 -
2 files changed, 63 deletions(-)
diff --git a/drivers/staging/csr/csr_framework_ext.h b/drivers/staging/csr/csr_framework_ext.h
index 16635a9..f1295a1 100644
--- a/drivers/staging/csr/csr_framework_ext.h
+++ b/drivers/staging/csr/csr_framework_ext.h
@@ -36,67 +36,6 @@ extern "C" {
/*----------------------------------------------------------------------------*
* NAME
- * CsrEventCreate
- *
- * DESCRIPTION
- * Creates an event and returns a handle to the created event.
- *
- * RETURNS
- * Possible values:
- * CSR_RESULT_SUCCESS in case of success
- * CSR_FE_RESULT_NO_MORE_EVENTS in case of out of event resources
- * CSR_FE_RESULT_INVALID_POINTER in case the eventHandle pointer is invalid
- *
- *----------------------------------------------------------------------------*/
-CsrResult CsrEventCreate(CsrEventHandle *eventHandle);
-
-/*----------------------------------------------------------------------------*
- * NAME
- * CsrEventWait
- *
- * DESCRIPTION
- * Wait fore one or more of the event bits to be set.
- *
- * RETURNS
- * Possible values:
- * CSR_RESULT_SUCCESS in case of success
- * CSR_FE_RESULT_TIMEOUT in case of timeout
- * CSR_FE_RESULT_INVALID_HANDLE in case the eventHandle is invalid
- * CSR_FE_RESULT_INVALID_POINTER in case the eventBits pointer is invalid
- *
- *----------------------------------------------------------------------------*/
-CsrResult CsrEventWait(CsrEventHandle *eventHandle, u16 timeoutInMs, u32 *eventBits);
-
-/*----------------------------------------------------------------------------*
- * NAME
- * CsrEventSet
- *
- * DESCRIPTION
- * Set an event.
- *
- * RETURNS
- * Possible values:
- * CSR_RESULT_SUCCESS in case of success
- * CSR_FE_RESULT_INVALID_HANDLE in case the eventHandle is invalid
- *
- *----------------------------------------------------------------------------*/
-CsrResult CsrEventSet(CsrEventHandle *eventHandle, u32 eventBits);
-
-/*----------------------------------------------------------------------------*
- * NAME
- * CsrEventDestroy
- *
- * DESCRIPTION
- * Destroy the event associated.
- *
- * RETURNS
- * void
- *
- *----------------------------------------------------------------------------*/
-void CsrEventDestroy(CsrEventHandle *eventHandle);
-
-/*----------------------------------------------------------------------------*
- * NAME
* CsrMutexCreate
*
* DESCRIPTION
diff --git a/drivers/staging/csr/csr_framework_ext_types.h b/drivers/staging/csr/csr_framework_ext_types.h
index cd1f877..22340c2 100644
--- a/drivers/staging/csr/csr_framework_ext_types.h
+++ b/drivers/staging/csr/csr_framework_ext_types.h
@@ -30,7 +30,6 @@ struct CsrEvent {
unsigned int wakeup_flag;
};
-typedef struct CsrEvent CsrEventHandle;
typedef struct semaphore CsrMutexHandle;
#else /* __KERNEL __ */
@@ -41,7 +40,6 @@ struct CsrEvent {
u32 eventBits;
};
-typedef struct CsrEvent CsrEventHandle;
typedef pthread_mutex_t CsrMutexHandle;
#endif /* __KERNEL__ */
--
1.7.9.5
^ permalink raw reply related [flat|nested] 4+ messages in thread
* [PATCH 2/2] staging: csr: Remove struct CsrEvent
2012-10-27 18:45 [PATCH 1/2] staging: csr: Remove CsrEventHandle SeongJae Park
@ 2012-10-27 18:45 ` SeongJae Park
2012-10-29 21:58 ` [PATCH 1/2] staging: csr: Remove CsrEventHandle Greg KH
1 sibling, 0 replies; 4+ messages in thread
From: SeongJae Park @ 2012-10-27 18:45 UTC (permalink / raw)
To: linux-kernel; +Cc: gregkh, SeongJae Park
No one use struct CsrEvent. So it's unnecessary.
Signed-off-by: SeongJae Park <sj38.park@gmail.com>
---
drivers/staging/csr/csr_framework_ext_types.h | 12 ------------
1 file changed, 12 deletions(-)
diff --git a/drivers/staging/csr/csr_framework_ext_types.h b/drivers/staging/csr/csr_framework_ext_types.h
index 22340c2..7ad8720 100644
--- a/drivers/staging/csr/csr_framework_ext_types.h
+++ b/drivers/staging/csr/csr_framework_ext_types.h
@@ -24,22 +24,10 @@ extern "C" {
#ifdef __KERNEL__
-struct CsrEvent {
- /* wait_queue for waking the kernel thread */
- wait_queue_head_t wakeup_q;
- unsigned int wakeup_flag;
-};
-
typedef struct semaphore CsrMutexHandle;
#else /* __KERNEL __ */
-struct CsrEvent {
- pthread_cond_t event;
- pthread_mutex_t mutex;
- u32 eventBits;
-};
-
typedef pthread_mutex_t CsrMutexHandle;
#endif /* __KERNEL__ */
--
1.7.9.5
^ permalink raw reply related [flat|nested] 4+ messages in thread
* Re: [PATCH 1/2] staging: csr: Remove CsrEventHandle
2012-10-27 18:45 [PATCH 1/2] staging: csr: Remove CsrEventHandle SeongJae Park
2012-10-27 18:45 ` [PATCH 2/2] staging: csr: Remove struct CsrEvent SeongJae Park
@ 2012-10-29 21:58 ` Greg KH
2012-10-30 2:28 ` SeongJae Park
1 sibling, 1 reply; 4+ messages in thread
From: Greg KH @ 2012-10-29 21:58 UTC (permalink / raw)
To: SeongJae Park; +Cc: linux-kernel
On Sun, Oct 28, 2012 at 03:45:24AM +0900, SeongJae Park wrote:
> No one use CsrEventHandle, No one call functions using it as parameter.
> So those are not need to be here.
>
> Signed-off-by: SeongJae Park <sj38.park@gmail.com>
> ---
> drivers/staging/csr/csr_framework_ext.h | 61 -------------------------
> drivers/staging/csr/csr_framework_ext_types.h | 2 -
> 2 files changed, 63 deletions(-)
Sorry, but someone already did this. Look at the linux-next tree to see
the patch there that cleaned up part of this. But, the second file you
changed here still applies, so can you redo this, and the 2/2 patch and
resend them?
thanks,
greg k-h
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH 1/2] staging: csr: Remove CsrEventHandle
2012-10-29 21:58 ` [PATCH 1/2] staging: csr: Remove CsrEventHandle Greg KH
@ 2012-10-30 2:28 ` SeongJae Park
0 siblings, 0 replies; 4+ messages in thread
From: SeongJae Park @ 2012-10-30 2:28 UTC (permalink / raw)
To: Greg KH; +Cc: linux-kernel
Sure, I will.
Actually, I sent new patch already :)
On Tue, Oct 30, 2012 at 6:58 AM, Greg KH <gregkh@linuxfoundation.org> wrote:
>
> On Sun, Oct 28, 2012 at 03:45:24AM +0900, SeongJae Park wrote:
> > No one use CsrEventHandle, No one call functions using it as parameter.
> > So those are not need to be here.
> >
> > Signed-off-by: SeongJae Park <sj38.park@gmail.com>
> > ---
> > drivers/staging/csr/csr_framework_ext.h | 61
> > -------------------------
> > drivers/staging/csr/csr_framework_ext_types.h | 2 -
> > 2 files changed, 63 deletions(-)
>
> Sorry, but someone already did this. Look at the linux-next tree to see
> the patch there that cleaned up part of this. But, the second file you
> changed here still applies, so can you redo this, and the 2/2 patch and
> resend them?
>
> thanks,
>
> greg k-h
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2012-10-30 2:28 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2012-10-27 18:45 [PATCH 1/2] staging: csr: Remove CsrEventHandle SeongJae Park
2012-10-27 18:45 ` [PATCH 2/2] staging: csr: Remove struct CsrEvent SeongJae Park
2012-10-29 21:58 ` [PATCH 1/2] staging: csr: Remove CsrEventHandle Greg KH
2012-10-30 2:28 ` SeongJae Park
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.